228998 2021-08-11 06:34:03 -0700 Web Inspector: Show syntax in contextual documentation popup 2021-08-11 11:02:21 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All ASSIGNED InRadar P2 Normal --- 226883 1 rcaliman rcaliman ews-watchlist hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1783477 0 rcaliman 2021-08-11 06:34:03 -0700 Follow-up to Bug 226883 Remove the flag to toggle the visibility of the syntax section. 1783478 1 webkit-bug-importer 2021-08-11 06:34:35 -0700 <rdar://problem/81791494> 1783481 2 435341 rcaliman 2021-08-11 06:55:56 -0700 Created attachment 435341 Patch 1783560 3 hi 2021-08-11 11:02:21 -0700 I still don't think this is a good idea for all the reasons I mentioned in bug 226883 435341 2021-08-11 06:55:56 -0700 2021-08-11 09:41:25 -0700 Patch bug-228998-20210811155555.patch text/plain 5194 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFiZTNjOWY1MDA0YzJjM2MzYzc2OTM2NjkxYTE0 YjQ2MTM1MzFlYmIuLmU5ZmQyOThiYjZlODEzNGY0ZGExZDQwOTRjM2EwYmU0MWJlOTgxMzcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA4LTExICBSYXp2 YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBTaG93IHN5bnRheCBpbiBjb250ZXh0dWFsIGRvY3VtZW50YXRpb24gcG9wdXAKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyODk5OAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vODE3OTE0OTQ+CisKKyAgICAgICAgQWx3YXlzIHNob3cgdGhlIHN5bnRh eCBzZWN0aW9uIG9mIHRoZSBkb2N1bWVudGF0aW9uIHBvcHVwIGFuZCByZW1vdmUgdGhlIHNldHRp bmcgdG8gdG9nZ2xlIGl0cyB2aXNpYmlsaXR5LgorCisgICAgICAgICogTG9jYWxpemF0aW9ucy9l bi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFz ZS9TZXR0aW5nLmpzOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29udGV4dHVhbERv Y3VtZW50YXRpb25Qb3BvdmVyLmpzOgorICAgICAgICAoV0kuQ29udGV4dHVhbERvY3VtZW50YXRp b25Qb3BvdmVyLnByb3RvdHlwZS5fY3JlYXRlRG9jdW1lbnRhdGlvbkVsZW1lbnQpOgorICAgICAg ICAoV0kuQ29udGV4dHVhbERvY3VtZW50YXRpb25Qb3BvdmVyKToKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanM6CisgICAgICAgIChXSS5TZXR0 aW5nc1RhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5fY3JlYXRlRWxlbWVudHNTZXR0aW5nc1ZpZXcp OgorCiAyMDIxLTA4LTAzICBTb25pYSBTaW5nbGEgIDxzb25pYXNpbmdsYS4xODEyQGdtYWlsLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgc3RhbmRhcmQgbG9naWNhbCBwcm9wZXJ0 aWVzIHRvIENTUyBrZXl3b3JkIGNvbXBsZXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdz LmpzCmluZGV4IDFjYWUxODE4MTQwZDIxZDI5ZjJkYjIxYzkxMTZmNWI2N2FiZTYzNDIuLmJhMGEw NTIyNmE0ZjIzYTc3MDIzNzc5ZjFmY2NiOGJhNTA3MDg5M2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxp emVkU3RyaW5ncy5qcwpAQCAtMTM0OSw3ICsxMzQ5LDYgQEAgbG9jYWxpemVkU3RyaW5nc1siU2hv dyBpbmRlcGVuZGVudCBTdHlsZXMgc2lkZWJhciBAIFNldHRpbmdzIEVsZW1lbnRzIFBhbmUiXSA9 ICIKIGxvY2FsaXplZFN0cmluZ3NbIlNob3cganVtcCB0byBlZmZlY3RpdmUgcHJvcGVydHkgYnV0 dG9uIl0gPSAiU2hvdyBqdW1wIHRvIGVmZmVjdGl2ZSBwcm9wZXJ0eSBidXR0b24iOwogbG9jYWxp emVkU3RyaW5nc1siU2hvdyBqdW1wIHRvIHZhcmlhYmxlIGRlY2xhcmF0aW9uIGJ1dHRvbiJdID0g IlNob3cganVtcCB0byB2YXJpYWJsZSBkZWNsYXJhdGlvbiBidXR0b24iOwogbG9jYWxpemVkU3Ry aW5nc1siU2hvdyBwYWdlIHJ1bGVycyBhbmQgbm9kZSBib3JkZXIgbGluZXMiXSA9ICJTaG93IHBh Z2UgcnVsZXJzIGFuZCBub2RlIGJvcmRlciBsaW5lcyI7Ci1sb2NhbGl6ZWRTdHJpbmdzWyJTaG93 IHByb3BlcnR5IHN5bnRheCBpbiBkb2N1bWVudGF0aW9uIHBvcG92ZXIiXSA9ICJTaG93IHByb3Bl cnR5IHN5bnRheCBpbiBkb2N1bWVudGF0aW9uIHBvcG92ZXIiOwogbG9jYWxpemVkU3RyaW5nc1si U2hvdyBydWxlcnMiXSA9ICJTaG93IHJ1bGVycyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJTaG93IHRo ZSBkZXRhaWxzIHNpZGViYXIgKCVzKSJdID0gIlNob3cgdGhlIGRldGFpbHMgc2lkZWJhciAoJXMp IjsKIGxvY2FsaXplZFN0cmluZ3NbIlNob3cgdGhlIG5hdmlnYXRpb24gc2lkZWJhciAoJXMpIl0g PSAiU2hvdyB0aGUgbmF2aWdhdGlvbiBzaWRlYmFyICglcykiOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzCmluZGV4IGJhYjE1MzVj ODYxNjhiYTNhZmQ5ZTA2MGFhOGIyMTQwYzRmZTAyMTEuLjI4M2EyODI4OTcwZTlkMTczYjI0MWUy YTU2MzZkN2I2ZWNlNDMyYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9CYXNlL1NldHRpbmcuanMKQEAgLTIxMSw3ICsyMTEsNiBAQCBXSS5zZXR0aW5n cyA9IHsKICAgICBzZWFyY2hSZWd1bGFyRXhwcmVzc2lvbjogbmV3IFdJLlNldHRpbmcoInNlYXJj aC1yZWd1bGFyLWV4cHJlc3Npb24iLCBmYWxzZSksCiAgICAgc2VsZWN0ZWROZXR3b3JrRGV0YWls Q29udGVudFZpZXdJZGVudGlmaWVyOiBuZXcgV0kuU2V0dGluZygibmV0d29yay1kZXRhaWwtY29u dGVudC12aWV3LWlkZW50aWZpZXIiLCAicHJldmlldyIpLAogICAgIHNvdXJjZU1hcHNFbmFibGVk OiBuZXcgV0kuU2V0dGluZygic291cmNlLW1hcHMtZW5hYmxlZCIsIHRydWUpLAotICAgIHNob3dD U1NQcm9wZXJ0eVN5bnRheEluRG9jdW1lbnRhdGlvblBvcG92ZXI6IG5ldyBXSS5TZXR0aW5nKCJz aG93LWNzcy1wcm9wZXJ0eS1zeW50YXgtaW4tZG9jdW1lbnRhdGlvbi1wb3BvdmVyIiwgZmFsc2Up LAogICAgIHNob3dDYW52YXNQYXRoOiBuZXcgV0kuU2V0dGluZygic2hvdy1jYW52YXMtcGF0aCIs IGZhbHNlKSwKICAgICBzaG93SW1hZ2VHcmlkOiBuZXcgV0kuU2V0dGluZygic2hvdy1pbWFnZS1n cmlkIiwgdHJ1ZSksCiAgICAgc2hvd0ludmlzaWJsZUNoYXJhY3RlcnM6IG5ldyBXSS5TZXR0aW5n KCJzaG93LWludmlzaWJsZS1jaGFyYWN0ZXJzIiwgISFXSS5TZXR0aW5nLm1pZ3JhdGVWYWx1ZSgi c2hvdy1pbnZhbGlkLWNoYXJhY3RlcnMiKSksCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZXh0dWFsRG9jdW1lbnRhdGlvblBvcG92ZXIu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZXh0dWFs RG9jdW1lbnRhdGlvblBvcG92ZXIuanMKaW5kZXggNmJjMDVjZDE0OTQ0MTJiMmM0ODAzZjg3YmNi YzRmYTdmZGRkNjMwZC4uNjhlZjc1NDAzYTU0NmRjMzVlZWJkNWNkMzQzYmE4MWVkYjhkYjJiMSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29u dGV4dHVhbERvY3VtZW50YXRpb25Qb3BvdmVyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRleHR1YWxEb2N1bWVudGF0aW9uUG9wb3Zlci5qcwpA QCAtOTMsNyArOTMsNyBAQCBXSS5Db250ZXh0dWFsRG9jdW1lbnRhdGlvblBvcG92ZXIgPSBjbGFz cyBDb250ZXh0dWFsRG9jdW1lbnRhdGlvblBvcG92ZXIgZXh0ZW5kcwogICAgICAgICBsZXQgZGVz Y3JpcHRpb25FbGVtZW50ID0gZG9jdW1lbnRhdGlvbkVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgicCIpKTsKICAgICAgICAgZGVzY3JpcHRpb25FbGVtZW50LnRleHRD b250ZW50ID0gZGV0YWlscy5kZXNjcmlwdGlvbjsKIAotICAgICAgICBpZiAoZGV0YWlscy5zeW50 YXggJiYgV0kuc2V0dGluZ3Muc2hvd0NTU1Byb3BlcnR5U3ludGF4SW5Eb2N1bWVudGF0aW9uUG9w b3Zlci52YWx1ZSkgeworICAgICAgICBpZiAoZGV0YWlscy5zeW50YXgpIHsKICAgICAgICAgICAg IGxldCBzeW50YXhFbGVtZW50ID0gZG9jdW1lbnRhdGlvbkVsZW1lbnQuYXBwZW5kQ2hpbGQoZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgicCIpKTsKICAgICAgICAgICAgIHN5bnRheEVsZW1lbnQuY2xh c3NOYW1lID0gInN5bnRheCI7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3Lmpz CmluZGV4IDUxOTA0MjlkYmIxYmU2NmY5ZTZjN2NlZjZjYmJjZDBiZWM1YzI1MTIuLjM3ZDA0ZmNh NWZjODhjNzBmMjU1ZWM5Yjc3NzgwN2ZhZjA4ODhkMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NU YWJDb250ZW50Vmlldy5qcwpAQCAtMjkwLDcgKzI5MCw2IEBAIFdJLlNldHRpbmdzVGFiQ29udGVu dFZpZXcgPSBjbGFzcyBTZXR0aW5nc1RhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuVGFiQ29udGVu dFZpCiAKICAgICAgICAgbGV0IGNzc0dyb3VwID0gZWxlbWVudHNTZXR0aW5nc1ZpZXcuYWRkR3Jv dXAoV0kuVUlTdHJpbmcoIkNTUzoiKSk7CiAgICAgICAgIGNzc0dyb3VwLmFkZFNldHRpbmcoV0ku c2V0dGluZ3MuY3NzQ2hhbmdlc1Blck5vZGUsIFdJLlVJU3RyaW5nKCJTaG93IGNoYW5nZXMgb25s eSBmb3Igc2VsZWN0ZWQgbm9kZSIpKTsKLSAgICAgICAgY3NzR3JvdXAuYWRkU2V0dGluZyhXSS5z ZXR0aW5ncy5zaG93Q1NTUHJvcGVydHlTeW50YXhJbkRvY3VtZW50YXRpb25Qb3BvdmVyLCBXSS5V SVN0cmluZygiU2hvdyBwcm9wZXJ0eSBzeW50YXggaW4gZG9jdW1lbnRhdGlvbiBwb3BvdmVyIikp OwogCiAgICAgICAgIHRoaXMuX2NyZWF0ZVJlZmVyZW5jZUxpbmsoZWxlbWVudHNTZXR0aW5nc1Zp ZXcpOwogCg==