228995 2021-08-11 04:47:00 -0700 CSS keyframed animations don't respect edges in 4 value background-position 2021-09-06 09:34:09 -0700 1 1 1 Unclassified WebKit Animations Safari 14 All macOS 11 RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=229764 BrowserCompat, InRadar P2 Normal --- 1 hello simon.fraser clopez crzwdjk darin dino graouts graouts gsnedders simon.fraser webkit-bug-importer zalan oldest_to_newest 1783462 0 hello 2021-08-11 04:47:00 -0700 The following example behaves as expected in Chrome and FF, but behaves incorrectly in Safari: In Firefox and Chrome the Deno logo moves from the top right to the middle. In Safari the logo moves from the top left to the middle. ```html <style> div { background-image: url(https://deno.land/logo.svg); background-size: 10px; background-repeat: no-repeat; height: 100px; width: 100px; animation: move 1s; } @keyframes move { from { background-position: right 0 top 0px; } to { background-position: right 50px top 10px; } } </style> <div></div> ``` 1783592 1 webkit-bug-importer 2021-08-11 12:20:57 -0700 <rdar://problem/81807407> 1787705 2 436541 simon.fraser 2021-08-26 11:42:02 -0700 Created attachment 436541 Test case 1787725 3 simon.fraser 2021-08-26 12:17:50 -0700 The issue here is that the style that results from the animation does not have m_backgroundXOrigin/m_backgroundYOrigin set in it. 1787854 4 436581 simon.fraser 2021-08-26 15:58:19 -0700 Created attachment 436581 Patch 1787943 5 ews-feeder 2021-08-26 20:53:02 -0700 Committed r281683 (241033@main): <https://commits.webkit.org/241033@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436581. 1789330 6 crzwdjk 2021-09-01 08:34:32 -0700 It appears that the test added in this change is flaky, mostly failing (but sometimes passing) on GTK and WPE, and mostly passing (but sometimes failing) on Mac/iOS: https://results.webkit.org/?suite=layout-tests&test=animations%2Fbackground-position.html 1790727 7 clopez 2021-09-06 09:34:09 -0700 (In reply to Arcady Goldmints-Orlov from comment #6) > It appears that the test added in this change is flaky, mostly failing (but > sometimes passing) on GTK and WPE, and mostly passing (but sometimes > failing) on Mac/iOS: > https://results.webkit.org/?suite=layout-tests&test=animations%2Fbackground- > position.html See bug 229764 436541 2021-08-26 11:42:02 -0700 2021-08-26 11:42:02 -0700 Test case background-position-animation2.html text/html 398 simon.fraser PHN0eWxlPgogIGRpdiB7CiAgICBiYWNrZ3JvdW5kLWltYWdlOiBsaW5lYXItZ3JhZGllbnQocmVk LCBibHVlKTsKICAgIGJhY2tncm91bmQtc2l6ZTogNTBweCA1MHB4OwogICAgYmFja2dyb3VuZC1y ZXBlYXQ6IG5vLXJlcGVhdDsKICAgIGhlaWdodDogMzAwcHg7CiAgICB3aWR0aDogMzAwcHg7CiAg ICBib3JkZXI6IDFweCBzb2xpZCBibGFjazsKICAgIGFuaW1hdGlvbjogbW92ZSAxczsKICB9Cgog IEBrZXlmcmFtZXMgbW92ZSB7CiAgICBmcm9tIHsKICAgICAgYmFja2dyb3VuZC1wb3NpdGlvbjog cmlnaHQgMCB0b3AgMHB4OwogICAgfQoKICAgIHRvIHsKICAgICAgYmFja2dyb3VuZC1wb3NpdGlv bjogcmlnaHQgMjUwcHggdG9wIDIxMHB4OwogICAgfQogIH0KPC9zdHlsZT4KPGRpdj48L2Rpdj4= 436581 2021-08-26 15:58:19 -0700 2021-08-26 20:53:03 -0700 Patch bug-228995-20210826155819.patch text/plain 5046 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDZkNzJiNWU2ODBkYjJh YTNkMjJiMjQwZmMxMTBhY2U1ZjBkY2NlZS4uY2QzYjlkZThhMGI4OTg4NjRlNGRhMGM4YjlkOWIy Njk3YThmM2Y3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA4LTI2ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENTUyBrZXlmcmFt ZWQgYW5pbWF0aW9ucyBkb24ndCByZXNwZWN0IGVkZ2VzIGluIDQgdmFsdWUgYmFja2dyb3VuZC1w b3NpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjI4OTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rm9yIHNvbWUgYmFja2dyb3VuZC1wb3NpdGlvbiBhbmltYXRpb25zIHdlJ2QgZmFpbCB0byBzZXQg YmFja2dyb3VuZE9yaWdpblgvWSBpbiB0aGUKKyAgICAgICAgZGVzdGluYXRpb24gc3R5bGUncyBG aWxsTGF5ZXIsIGJlY2F1c2UgdGhpcyBpcyBub3Qgc2V0IGluIHRoZSBkZXN0aW5hdGlvbiBzdHls ZSBpbml0aWFsbHkuCisgICAgICAgIAorICAgICAgICBTbyBoYXZlIEZpbGxMYXllclBvc2l0aW9u UHJvcGVydHlXcmFwcGVyOjpibGVuZCgpIGFsd2F5cyBzZXQgaXQuCisKKyAgICAgICAgVGVzdDog YW5pbWF0aW9ucy9iYWNrZ3JvdW5kLXBvc2l0aW9uLmh0bWwKKworICAgICAgICAqIGFuaW1hdGlv bi9DU1NQcm9wZXJ0eUFuaW1hdGlvbi5jcHA6CisKIDIwMjEtMDgtMjUgIEFsYW4gQnVqdGFzICA8 emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gTGluZSBzcGFubmluZyBpbmxp bmUgYm94ZXMgc2hvdWxkIGFsc28gYmUgaW4gdGhlIHJ1biBsaXN0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9hbmltYXRpb24vQ1NTUHJvcGVydHlBbmltYXRpb24uY3BwIGIvU291cmNlL1dl YkNvcmUvYW5pbWF0aW9uL0NTU1Byb3BlcnR5QW5pbWF0aW9uLmNwcAppbmRleCA0MjgyMzBhNGUx OGQ4NGUwZTZiMGE0Y2Q3MjEzY2Y5ZmUwODBjOTU5Li40NjQ5Mjk4ZDgxYzk4Yjg0NTU1ZjFiZjEx YzE0OTAzMzVjZTlhNmNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vQ1NT UHJvcGVydHlBbmltYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FuaW1hdGlvbi9DU1NQ cm9wZXJ0eUFuaW1hdGlvbi5jcHAKQEAgLTE2NDMsMTYgKzE2NDMsMTggQEAgcHJpdmF0ZToKICAg ICAgICAgRWRnZSBmcm9tRWRnZSA9IChmcm9tLT4qbV9vcmlnaW5HZXR0ZXIpKCk7CiAgICAgICAg IEVkZ2UgdG9FZGdlID0gKHRvLT4qbV9vcmlnaW5HZXR0ZXIpKCk7CiAgICAgICAgIAorICAgICAg ICBFZGdlIGRlc3RpbmF0aW9uRWRnZSA9IHRvRWRnZTsKICAgICAgICAgaWYgKGZyb21FZGdlICE9 IHRvRWRnZSkgewogICAgICAgICAgICAgLy8gQ29udmVydCB0aGUgcmlnaHQvYm90dG9tIGludG8g YSBjYWxjIGV4cHJlc3Npb24sCiAgICAgICAgICAgICBpZiAoZnJvbUVkZ2UgPT0gbV9mYXJFZGdl KQogICAgICAgICAgICAgICAgIGZyb21MZW5ndGggPSBjb252ZXJ0VG8xMDBQZXJjZW50TWludXNM ZW5ndGgoZnJvbUxlbmd0aCk7CiAgICAgICAgICAgICBlbHNlIGlmICh0b0VkZ2UgPT0gbV9mYXJF ZGdlKSB7CiAgICAgICAgICAgICAgICAgdG9MZW5ndGggPSBjb252ZXJ0VG8xMDBQZXJjZW50TWlu dXNMZW5ndGgodG9MZW5ndGgpOwotICAgICAgICAgICAgICAgIChkZXN0aW5hdGlvbi0+Km1fb3Jp Z2luU2V0dGVyKShmcm9tRWRnZSk7IC8vIE5vdyB3ZSBoYXZlIGEgY2FsYygxMDAlIC0gbCksIGl0 J3MgcmVsYXRpdmUgdG8gdGhlIGxlZnQvdG9wIGVkZ2UuCisgICAgICAgICAgICAgICAgZGVzdGlu YXRpb25FZGdlID0gZnJvbUVkZ2U7IC8vIE5vdyB3ZSBoYXZlIGEgY2FsYygxMDAlIC0gbCksIGl0 J3MgcmVsYXRpdmUgdG8gdGhlIGxlZnQvdG9wIGVkZ2UuCiAgICAgICAgICAgICB9CiAgICAgICAg IH0KIAorICAgICAgICAoZGVzdGluYXRpb24tPiptX29yaWdpblNldHRlcikoZGVzdGluYXRpb25F ZGdlKTsKICAgICAgICAgKGRlc3RpbmF0aW9uLT4qbV9sZW5ndGhTZXR0ZXIpKGJsZW5kRnVuYyhm cm9tTGVuZ3RoLCB0b0xlbmd0aCwgY29udGV4dCkpOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDUwNDU5Yjcw YmE5MDkzMThiNzNjY2U3NGRiZWMxNGNlODMwNWMxYTUuLmRmNjk3Y2E3NjIwNTMxMThiYzg5ZmQ5 NzFlMjQ0ZGNjYTgxZTZkMTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAyMS0wOC0yNiAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBDU1Mga2V5ZnJh bWVkIGFuaW1hdGlvbnMgZG9uJ3QgcmVzcGVjdCBlZGdlcyBpbiA0IHZhbHVlIGJhY2tncm91bmQt cG9zaXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyODk5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZvciBzb21lIGJhY2tncm91bmQtcG9zaXRpb24gYW5pbWF0aW9ucyB3ZSdkIGZhaWwgdG8gc2V0 IGJhY2tncm91bmRPcmlnaW5YL1kgaW4gdGhlCisgICAgICAgIGRlc3RpbmF0aW9uIHN0eWxlJ3Mg RmlsbExheWVyLCBiZWNhdXNlIHRoaXMgaXMgbm90IHNldCBpbiB0aGUgZGVzdGluYXRpb24gc3R5 bGUgaW5pdGlhbGx5LgorICAgICAgICAKKyAgICAgICAgU28gaGF2ZSBGaWxsTGF5ZXJQb3NpdGlv blByb3BlcnR5V3JhcHBlcjo6YmxlbmQoKSBhbHdheXMgc2V0IGl0LgorCisgICAgICAgICogYW5p bWF0aW9ucy9iYWNrZ3JvdW5kLXBvc2l0aW9uLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIGFuaW1hdGlvbnMvYmFja2dyb3VuZC1wb3NpdGlvbi5odG1sOiBBZGRlZC4KKwogMjAyMS0w OC0yNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBV cGRhdGUgY3NzLW1hc2tpbmcgV1BUCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9hbmltYXRpb25z L2JhY2tncm91bmQtcG9zaXRpb24tZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2FuaW1hdGlv bnMvYmFja2dyb3VuZC1wb3NpdGlvbi1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjU0ZWE2MjVm MGRiYTU1YTFjNjRkYTcwZDJlZjMxYjlhMTU2MjEyMTIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9hbmltYXRpb25zL2JhY2tncm91bmQtcG9zaXRpb24tZXhwZWN0ZWQuaHRtbApAQCAt MCwwICsxLDI4IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+CisgICAgPHN0eWxl PgorICAgIEBrZXlmcmFtZXMgcGxheSB7CisgICAgICAgIGZyb20geworICAgICAgICAgICAgYmFj a2dyb3VuZC1wb3NpdGlvbjogbGVmdCAyNTBweCB0b3AgMjUwcHg7CisgICAgICAgIH0KKyAgICAg ICAgdG8geworICAgICAgICAgICAgYmFja2dyb3VuZC1wb3NpdGlvbjogdG9wIDBweCB0b3AgMHB4 OworICAgICAgICB9CisgICAgfQorCisgICAgZGl2IHsKKyAgICAgICAgYmFja2dyb3VuZC1pbWFn ZTogbGluZWFyLWdyYWRpZW50KGJsdWUsIGJsdWUpOworICAgICAgICBiYWNrZ3JvdW5kLXNpemU6 IDUwcHggNTBweDsKKyAgICAgICAgYmFja2dyb3VuZC1yZXBlYXQ6IG5vLXJlcGVhdDsKKyAgICAg ICAgaGVpZ2h0OiAzMDBweDsKKyAgICAgICAgd2lkdGg6IDMwMHB4OworICAgICAgICBib3JkZXI6 IDFweCBzb2xpZCBibGFjazsKKyAgICAgICAgYW5pbWF0aW9uOiBwbGF5IDEwMDAwMDBzIC0xMDAw MHMgbGluZWFyOworICAgIH0gICAgICAgIAorICAgIDwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9keT4K KyAgICA8ZGl2PjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvYW5pbWF0aW9ucy9iYWNrZ3JvdW5kLXBvc2l0aW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9hbmlt YXRpb25zL2JhY2tncm91bmQtcG9zaXRpb24uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hMDFkZGMxNDNiOTJm OGQ1ZjdkYmQxMDYwNmI3OTk1NjljYzljNzk2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvYW5pbWF0aW9ucy9iYWNrZ3JvdW5kLXBvc2l0aW9uLmh0bWwKQEAgLTAsMCArMSwyOCBAQAor PCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDxzdHlsZT4KKyAgICBAa2V5ZnJh bWVzIHBsYXkgeworICAgICAgICBmcm9tIHsKKyAgICAgICAgICAgIGJhY2tncm91bmQtcG9zaXRp b246IHJpZ2h0IDBweCBib3R0b20gMHB4OworICAgICAgICB9CisgICAgICAgIHRvIHsKKyAgICAg ICAgICAgIGJhY2tncm91bmQtcG9zaXRpb246IHJpZ2h0IDI1MHB4IGJvdHRvbSAyNTBweDsKKyAg ICAgICAgfQorICAgIH0KKworICAgIGRpdiB7CisgICAgICAgIGJhY2tncm91bmQtaW1hZ2U6IGxp bmVhci1ncmFkaWVudChibHVlLCBibHVlKTsKKyAgICAgICAgYmFja2dyb3VuZC1zaXplOiA1MHB4 IDUwcHg7CisgICAgICAgIGJhY2tncm91bmQtcmVwZWF0OiBuby1yZXBlYXQ7CisgICAgICAgIGhl aWdodDogMzAwcHg7CisgICAgICAgIHdpZHRoOiAzMDBweDsKKyAgICAgICAgYm9yZGVyOiAxcHgg c29saWQgYmxhY2s7CisgICAgICAgIGFuaW1hdGlvbjogcGxheSAxMDAwMDAwcyAtMTAwMDBzIGxp bmVhcjsKKyAgICB9ICAgICAgICAKKyAgICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+CisgICAg PGRpdj48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K