228987 2021-08-11 02:20:43 -0700 ANGLE Cocoa compiles contents of ContextEAGL on mac 2021-08-12 06:02:19 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kkinnunen kkinnunen dino ews-watchlist kbr kkinnunen kondapallykalyan webkit-bug-importer oldest_to_newest 1783427 0 kkinnunen 2021-08-11 02:20:43 -0700 ANGLE Cocoa compiles contents ContextEAGL on Mac, guards missing 1783428 1 435330 kkinnunen 2021-08-11 02:22:35 -0700 Created attachment 435330 Patch 1783429 2 ews-watchlist 2021-08-11 02:23:25 -0700 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1783596 3 435330 kbr 2021-08-11 12:30:13 -0700 Comment on attachment 435330 Patch Looks good to me. We need to be sure to either upstream this or avoid losing it while rolling ANGLE back down into WebKit. Do you want to point to this on https://bugs.chromium.org/p/angleproject/issues/detail?id=5505 ? r+ 1783611 4 435330 dino 2021-08-11 13:15:26 -0700 Comment on attachment 435330 Patch Before we can land this - please check that it doesn't break Catalyst. 1783746 5 kkinnunen 2021-08-11 23:29:28 -0700 Upstreaming bug: https://bugs.chromium.org/p/angleproject/issues/detail?id=6271 1783803 6 kkinnunen 2021-08-12 05:57:48 -0700 (In reply to Dean Jackson from comment #4) > Comment on attachment 435330 [details] > Patch > > Before we can land this - please check that it doesn't break Catalyst. I checked that it compiles on Catalyst. The Catalyst doesn't yet have tests so I didn't spend time building an app to verify that WebGL works. The condition itself is same as in other files. Before, the condition was in 4 EAGL files and missing in 1 EAGL file. After, the condition was in 5 EAGL files. Based on this, I'll land. 1783804 7 ews-feeder 2021-08-12 06:01:34 -0700 Committed r280962 (240468@main): <https://commits.webkit.org/240468@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435330. 1783805 8 webkit-bug-importer 2021-08-12 06:02:19 -0700 <rdar://problem/81844871> 435330 2021-08-11 02:22:35 -0700 2021-08-12 06:01:35 -0700 Patch bug-228987-20210811122233.patch text/plain 1559 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwODgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggN2Y1NzgwODNhZmRmOTU5OTJkMDdiOWVhNjM4ODcwMzk1ODRiNWEyOS4uYTY1NjFjYmI2NThl NTkyOTUzMDY1NzkyNjZiY2UzZmIxMzJhYTgzZSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA4LTExICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5l bkBhcHBsZS5jb20+CisKKyAgICAgICAgQU5HTEUgQ29jb2EgY29tcGlsZXMgY29udGVudHMgb2Yg Q29udGV4dEVBR0wgb24gbWFjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjg5ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgaW5jbHVkZSBndWFyZHMgdGhhdCBhcmUgY29uc2lzdGVudCB3aXRoIG90 aGVyIEVBR0wgZmlsZXMuCisKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvZWFn bC9Db250ZXh0RUFHTC5jcHA6CisKIDIwMjEtMDgtMTEgIEtpbW1vIEtpbm51bmVuICA8a2tpbm51 bmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBBTkdMRSBDb2NvYSBjb21waWxlcyBwYXJ0cyBvZiBI TFNMIHRyYW5zbGF0b3IsIHZ1bGthbiB0cmFuc2xhdG9yLCBsaWJnbCBhcGksIGNhcHR1cmUgcmVk dW5kYW50bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdM RS9yZW5kZXJlci9nbC9lYWdsL0NvbnRleHRFQUdMLmNwcCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FO R0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9lYWdsL0NvbnRleHRFQUdMLmNwcAppbmRleCBk MjE0ODUwOTFlMGZmZTA0NjVhMGI3MDczZWE5NzE3MDM5NWE1MjU5Li5lMTAwNTBlZjRlMzk3YjZi YjU5ODk1MWZjYTY4MWQ1MWUyYjQyYzhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvZWFnbC9Db250ZXh0RUFHTC5jcHAKKysrIGIv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL2VhZ2wvQ29u dGV4dEVBR0wuY3BwCkBAIC04LDYgKzgsMTAgQEAKIC8vICAgaU9TLXNwZWNpZmljIHN1YmNsYXNz IG9mIENvbnRleHRHTC4KIC8vCiAKKyNpbXBvcnQgImNvbW1vbi9wbGF0Zm9ybS5oIgorCisjaWYg ZGVmaW5lZChBTkdMRV9FTkFCTEVfRUFHTCkKKwogI2luY2x1ZGUgImxpYkFOR0xFL3JlbmRlcmVy L2dsL2VhZ2wvQ29udGV4dEVBR0wuaCIKIAogI2luY2x1ZGUgImxpYkFOR0xFL0NvbnRleHQuaCIK QEAgLTI0LDMgKzI4LDUgQEAgQ29udGV4dEVBR0w6OkNvbnRleHRFQUdMKGNvbnN0IGdsOjpTdGF0 ZSAmc3RhdGUsCiB7fQogCiB9ICAvLyBuYW1lc3BhY2UgcngKKworI2VuZGlmICAvLyBkZWZpbmVk KEFOR0xFX0VOQUJMRV9FQUdMKQo=