22897 2008-12-16 23:09:05 -0800 Clear bytecode vector after JITing 2008-12-17 13:31:45 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam webkit-unassigned oldest_to_newest 102754 0 sam 2008-12-16 23:09:05 -0800 Clearing the bytecode vector after JITing will save about 4.8MB on Membuster head. 102755 1 26087 sam 2008-12-16 23:10:02 -0800 Created attachment 26087 patch 102785 2 26087 darin 2008-12-17 10:00:21 -0800 Comment on attachment 26087 patch > + (JSC::CodeBlock::handlerForBytecodeOffset): Don't assert that the offset > + is less than the size of the bytecode vector since it may have been cleared > + and therefore 0. I think it would be better to keep around the size of the bytecode vector in a separate variable in debug versions so we could keep these assertions. r=me 102794 3 26087 ggaren 2008-12-17 11:41:20 -0800 Comment on attachment 26087 patch > m_codeBlock->setJITCode(codeRef); > +#if !ENABLE(OPCODE_SAMPLING) > + m_codeBlock->instructions().clear(); > +#endif I think it would be better to do this: #if ENABLE(OPCODE_SAMPLING) // Don't clear instructions -- we need them for sampling. #elsif !defined(NDEBUG) if (!s_dumpsGeneratedCode) m_codeBlock->instructions().clear(); #else m_codeBlock->instructions().clear(); #endif 102795 4 ggaren 2008-12-17 11:41:56 -0800 > I think it would be better to do this: That way, you can still dump code in debug builds. 102805 5 sam 2008-12-17 13:31:45 -0800 Fixed in r39366. 26087 2008-12-16 23:10:02 -0800 2008-12-17 10:00:21 -0800 patch patch.diff text/plain 4045 sam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM5MzU0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzAgQEAKKzIwMDgtMTIt MTYgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjg5NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQyODM0Mj4K KyAgICAgICAgTG9vayBpbnRvIGZlYXNpYmlsaXR5IG9mIGRpc2NhcmRpbmcgYnl0ZWNvZGUgYWZ0 ZXIgbmF0aXZlIGNvZGVnZW4KKworICAgICAgICBDbGVhciB0aGUgYnl0ZWNvZGUgSW5zdHJ1Y3Rp b24gdmVjdG9yIGF0IHRoZSBlbmQgSklUIGdlbmVyYXRpb24uCisKKyAgICAgICAgU2F2ZXMgNC44 IE1CIG9uIE1lbWJ1c3RlciBoZWFkLgorCisgICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmNw cDoKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjpkdW1wKTogQWRkIGxvZ2dpbmcgZm9yIHRoZSBj YXNlIHRoYXQgc29tZW9uZSB0cmllcworICAgICAgICB0byBkdW1wIHRoZSBpbnN0cnVjdGlvbnMg b2YgYSBDb2RlQmxvY2sgdGhhdCBoYXMgaGFkIGl0cyBieXRlY29kZQorICAgICAgICB2ZWN0b3Ig Y2xlYXJlZC4KKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjpoYW5kbGVyRm9yQnl0ZWNvZGVPZmZz ZXQpOiBEb24ndCBhc3NlcnQgdGhhdCB0aGUgb2Zmc2V0CisgICAgICAgIGlzIGxlc3MgdGhhbiB0 aGUgc2l6ZSBvZiB0aGUgYnl0ZWNvZGUgdmVjdG9yIHNpbmNlIGl0IG1heSBoYXZlIGJlZW4gY2xl YXJlZAorICAgICAgICBhbmQgdGhlcmVmb3JlIDAuCisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6 bGluZU51bWJlckZvckJ5dGVjb2RlT2Zmc2V0KTogRGl0dG8uCisgICAgICAgIChKU0M6OkNvZGVC bG9jazo6ZXhwcmVzc2lvblJhbmdlRm9yQnl0ZWNvZGVPZmZzZXQpOiBEaXR0by4KKyAgICAgICAg KEpTQzo6Q29kZUJsb2NrOjpnZXRCeUlkRXhjZXB0aW9uSW5mb0ZvckJ5dGVjb2RlT2Zmc2V0KTog RGl0dG8uCisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6ZnVuY3Rpb25SZWdpc3RlckZvckJ5dGVj b2RlT2Zmc2V0KTogRGl0dG8uCisgICAgICAgICogaml0L0pJVC5jcHA6CisgICAgICAgIChKU0M6 OkpJVDo6cHJpdmF0ZUNvbXBpbGUpOiBDbGVhciB0aGUgYnl0ZWNvZGUgdmVjdG9yIHVubGVzcyB3 ZQorICAgICAgICBoYXZlIGNvbXBpbGVkIHdpdGggT3Bjb2RlIHNhbXBsaW5nIHdoZXJlIHdlIHdp bGwgY29udGludWUgdG8gcmVxdWlyZSBpdC4KKwogMjAwOC0xMi0xNiAgU2FtIFdlaW5pZyAgPHNh bUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVuLgpJbmRl eDogYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBieXRlY29kZS9Db2RlQmxv Y2suY3BwCShyZXZpc2lvbiAzOTM1NCkKKysrIGJ5dGVjb2RlL0NvZGVCbG9jay5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTMyMiw2ICszMjIsMTEgQEAgdm9pZCBDb2RlQmxvY2s6OnByaW50U3RydWN0 dXJlcyhjb25zdCBJbgogCiB2b2lkIENvZGVCbG9jazo6ZHVtcChFeGVjU3RhdGUqIGV4ZWMpIGNv bnN0CiB7CisgICAgaWYgKG1faW5zdHJ1Y3Rpb25zLmlzRW1wdHkoKSkgeworICAgICAgICBwcmlu dGYoIk5vIGluc3RydWN0aW9ucyBhdmFpbGFibGUuXG4iKTsKKyAgICAgICAgcmV0dXJuOworICAg IH0KKwogICAgIHNpemVfdCBpbnN0cnVjdGlvbkNvdW50ID0gMDsKIAogICAgIGZvciAoc2l6ZV90 IGkgPSAwOyBpIDwgbV9pbnN0cnVjdGlvbnMuc2l6ZSgpOyBpICs9IG9wY29kZUxlbmd0aHNbZXhl Yy0+aW50ZXJwcmV0ZXIoKS0+Z2V0T3Bjb2RlSUQobV9pbnN0cnVjdGlvbnNbaV0udS5vcGNvZGUp XSkKQEAgLTEzMzEsOCArMTMzNiw2IEBAIEhhbmRsZXJJbmZvKiBDb2RlQmxvY2s6OmhhbmRsZXJG b3JCeXRlY28KIHsKICAgICBpZiAoIW1fcmFyZURhdGEpCiAgICAgICAgIHJldHVybiAwOwotCi0g ICAgQVNTRVJUKGJ5dGVjb2RlT2Zmc2V0IDwgbV9pbnN0cnVjdGlvbnMuc2l6ZSgpKTsKICAgICAK ICAgICBWZWN0b3I8SGFuZGxlckluZm8+JiBleGNlcHRpb25IYW5kbGVycyA9IG1fcmFyZURhdGEt Pm1fZXhjZXB0aW9uSGFuZGxlcnM7CiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBleGNlcHRp b25IYW5kbGVycy5zaXplKCk7ICsraSkgewpAQCAtMTM0Nyw4ICsxMzUwLDYgQEAgSGFuZGxlcklu Zm8qIENvZGVCbG9jazo6aGFuZGxlckZvckJ5dGVjbwogCiBpbnQgQ29kZUJsb2NrOjpsaW5lTnVt YmVyRm9yQnl0ZWNvZGVPZmZzZXQodW5zaWduZWQgYnl0ZWNvZGVPZmZzZXQpCiB7Ci0gICAgQVNT RVJUKGJ5dGVjb2RlT2Zmc2V0IDwgbV9pbnN0cnVjdGlvbnMuc2l6ZSgpKTsKLQogICAgIGlmICgh bV9saW5lSW5mby5zaXplKCkpCiAgICAgICAgIHJldHVybiBtX293bmVyTm9kZS0+c291cmNlKCku Zmlyc3RMaW5lKCk7IC8vIEVtcHR5IGZ1bmN0aW9uCiAKQEAgLTEzNjksOCArMTM3MCw2IEBAIGlu dCBDb2RlQmxvY2s6OmxpbmVOdW1iZXJGb3JCeXRlY29kZU9mZnMKIAogaW50IENvZGVCbG9jazo6 ZXhwcmVzc2lvblJhbmdlRm9yQnl0ZWNvZGVPZmZzZXQodW5zaWduZWQgYnl0ZWNvZGVPZmZzZXQs IGludCYgZGl2b3QsIGludCYgc3RhcnRPZmZzZXQsIGludCYgZW5kT2Zmc2V0KQogewotICAgIEFT U0VSVChieXRlY29kZU9mZnNldCA8IG1faW5zdHJ1Y3Rpb25zLnNpemUoKSk7Ci0KICAgICBpZiAo IW1fZXhwcmVzc2lvbkluZm8uc2l6ZSgpKSB7CiAgICAgICAgIC8vIFdlIGRpZG4ndCB0aGluayBh bnl0aGluZyBjb3VsZCB0aHJvdy4gIEFwcGFyZW50bHkgd2Ugd2VyZSB3cm9uZy4KICAgICAgICAg c3RhcnRPZmZzZXQgPSAwOwpAQCAtMTQwNSw4ICsxNDA0LDYgQEAgaW50IENvZGVCbG9jazo6ZXhw cmVzc2lvblJhbmdlRm9yQnl0ZWNvZAogCiBib29sIENvZGVCbG9jazo6Z2V0QnlJZEV4Y2VwdGlv bkluZm9Gb3JCeXRlY29kZU9mZnNldCh1bnNpZ25lZCBieXRlY29kZU9mZnNldCwgT3Bjb2RlSUQm IG9wY29kZUlEKQogewotICAgIEFTU0VSVChieXRlY29kZU9mZnNldCA8IG1faW5zdHJ1Y3Rpb25z LnNpemUoKSk7Ci0KICAgICBpZiAoIW1fZ2V0QnlJZEV4Y2VwdGlvbkluZm8uc2l6ZSgpKQogICAg ICAgICByZXR1cm4gZmFsc2U7CiAKQEAgLTE0MzAsOCArMTQyNyw2IEBAIGJvb2wgQ29kZUJsb2Nr OjpnZXRCeUlkRXhjZXB0aW9uSW5mb0ZvckIKICNpZiBFTkFCTEUoSklUKQogYm9vbCBDb2RlQmxv Y2s6OmZ1bmN0aW9uUmVnaXN0ZXJGb3JCeXRlY29kZU9mZnNldCh1bnNpZ25lZCBieXRlY29kZU9m ZnNldCwgaW50JiBmdW5jdGlvblJlZ2lzdGVySW5kZXgpCiB7Ci0gICAgQVNTRVJUKGJ5dGVjb2Rl T2Zmc2V0IDwgbV9pbnN0cnVjdGlvbnMuc2l6ZSgpKTsKLQogICAgIGlmICghbV9yYXJlRGF0YSB8 fCAhbV9yYXJlRGF0YS0+bV9mdW5jdGlvblJlZ2lzdGVySW5mb3Muc2l6ZSgpKQogICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKSW5kZXg6IGppdC9KSVQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGppdC9KSVQu Y3BwCShyZXZpc2lvbiAzOTM1MCkKKysrIGppdC9KSVQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0x ODYxLDYgKzE4NjEsOSBAQCB2b2lkIEpJVDo6cHJpdmF0ZUNvbXBpbGUoKQogICAgIH0KIAogICAg IG1fY29kZUJsb2NrLT5zZXRKSVRDb2RlKGNvZGVSZWYpOworI2lmICFFTkFCTEUoT1BDT0RFX1NB TVBMSU5HKQorICAgIG1fY29kZUJsb2NrLT5pbnN0cnVjdGlvbnMoKS5jbGVhcigpOworI2VuZGlm CiB9CiAKIHZvaWQgSklUOjpwcml2YXRlQ29tcGlsZUNUSU1hY2hpbmVUcmFtcG9saW5lcygpCg==