228944 2021-08-09 22:19:13 -0700 [Monterey] WebContent process immediately crash when GPU Process is disabled 2021-08-11 20:48:38 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jean-yves.avenard jean-yves.avenard bfulgham pvollan webkit-bug-importer oldest_to_newest 1783109 0 jean-yves.avenard 2021-08-09 22:19:13 -0700 [Montarey] WebContent process immediately crash when GPU Process is disabled 1783110 1 jean-yves.avenard 2021-08-09 22:20:38 -0700 rdar://81727094 1783111 2 435243 jean-yves.avenard 2021-08-09 22:25:23 -0700 Created attachment 435243 Patch 1783191 3 435243 bfulgham 2021-08-10 09:39:12 -0700 Comment on attachment 435243 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435243&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1453 > + (require-not (extension "com.apple.webkit.extension.mach")) This says that if we did not extend access to SYS_getpriority dynamically, allow the syscall. Since we don't currently extend any syscalls dynamically I think this will always be true. Consequently, I would just add this to the existing "(when (defined? 'syscall-unix)" case inside a version check like we do for SYS_setattrlist. Please also add the radar and a comment that we should remove it once the GPU Process is permanently enabled. 1783375 4 435243 jean-yves.avenard 2021-08-10 18:42:23 -0700 Comment on attachment 435243 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435243&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1453 > + (require-not (extension "com.apple.webkit.extension.mach")) the way that test appears to be used thorough the file is to check if the GPU Process is enabled. require-all tells me that extension "com.apple.webkit.extension.mach" needs to be false for SYS_getpriority to be allowed. I admit I'm definitely not a sandbox expert Also, I can't definitely say that this is only required for MacOS >= 12, it's just where I noticed the problem and that I can definitely test with. it may be required with other OS once AudioToolbox framework gets updated. 1783376 5 435316 jean-yves.avenard 2021-08-10 18:47:18 -0700 Created attachment 435316 Patch Apply comment 1783712 6 435391 jean-yves.avenard 2021-08-11 19:27:49 -0700 Created attachment 435391 Patch update Changelog 1783713 7 435391 bfulgham 2021-08-11 19:38:16 -0700 Comment on attachment 435391 Patch R=me 1783715 8 jean-yves.avenard 2021-08-11 19:52:58 -0700 thank you 1783721 9 ews-feeder 2021-08-11 20:48:36 -0700 Committed r280955 (240461@main): <https://commits.webkit.org/240461@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435391. 435243 2021-08-09 22:25:23 -0700 2021-08-10 18:47:15 -0700 Patch bug-228944-20210810152522.patch text/plain 1715 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNzY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUwNGRkMWIxMjY5MjM4NzFj ZWJmNGMxYjM1NjRhNGRkYzJhMjBhMWIuLjQ5Y2NmYWFmODAzYmJiYzhjMTdmYTU4OGJiZTNhNTI1 YjNhODE4MjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDgtMDkgIEplYW4tWXZl cyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KKworICAgICAgICBbTW9udGVyZXldIFdlYkNvbnRl bnQgcHJvY2VzcyBpbW1lZGlhdGVseSBjcmFzaCB3aGVuIEdQVSBQcm9jZXNzIGlzIGRpc2FibGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg5NDQK KyAgICAgICAgcmRhcjovLzgxNzI3MDk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmlu OiBBbGxvdyBTWVNfZ2V0cHJpb3JpdHkgc3lzY2FsbCB3aGVuIEdQVQorICAgICAgICBwcm9jZXNz IGlzIGRpc2FibGVkLgorCiAyMDIxLTA4LTA3ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gV2ViIHByb2Nlc3MgY3Jhc2hlcyB3aGVuIGRl dGFjaGluZyBEb2N1bWVudCB3aXRoIHVuY29tbWl0dGVkIG1hcmtlZCB0ZXh0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4gYi9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4KaW5kZXgg Yzg3ZWE3NjljMTE2OTM5ODhjZWFmYmFiYmU2YjQ5M2U3Njg4YWNhNS4uZjBkZDE2MzdlY2Y5Y2U2 ZGI1OTAyZTQxMzM2NGM0OWU3ZDRmZDEzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCisrKyBiL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgpAQCAtMTQ0NCw2ICsxNDQ0LDE5IEBA CiApCiAjZW5kaWYKIAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTIw MDAwCis7OyByZGFyOi8vODE3MjcwOTQuIFJlbW92ZSB3aGVuIEdQVSBwcm9jZXNzIGlzIGVuYWJs ZWQgYnkgZGVmYXVsdC4KKzs7IFJlcXVpcmVkIGZvciBDb3JlQXVkaW8gQXVkaW9PdXRwdXRVbml0 U3RhcnQgY2FsbC4KKyh3aGVuIChkZWZpbmVkPyAnc3lzY2FsbC11bml4KQorICAgIChhbGxvdyBz eXNjYWxsLXVuaXgKKyAgICAgICAgKHJlcXVpcmUtYWxsCisgICAgICAgICAgICAocmVxdWlyZS1u b3QgKGV4dGVuc2lvbiAiY29tLmFwcGxlLndlYmtpdC5leHRlbnNpb24ubWFjaCIpKQorICAgICAg ICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19nZXRwcmlvcml0eSkKKyAgICAgICAgKQorICAgICkK KykKKyNlbmRpZgorCiAjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0 MDAgfHwgUExBVEZPUk0oTUFDQ0FUQUxZU1QpCiAoZGVueSBtYWNoLWxvb2t1cCAod2l0aCBuby1s b2cpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuQ29yZVNlcnZpY2VzLmNvcmVzZXJ2aWNl c2QiKQo= 435316 2021-08-10 18:47:18 -0700 2021-08-11 19:27:45 -0700 Patch bug-228944-20210811114717.patch text/plain 1496 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwODcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZhYjNmNTRkMmQ1NjExN2Fl M2E1ZWQ0MDkyNjJmOGU5OTgwOTQ1OGEuLjY1OTViOWFkMGFiODFkMjY2MmE5ZGM5MzIxMWE4NjVi YTkyMDFkNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDgtMDkgIEplYW4tWXZl cyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KKworICAgICAgICBbTW9udGVyZXldIFdlYkNvbnRl bnQgcHJvY2VzcyBpbW1lZGlhdGVseSBjcmFzaCB3aGVuIEdQVSBQcm9jZXNzIGlzIGRpc2FibGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg5NDQK KyAgICAgICAgcmRhcjovLzgxNzI3MDk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmlu OiBBbGxvdyBTWVNfZ2V0cHJpb3JpdHkgc3lzY2FsbCB3aGVuIEdQVQorICAgICAgICBwcm9jZXNz IGlzIGRpc2FibGVkLgorCiAyMDIxLTA4LTEwICBBbmRyZXMgR29uemFsZXogIDxhbmRyZXNnXzIy QGFwcGxlLmNvbT4KIAogICAgICAgICBOb3RpZnkgYWNjZXNzaWJpbGl0eSB0aGF0IFdlYlByb2Nl c3MgaXMgc3VzcGVuZGVkIHdoZW4gaW4gcHJvY2VzcyBjYWNoZS4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbiBiL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgppbmRleCBjODdlYTc2 OWMxMTY5Mzk4OGNlYWZiYWJiZTZiNDkzZTc2ODhhY2E1Li44MDczYTE0NGYzYzk0MzhmZTU4ZDY2 YmY4OGE3ZjBiMDAyMWU2YmE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv Y29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCkBAIC0yMDQ0LDYgKzIwNDQsNyBAQAogICAgICAg ICAoc3lzY2FsbC1udW1iZXIgU1lTX3NldGF0dHJsaXN0KSA7OyByZGFyOi8vcHJvYmxlbS83NDE2 Mjc3NwogI2VuZGlmCiAgICAgICAgIChzeXNjYWxsLW51bWJlciBTWVNfb3Blbl9kcHJvdGVjdGVk X25wKSA7OyA8cmRhcjovL3Byb2JsZW0vNzQ0NzM4MjQ+CisgICAgICAgIChzeXNjYWxsLW51bWJl ciBTWVNfZ2V0cHJpb3JpdHkpIDs7IHJkYXI6Ly84MTcyNzA5NC4gUmVxdWlyZWQgZm9yIENvcmVB dWRpbyBBdWRpb091dHB1dFVuaXRTdGFydCBjYWxsLiBSZW1vdmUgd2hlbiBHUFUgcHJvY2VzcyBp cyBlbmFibGVkIGJ5IGRlZmF1bHQuCiAgICAgKQogCiAgICAgKGlmIChlcXVhbD8gKHBhcmFtICJD UFUiKSAiYXJtNjQiKQo= 435391 2021-08-11 19:27:49 -0700 2021-08-11 20:48:37 -0700 Patch bug-228944-20210812122748.patch text/plain 1470 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwOTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdjNDljMDBkY2EwYWRhOGFj OGU2YjE2MWIzY2Q1MjY4MDdmYTEwOTUuLjRiZWZiNGQwMWVhM2I4YjYzMTAxNWZhOWY1ZTljYmNh OWEwODgwZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDgtMDkgIEplYW4tWXZl cyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KKworICAgICAgICBbTW9udGVyZXldIFdlYkNvbnRl bnQgcHJvY2VzcyBpbW1lZGlhdGVseSBjcmFzaCB3aGVuIEdQVSBQcm9jZXNzIGlzIGRpc2FibGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg5NDQK KyAgICAgICAgcmRhcjovLzgxNzI3MDk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmlu OiBBbGxvdyBTWVNfZ2V0cHJpb3JpdHkgc3lzY2FsbC4KKwogMjAyMS0wOC0xMSAgRGFyaW4gQWRs ZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGRlZHVjdGlvbiBndWlkZSB0byBS ZXRhaW5QdHIsIHVzZSBjb25zdGV4cHIgYSBiaXQgbW9yZSwgYW5kIHN0cmVhbWxpbmUgdGhlIGlt cGxlbWVudGF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFw cGxlLldlYlByb2Nlc3Muc2IuaW4gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxl LldlYlByb2Nlc3Muc2IuaW4KaW5kZXggYzg3ZWE3NjljMTE2OTM5ODhjZWFmYmFiYmU2YjQ5M2U3 Njg4YWNhNS4uODA3M2ExNDRmM2M5NDM4ZmU1OGQ2NmJmODhhN2YwYjAwMjFlNmJhNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmlu CisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5p bgpAQCAtMjA0NCw2ICsyMDQ0LDcgQEAKICAgICAgICAgKHN5c2NhbGwtbnVtYmVyIFNZU19zZXRh dHRybGlzdCkgOzsgcmRhcjovL3Byb2JsZW0vNzQxNjI3NzcKICNlbmRpZgogICAgICAgICAoc3lz Y2FsbC1udW1iZXIgU1lTX29wZW5fZHByb3RlY3RlZF9ucCkgOzsgPHJkYXI6Ly9wcm9ibGVtLzc0 NDczODI0PgorICAgICAgICAoc3lzY2FsbC1udW1iZXIgU1lTX2dldHByaW9yaXR5KSA7OyByZGFy Oi8vODE3MjcwOTQuIFJlcXVpcmVkIGZvciBDb3JlQXVkaW8gQXVkaW9PdXRwdXRVbml0U3RhcnQg Y2FsbC4gUmVtb3ZlIHdoZW4gR1BVIHByb2Nlc3MgaXMgZW5hYmxlZCBieSBkZWZhdWx0LgogICAg ICkKIAogICAgIChpZiAoZXF1YWw/IChwYXJhbSAiQ1BVIikgImFybTY0IikK