228938 2021-08-09 18:46:21 -0700 [GTK][WPE] REGRESSION(r280795): MemoryPressureHandlerUnix.cpp:45:28: error: ‘LogMemoryPressure’ was not declared in this scope 2021-08-09 21:36:53 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fujii fujii benjamin cdumez cmarcelo ews-watchlist webkit-bug-importer oldest_to_newest 1783059 0 fujii 2021-08-09 18:46:21 -0700 [GTK][WPE] REGRESSION(r280795): MemoryPressureHandlerUnix.cpp:45:28: error: ‘LogMemoryPressure’ was not declared in this scope FAILED: Source/WTF/wtf/CMakeFiles/WTF.dir/unix/MemoryPressureHandlerUnix.cpp.o /usr/bin/ccache /usr/bin/c++ -DBUILDING_GTK__=1 -DBUILDING_WITH_CMAKE=1 -DBUILDING_WTF -DGETTEXT_PACKAGE=\"WebKit2GTK-4.1\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DSTATICALLY_LINKED_WITH_bmalloc -DWEBKITGTK_API_VERSION_STRING=\"4.1\" -I. -IWTF/DerivedSources -I../../Source/WTF -I../../Source/WTF/wtf -I../../Source/WTF/wtf/dtoa -I../../Source/WTF/wtf/persistence -I../../Source/WTF/wtf/text -I../../Source/WTF/wtf/text/icu -I../../Source/WTF/wtf/threads -I../../Source/WTF/wtf/unicode -Ibmalloc/Headers -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/glib-2.0 -isystem /usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem /usr/include/libmount -isystem /usr/include/blkid -fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined -Wno-noexcept-type -Wno-psabi -Wno-misleading-indentation -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -Wno-tautological-compare -fno-strict-aliasing -fno-exceptions -fno-rtti -gsplit-dwarf -g -fPIC -fvisibility=hidden -std=c++17 -MD -MT Source/WTF/wtf/CMakeFiles/WTF.dir/unix/MemoryPressureHandlerUnix.cpp.o -MF Source/WTF/wtf/CMakeFiles/WTF.dir/unix/MemoryPressureHandlerUnix.cpp.o.d -o Source/WTF/wtf/CMakeFiles/WTF.dir/unix/MemoryPressureHandlerUnix.cpp.o -c ../../Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp In file included from ../../Source/WTF/wtf/StdLibExtras.h:32, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/WTF/config.h:31, from ../../Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp:28: ../../Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp: In member function ‘void WTF::MemoryPressureHandler::triggerMemoryPressureEvent(bool)’: ../../Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp:45:28: error: ‘LogMemoryPressure’ was not declared in this scope; did you mean ‘isUnderMemoryPressure’? 45 | #define LOG_CHANNEL_PREFIX Log | ^~~ ../../Source/WTF/wtf/Assertions.h:175:63: note: in definition of macro ‘JOIN_LOG_CHANNEL_WITH_PREFIX_LEVEL_2’ 175 | #define JOIN_LOG_CHANNEL_WITH_PREFIX_LEVEL_2(prefix, channel) prefix ## channel | ^~~~~~ ../../Source/WTF/wtf/Assertions.h:172:27: note: in expansion of macro ‘JOIN_LOG_CHANNEL_WITH_PREFIX’ 172 | #define LOG_CHANNEL(name) JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, name) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WTF/wtf/Assertions.h:172:56: note: in expansion of macro ‘LOG_CHANNEL_PREFIX’ 172 | #define LOG_CHANNEL(name) JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, name) | ^~~~~~~~~~~~~~~~~~ ../../Source/WTF/wtf/Assertions.h:495:35: note: in expansion of macro ‘LOG_CHANNEL’ 495 | #define LOG(channel, ...) WTFLog(&LOG_CHANNEL(channel), __VA_ARGS__) | ^~~~~~~~~~~ ../../Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp:68:9: note: in expansion of macro ‘LOG’ 68 | LOG(MemoryPressure, "Got memory pressure notification (%s)", isCritical ? "critical" : "non-critical"); | ^~~ ../../Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp:45:28: error: ‘LogMemoryPressure’ was not declared in this scope; did you mean ‘isUnderMemoryPressure’? 45 | #define LOG_CHANNEL_PREFIX Log | ^~~ ../../Source/WTF/wtf/Assertions.h:175:63: note: in definition of macro ‘JOIN_LOG_CHANNEL_WITH_PREFIX_LEVEL_2’ 175 | #define JOIN_LOG_CHANNEL_WITH_PREFIX_LEVEL_2(prefix, channel) prefix ## channel | ^~~~~~ ../../Source/WTF/wtf/Assertions.h:172:27: note: in expansion of macro ‘JOIN_LOG_CHANNEL_WITH_PREFIX’ 172 | #define LOG_CHANNEL(name) JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, name) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WTF/wtf/Assertions.h:172:56: note: in expansion of macro ‘LOG_CHANNEL_PREFIX’ 172 | #define LOG_CHANNEL(name) JOIN_LOG_CHANNEL_WITH_PREFIX(LOG_CHANNEL_PREFIX, name) | ^~~~~~~~~~~~~~~~~~ ../../Source/WTF/wtf/Assertions.h:495:35: note: in expansion of macro ‘LOG_CHANNEL’ 495 | #define LOG(channel, ...) WTFLog(&LOG_CHANNEL(channel), __VA_ARGS__) | ^~~~~~~~~~~ ../../Source/WTF/wtf/unix/MemoryPressureHandlerUnix.cpp:77:9: note: in expansion of macro ‘LOG’ 77 | LOG(MemoryPressure, "System is no longer under memory pressure."); | ^~~ 1783060 1 435230 fujii 2021-08-09 18:47:29 -0700 Created attachment 435230 Patch 1783075 2 ews-feeder 2021-08-09 19:30:04 -0700 Committed r280821 (240384@main): <https://commits.webkit.org/240384@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435230. 1783079 3 webkit-bug-importer 2021-08-09 19:40:21 -0700 <rdar://problem/81724322> 435230 2021-08-09 18:47:29 -0700 2021-08-09 21:36:53 -0700 Patch bug-228938-20210810104726.patch text/plain 1470 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE3MTRlMDllODY2ZGMwYTQ1YTIzODE0 NzEyNDAzYWFmZWY5NDRkYTkuLjY0MTYyZGI0NGFmOWY2M2Y1ODMwMmE0NTVlMWE5ZjlkMDZlOTFi MDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMDgtMDkgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBSRUdSRVNTSU9OKHIy ODA3OTUpOiBNZW1vcnlQcmVzc3VyZUhhbmRsZXJVbml4LmNwcDo0NToyODogZXJyb3I6IOKAmExv Z01lbW9yeVByZXNzdXJl4oCZIHdhcyBub3QgZGVjbGFyZWQgaW4gdGhpcyBzY29wZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4OTM4CisKKyAgICAg ICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCisKKyAgICAgICAgKiB3dGYvdW5peC9NZW1vcnlQcmVz c3VyZUhhbmRsZXJVbml4LmNwcDoKKwogMjAyMS0wOC0wOSAgRnVqaWkgSGlyb25vcmkgIDxIaXJv bm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBbV1RGXVtXaW5dIFJFR1JFU1NJT04ocjI4 MDc5NSkgZXJyb3IgTE5LMjAxOTogdW5yZXNvbHZlZCBleHRlcm5hbCBzeW1ib2wgImNsYXNzIFdU Rjo6U3RyaW5nIF9fY2RlY2wgV1RGOjpsb2dMZXZlbFN0cmluZyh2b2lkKSIKZGlmZiAtLWdpdCBh L1NvdXJjZS9XVEYvd3RmL3VuaXgvTWVtb3J5UHJlc3N1cmVIYW5kbGVyVW5peC5jcHAgYi9Tb3Vy Y2UvV1RGL3d0Zi91bml4L01lbW9yeVByZXNzdXJlSGFuZGxlclVuaXguY3BwCmluZGV4IDRiY2Qy NGY0NzAzODYzZTE1ZGRhNmExODIzMDczY2NlZTM3MGM2NzQuLjhjNTBlNGNlMDZjZTIxYjk1YWZm Mjg5MWY5ZWQ5MWJiOTY3NDI4ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3VuaXgvTWVt b3J5UHJlc3N1cmVIYW5kbGVyVW5peC5jcHAKKysrIGIvU291cmNlL1dURi93dGYvdW5peC9NZW1v cnlQcmVzc3VyZUhhbmRsZXJVbml4LmNwcApAQCAtMzAsNiArMzAsNyBAQAogCiAjaW5jbHVkZSA8 bWFsbG9jLmg+CiAjaW5jbHVkZSA8dW5pc3RkLmg+CisjaW5jbHVkZSA8d3RmL0xvZ2dpbmcuaD4K ICNpbmNsdWRlIDx3dGYvTWFpblRocmVhZC5oPgogI2luY2x1ZGUgPHd0Zi9NZW1vcnlGb290cHJp bnQuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KQEAgLTQyLDggKzQzLDYgQEAK ICNpbmNsdWRlIDxzeXMvdXNlci5oPgogI2VuZGlmCiAKLSNkZWZpbmUgTE9HX0NIQU5ORUxfUFJF RklYIExvZwotCiBuYW1lc3BhY2UgV1RGIHsKIAogLy8gRGlzYWJsZSBtZW1vcnkgZXZlbnQgcmVj ZXB0aW9uIGZvciBhIG1pbmltdW0gb2Ygc19taW5pbXVtSG9sZE9mZlRpbWUK