228929 2021-08-09 15:45:57 -0700 Don't instantiate a SYNotesActivationObserver to just say that it's not active or visible. 2021-08-10 10:40:27 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner webkit-bug-importer wenson_hsieh oldest_to_newest 1783005 0 megan_gardner 2021-08-09 15:45:57 -0700 Don't instantiate a SYNotesActivationObserver to just say that it's not active or visible. 1783006 1 435219 megan_gardner 2021-08-09 15:48:23 -0700 Created attachment 435219 Patch 1783008 2 435219 wenson_hsieh 2021-08-09 15:51:07 -0700 Comment on attachment 435219 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435219&action=review > Source/WebKit/UIProcess/Cocoa/WebPageProxyCocoa.mm:602 > if (!m_appHighlightsObserver) > - setUpHighlightsObserver(); > + return false; Nit - I think you can just remove this early return altogether. 1783018 3 435224 megan_gardner 2021-08-09 16:25:59 -0700 Created attachment 435224 Patch 1783206 4 ews-feeder 2021-08-10 10:29:47 -0700 Committed r280850 (240395@main): <https://commits.webkit.org/240395@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435224. 1783215 5 webkit-bug-importer 2021-08-10 10:40:27 -0700 <rdar://problem/81750820> 435219 2021-08-09 15:48:23 -0700 2021-08-09 15:51:07 -0700 Patch bug-228929-20210809154822.patch text/plain 1981 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI1MGUzMGE0MjZjY2FmZGE0 Mjk0ODM4NWU5ZjIxNTEwMGMwNzhiMzcuLmU5MDJiZjIzZTlkYTFlZTFlN2Q0MjVhNTE3ZmJhNmFj Y2I5Mzc3OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDgtMDkgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBpbnN0YW50 aWF0ZSBhIFNZTm90ZXNBY3RpdmF0aW9uT2JzZXJ2ZXIgdG8ganVzdCBzYXkgdGhhdCBpdCdzIG5v dCBhY3RpdmUgb3IgdmlzaWJsZS4gCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjg5MjkKKyAgICAgICAgcmRhcjovLzgxNjM0MTgyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgd2UgZG8gbm90IGhhdmUg YW4gU1lOb3Rlc0FjdGl2YXRpb25PYnNlcnZlciB0aGVuIHdlIGRvIG5vdCBuZWVkIHRvIG1ha2Ug b25lIHRvIHNheSB0aGF0IGl0IGlzIG5vdCB2aXNpYmxlCisgICAgICAgIG9yIHRoYXQgaXQncyBu b3Qgb2NjdWRpbmcgdGhlIHNjcmVlbi4gVGhpcyBpcyBhIHBlcmZvcm1hbmNlIG9wdGltaXphdGlv biBmb3IgYWxsIFdlYlZpZXdzIHRoYXQgYXJlIG5vdCAKKyAgICAgICAgaW4gU2FmYXJpIGFzIHdl bGwgYXMgYWxsIHBhZ2VzIHRoYXQgZG8gbm90IGhhdmUgaGlnaGxpZ2h0cyB0byByZXN0b3JlLgor CisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlBhZ2VQcm94eUNvY29hLm1tOgorICAgICAg ICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmFwcEhpZ2hsaWdodHNWaXNpYmlsaXR5KToKKyAgICAg ICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjphcHBIaWdobGlnaHRzT3ZlcmxheVJlY3QpOgorCiAy MDIxLTA4LTA1ICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgogCiAg ICAgICAgIExvYWRXZWJBcmNoaXZlLkZhaWxOYXZpZ2F0aW9uMSB0ZXN0IGlzIGEgZmFsc2UgcG9z aXRpdmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlBhZ2VQ cm94eUNvY29hLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUGFnZVByb3h5 Q29jb2EubW0KaW5kZXggZDg5ZWJhMmIxMzQ3MWM0YTNjZTk3OTgyZmZiZjdhN2ViYmZmYzljZS4u NmVmMmI5NTMxMjZlZDM2OWI1ZWQ3OWI5MmRhYTNjYWIxNDY0YjkxYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUGFnZVByb3h5Q29jb2EubW0KKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUGFnZVByb3h5Q29jb2EubW0KQEAgLTU5OSwx NCArNTk5LDE0IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpzZXRBcHBIaWdobGlnaHRzVmlzaWJpbGl0 eShXZWJDb3JlOjpIaWdobGlnaHRWaXNpYmlsaXR5IGFwcEhpCiBib29sIFdlYlBhZ2VQcm94eTo6 YXBwSGlnaGxpZ2h0c1Zpc2liaWxpdHkoKQogewogICAgIGlmICghbV9hcHBIaWdobGlnaHRzT2Jz ZXJ2ZXIpCi0gICAgICAgIHNldFVwSGlnaGxpZ2h0c09ic2VydmVyKCk7CisgICAgICAgIHJldHVy biBmYWxzZTsKICAgICByZXR1cm4gW21fYXBwSGlnaGxpZ2h0c09ic2VydmVyIGlzVmlzaWJsZV07 CiB9CiAKIENHUmVjdCBXZWJQYWdlUHJveHk6OmFwcEhpZ2hsaWdodHNPdmVybGF5UmVjdCgpCiB7 CiAgICAgaWYgKCFtX2FwcEhpZ2hsaWdodHNPYnNlcnZlcikKLSAgICAgICAgc2V0VXBIaWdobGln aHRzT2JzZXJ2ZXIoKTsKKyAgICAgICAgcmV0dXJuIENHUmVjdE51bGw7CiAgICAgcmV0dXJuIFtt X2FwcEhpZ2hsaWdodHNPYnNlcnZlciB2aXNpYmxlRnJhbWVdOwogfQogCg== 435224 2021-08-09 16:25:59 -0700 2021-08-10 10:29:47 -0700 Patch bug-228929-20210809162558.patch text/plain 1960 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI1MGUzMGE0MjZjY2FmZGE0 Mjk0ODM4NWU5ZjIxNTEwMGMwNzhiMzcuLmU5MDJiZjIzZTlkYTFlZTFlN2Q0MjVhNTE3ZmJhNmFj Y2I5Mzc3OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDgtMDkgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBEb24ndCBpbnN0YW50 aWF0ZSBhIFNZTm90ZXNBY3RpdmF0aW9uT2JzZXJ2ZXIgdG8ganVzdCBzYXkgdGhhdCBpdCdzIG5v dCBhY3RpdmUgb3IgdmlzaWJsZS4gCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjg5MjkKKyAgICAgICAgcmRhcjovLzgxNjM0MTgyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgd2UgZG8gbm90IGhhdmUg YW4gU1lOb3Rlc0FjdGl2YXRpb25PYnNlcnZlciB0aGVuIHdlIGRvIG5vdCBuZWVkIHRvIG1ha2Ug b25lIHRvIHNheSB0aGF0IGl0IGlzIG5vdCB2aXNpYmxlCisgICAgICAgIG9yIHRoYXQgaXQncyBu b3Qgb2NjdWRpbmcgdGhlIHNjcmVlbi4gVGhpcyBpcyBhIHBlcmZvcm1hbmNlIG9wdGltaXphdGlv biBmb3IgYWxsIFdlYlZpZXdzIHRoYXQgYXJlIG5vdCAKKyAgICAgICAgaW4gU2FmYXJpIGFzIHdl bGwgYXMgYWxsIHBhZ2VzIHRoYXQgZG8gbm90IGhhdmUgaGlnaGxpZ2h0cyB0byByZXN0b3JlLgor CisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlBhZ2VQcm94eUNvY29hLm1tOgorICAgICAg ICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OmFwcEhpZ2hsaWdodHNWaXNpYmlsaXR5KToKKyAgICAg ICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjphcHBIaWdobGlnaHRzT3ZlcmxheVJlY3QpOgorCiAy MDIxLTA4LTA1ICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgogCiAg ICAgICAgIExvYWRXZWJBcmNoaXZlLkZhaWxOYXZpZ2F0aW9uMSB0ZXN0IGlzIGEgZmFsc2UgcG9z aXRpdmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlBhZ2VQ cm94eUNvY29hLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUGFnZVByb3h5 Q29jb2EubW0KaW5kZXggZDg5ZWJhMmIxMzQ3MWM0YTNjZTk3OTgyZmZiZjdhN2ViYmZmYzljZS4u YzcxOTBmOGZmNjhhYWZjMGQxY2ZjMjcwMTZkNDBmMTc1MTk0MjQ4ZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUGFnZVByb3h5Q29jb2EubW0KKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUGFnZVByb3h5Q29jb2EubW0KQEAgLTU5OCwx NSArNTk4LDEzIEBAIHZvaWQgV2ViUGFnZVByb3h5OjpzZXRBcHBIaWdobGlnaHRzVmlzaWJpbGl0 eShXZWJDb3JlOjpIaWdobGlnaHRWaXNpYmlsaXR5IGFwcEhpCiAKIGJvb2wgV2ViUGFnZVByb3h5 OjphcHBIaWdobGlnaHRzVmlzaWJpbGl0eSgpCiB7Ci0gICAgaWYgKCFtX2FwcEhpZ2hsaWdodHNP YnNlcnZlcikKLSAgICAgICAgc2V0VXBIaWdobGlnaHRzT2JzZXJ2ZXIoKTsKICAgICByZXR1cm4g W21fYXBwSGlnaGxpZ2h0c09ic2VydmVyIGlzVmlzaWJsZV07CiB9CiAKIENHUmVjdCBXZWJQYWdl UHJveHk6OmFwcEhpZ2hsaWdodHNPdmVybGF5UmVjdCgpCiB7CiAgICAgaWYgKCFtX2FwcEhpZ2hs aWdodHNPYnNlcnZlcikKLSAgICAgICAgc2V0VXBIaWdobGlnaHRzT2JzZXJ2ZXIoKTsKKyAgICAg ICAgcmV0dXJuIENHUmVjdE51bGw7CiAgICAgcmV0dXJuIFttX2FwcEhpZ2hsaWdodHNPYnNlcnZl ciB2aXNpYmxlRnJhbWVdOwogfQogCg==