228900 2021-08-07 13:08:13 -0700 [ews] Limit the size of error context buffer 2021-08-09 04:44:44 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dewei_zhu jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1782722 0 aakash_jain 2021-08-07 13:08:13 -0700 In EWS, when build fails, we provide a filtered log for errors. In that log, apart from filtering lines containign the word Error, we also include few lines before that to provide additional context. However, sometimes, those additional context line might be pretty large (almost the whole log). For e.g.: in https://ews-build.webkit.org/#/builders/36/builds/42029 overall stdio logs were 9171 lines, while filtered error log was 9150 lines (almost same length as complete logs). This defeats the purpose of filtering. Also adding large number of lines in the filtered error logs slow down the build (e.g.: in https://ews-build.webkit.org/#/builders/36/builds/42029 in step 15 the actual script took ~3 minutes (183 seconds), while the step took ~5 minutes). I have noticed few times that after the step is finished, adding logs in error view takes long time when there are large amount of lines being added to errors log. We should limit the number of additional lines we add in errors log. 1782724 1 435134 aakash_jain 2021-08-07 13:12:44 -0700 Created attachment 435134 Patch 1782726 2 aakash_jain 2021-08-07 13:18:16 -0700 Tested on uat instance. With this patch: https://ews-build.webkit-uat.org/#/builders/35/builds/105397 (see errors log in step 11) Without this patch: https://ews-build.webkit-uat.org/#/builders/35/builds/105398 (see errors log in step 11) 1782729 3 webkit-bug-importer 2021-08-07 13:26:25 -0700 <rdar://problem/81657334> 1782744 4 ews-feeder 2021-08-07 18:20:54 -0700 Committed r280763 (240348@main): <https://commits.webkit.org/240348@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435134. 1782867 5 aakash_jain 2021-08-09 04:44:44 -0700 Restarted buildbot to pick up this fix 435134 2021-08-07 13:12:44 -0700 2021-08-07 18:20:55 -0700 Patch bug-228900-20210807161243.patch text/plain 1193 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4MDc1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIxLTA4LTA3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBMaW1pdCB0aGUgc2l6ZSBvZiBlcnJvciBjb250ZXh0IGJ1ZmZl cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4OTAw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDSVN1 cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoQnVpbGRMb2dMaW5lT2JzZXJ2ZXIu b3V0TGluZVJlY2VpdmVkKTogTGltaXQgdGhlIGxpbmVzIGZvciBhZGRpdGlvbmFsIGNvbnRleHQg dG8gNTAgbGluZXMuCisKIDIwMjEtMDgtMDYgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBw bGUuY29tPgogCiAgICAgICAgIFtnaXQtd2Via2l0XSBBZGQgc2V0dXAgZnVuY3Rpb24KSW5kZXg6 IFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv Q0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjgwNzU4KQorKysgVG9vbHMv Q0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMTUyOSw3ICsx NTI5LDcgQEAgY2xhc3MgQnVpbGRMb2dMaW5lT2JzZXJ2ZXIobG9nb2JzZXJ2ZXIuTAogICAgICAg ICAgICAgc2VsZi5lcnJvcl9jb250ZXh0X2J1ZmZlci5hcHBlbmQobGluZSkKIAogICAgICAgICBp ZiBzZWxmLnNlYXJjaFN0cmluZyBpbiBsaW5lOgotICAgICAgICAgICAgZm9yIGxvZyBpbiBzZWxm LmVycm9yX2NvbnRleHRfYnVmZmVyOgorICAgICAgICAgICAgZm9yIGxvZyBpbiBzZWxmLmVycm9y X2NvbnRleHRfYnVmZmVyWy01MDpdOgogICAgICAgICAgICAgICAgIHNlbGYuZXJyb3JSZWNlaXZl ZChsb2cpCiAgICAgICAgICAgICBzZWxmLmVycm9yX2NvbnRleHRfYnVmZmVyID0gW10KIAo=