228899 2021-08-07 12:30:55 -0700 Update logging docs after r280758 2021-08-09 20:21:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 228809 1 mmaxfield mmaxfield darin fujii rniwa twilco.o webkit-bug-importer oldest_to_newest 1782717 0 mmaxfield 2021-08-07 12:30:55 -0700 Update logging docs after r280758 1782718 1 435133 mmaxfield 2021-08-07 12:31:22 -0700 Created attachment 435133 Patch 1783072 2 435133 fujii 2021-08-09 19:27:24 -0700 Comment on attachment 435133 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435133&action=review LGTM > Introduction.md:1372 > +Here's an exmaple invocation of `LOG()`: exmaple → example 1783091 3 mmaxfield 2021-08-09 20:12:00 -0700 Committed r280823 (240386@main): <https://commits.webkit.org/240386@main> 1783094 4 webkit-bug-importer 2021-08-09 20:21:23 -0700 <rdar://problem/81725351> 435133 2021-08-07 12:31:22 -0700 2021-08-09 19:27:24 -0700 Patch bug-228899-20210807123122.patch text/plain 6909 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNzU4CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFu Z2VMb2cKaW5kZXggMjRkYjk4M2M1MTdmY2MyOWRlZDc1MTkzNjcwNzU2NTYyZTJjYmI0Ny4uMmM2 NzhmNzhkNDQwZjZiODMzZDQwNjIxNDJjMjRiODc3OGY1MTQyNiAxMDA2NDQKLS0tIGEvQ2hhbmdl TG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTA4LTA3ICBNeWxlcyBD LiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIGxvZ2dp bmcgZG9jcyBhZnRlciByMjgwNzU4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjg4OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgbW9yZSBpbmZvcm1hdGlvbiBhYm91dCBsb2dnaW5nLgorCisgICAg ICAgICogSW50cm9kdWN0aW9uLm1kOgorCiAyMDIxLTA4LTA1ICBNaWNoYWVsIENhdGFuemFybyAg PG1jYXRhbnphcm9AZ25vbWUub3JnPgogCiAgICAgICAgIEdDQyAxMSBidWlsZHMgc2hvdWxkIHVz ZSAtV25vLWFycmF5LWJvdW5kcywgLVduby1ub25udWxsCmRpZmYgLS1naXQgYS9JbnRyb2R1Y3Rp b24ubWQgYi9JbnRyb2R1Y3Rpb24ubWQKaW5kZXggMGEyMWJhNjE0MjM3OTc0N2E4NjczZDIzZmU2 ZDA0MzdiZTMwZGIxNi4uOGI0NjQzN2YzNTQ5M2ZhMmNjODA2ZjNmNDdmN2E2MzE5ZTFlMDA5YyAx MDA2NDQKLS0tIGEvSW50cm9kdWN0aW9uLm1kCisrKyBiL0ludHJvZHVjdGlvbi5tZApAQCAtMTM0 NCwyMyArMTM0NCw3OCBAQCBGSVhNRTogVGFsayBhYm91dCBob3cgdG8gZGVidWcgQVBJIHRlc3Rz LgogCiAjIExvZ2dpbmcgaW4gV2ViS2l0CiAKLVNvbWUgcGxhY2VzIGluIFdlYktpdCB1c2UgYSBt YWNybyBjYWxsZWQgYExPR19XSVRIX1NUUkVBTWAuIEhlcmUncyBhbiBleGFtcGxlIGludm9jYXRp b246CisjIyBTZXR1cAorCitFYWNoIGZyYW1ld29yayAoV2ViQ29yZSwgV2ViS2l0LCBXZWJLaXRM ZWdhY3ksIFdURikgZW5hYmxlIHRoZWlyIG93biBsb2dnaW5nIGluZnJhc3RydWN0dXJlIGluZGVw ZW5kZW50bHkgKHRob3VnaCB0aGUgaW5mcmFzdHJ1Y3R1cmUgaXRzZWxmIGlzIHNoYXJlZCkuIElm IHlvdSB3YW50IHRvIGxvZyBhIG1lc3NhZ2UsIGAjaW5jbHVkZWAgdGhlIHJlbGV2YW50IGZyYW1l d29yaydzIGBMb2dnaW5nLmhgIGhlYWRlci4gVGhlbiwgeW91IGNhbiB1c2UgdGhlIG1hY3JvcyBi ZWxvdy4KKworQmV3YXJlIHRoYXQgeW91IGNhbid0IGAjaW5jbHVkZWAgbXVsdGlwbGUgZnJhbWV3 b3JrJ3MgYExvZ2dpbmcuaGAgaGVhZGVycyBhdCB0aGUgc2FtZSB0aW1lIC0gdGhleSBlYWNoIGRl ZmluZSBhIG1hY3JvIGBMT0dfQ0hBTk5FTF9QUkVGSVhgIHdoaWNoIHdpbGwgY29uZmxpY3Qgd2l0 aCBlYWNoIG90aGVyLiBPbmx5IGAjaW5jbHVkZWAgdGhlIGBMb2dnaW5nLmhgIGhlYWRlciBmcm9t IHlvdXIgc3BlY2lmaWMgZnJhbWV3b3JrLgorCitJZiB5b3Ugd2FudCB0byBkbyBtb3JlIGFkdmFu Y2VkIG9wZXJhdGlvbnMsIGxpa2Ugc2VhcmNoaW5nIHRocm91Z2ggdGhlIGxpc3Qgb2YgbG9nIGNo YW5uZWxzLCBgI2luY2x1ZGVgIHlvdXIgZnJhbWV3b3JrJ3MgYExvZ0luaXRpYWxpemF0aW9uLmhg IGhlYWRlci4gVGhlc2UgZG8gbm90IGNvbmZsaWN0IGFjcm9zcyBmcmFtZXdvcmtzLCBzbyB5b3Ug Y2FuIGRvIHNvbWV0aGluZyBsaWtlCisKK2BgYAorI2luY2x1ZGUgIkxvZ0luaXRpYWxpemF0aW9u LmgiCisjaW5jbHVkZSA8V2ViQ29yZS9Mb2dJbml0aWFsaXphdGlvbi5oPgorI2luY2x1ZGUgPFdU Ri9Mb2dJbml0aWFsaXphdGlvbi5oPgorYGBgCisKK0luZGVlZCwgV2ViS2l0IGRvZXMgdGhpcyB0 byBpbml0aWFsaXplIGFsbCBmcmFtZXdvcmtzJyBsb2cgY2hhbm5lbHMgZHVyaW5nIFdlYiBQcm9j ZXNzIHN0YXJ0dXAuCisKKyMjIExvZ2dpbmcgbWVzc2FnZXMKKworVGhlcmUgYXJlIGEgZmV3IHJl bGV2YW50IG1hY3JvcyBmb3IgbG9nZ2luZyBtZXNzYWdlczoKKworLSBgTE9HKClgOiBMb2cgYSBw cmludGYtc3R5bGUgbWVzc2FnZSBpbiBkZWJ1ZyBidWlsZHMuIFJlcXVpcmVzIHlvdSB0byBuYW1l IGEgbG9nZ2luZyBjaGFubmVsIHRvIG91dHB1dCB0by4KKy0gYExPR19XSVRIX1NUUkVBTSgpYCBM b2cgYW4gaW9zdHJlYW0tc3R5bGUgbWVzc2FnZSBpbiBkZWJ1ZyBidWlsZHMuIFJlcXVpcmVzIHlv dSB0byBuYW1lIGEgbG9nZ2luZyBjaGFubmVsIHRvIG91dHB1dCB0by4KKy0gYFJFTEVBU0VfTE9H KClgOiBKdXN0IGxpa2UgYExPRygpYCBidXQgbG9ncyBpbiBib3RoIGRlYnVnIGFuZCByZWxlYXNl IGJ1aWxkcy4gUmVxdWlyZXMgeW91IHRvIG5hbWUgYSBsb2dnaW5nIGNoYW5uZWwgdG8gb3V0cHV0 IHRvLgorLSBgV1RGTG9nQWx3YXlzKClgOiBNYWlubHkgZm9yIGxvY2FsIGRlYnVnZ2luZywgdW5j b25kaXRpb25hbGx5IG91dHB1dCBhIG1lc3NhZ2UuIERvZXMgbm90IHJlcXVpcmUgYSBsb2dnaW5n IGNoYW5uZWwgdG8gb3V0cHV0IHRvLgorCitIZXJlJ3MgYW4gZXhtYXBsZSBpbnZvY2F0aW9uIG9m IGBMT0coKWA6CisKK2BgYAorTE9HKE1lZGlhUXVlcmllcywgIkhUTUxNZWRpYUVsZW1lbnQgJXAg c2VsZWN0TmV4dFNvdXJjZUNoaWxkIGV2YWx1YXRpbmcgbWVkaWEgcXVlcmllcyIsIHRoaXMpOwor YGBgCisKK1RoYXQgZmlyc3QgYXJndW1lbnQgaXMgYSBsb2cgY2hhbm5lbC4gVGhlc2UgaGF2ZSAy IHB1cnBvc2VzOgorCistIEluZGl2aWR1YWwgY2hhbm5lbHMgY2FuIGJlIGVuYWJsZWQvZGlzYWJs ZWQgaW5kZXBlbmRlbnRseSAoU28geW91IGNhbiBnZXQgYWxsIHRoZSBXZWJHTCBsb2dnaW5nIHdp dGhvdXQgZ2V0dGluZyBhbnkgTG9hZGluZyBsb2dnaW5nKQorLSBXaGVuIG11bHRpcGxlIGNoYW5u ZWxzIGFyZSBlbmFibGVkLCBhbmQgeW91J3JlIHZpZXdpbmcgdGhlIGxvZ3MsIHlvdSBjYW4gc2Vh cmNoL2ZpbHRlciBieSB0aGUgY2hhbm5lbAorCitIZXJlJ3MgYW4gZXhhbXBsZSBpbnZvY2F0aW9u IG9mIGBMT0dfV0lUSF9TVFJFQU0oKWA6CiAKIGBgYAogTE9HX1dJVEhfU1RSRUFNKFNjcm9sbGlu Zywgc3RyZWFtIDw8ICJTY3JvbGxpbmdUcmVlOjpjb21taXRUcmVlU3RhdGUgLSByZW1vdmluZyB1 bnZpc2l0ZWQgbm9kZSAiIDw8IG5vZGVJRCk7CiBgYGAKIAotVGhlIGZpcnN0IGFyZ3VtZW50IGlz IHRoZSBfbG9nIGNoYW5uZWxfIGFuZCB0aGUgc2Vjb25kIGlzIHRoZSBfbG9nIGNvbnRlbnRfLiBC eSBkZWZhdWx0LCB0aGlzIGxvZ2dpbmcgaXMgZW5hYmxlZCBpbgotZGVidWcgYnVpbGRzIGFuZCBk aXNhYmxlZCBpbiByZWxlYXNlIGJ1aWxkcyAoc2VlIGRlZmluaXRpb24gb2YgYExPR19ESVNBQkxF RGApLgorVGhlIG1hY3JvIHNldHMgdXAgYSBsb2NhbCB2YXJpYWJsZSBuYW1lZCBgc3RyZWFtYCB3 aGljaCB0aGUgc2Vjb25kIGFyZ3VtZW50IGNhbiBkaXJlY3QgbWVzc2FnZXMgdG8uIFRoZSBzZWNv bmQgYXJndW1lbnQgaXMgYSBjb2xsZWN0aW9uIG9mIHN0YXRlbWVudHMgLSBub3QgZXhwcmVzc2lv bnMgbGlrZSBgTE9HKClgIGFuZCBgUkVMRUFTRV9MT0coKWAuIFNvLCB5b3UgY2FuIGRvIHRoaW5n cyBsaWtlIHRoaXM6CisKK2BgYAorTE9HX1dJVEhfU1RSRUFNKFRoZUxvZ0NoYW5uZWwsCisgICAg Zm9yIChjb25zdCBhdXRvJiBzb21ldGhpbmcgOiBzdHVmZlRvTG9nKQorICAgICAgICBzdHJlYW0g PDwgIiAiIDw8IHNvbWV0aGluZzsKKyk7CitgYGAKKworVGhlIHJlYXNvbiB3aHkgKG1vc3Qgb2Yp IHRoZXNlIHVzZSBtYWNyb3MgaXMgc28gdGhlIGVudGlyZSB0aGluZyBjYW4gYmUgY29tcGlsZWQg b3V0IHdoZW4gbG9nZ2luZyBpcyBkaXNhYmxlZC4gQ29uc2lkZXIgdGhpczoKKworYGBgCitMT0co VGhlTG9nQ2hhbm5lbCwgIlRoZSByZXN1bHQgaXMgJWQiLCBzb21lU3VwZXJDb21wbGljYXRlZENh bGN1bGF0aW9uKCkpOworYGBgCisKK0lmIHRoZXNlIHdlcmUgbm90IG1hY3JvcywgeW91J2QgaGF2 ZSB0byBwYXkgZm9yIGBzb21lU3VwZXJDb21wbGljYXRlZENhbGN1bGF0aW9uKClgIHdoZXRoZXIg bG9nZ2luZyBpcyBlbmFibGVkIG9yIG5vdC4KKworIyMgRW5hYmxpbmcgYW5kIGRpc2FibGluZyBs b2cgY2hhbm5lbHMKKworQ2hhbm5lbHMgYXJlIGVuYWJsZWQvZGlzYWJsZWQgYXQgc3RhcnR1cCBi eSBwYXNzaW5nIGEgY2FyZWZ1bGx5IGNyYWZ0ZWQgc3RyaW5nIHRvIGBpbml0aWFsaXplTG9nQ2hh bm5lbHNJZk5lY2Vzc2FyeSgpYC4gT24gdGhlIG1hY09TIGFuZCBpT1MgcG9ydHMsIHRoaXMgc3Ry aW5nIGNvbWVzIGZyb20gdGhlIF9kZWZhdWx0c18gZGF0YWJhc2UuIE9uIG90aGVyIFVOSVggc3lz dGVtcyBhbmQgV2luZG93cywgaXQgY29tZXMgZnJvbSBlbnZpcm9ubWVudCB2YXJpYWJsZXMuCiAK LVRoZSBvbmx5IGxvZ3MgdGhhdCB3aWxsIGJlIHByaW50ZWQgYXJlIHRob3NlIHdob3NlIGNoYW5u ZWxzIHlvdSBoYXZlIGVuYWJsZWQuIFlvdSBjYW4gc3BlY2lmeSB0aGUgY2hhbm5lbHMgeW91IHdh bnQgdG8KLWVuYWJsZSBieSBjb25zdHJ1Y3RpbmcgYSBjb21tYS1zZXBhcmF0ZWQgbGlzdCB3aXRo IHRoZSBmb2xsb3dpbmcgc3ludGF4OgorWW91IGNhbiByZWFkIHRoZSBncmFtbWFyIG9mIHRoaXMg c3RyaW5nIGluIGBpbml0aWFsaXplTG9nQ2hhbm5lbHNJZk5lY2Vzc2FyeSgpYC4gSGVyZSBpcyBh biBleGFtcGxlOgogCi0qIGBDaGFubmVsTmFtZWAgdG8gZW5hYmxlIGxvZ2dpbmcgZm9yIHRoaXMg Y2hhbm5lbAotKiBgYWxsYCB0byBlbmFibGUgbG9nZ2luZyBmb3IgYWxsIGNoYW5uZWxzCi0qIGAt Q2hhbm5lbE5hbWVgIHRvIGRpc2FibGUgbG9nZ2luZyBmb3IgdGhpcyBjaGFubmVsCitgYGAKK1dl YkdMIC1Mb2FkaW5nCitgYGAKIAotV2hlcmUgeW91IHNwZWNpZnkgdGhpcyBsaXN0IGRlcGVuZHMg b24gdGhlIHBsYXRmb3JtIHlvdSBhcmUgcnVubmluZyBXZWJLaXQgb24uCitZb3UgY2FuIGFsc28g c3BlY2lmeSB0aGUgc3RyaW5nIGBhbGxgIHRvIGVuYWJsZSBhbGwgbG9nZ2luZy4KKworT24gbWFj T1MvaU9TIGFuZCBXaW5kb3dzLCBlYWNoIGZyYW1ld29yayBoYXMgaXRzIG93biBpbmRpdmlkdWFs bHkgc3VwcGxpZWQgc3RyaW5nIHRoYXQgaXQgdXNlcyB0byBlbmFibGUgaXRzIG93biBsb2dnaW5n IGNoYW5uZWxzLiBPbiBMaW51eCwgYWxsIGZyYW1ld29ya3Mgc2hhcmUgdGhlIHNhbWUgc3RyaW5n LgogCiAjIyMgTGludXgKIApAQCAtMTM3MCwyMyArMTQyNSwyOCBAQCBTZXQgdGhlIGBXRUJLSVRf REVCVUdgIGVudmlyb25tZW50IHZhcmlhYmxlLgogV0VCS0lUX0RFQlVHPVNjcm9sbGluZyBUb29s cy9TY3JpcHRzL3J1bi1taW5pYnJvd3NlciAtLWd0ayAtLWRlYnVnCiBgYGAKIAotIyMjIE1hYwot Ci1TZXQgYSB2YWx1ZSBmb3IgdGhlIGBXZWJDb3JlTG9nZ2luZ2Aga2V5IGluIFtzdGFuZGFyZFVz ZXJEZWZhdWx0c10oaHR0cHM6Ly9kZXZlbG9wZXIuYXBwbGUuY29tL2RvY3VtZW50YXRpb24vZm91 bmRhdGlvbi9uc3VzZXJkZWZhdWx0cy8xNDE2NjAzLXN0YW5kYXJkdXNlcmRlZmF1bHRzKS4KKyMj IyBtYWNPUwogCi1Zb3UgbWF5IGFsc28gcGFzcyB0aGlzIGtleSBhbmQgdmFsdWUgYXMgYW4gYXJn dW1lbnQ6CitPbiBtYWNPUywgeW91IGNhbiBzdXBwbHkgdGhlc2Ugc3RyaW5ncyB3aXRoIHRoZXNl IHRlcm1pbmFsIGNvbW1hbmRzOgogCiBgYGAKLVRvb2xzL1NjcmlwdHMvcnVuLW1pbmlicm93c2Vy IC0tZGVidWcgLVdlYkNvcmVMb2dnaW5nIFNjcm9sbGluZworJSBkZWZhdWx0cyB3cml0ZSBjb20u YXBwbGUuV2ViS2l0LldlYkNvbnRlbnQgV1RGTG9nZ2luZyAiVGhyZWFkaW5nIgorJSBkZWZhdWx0 cyB3cml0ZSBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQgV2ViQ29yZUxvZ2dpbmcgIldlYkdM IgorJSBkZWZhdWx0cyB3cml0ZSBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQgV2ViS2l0Mkxv Z2dpbmcgIlJlc291cmNlTG9hZFN0YXRpc3RpY3MiCiBgYGAKIAotb3Igc2V0IHRoZSBrZXkgYW5k IHZhbHVlIG9uIHRoZSBbTlNHbG9iYWxEb21haW5dKGh0dHBzOi8vZGV2ZWxvcGVyLmFwcGxlLmNv bS9kb2N1bWVudGF0aW9uL2ZvdW5kYXRpb24vbnNnbG9iYWxkb21haW4pLgorWW91IG1heSBhbHNv IG5lZWQgdG8gc3BlY2lmeSB0aGVzZSBzdHJpbmdzIHRvIGBjb20uYXBwbGUuV2ViS2l0LldlYkNv bnRlbnQuRGV2ZWxvcG1lbnRgLCB0aGUgZ2xvYmFsIGRvbWFpbiwgb3IgdGhlIFNhZmFyaSBjb250 YWluZXIsIGRlcGVuZGluZyBvbiB3aGF0IHlvdSdyZSBydW5uaW5nLgorCitZb3UgbWF5IGFsc28g cGFzcyB0aGlzIGtleSBhbmQgdmFsdWUgYXMgYW4gYXJndW1lbnQ6CiAKIGBgYAotZGVmYXVsdHMg d3JpdGUgTlNHbG9iYWxEb21haW4gIFdlYkNvcmVMb2dnaW5nIC1zdHJpbmcgU2Nyb2xsaW5nCi1U b29scy9TY3JpcHRzL3J1bi1taW5pYnJvd3NlciAtLWRlYnVnCitUb29scy9TY3JpcHRzL3J1bi1t aW5pYnJvd3NlciAtLWRlYnVnIC1XZWJDb3JlTG9nZ2luZyBTY3JvbGxpbmcKIGBgYAogCiAjIyMg V2luZG93cwogCiBTZXQgdGhlIGBXZWJDb3JlTG9nZ2luZ2AgZW52aXJvbm1lbnQgdmFyaWFibGUu CisKKyMjIEFkZGluZyBhIG5ldyBsb2cgY2hhbm5lbAorCitTaW1wbHkgYWRkIGEgbGluZSB0byB5 b3VyIGZyYW1ld29yaydzIGBMb2dnaW5nLmhgIGhlYWRlci4gRGVwZW5kaW5nIG9uIGhvdyB0aGUg YWNjb21wYW55aW5nIGBMb2dnaW5nLmNwcGAgZmlsZSBpcyBzZXQgdXAsIHlvdSBtYXkgbmVlZCB0 byBhZGQgYSBwYXJhbGxlbCBsaW5lIHRoZXJlLiBUaGF0IHNob3VsZCBiZSBhbGwgeW91IG5lZWQu IEl0IGlzIGFjY2VwdGFibGUgdG8gaGF2ZSBsb2cgY2hhbm5lbHMgaW4gZGlmZmVyZW50IGZyYW1l d29ya3Mgd2l0aCB0aGUgc2FtZSBuYW1lIC0gdGhpcyBpcyB3aGF0IGBMT0dfQ0hBTk5FTF9QUkVG SVhgIGlzIGZvci4K