228878 2021-08-06 14:59:28 -0700 CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CryptoKeyRSA::exportJwk const 2021-08-07 04:56:43 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham ddkilzer ews-watchlist jiewen_tan webkit-bug-importer oldest_to_newest 1782580 0 katherine_cheney 2021-08-06 14:59:28 -0700 CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CryptoKeyRSA::exportJwk const 1782581 1 435093 katherine_cheney 2021-08-06 15:01:19 -0700 Created attachment 435093 Patch 1782582 2 katherine_cheney 2021-08-06 15:01:30 -0700 rdar://60147231 1782617 3 435093 bfulgham 2021-08-06 17:32:18 -0700 Comment on attachment 435093 Patch R=me 1782618 4 435093 bfulgham 2021-08-06 17:33:58 -0700 Comment on attachment 435093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435093&action=review > Source/WebCore/crypto/keys/CryptoKeyRSA.cpp:143 > + return result; Should we log anything here? I assume JsonWebKey initialized these values appropriately? 1782624 5 435093 katherine_cheney 2021-08-06 17:47:33 -0700 Comment on attachment 435093 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=435093&action=review >> Source/WebCore/crypto/keys/CryptoKeyRSA.cpp:143 >> + return result; > > Should we log anything here? I assume JsonWebKey initialized these values appropriately? The exportData() function logs anytime it returns nullptr, so I think extra logging here would be unnecessary. It probably is a good idea to investigate why CCRSAGetKeyComponents is failing sometimes and causing rsaComponents to be null, though. 1782628 6 ews-feeder 2021-08-06 18:16:36 -0700 Committed r280747 (240333@main): <https://commits.webkit.org/240333@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435093. 1782645 7 katherine_cheney 2021-08-06 20:04:42 -0700 Layout test failures are in web animations and seem super unrelated. 435093 2021-08-06 15:01:19 -0700 2021-08-06 19:23:18 -0700 Patch bug-228878-20210806150118.patch text/plain 1499 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2U2OWVkYjQ0NWU2MDBi YzA1ZjMzNTE0Y2RkNTdlZDJkYzMyZjViMy4uOWQ0YzBmYzAwNjg2OTU3ZWYzNTAxYTNlYzZhZTg5 ZmNjNzI0OGYzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA4LTA2ICBLYXRl IENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoVHJh Y2VyOiBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQgYXQgY29tLmFwcGxlLldlYkNvcmU6IFdl YkNvcmU6OkNyeXB0b0tleVJTQTo6ZXhwb3J0SndrIGNvbnN0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg4NzgKKyAgICAgICAgPHJkYXI6Ly9wcm9i bGVtLzYwMTQ3MjMxPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGV4cG9ydERhdGEoKSBjb3VsZCByZXR1cm4gbnVsbHB0ci4gV2Ugc2hvdWxkIGNoZWNr IHRoZSB2YWx1ZSBvZgorICAgICAgICByc2FDb21wb25lbnRzIGJlZm9yZSB0cnlpbmcgdG8gdXNl IGl0LgorCisgICAgICAgICogY3J5cHRvL2tleXMvQ3J5cHRvS2V5UlNBLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNyeXB0b0tleVJTQTo6ZXhwb3J0SndrIGNvbnN0KToKKwogMjAyMS0wOC0wNSAg TWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21lLm9yZz4KIAogICAgICAgICBTdXBw cmVzcyBtb3JlIC1XcmV0dXJuLXR5cGUgd2FybmluZ3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2NyeXB0by9rZXlzL0NyeXB0b0tleVJTQS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jcnlwdG8v a2V5cy9DcnlwdG9LZXlSU0EuY3BwCmluZGV4IDAxODNjMWRkNDg3YWYwMTBlNWU1MDlkMjI2MGQ2 NTIyNTE5NWQ0N2YuLjZiYmYxNGYyNDYwYjNkMWY1MDQ4OGFmMzkyOTcwOWY3NDIxNmVlMjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2NyeXB0by9rZXlzL0NyeXB0b0tleVJTQS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvY3J5cHRvL2tleXMvQ3J5cHRvS2V5UlNBLmNwcApAQCAtMTM5LDYg KzEzOSw5IEBAIEpzb25XZWJLZXkgQ3J5cHRvS2V5UlNBOjpleHBvcnRKd2soKSBjb25zdAogCiAg ICAgYXV0byByc2FDb21wb25lbnRzID0gZXhwb3J0RGF0YSgpOwogCisgICAgaWYgKCFyc2FDb21w b25lbnRzKQorICAgICAgICByZXR1cm4gcmVzdWx0OworCiAgICAgLy8gcHVibGljIGtleQogICAg IHJlc3VsdC5uID0gYmFzZTY0VVJMRW5jb2RlVG9TdHJpbmcocnNhQ29tcG9uZW50cy0+bW9kdWx1 cygpKTsKICAgICByZXN1bHQuZSA9IGJhc2U2NFVSTEVuY29kZVRvU3RyaW5nKHJzYUNvbXBvbmVu dHMtPmV4cG9uZW50KCkpOwo=