228874 2021-08-06 14:25:28 -0700 MallocBench: fix ODR violation 2021-08-06 15:14:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro cdumez ews-watchlist ggaren jbedard mcatanzaro rniwa webkit-bug-importer oldest_to_newest 1782565 0 mcatanzaro 2021-08-06 14:25:28 -0700 When built with LTO enabled, GCC will warn about violations of C++'s one-definition rule. MallocBench has two different Objects in two different files, which is illegal. We could rename one of them, but I decided it's simplest to just put them each in anonymous namespaces in order to restrict them to file scope. 1782566 1 435087 mcatanzaro 2021-08-06 14:27:18 -0700 Created attachment 435087 Patch 1782583 2 435087 ggaren 2021-08-06 15:05:04 -0700 Comment on attachment 435087 Patch r=me 1782588 3 ews-feeder 2021-08-06 15:13:39 -0700 Committed r280738 (240324@main): <https://commits.webkit.org/240324@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435087. 1782589 4 webkit-bug-importer 2021-08-06 15:14:17 -0700 <rdar://problem/81634723> 435087 2021-08-06 14:27:18 -0700 2021-08-06 15:13:40 -0700 Patch bug-228874-20210806162717.patch text/plain 2296 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNzI3CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGY5NDkwOTU3NDQ3 M2NiOTE1YmMyODNmZWU2OGM5OTE0ZmNhNzM5YzMuLjhjMWY0M2MzYTFhMjJlMjdmYmZmYTBlYjBl OWRhMTUyOGNkNjE4OTMgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCisr KyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDgt MDYgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAg TWFsbG9jQmVuY2g6IGZpeCBPRFIgdmlvbGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg4NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGJ1aWx0IHdpdGggTFRPIGVuYWJsZWQsIEdDQyB3 aWxsIHdhcm4gYWJvdXQgdmlvbGF0aW9ucyBvZiBDKysncyBvbmUtZGVmaW5pdGlvbiBydWxlLgor ICAgICAgICBNYWxsb2NCZW5jaCBoYXMgdHdvIGRpZmZlcmVudCBPYmplY3RzIGluIHR3byBkaWZm ZXJlbnQgZmlsZXMsIHdoaWNoIGlzIGlsbGVnYWwuIFdlIGNvdWxkCisgICAgICAgIHJlbmFtZSBv bmUgb2YgdGhlbSwgYnV0IEkgZGVjaWRlZCBpdCdzIHNpbXBsZXN0IHRvIGp1c3QgcHV0IHRoZW0g ZWFjaCBpbiBhbm9ueW1vdXMKKyAgICAgICAgbmFtZXNwYWNlcyBpbiBvcmRlciB0byByZXN0cmlj dCB0aGVtIHRvIGZpbGUgc2NvcGUuCisKKyAgICAgICAgKiBNYWxsb2NCZW5jaC9NYWxsb2NCZW5j aC9iaWcuY3BwOgorICAgICAgICAqIE1hbGxvY0JlbmNoL01hbGxvY0JlbmNoL3N0cmVzcy5jcHA6 CisKIDIwMjEtMDctMjUgIENhdGhpZSBDaGVuICA8Y2F0aGllY2hlbkBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtQZXJmb3JtYW5jZSB0ZXN0XVtjc3MtY29udGFpbl0gQWRkIHRlc3QgdG8gY29udGFp bjogc2l6ZSBsYXlvdXQKZGlmZiAtLWdpdCBhL1BlcmZvcm1hbmNlVGVzdHMvTWFsbG9jQmVuY2gv TWFsbG9jQmVuY2gvYmlnLmNwcCBiL1BlcmZvcm1hbmNlVGVzdHMvTWFsbG9jQmVuY2gvTWFsbG9j QmVuY2gvYmlnLmNwcAppbmRleCAzZmJmNGY2YmYzMGI1ODNjNGE0NzJlZDNkM2M2ZGU1MjI4NDFm NjMxLi40OTkxZWFhMDUzODg2NmNiMDNkMGQ0NjlkNjRkMTY2YWFiODg1OTk1IDEwMDY0NAotLS0g YS9QZXJmb3JtYW5jZVRlc3RzL01hbGxvY0JlbmNoL01hbGxvY0JlbmNoL2JpZy5jcHAKKysrIGIv UGVyZm9ybWFuY2VUZXN0cy9NYWxsb2NCZW5jaC9NYWxsb2NCZW5jaC9iaWcuY3BwCkBAIC0zNCwx MSArMzQsMTUgQEAKIAogdXNpbmcgbmFtZXNwYWNlIHN0ZDsKIAorbmFtZXNwYWNlIHsKKwogc3Ry dWN0IE9iamVjdCB7CiAgICAgZG91YmxlKiBwOwogICAgIHNpemVfdCBzaXplOwogfTsKIAorfQor CiB2b2lkIGJlbmNobWFya19iaWcoQ29tbWFuZExpbmUmIGNvbW1hbmRMaW5lKQogewogICAgIHNp emVfdCB0aW1lcyA9IDE7CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3RzL01hbGxvY0JlbmNo L01hbGxvY0JlbmNoL3N0cmVzcy5jcHAgYi9QZXJmb3JtYW5jZVRlc3RzL01hbGxvY0JlbmNoL01h bGxvY0JlbmNoL3N0cmVzcy5jcHAKaW5kZXggMWMxNDc0N2JiYzJhMzdmOGMwNjNiZWNlMTc1MDUz NzUyYjk2OGVhOC4uNmJkMDVhOWZiYTEwZWM3YWIzZmNjZjkxMWIwNDgzMzU2MjEzMDFiOSAxMDA2 NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9NYWxsb2NCZW5jaC9NYWxsb2NCZW5jaC9zdHJlc3Mu Y3BwCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvTWFsbG9jQmVuY2gvTWFsbG9jQmVuY2gvc3RyZXNz LmNwcApAQCAtMzksNiArMzksOCBAQAogc3RhdGljIGNvbnN0IHNpemVfdCBrQiA9IDEwMjQ7CiBz dGF0aWMgY29uc3Qgc2l6ZV90IE1CID0ga0IgKiBrQjsKIAorbmFtZXNwYWNlIHsKKwogc3RydWN0 IE9iamVjdCB7CiAgICAgT2JqZWN0KHZvaWQqIHBvaW50ZXIsIHNpemVfdCBzaXplLCBsb25nIHV1 aWQpCiAgICAgICAgIDogcG9pbnRlcihwb2ludGVyKQpAQCAtMTIzLDYgKzEyNSw4IEBAIHZvaWQg ZGVhbGxvY2F0ZShjb25zdCBPYmplY3QmIG9iamVjdCkKICAgICBtYmZyZWUob2JqZWN0LnBvaW50 ZXIsIG9iamVjdC5zaXplKTsKIH0KIAorfSAvLyBhbm9ueW1vdXMgbmFtZXNwYWNlCisKIHZvaWQg YmVuY2htYXJrX3N0cmVzcyhDb21tYW5kTGluZSYpCiB7CiAgICAgY29uc3Qgc2l6ZV90IGhlYXBT aXplID0gMTAwICogTUI7Cg==