228866 2021-08-06 09:42:05 -0700 [ews] Ensure file handle is not leaked in loadConfig.py 2021-08-07 13:56:16 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=225360 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dewei_zhu jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1782509 0 aakash_jain 2021-08-06 09:42:05 -0700 Ensure file handle is not leaked in loadConfig.py, for ews and build.webkit.org Similar to https://commits.webkit.org/237299@main 1782510 1 435074 aakash_jain 2021-08-06 09:43:15 -0700 Created attachment 435074 Patch 1782519 2 435074 ap 2021-08-06 10:32:27 -0700 Comment on attachment 435074 Patch The change is clearly an improvement, but I'm curious if we actually observed the problem in practice (i.e. observed that garbage collection didn't do it quickly). 1782728 3 aakash_jain 2021-08-07 13:24:48 -0700 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 435074 [details] > I'm curious if we actually observed the problem in practice. Not really. The motivation for this change was that when the unit-test fail for something, they also print following error about this closed file. This sometimes makes the unit-test failure message ugly and confusing (e.g. https://ews-build.webkit.org/#/builders/20/builds/53092/steps/12/logs/stdio). Stderr: Exception ignored in: <_io.FileIO name='Tools/CISupport/ews-build/config.json' mode='rb' closefd=True> ResourceWarning: unclosed file <_io.TextIOWrapper name='Tools/CISupport/ews-build/config.json' mode='r' encoding='UTF-8'> 1782731 4 ews-feeder 2021-08-07 13:55:31 -0700 Committed r280759 (240344@main): <https://commits.webkit.org/240344@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435074. 1782732 5 webkit-bug-importer 2021-08-07 13:56:16 -0700 <rdar://problem/81657719> 435074 2021-08-06 09:43:15 -0700 2021-08-07 13:55:32 -0700 Patch bug-228866-20210806124314.patch text/plain 1988 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4MDcyNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTA4LTA2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBFbnN1cmUgZmlsZSBoYW5kbGUgaXMgbm90IGxlYWtlZCBpbiBs b2FkQ29uZmlnLnB5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjg4NjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIENJU3VwcG9ydC9idWlsZC13ZWJraXQtb3JnL2xvYWRDb25maWcucHk6CisgICAgICAg IChsb2FkQnVpbGRlckNvbmZpZyk6CisgICAgICAgICogQ0lTdXBwb3J0L2V3cy1idWlsZC9sb2Fk Q29uZmlnLnB5OgorICAgICAgICAobG9hZEJ1aWxkZXJDb25maWcpOgorCiAyMDIxLTA4LTA2ICBB YWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzXSBNYWtl IGNvbmZpZy5qc29uIGNvbXBhY3QKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9idWlsZC13ZWJraXQt b3JnL2xvYWRDb25maWcucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdl YmtpdC1vcmcvbG9hZENvbmZpZy5weQkocmV2aXNpb24gMjgwNzI1KQorKysgVG9vbHMvQ0lTdXBw b3J0L2J1aWxkLXdlYmtpdC1vcmcvbG9hZENvbmZpZy5weQkod29ya2luZyBjb3B5KQpAQCAtNDcs OCArNDcsOCBAQCBkZWYgcGlja0xhdGVzdEJ1aWxkKGJ1aWxkZXIsIHJlcXVlc3RzKToKIAogCiBk ZWYgbG9hZEJ1aWxkZXJDb25maWcoYywgaXNfdGVzdF9tb2RlX2VuYWJsZWQ9RmFsc2UsIG1hc3Rl cl9wcmVmaXhfcGF0aD0nLi8nKToKLSAgICAjIEZJWE1FOiBUaGVzZSBmaWxlIGhhbmRsZXMgYXJl IGxlYWtlZC4KLSAgICBjb25maWcgPSBqc29uLmxvYWQob3Blbihvcy5wYXRoLmpvaW4obWFzdGVy X3ByZWZpeF9wYXRoLCAnY29uZmlnLmpzb24nKSkpCisgICAgd2l0aCBvcGVuKG9zLnBhdGguam9p bihtYXN0ZXJfcHJlZml4X3BhdGgsICdjb25maWcuanNvbicpKSBhcyBjb25maWdfanNvbjoKKyAg ICAgICAgY29uZmlnID0ganNvbi5sb2FkKGNvbmZpZ19qc29uKQogICAgIGlmIGlzX3Rlc3RfbW9k ZV9lbmFibGVkOgogICAgICAgICBwYXNzd29yZHMgPSB7fQogICAgIGVsc2U6CkluZGV4OiBUb29s cy9DSVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWcucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv Q0lTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5CShyZXZpc2lvbiAyODA3MjUpCisrKyBU b29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWcucHkJKHdvcmtpbmcgY29weSkKQEAg LTQyLDcgKzQyLDggQEAgU1RFUF9OQU1FX0xFTkdUSF9MSU1JVCA9IDUwCiAKIAogZGVmIGxvYWRC dWlsZGVyQ29uZmlnKGMsIGlzX3Rlc3RfbW9kZV9lbmFibGVkPUZhbHNlLCBtYXN0ZXJfcHJlZml4 X3BhdGg9Jy4vJyk6Ci0gICAgY29uZmlnID0ganNvbi5sb2FkKG9wZW4ob3MucGF0aC5qb2luKG1h c3Rlcl9wcmVmaXhfcGF0aCwgJ2NvbmZpZy5qc29uJykpKQorICAgIHdpdGggb3Blbihvcy5wYXRo LmpvaW4obWFzdGVyX3ByZWZpeF9wYXRoLCAnY29uZmlnLmpzb24nKSkgYXMgY29uZmlnX2pzb246 CisgICAgICAgIGNvbmZpZyA9IGpzb24ubG9hZChjb25maWdfanNvbikKICAgICBpZiBpc190ZXN0 X21vZGVfZW5hYmxlZDoKICAgICAgICAgcGFzc3dvcmRzID0ge30KICAgICBlbHNlOgo=