228865 2021-08-06 09:21:06 -0700 Adding missing REFERENCED_FROM_ASM annotations to facilitate LTO 2021-08-23 12:35:39 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build PC Linux RESOLVED FIXED https://bugzilla.redhat.com/show_bug.cgi?id=1990111 InRadar P2 Normal --- 1 mcatanzaro mcatanzaro aperez bugs-noreply ews-watchlist keith_miller kloczko.tomasz mark.lam mcatanzaro mgorse msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1782500 0 mcatanzaro 2021-08-06 09:21:06 -0700 When investigating why WebKitGTK fails to build with LTO (link-time optimization) enabled, one of the GCC developers noticed that we are missing __attribute__ (("used")) on several C++ functions declared in LLIntSlowPaths.h and WasmSlowPaths.h that are called only from asm. Without this attribute, GCC assumes the functions are unused and drops them, then linking fails because they really are used. Turns out, this is the *only* problem that prevents building WebKit with LTO, so this patch should allow distros like Fedora and SUSE to drop downstream workarounds to turn off LTO. To test building with LTO, I used -DCMAKE_C_FLAGS="-flto=auto -ffat-lto-objects" -DCMAKE_CXX_FLAGS="-flto=auto -ffat-lto-objects" with GCC. Note that is GCC-specific. Clang uses "-flto" instead, simpler. 1782501 1 mcatanzaro 2021-08-06 09:24:33 -0700 (In reply to Michael Catanzaro from comment #0) > Turns out, this is the *only* problem that prevents building WebKit with > LTO, so this patch should allow distros like Fedora and SUSE to drop > downstream workarounds to turn off LTO. Oh, well I'm actually getting an ld.gold internal error as well. Workaround for that is -DUSE_LD_GOLD=OFF. We might want to get rid of ld.gold anyway since it's no longer well-maintained. 1782504 2 435072 mcatanzaro 2021-08-06 09:28:19 -0700 Created attachment 435072 Patch 1782841 3 435072 aperez 2021-08-09 00:36:48 -0700 Comment on attachment 435072 Patch Nice find. I think the patch is correct 😉 1782842 4 435072 ysuzuki 2021-08-09 00:46:00 -0700 Comment on attachment 435072 Patch r=me 1782861 5 ews-feeder 2021-08-09 03:53:12 -0700 Committed r280770 (240354@main): <https://commits.webkit.org/240354@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 435072. 1782863 6 webkit-bug-importer 2021-08-09 03:54:17 -0700 <rdar://problem/81689158> 1783927 7 mcatanzaro 2021-08-12 13:08:26 -0700 (In reply to Michael Catanzaro from comment #0) > To test building with LTO, I used -DCMAKE_C_FLAGS="-flto=auto > -ffat-lto-objects" -DCMAKE_CXX_FLAGS="-flto=auto -ffat-lto-objects" with > GCC. Note that is GCC-specific. Clang uses "-flto" instead, simpler. Correction: according to https://fedoraproject.org/wiki/Changes/LTOBuildImprovements#Detailed_Description actually do not want to use -ffat-lto-objects because we don't install any .o or .a files. Huh. 1786511 8 mcatanzaro 2021-08-23 12:35:39 -0700 *** Bug 202346 has been marked as a duplicate of this bug. *** 435072 2021-08-06 09:28:19 -0700 2021-08-09 03:53:15 -0700 Patch bug-228865-20210806112818.patch text/plain 6007 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 NDRiYTFjNDM3MjllYjAwYWE4ZDVmNWJjN2E0ZmZjMmM3ZWQ5YzQ1Li4zY2Y1MGMxOGYxNmRmNDlj ZTFmYTg2YzVkNjUzMjUzNjQ1MGQxMjdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAyMS0wOC0wNiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdu b21lLm9yZz4KKworICAgICAgICBBZGRpbmcgbWlzc2luZyBSRUZFUkVOQ0VEX0ZST01fQVNNIGFu bm90YXRpb25zIHRvIGZhY2lsaXRhdGUgTFRPCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg4NjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXaGVuIGludmVzdGlnYXRpbmcgd2h5IFdlYktpdEdUSyBmYWls cyB0byBidWlsZCB3aXRoIExUTyAobGluay10aW1lIG9wdGltaXphdGlvbikgZW5hYmxlZCwKKyAg ICAgICAgb25lIG9mIHRoZSBHQ0MgZGV2ZWxvcGVycyBub3RpY2VkIHRoYXQgd2UgYXJlIG1pc3Np bmcgX19hdHRyaWJ1dGVfXyAoKCJ1c2VkIikpIG9uIHNldmVyYWwKKyAgICAgICAgQysrIGZ1bmN0 aW9ucyBkZWNsYXJlZCBpbiBMTEludFNsb3dQYXRocy5oIGFuZCBXYXNtU2xvd1BhdGhzLmggdGhh dCBhcmUgY2FsbGVkIG9ubHkgZnJvbQorICAgICAgICBhc20uIFdpdGhvdXQgdGhpcyBhdHRyaWJ1 dGUsIEdDQyBhc3N1bWVzIHRoZSBmdW5jdGlvbnMgYXJlIHVudXNlZCBhbmQgZHJvcHMgdGhlbSwg dGhlbgorICAgICAgICBsaW5raW5nIGZhaWxzIGJlY2F1c2UgdGhleSByZWFsbHkgYXJlIHVzZWQu CisKKyAgICAgICAgKiBsbGludC9MTEludFNsb3dQYXRocy5oOgorICAgICAgICAqIHdhc20vV2Fz bVNsb3dQYXRocy5oOgorCiAyMDIxLTA4LTA0ICBZaWppYSBIdWFuZyAgPHlpamlhX2h1YW5nQGFw cGxlLmNvbT4KIAogICAgICAgICBbQVJNNjRdIEZpeCBab29tIGJsYWNrIHNjcmVlbiBkdXJpbmcg dmlkZW8gbWVldGluZyBvbiBTYWZhcmkKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9sbGludC9MTEludFNsb3dQYXRocy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xM SW50U2xvd1BhdGhzLmgKaW5kZXggZmJmZDUzY2M1NTFmN2JmNmYyNzZlZWY1ZTQwZmIyZDI2MzE4 MWUyMS4uZTIwYTBkZmM2Yjg3YWNkNjIyNjhlODhhYTZhYTk2NGZiNmUwOWI2NiAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmgKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xMSW50U2xvd1BhdGhzLmgKQEAgLTM2LDE1ICszNiwx NSBAQCBzdHJ1Y3QgUHJvdG9DYWxsRnJhbWU7CiAKIG5hbWVzcGFjZSBMTEludCB7CiAKLWV4dGVy biAiQyIgU2xvd1BhdGhSZXR1cm5UeXBlIGxsaW50X3RyYWNlX29wZXJhbmQoQ2FsbEZyYW1lKiwg Y29uc3QgSW5zdHJ1Y3Rpb24qLCBpbnQgZnJvbVdoZXJlLCBpbnQgb3BlcmFuZCk7Ci1leHRlcm4g IkMiIFNsb3dQYXRoUmV0dXJuVHlwZSBsbGludF90cmFjZV92YWx1ZShDYWxsRnJhbWUqLCBjb25z dCBJbnN0cnVjdGlvbiosIGludCBmcm9tV2hlcmUsIFZpcnR1YWxSZWdpc3RlciBvcGVyYW5kKTsK LWV4dGVybiAiQyIgdm9pZCBsbGludF93cml0ZV9iYXJyaWVyX3Nsb3coQ2FsbEZyYW1lKiwgSlND ZWxsKikgV1RGX0lOVEVSTkFMOworZXh0ZXJuICJDIiBTbG93UGF0aFJldHVyblR5cGUgbGxpbnRf dHJhY2Vfb3BlcmFuZChDYWxsRnJhbWUqLCBjb25zdCBJbnN0cnVjdGlvbiosIGludCBmcm9tV2hl cmUsIGludCBvcGVyYW5kKSBSRUZFUkVOQ0VEX0ZST01fQVNNOworZXh0ZXJuICJDIiBTbG93UGF0 aFJldHVyblR5cGUgbGxpbnRfdHJhY2VfdmFsdWUoQ2FsbEZyYW1lKiwgY29uc3QgSW5zdHJ1Y3Rp b24qLCBpbnQgZnJvbVdoZXJlLCBWaXJ0dWFsUmVnaXN0ZXIgb3BlcmFuZCkgUkVGRVJFTkNFRF9G Uk9NX0FTTTsKK2V4dGVybiAiQyIgdm9pZCBsbGludF93cml0ZV9iYXJyaWVyX3Nsb3coQ2FsbEZy YW1lKiwgSlNDZWxsKikgUkVGRVJFTkNFRF9GUk9NX0FTTSBXVEZfSU5URVJOQUw7CiAKICNkZWZp bmUgTExJTlRfU0xPV19QQVRIX0RFQ0wobmFtZSkgXAogICAgIGV4dGVybiAiQyIgU2xvd1BhdGhS ZXR1cm5UeXBlIGxsaW50XyMjbmFtZShDYWxsRnJhbWUqIGNhbGxGcmFtZSwgY29uc3QgSW5zdHJ1 Y3Rpb24qIHBjKQogCiAjZGVmaW5lIExMSU5UX1NMT1dfUEFUSF9ISURERU5fREVDTChuYW1lKSBc Ci0gICAgTExJTlRfU0xPV19QQVRIX0RFQ0wobmFtZSkgV1RGX0lOVEVSTkFMCisgICAgTExJTlRf U0xPV19QQVRIX0RFQ0wobmFtZSkgUkVGRVJFTkNFRF9GUk9NX0FTTSBXVEZfSU5URVJOQUwKIAog TExJTlRfU0xPV19QQVRIX0hJRERFTl9ERUNMKHRyYWNlX3Byb2xvZ3VlKTsKIExMSU5UX1NMT1df UEFUSF9ISURERU5fREVDTCh0cmFjZV9wcm9sb2d1ZV9mdW5jdGlvbl9mb3JfY2FsbCk7CkBAIC0x NDksMTMgKzE0OSwxMyBAQCBMTElOVF9TTE9XX1BBVEhfSElEREVOX0RFQ0woc2xvd19wYXRoX2xv Z19zaGFkb3dfY2hpY2tlbl90YWlsKTsKIExMSU5UX1NMT1dfUEFUSF9ISURERU5fREVDTChzbG93 X3BhdGhfc3VwZXJfc2FtcGxlcl9iZWdpbik7CiBMTElOVF9TTE9XX1BBVEhfSElEREVOX0RFQ0wo c2xvd19wYXRoX3N1cGVyX3NhbXBsZXJfZW5kKTsKIExMSU5UX1NMT1dfUEFUSF9ISURERU5fREVD TChzbG93X3BhdGhfb3V0X29mX2xpbmVfanVtcF90YXJnZXQpOwotZXh0ZXJuICJDIiBTbG93UGF0 aFJldHVyblR5cGUgbGxpbnRfdGhyb3dfc3RhY2tfb3ZlcmZsb3dfZXJyb3IoVk0qLCBQcm90b0Nh bGxGcmFtZSopIFdURl9JTlRFUk5BTDsKLWV4dGVybiAiQyIgU2xvd1BhdGhSZXR1cm5UeXBlIGxs aW50X3Nsb3dfcGF0aF9jaGVja3BvaW50X29zcl9leGl0KENhbGxGcmFtZSogY2FsbEZyYW1lLCBF bmNvZGVkSlNWYWx1ZSB1bnVzZWQpIFdURl9JTlRFUk5BTDsKLWV4dGVybiAiQyIgU2xvd1BhdGhS ZXR1cm5UeXBlIGxsaW50X3Nsb3dfcGF0aF9jaGVja3BvaW50X29zcl9leGl0X2Zyb21faW5saW5l ZF9jYWxsKENhbGxGcmFtZSogY2FsbEZyYW1lLCBFbmNvZGVkSlNWYWx1ZSBjYWxsUmVzdWx0KSBX VEZfSU5URVJOQUw7CitleHRlcm4gIkMiIFNsb3dQYXRoUmV0dXJuVHlwZSBsbGludF90aHJvd19z dGFja19vdmVyZmxvd19lcnJvcihWTSosIFByb3RvQ2FsbEZyYW1lKikgUkVGRVJFTkNFRF9GUk9N X0FTTSBXVEZfSU5URVJOQUw7CitleHRlcm4gIkMiIFNsb3dQYXRoUmV0dXJuVHlwZSBsbGludF9z bG93X3BhdGhfY2hlY2twb2ludF9vc3JfZXhpdChDYWxsRnJhbWUqIGNhbGxGcmFtZSwgRW5jb2Rl ZEpTVmFsdWUgdW51c2VkKSBSRUZFUkVOQ0VEX0ZST01fQVNNIFdURl9JTlRFUk5BTDsKK2V4dGVy biAiQyIgU2xvd1BhdGhSZXR1cm5UeXBlIGxsaW50X3Nsb3dfcGF0aF9jaGVja3BvaW50X29zcl9l eGl0X2Zyb21faW5saW5lZF9jYWxsKENhbGxGcmFtZSogY2FsbEZyYW1lLCBFbmNvZGVkSlNWYWx1 ZSBjYWxsUmVzdWx0KSBSRUZFUkVOQ0VEX0ZST01fQVNNIFdURl9JTlRFUk5BTDsKICNpZiBFTkFC TEUoQ19MT09QKQotZXh0ZXJuICJDIiBTbG93UGF0aFJldHVyblR5cGUgbGxpbnRfc3RhY2tfY2hl Y2tfYXRfdm1fZW50cnkoVk0qLCBSZWdpc3RlciopIFdURl9JTlRFUk5BTDsKK2V4dGVybiAiQyIg U2xvd1BhdGhSZXR1cm5UeXBlIGxsaW50X3N0YWNrX2NoZWNrX2F0X3ZtX2VudHJ5KFZNKiwgUmVn aXN0ZXIqKSBSRUZFUkVOQ0VEX0ZST01fQVNNIFdURl9JTlRFUk5BTDsKICNlbmRpZgotZXh0ZXJu ICJDIiBTbG93UGF0aFJldHVyblR5cGUgbGxpbnRfY2hlY2tfdm1fZW50cnlfcGVybWlzc2lvbihW TSosIFByb3RvQ2FsbEZyYW1lKikgV1RGX0lOVEVSTkFMOwotZXh0ZXJuICJDIiBOT19SRVRVUk5f RFVFX1RPX0NSQVNIIHZvaWQgbGxpbnRfY3Jhc2goKSBXVEZfSU5URVJOQUw7CitleHRlcm4gIkMi IFNsb3dQYXRoUmV0dXJuVHlwZSBsbGludF9jaGVja192bV9lbnRyeV9wZXJtaXNzaW9uKFZNKiwg UHJvdG9DYWxsRnJhbWUqKSBSRUZFUkVOQ0VEX0ZST01fQVNNIFdURl9JTlRFUk5BTDsKK2V4dGVy biAiQyIgTk9fUkVUVVJOX0RVRV9UT19DUkFTSCB2b2lkIGxsaW50X2NyYXNoKCkgUkVGRVJFTkNF RF9GUk9NX0FTTSBXVEZfSU5URVJOQUw7CiAKIH0gfSAvLyBuYW1lc3BhY2UgSlNDOjpMTEludApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbVNsb3dQYXRocy5oIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbVNsb3dQYXRocy5oCmluZGV4IDViMmI4ZjI4 OTVhMWU2YzgyZjQwOWY2ZTVlODZjY2RmMGZkNTA0YjMuLjc3NjIxMTgzMzhhN2I3MDY5NjliMjVi NTJjZTE2ZTJjM2RjN2JkNGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNt L1dhc21TbG93UGF0aHMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtU2xv d1BhdGhzLmgKQEAgLTQ3LDcgKzQ3LDcgQEAgbmFtZXNwYWNlIExMSW50IHsKICAgICBleHRlcm4g IkMiIFNsb3dQYXRoUmV0dXJuVHlwZSBzbG93X3BhdGhfd2FzbV8jI25hbWUoQ2FsbEZyYW1lKiBj YWxsRnJhbWUsIGNvbnN0IEluc3RydWN0aW9uKiBwYywgV2FzbTo6SW5zdGFuY2UqIGluc3RhbmNl KQogCiAjZGVmaW5lIFdBU01fU0xPV19QQVRIX0hJRERFTl9ERUNMKG5hbWUpIFwKLSAgICBXQVNN X1NMT1dfUEFUSF9ERUNMKG5hbWUpIFdURl9JTlRFUk5BTAorICAgIFdBU01fU0xPV19QQVRIX0RF Q0wobmFtZSkgUkVGRVJFTkNFRF9GUk9NX0FTTSBXVEZfSU5URVJOQUwKIAogI2lmIEVOQUJMRShX RUJBU1NFTUJMWV9CM0pJVCkKIFdBU01fU0xPV19QQVRIX0hJRERFTl9ERUNMKHByb2xvZ3VlX29z cik7CkBAIC04NCw5ICs4NCw5IEBAIFdBU01fU0xPV19QQVRIX0hJRERFTl9ERUNMKG1lbW9yeV9h dG9taWNfd2FpdDMyKTsKIFdBU01fU0xPV19QQVRIX0hJRERFTl9ERUNMKG1lbW9yeV9hdG9taWNf d2FpdDY0KTsKIFdBU01fU0xPV19QQVRIX0hJRERFTl9ERUNMKG1lbW9yeV9hdG9taWNfbm90aWZ5 KTsKIAotZXh0ZXJuICJDIiBTbG93UGF0aFJldHVyblR5cGUgc2xvd19wYXRoX3dhc21fdGhyb3df ZXhjZXB0aW9uKENhbGxGcmFtZSosIGNvbnN0IEluc3RydWN0aW9uKiwgV2FzbTo6SW5zdGFuY2Uq IGluc3RhbmNlLCBXYXNtOjpFeGNlcHRpb25UeXBlKSBXVEZfSU5URVJOQUw7Ci1leHRlcm4gIkMi IFNsb3dQYXRoUmV0dXJuVHlwZSBzbG93X3BhdGhfd2FzbV9wb3Bjb3VudChjb25zdCBJbnN0cnVj dGlvbiogcGMsIHVpbnQzMl90KSBXVEZfSU5URVJOQUw7Ci1leHRlcm4gIkMiIFNsb3dQYXRoUmV0 dXJuVHlwZSBzbG93X3BhdGhfd2FzbV9wb3Bjb3VudGxsKGNvbnN0IEluc3RydWN0aW9uKiBwYywg dWludDY0X3QpIFdURl9JTlRFUk5BTDsKK2V4dGVybiAiQyIgU2xvd1BhdGhSZXR1cm5UeXBlIHNs b3dfcGF0aF93YXNtX3Rocm93X2V4Y2VwdGlvbihDYWxsRnJhbWUqLCBjb25zdCBJbnN0cnVjdGlv biosIFdhc206Okluc3RhbmNlKiBpbnN0YW5jZSwgV2FzbTo6RXhjZXB0aW9uVHlwZSkgUkVGRVJF TkNFRF9GUk9NX0FTTSBXVEZfSU5URVJOQUw7CitleHRlcm4gIkMiIFNsb3dQYXRoUmV0dXJuVHlw ZSBzbG93X3BhdGhfd2FzbV9wb3Bjb3VudChjb25zdCBJbnN0cnVjdGlvbiogcGMsIHVpbnQzMl90 KSBSRUZFUkVOQ0VEX0ZST01fQVNNIFdURl9JTlRFUk5BTDsKK2V4dGVybiAiQyIgU2xvd1BhdGhS ZXR1cm5UeXBlIHNsb3dfcGF0aF93YXNtX3BvcGNvdW50bGwoY29uc3QgSW5zdHJ1Y3Rpb24qIHBj LCB1aW50NjRfdCkgUkVGRVJFTkNFRF9GUk9NX0FTTSBXVEZfSU5URVJOQUw7CiAKIH0gfSAvLyBu YW1lc3BhY2UgSlNDOjpMTEludAogCg==