228845 2021-08-05 14:56:44 -0700 preventDefault() on keydown event should prevent dialog cancelation from happening 2021-08-24 16:21:21 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 229475 84635 1 ntim ntim cdumez changseok esprehn+autocc ews-watchlist gyuyoung.kim koivisto rniwa webkit-bug-importer oldest_to_newest 1782348 0 ntim 2021-08-05 14:56:44 -0700 This is covered by dialog-keydown-preventDefault.html: https://github.com/web-platform-tests/wpt/blob/master/html/semantics/interactive-elements/the-dialog-element/dialog-keydown-preventDefault.html Not sure if there are any other events that should also prevent dialog cancelation, but they should be covered by tests as well if so. 1783622 1 webkit-bug-importer 2021-08-11 13:40:44 -0700 <rdar://problem/81811203> 1786705 2 436273 ntim 2021-08-24 03:36:54 -0700 Created attachment 436273 Patch 1786722 3 ntim 2021-08-24 05:57:54 -0700 Committed r281492 (240866@main): <https://commits.webkit.org/240866@main> 1786827 4 436273 rniwa 2021-08-24 11:01:55 -0700 Comment on attachment 436273 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=436273&action=review > Source/WebCore/page/EventHandler.cpp:3804 > + if (auto* activeModalDialog = m_frame.document()->activeModalDialog()) Use RefPtr > Source/WebCore/page/EventHandler.cpp:3812 > + Why are we adding a blank line here? 436273 2021-08-24 03:36:54 -0700 2021-08-24 04:17:14 -0700 Patch bug-228845-20210824123653.patch text/plain 6137 ntim U3VidmVyc2lvbiBSZXZpc2lvbjogMjgxNDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWM3MThlM2I2YTlhZGZk ODA1ZTMxYzliNmRmYzAwMzEwNzU0NTJhNS4uODlhYzYzZTZmM2ZhMjg5MDhiYTA3YjdiMGRkNzVm ZGY5ZmU0ZjlkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTA4LTI0ICBUaW0g Tmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSBjYW5jZWwgZGlhbG9nIHRh c2sgdG8gYGRlZmF1bHRLZXlib2FyZEV2ZW50SGFuZGxlcmAuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg4NDUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2ludGVyYWN0aXZlLWVsZW1lbnRzL3RoZS1kaWFsb2ct ZWxlbWVudC9kaWFsb2cta2V5ZG93bi1wcmV2ZW50RGVmYXVsdC5odG1sCisKKyAgICAgICAgQWxs b3dzIHByZXZlbnREZWZhdWx0KCkgb24ga2V5ZG93biBldmVudCB0byBwcmV2ZW50IGNhbmNlbGF0 aW9uLgorCisgICAgICAgIEFsc28gcmVuYW1lIEhUTUxEaWFsb2dFbGVtZW50OjpjYW5jZWwgdG8g SFRNTERpYWxvZ0VsZW1lbnQ6OnF1ZXVlQ2FuY2VsVGFzayB0byByZWZsZWN0IGJldHRlciB3aGF0 IHRoZSBmdW5jdGlvbiBkb2VzLgorCisgICAgICAgICogaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MRGlhbG9nRWxlbWVudDo6cXVldWVDYW5jZWxUYXNr KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxEaWFsb2dFbGVtZW50OjpjYW5jZWwpOiBEZWxldGVk LgorICAgICAgICAqIGh0bWwvSFRNTERpYWxvZ0VsZW1lbnQuaDoKKyAgICAgICAgKiBwYWdlL0V2 ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmludGVybmFs S2V5RXZlbnQpOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpkZWZhdWx0S2V5Ym9h cmRFdmVudEhhbmRsZXIpOgorCiAyMDIxLTA4LTIyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbRnJlZXR5cGVdIFNldCBtYXhpbXVtIGFsbG93 ZWQgZm9udCBzaXplIGZvciBGcmVldHlwZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRGlhbG9nRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dF bGVtZW50LmNwcAppbmRleCBlYTg5MDY0NmQ3NTYxNDg2OWM4M2FkYWE0ZTQwYzQ2YmY1OGQ0ZGZm Li4yNjE4MmZmYmU2NjE3MzM2Y2Q1MjQ1M2U3MWIzZTNkZmU4YjhkOTRkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcApAQCAtOTUsNyArOTUsNyBAQCB2b2lkIEhU TUxEaWFsb2dFbGVtZW50OjpjbG9zZShjb25zdCBTdHJpbmcmIHJlc3VsdCkKICAgICB9KTsKIH0K IAotdm9pZCBIVE1MRGlhbG9nRWxlbWVudDo6Y2FuY2VsKCkKK3ZvaWQgSFRNTERpYWxvZ0VsZW1l bnQ6OnF1ZXVlQ2FuY2VsVGFzaygpCiB7CiAgICAgZG9jdW1lbnQoKS5ldmVudExvb3AoKS5xdWV1 ZVRhc2soVGFza1NvdXJjZTo6VXNlckludGVyYWN0aW9uLCBbcHJvdGVjdGVkVGhpcyA9IEdDUmVh Y2hhYmxlUmVmIHsgKnRoaXMgfV0gewogICAgICAgICBhdXRvIGNhbmNlbEV2ZW50ID0gRXZlbnQ6 OmNyZWF0ZShldmVudE5hbWVzKCkuY2FuY2VsRXZlbnQsIEV2ZW50OjpDYW5CdWJibGU6Ok5vLCBF dmVudDo6SXNDYW5jZWxhYmxlOjpZZXMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRt bC9IVE1MRGlhbG9nRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxl bWVudC5oCmluZGV4IDZjYTFmMTlmZDc4OTVhNjg3MGQ4YmM5MGZjNzg3YTNhMjBkODc4NTQuLjE5 NmFkYWU4NTI4MzZhNjMwMjU4ZjRhM2YyZjk1ZGQ4MDQ2OGE5NGIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxEaWFsb2dFbGVtZW50LmgKQEAgLTQzLDEwICs0MywxMCBAQCBwdWJsaWM6CiAgICAg RXhjZXB0aW9uT3I8dm9pZD4gc2hvd01vZGFsKCk7CiAgICAgdm9pZCBjbG9zZShjb25zdCBTdHJp bmcmKTsKIAotICAgIHZvaWQgY2FuY2VsKCk7Ci0KICAgICBib29sIGlzTW9kYWwoKSBjb25zdCB7 IHJldHVybiBtX2lzTW9kYWw7IH07CiAKKyAgICB2b2lkIHF1ZXVlQ2FuY2VsVGFzaygpOworCiBw cml2YXRlOgogICAgIEhUTUxEaWFsb2dFbGVtZW50KGNvbnN0IFF1YWxpZmllZE5hbWUmLCBEb2N1 bWVudCYpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5kZXggOGFjYmZhZTM0 OTM1ODNhYjYzYmFmN2VjMjRmMWZhMGI2YmIxZWY1Ny4uYTFlMzI3M2U3ZjA3NzRhY2RlN2YwMDhm OGI5NWRlMGJhODdkYmM2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhh bmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAt MzUyMCwxMyArMzUyMCw2IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjppbnRlcm5hbEtleUV2ZW50KGNv bnN0IFBsYXRmb3JtS2V5Ym9hcmRFdmVudCYgaW5pdGlhbEtleUV2ZW50CiAgICAgICAgIH0KICAg ICB9CiAKLSAgICBpZiAoYXV0byogYWN0aXZlTW9kYWxEaWFsb2cgPSBtX2ZyYW1lLmRvY3VtZW50 KCktPmFjdGl2ZU1vZGFsRGlhbG9nKCkpIHsKLSAgICAgICAgaWYgKGluaXRpYWxLZXlFdmVudC50 eXBlKCkgPT0gUGxhdGZvcm1FdmVudDo6S2V5RG93biAmJiBpbml0aWFsS2V5RXZlbnQud2luZG93 c1ZpcnR1YWxLZXlDb2RlKCkgPT0gVktfRVNDQVBFKSB7Ci0gICAgICAgICAgICBhY3RpdmVNb2Rh bERpYWxvZy0+Y2FuY2VsKCk7Ci0gICAgICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICAgICAgfQot ICAgIH0KLQogI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICBpZiAobV9mcmFtZS5kb2N1 bWVudCgpLT5mdWxsc2NyZWVuTWFuYWdlcigpLmlzRnVsbHNjcmVlbigpKSB7CiAgICAgICAgIGlm IChpbml0aWFsS2V5RXZlbnQudHlwZSgpID09IFBsYXRmb3JtRXZlbnQ6OktleURvd24gJiYgaW5p dGlhbEtleUV2ZW50LndpbmRvd3NWaXJ0dWFsS2V5Q29kZSgpID09IFZLX0VTQ0FQRSkgewpAQCAt MzgwNywxMiArMzgwMCwxNiBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6ZGVmYXVsdEtleWJvYXJkRXZl bnRIYW5kbGVyKEtleWJvYXJkRXZlbnQmIGV2ZW50KQogICAgICAgICBtX2ZyYW1lLmVkaXRvcigp LmhhbmRsZUtleWJvYXJkRXZlbnQoZXZlbnQpOwogICAgICAgICBpZiAoZXZlbnQuZGVmYXVsdEhh bmRsZWQoKSkKICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgaWYgKGV2ZW50LmtleUlkZW50 aWZpZXIoKSA9PSAiVSswMDA5IikKKyAgICAgICAgaWYgKGV2ZW50LmtleSgpID09ICJFc2NhcGUi KSB7CisgICAgICAgICAgICBpZiAoYXV0byogYWN0aXZlTW9kYWxEaWFsb2cgPSBtX2ZyYW1lLmRv Y3VtZW50KCktPmFjdGl2ZU1vZGFsRGlhbG9nKCkpCisgICAgICAgICAgICAgICAgYWN0aXZlTW9k YWxEaWFsb2ctPnF1ZXVlQ2FuY2VsVGFzaygpOworICAgICAgICB9IGVsc2UgaWYgKGV2ZW50Lmtl eUlkZW50aWZpZXIoKSA9PSAiVSswMDA5IikKICAgICAgICAgICAgIGRlZmF1bHRUYWJFdmVudEhh bmRsZXIoZXZlbnQpOwogICAgICAgICBlbHNlIGlmIChldmVudC5rZXlJZGVudGlmaWVyKCkgPT0g IlUrMDAwOCIpCiAgICAgICAgICAgICBkZWZhdWx0QmFja3NwYWNlRXZlbnRIYW5kbGVyKGV2ZW50 KTsKICAgICAgICAgZWxzZSBpZiAoZXZlbnQua2V5SWRlbnRpZmllcigpID09ICJQYWdlVXAiIHx8 IGV2ZW50LmtleUlkZW50aWZpZXIoKSA9PSAiUGFnZURvd24iKQogICAgICAgICAgICAgc3RhcnRL ZXlib2FyZFNjcm9sbGluZyhldmVudCk7CisKICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICBG b2N1c0RpcmVjdGlvbiBkaXJlY3Rpb24gPSBmb2N1c0RpcmVjdGlvbkZvcktleShldmVudC5rZXlJ ZGVudGlmaWVyKCkpOwogICAgICAgICAgICAgaWYgKGRpcmVjdGlvbiAhPSBGb2N1c0RpcmVjdGlv bjo6Tm9uZSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDViNjcxOTY5YWQxMjFi Y2ExNTdkN2JiZmY5OGEyZGRlNTBmNTlkM2QuLmYzNTYyYjVlZjNjYzA5YzhkYjkwOTg1YTI0ODVj YWMzMzMxMjIyODAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIxLTA4LTI0ICBUaW0gTmd1eWVuICA8bnRpbUBhcHBsZS5jb20+CisKKyAgICAgICAg TW92ZSBjYW5jZWwgZGlhbG9nIHRhc2sgdG8gYGRlZmF1bHRLZXlib2FyZEV2ZW50SGFuZGxlcmAu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg4NDUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGVk IHRlc3QgZXhwZWN0YXRpb25zLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwv c2VtYW50aWNzL2ludGVyYWN0aXZlLWVsZW1lbnRzL3RoZS1kaWFsb2ctZWxlbWVudC9kaWFsb2ct a2V5ZG93bi1wcmV2ZW50RGVmYXVsdC1leHBlY3RlZC50eHQ6CisKIDIwMjEtMDgtMjIgIE15bGVz IEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBDb250cm9sIGNo YXJhY3RlcnMgKFVuaWNvZGUgY2F0ZWdvcnkgQ2MpIHNob3VsZCBiZSByZW5kZXJlZCB2aXNpYmx5 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2h0bWwvc2VtYW50aWNzL2ludGVyYWN0aXZlLWVsZW1lbnRzL3RoZS1kaWFsb2ctZWxlbWVudC9k aWFsb2cta2V5ZG93bi1wcmV2ZW50RGVmYXVsdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvc2VtYW50aWNzL2ludGVyYWN0aXZl LWVsZW1lbnRzL3RoZS1kaWFsb2ctZWxlbWVudC9kaWFsb2cta2V5ZG93bi1wcmV2ZW50RGVmYXVs dC1leHBlY3RlZC50eHQKaW5kZXggNTRkMGU0ZWI3Mjk0NzQ1YWJmMDUxOGNlMjVmM2YzYWYwYTQ2 ZTBiMi4uYmM3ZGUwY2U4MzE0ZDkyZDdlOWI4ZGIzYWFjZThiZWVjODExY2I3NSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL3NlbWFu dGljcy9pbnRlcmFjdGl2ZS1lbGVtZW50cy90aGUtZGlhbG9nLWVsZW1lbnQvZGlhbG9nLWtleWRv d24tcHJldmVudERlZmF1bHQtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9zZW1hbnRpY3MvaW50ZXJhY3RpdmUtZWxlbWVu dHMvdGhlLWRpYWxvZy1lbGVtZW50L2RpYWxvZy1rZXlkb3duLXByZXZlbnREZWZhdWx0LWV4cGVj dGVkLnR4dApAQCAtMSw3ICsxLDcgQEAKIFRlc3QgY2FuY2VsIGV2ZW50IHdpdGggcHJldmVudERl ZmF1bHQgb24ga2V5ZG93biBldmVudCBmb3IgZGlhbG9nIGVsZW1lbnQKIAorSGVsbG8gV29ybGQK IAotSGFybmVzcyBFcnJvciAoVElNRU9VVCksIG1lc3NhZ2UgPSBudWxsCiAKLU5PVFJVTiBUZXN0 IGNhbmNlbCBldmVudCB3aXRoIHByZXZlbnREZWZhdWx0IG9uIGtleWRvd24gZXZlbnQgZm9yIGRp YWxvZyBlbGVtZW50CitQQVNTIFRlc3QgY2FuY2VsIGV2ZW50IHdpdGggcHJldmVudERlZmF1bHQg b24ga2V5ZG93biBldmVudCBmb3IgZGlhbG9nIGVsZW1lbnQKIAo=