228843 2021-08-05 13:28:52 -0700 Implement auto-expanding details 2025-06-26 23:15:43 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jarhar ntim andresg_22 aroselli bogdan.brinza bramus cdumez cfleizach emilio ggaren ggibson jcraig jhoffman23 kevin_neal mike nicolas nils.reibold rik steven tyler_w webkit-bug-importer oldest_to_newest 1782324 0 jarhar 2021-08-05 13:28:52 -0700 In this HTML spec PR, we are making <details> automatically expand for element fragments and find-in-page: https://github.com/whatwg/html/pull/6466 This way, the user can effectively use find-in-page to search for content hidden inside <details> elements without having to manually expand all of them first. In order to make it performant, the spec PR also suggests using content-visibility:hidden inside <details>'s user agent shadowdom instead of "removing the slot from the rendering" when <details> are closed. 1783882 1 webkit-bug-importer 2021-08-12 10:41:39 -0700 <rdar://problem/81856620> 1983334 2 mike 2023-10-06 14:32:50 -0700 Pull request: https://github.com/WebKit/WebKit/pull/18785 1992907 3 jcraig 2023-11-15 15:27:09 -0800 Whoever works on this feature, please work with WebKit Accessibility DRIs to make sure it works with accessibility, such as VoiceOver navigation by heading (VO+Cmd+H), where heading is in a collapsed section. Or VoiceOver Find (VO+F) 1993154 4 mike 2023-11-16 10:01:29 -0800 (In reply to James Craig from comment #3) > Whoever works on this feature, please work with WebKit Accessibility DRIs to > make sure it works with accessibility, such as VoiceOver navigation by > heading (VO+Cmd+H), where heading is in a collapsed section. Or VoiceOver > Find (VO+F) I have a PR ready for review at https://github.com/WebKit/WebKit/pull/18785. It doesn’t yet include any accessibility tests, and I’ve not yet done any manual testing of it myself with VoiceOver, but I’d love to get some guidance and review. 2001197 5 tyler_w 2023-12-20 15:33:56 -0800 (In reply to sideshowbarker from comment #4) > (In reply to James Craig from comment #3) > > Whoever works on this feature, please work with WebKit Accessibility DRIs to > > make sure it works with accessibility, such as VoiceOver navigation by > > heading (VO+Cmd+H), where heading is in a collapsed section. Or VoiceOver > > Find (VO+F) > > I have a PR ready for review at https://github.com/WebKit/WebKit/pull/18785. > It doesn’t yet include any accessibility tests, and I’ve not yet done any > manual testing of it myself with VoiceOver, but I’d love to get some > guidance and review. VO-Cmd-H (find next heading) works via Accessibility::findMatchingObjects, which traverses the AX tree to try and find objects that match the given search key. AccessibilitySearchKey::Heading is one of many such keys. VO-F works similarly, searching the AX tree for the target AccessibilitySearchCriteria::searchText and comparing it against several different types of accessibility text. Unfortunately, I don't think either will "just work" as the contents of collapsed details elements are not part of the AX tree (because they are not rendered, inherently excluding them). So we’ll need to do something special here. Maybe we need to compute “collapsed descendants” for closed details element AX objects, which includes AX objects ignored only due to their lack of visibility / rendering. This collapsed descendants function would return early if the object’s role is not details, or if it is expanded. Then we update `findMatchingObjects` to check an object’s collapsed descendants for matches. If a collapsed descendant is found to be a match, we’ll need to call `AXCoreObject::setIsExpanded(true)` on the containing details. But this is pretty complicated, maybe there is some simpler solution here...not sure. 2106888 6 ntim 2025-03-28 11:51:53 -0700 *** Bug 290170 has been marked as a duplicate of this bug. *** 2108573 7 ntim 2025-04-03 12:02:39 -0700 Pull request: https://github.com/WebKit/WebKit/pull/43558 2126222 8 ews-feeder 2025-06-26 23:15:40 -0700 Committed 296708@main (23cdbeb3cd77): <https://commits.webkit.org/296708@main> Reviewed commits have been landed. Closing PR #43558 and removing active labels.