228825 2021-08-05 06:53:30 -0700 [MSE][GStreamer] Update tracks synchronously 2021-08-12 18:19:27 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=229063 P2 Normal --- 1 aboya aboya bugs-noreply calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj pnormand sergio vjaquez oldest_to_newest 1782190 0 aboya 2021-08-05 06:53:30 -0700 A mistake introduced with the WebKitMediaSrc v2 patch made the call to updateTracks() in MediaPlayerPrivateGStreamer asynchronous. This introduced a subtle race condition in which the "resize" event may be handled before updateTracks() is called, therefore m_hasVideo has not yet been set to true, and querying the video size from the "resize" event handler returns 0x0. This fixes a timeout flake in media/media-source/media-source-resize.html. 1782191 1 434983 aboya 2021-08-05 06:54:26 -0700 Created attachment 434983 Patch 1782877 2 ews-feeder 2021-08-09 06:11:02 -0700 Committed r280775 (240359@main): <https://commits.webkit.org/240359@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434983. 434983 2021-08-05 06:54:26 -0700 2021-08-09 06:11:04 -0700 Patch bug-228825-20210805155425.patch text/plain 2107 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjc5OTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTg2OTY2YzRlMjRjN2M1 MDIwZWJmNTMyZWUyZjRhODgzNDBjYjgyYi4uNWQyOWNkZGE5YTNlNDNmMDYwZDFiY2ZmZmM2YzMz YWM4ZTFhODk5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIxLTA4LTA1ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIFVwZGF0ZSB0cmFja3Mgc3luY2hyb25vdXNseQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4ODI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSBtaXN0YWtlIGludHJvZHVjZWQgd2l0aCB0aGUg V2ViS2l0TWVkaWFTcmMgdjIgcGF0Y2ggbWFkZSB0aGUgY2FsbCB0bworICAgICAgICB1cGRhdGVU cmFja3MoKSBpbiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIgYXN5bmNocm9ub3VzLgorCisg ICAgICAgIFRoaXMgaW50cm9kdWNlZCBhIHN1YnRsZSByYWNlIGNvbmRpdGlvbiBpbiB3aGljaCB0 aGUgInJlc2l6ZSIgZXZlbnQKKyAgICAgICAgbWF5IGJlIGhhbmRsZWQgYmVmb3JlIHVwZGF0ZVRy YWNrcygpIGlzIGNhbGxlZCwgdGhlcmVmb3JlIG1faGFzVmlkZW8KKyAgICAgICAgaGFzIG5vdCB5 ZXQgYmVlbiBzZXQgdG8gdHJ1ZSwgYW5kIHF1ZXJ5aW5nIHRoZSB2aWRlbyBzaXplIGZyb20gdGhl CisgICAgICAgICJyZXNpemUiIGV2ZW50IGhhbmRsZXIgcmV0dXJucyAweDAuCisKKyAgICAgICAg VGhpcyBmaXhlcyBhIHRpbWVvdXQgZmxha2UgaW4gbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNv dXJjZS1yZXNpemUuaHRtbC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpoYW5kbGVTdHJlYW1Db2xsZWN0aW9uTWVzc2FnZSk6 CisKIDIwMjEtMDctMTUgIFRpbSBOZ3V5ZW4gIDxudGltQGFwcGxlLmNvbT4KIAogICAgICAgICA8 ZGlhbG9nPiBlbGVtZW50OiBkbyBub3QgcGVyZm9ybSBjbG9zZSgpIG1ldGhvZCBzdGVwcyB3aGVu IHJlbW92aW5nIG9wZW4gYXR0cmlidXRlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCBhZjM1NDNkZjNkYjFhOWNmNmVkMzgzMDJiMDBkNjk4 ODM5ZDY5MzA3Li4xNWQ1OWY5OGZmZGFhZGFkMGQyNmFiZGNhMzJjMjg1YzkyNTkyZTk2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtMTUz Niw3ICsxNTM2LDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmhhbmRsZVN0 cmVhbUNvbGxlY3Rpb25NZXNzYWdlKEdzdE1lc3NhZ2UqIG1lc3MKICAgICBpZiAoIWNvbGxlY3Rp b24pCiAgICAgICAgIHJldHVybjsKIAotICAgIGNhbGxPbk1haW5UaHJlYWQoW3BsYXllciA9IG1h a2VXZWFrUHRyKCp0aGlzKSwgY29sbGVjdGlvbiA9IFdURk1vdmUoY29sbGVjdGlvbildIHsKKyAg ICBjYWxsT25NYWluVGhyZWFkQW5kV2FpdChbcGxheWVyID0gbWFrZVdlYWtQdHIoKnRoaXMpLCBj b2xsZWN0aW9uID0gV1RGTW92ZShjb2xsZWN0aW9uKV0gewogICAgICAgICBpZiAocGxheWVyKQog ICAgICAgICAgICAgcGxheWVyLT51cGRhdGVUcmFja3MoY29sbGVjdGlvbik7CiAgICAgfSk7Cg==