228820 2021-08-05 04:40:03 -0700 [MSE][GStreamer] Missing support for aborts not followed by an initialization segment 2023-03-27 04:53:21 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 254222 1 aboya eocanha bugs-noreply oldest_to_newest 1782171 0 aboya 2021-08-05 04:40:03 -0700 Two new tests are failing: media/media-source/media-mp4-h264-partial-abort.html media/media-source/media-webm-opus-partial-abort.html The reason of these failures is that the current implementation of aborts in the AppendPipeline works by moving the state of the pipeline down to READY and back to PLAYING, which necessitates for an initialization segment afterwards to resume demuxing. Following an abort with an initialization segment is common, but not required by the spec. This makes those tests fail when they do exactly that. Unfortunately, making abort() correct necessitates from changes not only in WebKit, but also in the GStreamer demuxer elements. A patch was proposed for qtdemux long ago, but that effort was later deprioritized and stalled. https://bugzilla.gnome.org/show_bug.cgi?id=795424 qtdemux: Add MSE-style flush Since compatibility with older GStreamer versions is a problem, especially in slower moving distros, a solution to this problem would likely require patching GStreamer and WebKit in a way that the current suboptimal way to do aborts is preserved for GStreamer versions missing the patch. 1940137 1 eocanha 2023-03-09 11:00:31 -0800 Pull request: https://github.com/WebKit/WebKit/pull/11313 1940138 2 eocanha 2023-03-09 11:07:23 -0800 Note that the patch from https://github.com/WebKit/WebKit/pull/11313 still does NOT pass the layout tests, so if it eventually lands, this bug should be reopened. The reason is that the layout tests append partial data on purpose to check how the demuxer recovers from that, and qtdemux can't yet recover from that situation. However, if the tests are modified to use append full fragments, the test passes. Still, this patch would be an improvement and would unblock the test case in WebPlatformForEmbedded/WPEWebKit#1016 1943132 3 eocanha 2023-03-22 11:01:42 -0700 The media-webm-opus-partial-abort.html failure is unrelated to the partial abort support. That test is failing because non-glib/GStreamer ports aren't honoring the CodecDelay field in the webm file. It's being addressed separately on https://bugs.webkit.org/show_bug.cgi?id=254222, where a patch that changes the webm file to have a zero CodecDelay is being submitted. 1943159 4 eocanha 2023-03-22 13:11:26 -0700 Pull request: https://github.com/WebKit/WebKit/pull/11819 1944174 5 ews-feeder 2023-03-27 04:53:18 -0700 Committed 262144@main (9bc4d3cabf88): <https://commits.webkit.org/262144@main> Reviewed commits have been landed. Closing PR #11819 and removing active labels.