228815 2021-08-05 01:19:26 -0700 Fix warning in HTTPParsers.parseStructuredFieldValue 2021-08-05 08:03:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis sam webkit-bug-importer oldest_to_newest 1782155 0 rbuis 2021-08-05 01:19:26 -0700 In file included from WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-50.cpp:8: ../../Source/WebCore/platform/network/HTTPParsers.cpp: In function ‘std::optional<std::pair<WTF::StringView, WTF::HashMap<WTF::String, WTF::String> > > WebCore::parseStructuredFieldValue(WTF::StringView)’: ../../Source/WebCore/platform/network/HTTPParsers.cpp:651:47: warning: comparison is always true due to limited range of data type [-Wtype-limits] 651 | } else if ((header[index] >= 0x00 && header[index] <= 0x1F) || (header[index] >= 0x7F && header[index] <= 0xFF)) // Not in VCHAR or SP. | ~~~~~~~~~~~~~~^~~~~~~ 1782156 1 434972 rbuis 2021-08-05 01:22:43 -0700 Created attachment 434972 Patch 1782203 2 ews-feeder 2021-08-05 08:02:45 -0700 Committed r280686 (240288@main): <https://commits.webkit.org/240288@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434972. 1782204 3 webkit-bug-importer 2021-08-05 08:03:16 -0700 <rdar://problem/81566755> 434972 2021-08-05 01:22:43 -0700 2021-08-05 08:02:46 -0700 Patch bug-228815-20210805102242.patch text/plain 1790 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzE4MDQ3NjUwNWJiMzg3 OWYxZDllMWJmODE0ODE4NDUzMjdkYmFiNS4uNTRmYzAzYjllNzM0MGY1MmQ5MDFkN2FjZGQ5YjM2 MmUwNmQyOTQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA4LTA1ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IHdhcm5pbmcgaW4gSFRUUFBh cnNlcnMucGFyc2VTdHJ1Y3R1cmVkRmllbGRWYWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4ODE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVUNoYXIgaXMgdW5zaWduZWQsIHNvIGl0IGlzIG5vdCBu ZWVkZWQgdG8gY2hlY2sgdGhhdCBpdCBpcworICAgICAgICB6ZXdybyBvciBncmVhdGVyLgorCisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5jcHA6CisgICAgICAgIChXZWJD b3JlOjpwYXJzZVN0cnVjdHVyZWRGaWVsZFZhbHVlKToKKwogMjAyMS0wOC0wNCAgRGFyaW4gQWRs ZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2hhbmdlIFdlYlNvY2tldC5jcHAgdG8g QG5vLXVuaWZ5LCBzaW5jZSBpdOKAmXMgaGFyZCB0byBkbyB0aGF0IGZvciBzb21lb25lIHdpdGhv dXQgYSBNYWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRU UFBhcnNlcnMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vy cy5jcHAKaW5kZXggNzBjZTJlODVkNzgwZDUwMDFlNWU0ZDhhZWIxZjQ2YjFlNzgyMTQ0MC4uZjk4 MzY5MmE5Y2VlNjA2ODhlNzRhMDA5ZGUzMzNmZmRlMTA0ZTlhNSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5jcHAKQEAgLTY0OCw3ICs2NDgsNyBA QCBzdGQ6Om9wdGlvbmFsPHN0ZDo6cGFpcjxTdHJpbmdWaWV3LCBIYXNoTWFwPFN0cmluZywgU3Ry aW5nPj4+IHBhcnNlU3RydWN0dXJlZEZpZQogICAgICAgICAgICAgICAgICAgICB9IGVsc2UgaWYg KGhlYWRlcltpbmRleF0gPT0gJ1wiJykgewogICAgICAgICAgICAgICAgICAgICAgICAgdmFsdWUg PSB2YWx1ZUJ1aWxkZXIudG9TdHJpbmcoKTsKICAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFr OwotICAgICAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKChoZWFkZXJbaW5kZXhdID49IDB4MDAg JiYgaGVhZGVyW2luZGV4XSA8PSAweDFGKSB8fCAoaGVhZGVyW2luZGV4XSA+PSAweDdGICYmIGhl YWRlcltpbmRleF0gPD0gMHhGRikpIC8vIE5vdCBpbiBWQ0hBUiBvciBTUC4KKyAgICAgICAgICAg ICAgICAgICAgfSBlbHNlIGlmIChoZWFkZXJbaW5kZXhdIDw9IDB4MUYgfHwgKGhlYWRlcltpbmRl eF0gPj0gMHg3RiAmJiBoZWFkZXJbaW5kZXhdIDw9IDB4RkYpKSAvLyBOb3QgaW4gVkNIQVIgb3Ig U1AuCiAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OwogICAgICAg ICAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAgICAgICAgICAgICB2YWx1ZUJ1aWxkZXIu YXBwZW5kKGhlYWRlcltpbmRleF0pOwo=