228808 2021-08-04 18:15:51 -0700 Change WebSocket.cpp to @no-unify, since it’s hard to do that for someone without a Mac 2021-08-05 06:43:07 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other All All RESOLVED FIXED InRadar P2 Normal --- 226557 1 darin darin andersca mcatanzaro webkit-bug-importer oldest_to_newest 1782116 0 darin 2021-08-04 18:15:51 -0700 Michael Catanzaro asked for help making WebSocket.cpp a @no-unify file, including the Xcode project changes. 1782117 1 434960 darin 2021-08-04 18:18:26 -0700 Created attachment 434960 Patch 1782118 2 darin 2021-08-04 18:20:31 -0700 Not thrilled to be adding more @no-unify. We’d like to do the reverse and have fewer separately compiled files! 1782124 3 ews-feeder 2021-08-04 19:52:07 -0700 Committed r280677 (240279@main): <https://commits.webkit.org/240279@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434960. 1782125 4 webkit-bug-importer 2021-08-04 19:53:18 -0700 <rdar://problem/81546248> 1782186 5 mcatanzaro 2021-08-05 06:43:07 -0700 Thanks Darin! (In reply to Darin Adler from comment #2) > Not thrilled to be adding more @no-unify. We’d like to do the reverse and > have fewer separately compiled files! I know. :/ I've tried my best in bug #226557 and concluded it's either do this, or build all of WebCore with -Wno-stringop-overread. I'd rather suppress it for this one file than the entire project. 434960 2021-08-04 18:18:26 -0700 2021-08-04 19:52:08 -0700 Patch bug-228808-20210804181825.patch text/plain 3462 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDMyYjhiZWEyZWIxNTY1 ZTQ2NjY0NWEwZjQ4YjdlOTcxZmViN2Y1Ni4uZTI2NjZlZmFkYmJlY2I2ZWUyN2QyYTVkZTQzZjYx N2MxMzJhZWZlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTA4LTA0ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBDaGFuZ2UgV2ViU29ja2V0LmNw cCB0byBAbm8tdW5pZnksIHNpbmNlIGl04oCZcyBoYXJkIHRvIGRvIHRoYXQgZm9yIHNvbWVvbmUg d2l0aG91dCBhIE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI4ODA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBTb3VyY2VzLnR4dDogQWRkIEBuby11bmlmeS4KKyAgICAgICAgKiBXZWJDb3JlLnhj b2RlcHJvai9wcm9qZWN0LnBieHByb2o6IEFkZCBXZWJTb2NrZXQuY3BwIHRvIHRoZSBXZWJDb3Jl IHRhcmdldC4KKwogMjAyMS0wOC0wNCAgTWlndWVsIEdvbWV6ICA8bWFnb21lekBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdW1dQRV0gRWxsaXB0aWMgcmFkaWFsIGdyYWRpZW50cyBhcmUgbm90 IHdvcmtpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1NvdXJjZXMudHh0IGIvU291cmNl L1dlYkNvcmUvU291cmNlcy50eHQKaW5kZXggZTM4NDAwMDRiNmZlYjdkYTFkYmYzNGFhZGNhMzll MjFhN2RiOTNlMi4uMjY2MTRhN2Q5NzUzMjBkYjZiODVkNDNkMzljOWFkMzI1M2I1MjNjZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvU291cmNlcy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUv U291cmNlcy50eHQKQEAgLTMyMyw3ICszMjMsNyBAQCBNb2R1bGVzL3dlYmRyaXZlci9OYXZpZ2F0 b3JXZWJEcml2ZXIuY3BwCiBNb2R1bGVzL3dlYnNvY2tldHMvQ2xvc2VFdmVudC5jcHAKIE1vZHVs ZXMvd2Vic29ja2V0cy9UaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbC5jcHAKIE1vZHVsZXMvd2Vi c29ja2V0cy9UaHJlYWRhYmxlV2ViU29ja2V0Q2hhbm5lbENsaWVudFdyYXBwZXIuY3BwCi1Nb2R1 bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcAorTW9kdWxlcy93ZWJzb2NrZXRzL1dlYlNvY2tl dC5jcHAgQG5vLXVuaWZ5CiBNb2R1bGVzL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5jcHAK IE1vZHVsZXMvd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsSW5zcGVjdG9yLmNwcAogTW9kdWxl cy93ZWJzb2NrZXRzL1dlYlNvY2tldERlZmxhdGVGcmFtZXIuY3BwCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Tb3VyY2UvV2Vi Q29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKaW5kZXggODIzZWIyYjc4OWJm M2U5NGYzZjY3YzA5ZGZkOWNhZDE5OTBmNDk5Yi4uN2JlNDg3NjNhNjQ3OTNiMDhlNGY3NmZlOWQw NjQ2YzM1MDg5ODA1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS54Y29kZXBy b2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9q L3Byb2plY3QucGJ4cHJvagpAQCAtMjg0OSw2ICsyODQ5LDcgQEAKIAkJOTM4NDMwQjQyNDc1REU0 MDAwM0Y5NjE3IC8qIERpY3RhdGlvbkNvbnRleHQuaCBpbiBIZWFkZXJzICovID0ge2lzYSA9IFBC WEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDkzODQzMEIyMjQ3NURFM0YwMDNGOTYxNyAvKiBEaWN0YXRp b25Db250ZXh0LmggKi87IHNldHRpbmdzID0ge0FUVFJJQlVURVMgPSAoUHJpdmF0ZSwgKTsgfTsg fTsKIAkJOTM4NDlDMUYyNEJFNDA0QjAwNDQ4RDVBIC8qIEVtcHR5U2NyaXB0RXhlY3V0aW9uQ29u dGV4dC5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gOTM4 NDlDMUUyNEJFNDA0QTAwNDQ4RDVBIC8qIEVtcHR5U2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oICov OyB9OwogCQk5Mzg0OUMyMzI0QkVERDg5MDA0NDhENUEgLyogSlNJREJTZXJpYWxpemF0aW9uR2xv YmFsT2JqZWN0LmggaW4gSGVhZGVycyAqLyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYg PSA5Mzg0OUMyMTI0QkVERDg4MDA0NDhENUEgLyogSlNJREJTZXJpYWxpemF0aW9uR2xvYmFsT2Jq ZWN0LmggKi87IH07CisJCTkzOENGMjQyMjZCQjcyOEMwMEMwOTI0MCAvKiBXZWJTb2NrZXQuY3Bw IGluIFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gOTdBQUJDRkYx NEZBMDlENTAwNzQ1N0FFIC8qIFdlYlNvY2tldC5jcHAgKi87IH07CiAJCTkzOEU2NUYxMDlGMDk4 NDAwMDhBNDhFQyAvKiBKU0hUTUxFbGVtZW50V3JhcHBlckZhY3RvcnkuaCBpbiBIZWFkZXJzICov ID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDkzOEU2NUYwMDlGMDk4NDAwMDhBNDhF QyAvKiBKU0hUTUxFbGVtZW50V3JhcHBlckZhY3RvcnkuaCAqLzsgfTsKIAkJOTM4RTY2NjIwOUYw OUI4NzAwOEE0OEVDIC8qIEpTSFRNTENhbnZhc0VsZW1lbnQuaCBpbiBIZWFkZXJzICovID0ge2lz YSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDkzOEU2NjYxMDlGMDlCODcwMDhBNDhFQyAvKiBK U0hUTUxDYW52YXNFbGVtZW50LmggKi87IH07CiAJCTkzOTFBOTkxMTYyNzQ2Q0IwMDI5NzMzMCAv KiBTY3JvbGxpbmdDb29yZGluYXRvck1hYy5oIGluIEhlYWRlcnMgKi8gPSB7aXNhID0gUEJYQnVp bGRGaWxlOyBmaWxlUmVmID0gOTM5MUE5OTAxNjI3NDZDQjAwMjk3MzMwIC8qIFNjcm9sbGluZ0Nv b3JkaW5hdG9yTWFjLmggKi87IH07CkBAIC0zNjYwMiw2ICszNjYwMyw3IEBACiAJCQkJMDdGNUNG RjYyNTgyQTUyOTAwNjYyRUY1IC8qIFdlYk1BdWRpb1V0aWxpdGllc0NvY29hLm1tIGluIFNvdXJj ZXMgKi8sCiAJCQkJMDcwOUQ3OTIxQUU1NTU3RTAwNEU0MkY4IC8qIFdlYk1lZGlhU2Vzc2lvbk1h bmFnZXJNYWMuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJMUNBRjM0ODIwQTZDNDA1MjAwQUJFMDZF IC8qIFdlYlNjcmlwdE9iamVjdC5tbSBpbiBTb3VyY2VzICovLAorCQkJCTkzOENGMjQyMjZCQjcy OEMwMEMwOTI0MCAvKiBXZWJTb2NrZXQuY3BwIGluIFNvdXJjZXMgKi8sCiAJCQkJQ0VDREM5M0My MUYyOTcyOTAwOTc2QkQxIC8qIFdlYlZpZGVvRnVsbHNjcmVlbkNvbnRyb2xsZXJBVktpdC5tbSBp biBTb3VyY2VzICovLAogCQkJCUUxRUU4QjgwMjQxMzE5MUYwMEU3OTRENiAvKiBXZWJYUkJvdW5k ZWRSZWZlcmVuY2VTcGFjZS5jcHAgaW4gU291cmNlcyAqLywKIAkJCQlFMUVFOEI5MzI0MTMxOTUw MDBFNzk0RDYgLyogV2ViWFJGcmFtZS5jcHAgaW4gU291cmNlcyAqLywK