228807 2021-08-04 17:39:40 -0700 [macOS Monterey] Translate popover becomes detached from webpage after scrolling 2021-08-05 09:03:45 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh hi luming_yin megan_gardner sam thorton webkit-bug-importer oldest_to_newest 1782109 0 wenson_hsieh 2021-08-04 17:39:40 -0700 rdar://81540115 1782121 1 434961 wenson_hsieh 2021-08-04 19:24:40 -0700 Created attachment 434961 Patch 1782202 2 sam 2021-08-05 08:00:59 -0700 Can we make a test for this? 1782217 3 wenson_hsieh 2021-08-05 08:28:24 -0700 Thanks for the review! (In reply to Sam Weinig from comment #2) > Can we make a test for this? That's a good question.. It should be possible, but it might be somewhat tricky to make it listen for popover presentation hooks. We could naively observe NSPopoverDidShowNotification and NSPopoverDidCloseNotification, but I'm not sure that will be robust in the case where we have multiple test runners attempting to present popovers simultaneously. I'll experiment with this: filed https://webkit.org/b/228829. 1782227 4 ews-feeder 2021-08-05 09:03:43 -0700 Committed r280690 (240292@main): <https://commits.webkit.org/240292@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434961. 434961 2021-08-04 19:24:40 -0700 2021-08-05 09:03:44 -0700 Patch bug-228807-20210804192439.patch text/plain 4728 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU1MDMyMjJkZGE3YzlkODFl YzQwNjUxNmZkNmFlZDdlMWJjNGE0MTIuLjRjMzZmNjQ2YTNhYWM4MWEyMWRhMmE1NDAxMGJmNjQw MjRlMjcxMmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjEtMDgtMDQgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW21hY09TIE1vbnRlcmV5 XSBUcmFuc2xhdGUgcG9wb3ZlciBiZWNvbWVzIGRldGFjaGVkIGZyb20gd2VicGFnZSBhZnRlciBz Y3JvbGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIyODgwNworICAgICAgICByZGFyOi8vODE1NDAxMTUKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbG9zZSB0aGUgY29udGV4dCBtZW51IHRyYW5zbGF0 aW9uIHBvcG92ZXIgaW4gYFdlYlZpZXdJbXBsOjpkaXNtaXNzQ29udGVudFJlbGF0aXZlQ2hpbGRX aW5kb3dzRnJvbVZpZXdPbmx5YAorICAgICAgICAoYWxvbmcgd2l0aCBhbGwgb3RoZXIgY29udGVu dC1yZWxhdGl2ZSBVSSkgdG8gcHJldmVudCB0aGUgcG9wb3ZlciBmcm9tIGJlaW5nIGRldGFjaGVk IGZyb20gaXRzIHRyYW5zbGF0ZWQgdGV4dAorICAgICAgICB1cG9uIHNjcm9sbGluZyBvciB6b29t aW5nLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLmg6CisgICAgICAg ICogVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJW aWV3SW1wbDo6ZGlzbWlzc0NvbnRlbnRSZWxhdGl2ZUNoaWxkV2luZG93c0Zyb21WaWV3T25seSk6 CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpoYW5kbGVDb250ZXh0TWVudVRyYW5zbGF0 aW9uKToKKworICAgICAgICBTYXZlIGEgd2VhayBwb2ludGVyIHRvIHRoZSBjdXJyZW50IHRyYW5z bGF0aW9uIHBvcG92ZXIgd2hlbiB3ZSdyZSBhYm91dCB0byBwcmVzZW50IGl0LCBhbmQgdXNlIGl0 IHRvIGZvcmNlIHRoZQorICAgICAgICBwb3BvdmVyIHRvIGAtY2xvc2VgIHdoZW4gZGlzbWlzc2lu ZyBjb250ZW50LXJlbGF0aXZlIGNoaWxkIHdpbmRvd3MuIEFsc28gdGFrZSB0aGlzIG9wcG9ydHVu aXR5IHRvIHJlbW92ZSBzb21lCisgICAgICAgIHN0YWdpbmcgZGVjbGFyYXRpb25zIG9uIExUVUlU cmFuc2xhdGlvblZpZXdDb250cm9sbGVyIHRoYXQgaGF2ZSBsb25nIHNpbmNlIGxhbmRlZCBpbiB0 aGUgbWFjT1MgMTIgU0RLLgorCiAyMDIxLTA4LTA0ICBTYWlkIEFib3UtSGFsbGF3YSAgPHNhaWRA YXBwbGUuY29tPgogCiAgICAgICAgIFtHUFVQcm9jZXNzXSBSRUdSRVNTSU9OOiBBIG5vdGljZWFi bGUgc2xvdyBkb3duIHdoZW4gYnJvd3NpbmcgTGl2ZSBQaG90b3MgYWxidW0gb24gaUNsb3VkLmNv bQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwu aCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLmgKaW5kZXggZTgy NjBhNTlkOTRjZGM5MzhmMDExYzg5ZTgxZjg1NDAyMzIyZDk5OS4uMDFkNTZkMGE0YzE0MGU3NzZh NTRlZTIwN2FhNzNkZTNlNmE3OTA2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQ29jb2EvV2ViVmlld0ltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2Nv YS9XZWJWaWV3SW1wbC5oCkBAIC01Miw2ICs1Miw3IEBAIHVzaW5nIF9XS1JlY3RFZGdlID0gTlNV SW50ZWdlcjsKIE9CSkNfQ0xBU1MgTlNBY2Nlc3NpYmlsaXR5UmVtb3RlVUlFbGVtZW50OwogT0JK Q19DTEFTUyBOU0ltbWVkaWF0ZUFjdGlvbkdlc3R1cmVSZWNvZ25pemVyOwogT0JKQ19DTEFTUyBO U01lbnU7CitPQkpDX0NMQVNTIE5TUG9wb3ZlcjsKIE9CSkNfQ0xBU1MgTlNUZXh0SW5wdXRDb250 ZXh0OwogT0JKQ19DTEFTUyBOU1ZpZXc7CiBPQkpDX0NMQVNTIFFMUHJldmlld1BhbmVsOwpAQCAt OTA3LDYgKzkwOCwxMCBAQCBwcml2YXRlOgogICAgIFJlZlB0cjxXb3JrUXVldWU+IG1faW1hZ2VB bmFseXplclF1ZXVlOwogICAgIFJldGFpblB0cjxWS0ltYWdlQW5hbHl6ZXI+IG1faW1hZ2VBbmFs eXplcjsKICNlbmRpZgorCisjaWYgSEFWRShUUkFOU0xBVElPTl9VSV9TRVJWSUNFUykgJiYgRU5B QkxFKENPTlRFWFRfTUVOVVMpCisgICAgV2Vha09iakNQdHI8TlNQb3BvdmVyPiBtX2xhc3RDb250 ZXh0TWVudVRyYW5zbGF0aW9uUG9wb3ZlcjsKKyNlbmRpZgogfTsKICAgICAKIH0gLy8gbmFtZXNw YWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2Vi Vmlld0ltcGwubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5t bQppbmRleCA3NzAxMTNjODQ2ZTQwZmQ0Mjc3M2NlZDczMDU2M2M2ZmZmOTgyYTNjLi4wOGZmYWRl OTlhYzU1ODM5MGQxNDEzODliMzc1ODQ4NjY3Mjk3ZWI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQpAQCAtMTUwLDEwICsxNTAsNiBAQAogI2lmIEhB VkUoVFJBTlNMQVRJT05fVUlfU0VSVklDRVMpCiAjaW1wb3J0IDxUcmFuc2xhdGlvblVJU2Vydmlj ZXMvTFRVSVRyYW5zbGF0aW9uVmlld0NvbnRyb2xsZXIuaD4KIAotQGludGVyZmFjZSBMVFVJVHJh bnNsYXRpb25WaWV3Q29udHJvbGxlciAoU3RhZ2luZ183NzY2MDY3NSkKLUBwcm9wZXJ0eSAobm9u YXRvbWljLCBjb3B5KSB2b2lkKF5yZXBsYWNlbWVudEhhbmRsZXIpKE5TQXR0cmlidXRlZFN0cmlu ZyAqKTsKLUBlbmQKLQogU09GVF9MSU5LX1BSSVZBVEVfRlJBTUVXT1JLX09QVElPTkFMKFRyYW5z bGF0aW9uVUlTZXJ2aWNlcykKIFNPRlRfTElOS19DTEFTU19PUFRJT05BTChUcmFuc2xhdGlvblVJ U2VydmljZXMsIExUVUlUcmFuc2xhdGlvblZpZXdDb250cm9sbGVyKQogI2VuZGlmCkBAIC0zNzIw LDYgKzM3MTYsMTAgQEAgdm9pZCBXZWJWaWV3SW1wbDo6ZGlzbWlzc0NvbnRlbnRSZWxhdGl2ZUNo aWxkV2luZG93c0Zyb21WaWV3T25seSgpCiAgICAgW21faW1tZWRpYXRlQWN0aW9uQ29udHJvbGxl ciBkaXNtaXNzQ29udGVudFJlbGF0aXZlQ2hpbGRXaW5kb3dzXTsKIAogICAgIG1fcGFnZUNsaWVu dC0+ZGlzbWlzc0NvcnJlY3Rpb25QYW5lbChXZWJDb3JlOjpSZWFzb25Gb3JEaXNtaXNzaW5nQWx0 ZXJuYXRpdmVUZXh0SWdub3JlZCk7CisKKyNpZiBIQVZFKFRSQU5TTEFUSU9OX1VJX1NFUlZJQ0VT KSAmJiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKKyAgICBbc3RkOjpleGNoYW5nZShtX2xhc3RDb250 ZXh0TWVudVRyYW5zbGF0aW9uUG9wb3ZlciwgbmlsKSBjbG9zZV07CisjZW5kaWYKIH0KIAogdm9p ZCBXZWJWaWV3SW1wbDo6aGlkZVdvcmREZWZpbml0aW9uV2luZG93KCkKQEAgLTU3NzksNyArNTc3 OSw3IEBAIHZvaWQgV2ViVmlld0ltcGw6OmhhbmRsZUNvbnRleHRNZW51VHJhbnNsYXRpb24oY29u c3QgV2ViQ29yZTo6VHJhbnNsYXRpb25Db250ZXh0CiAgICAgYXV0byB2aWV3ID0gbV92aWV3Lmdl dCgpOwogICAgIGF1dG8gdHJhbnNsYXRpb25WaWV3Q29udHJvbGxlciA9IGFkb3B0TlMoW2FsbG9j TFRVSVRyYW5zbGF0aW9uVmlld0NvbnRyb2xsZXJJbnN0YW5jZSgpIGluaXRdKTsKICAgICBbdHJh bnNsYXRpb25WaWV3Q29udHJvbGxlciBzZXRUZXh0OmFkb3B0TlMoW1tOU0F0dHJpYnV0ZWRTdHJp bmcgYWxsb2NdIGluaXRXaXRoU3RyaW5nOmluZm8udGV4dF0pLmdldCgpXTsKLSAgICBpZiAoaW5m by5tb2RlID09IFdlYkNvcmU6OlRyYW5zbGF0aW9uQ29udGV4dE1lbnVNb2RlOjpFZGl0YWJsZSAm JiBbdHJhbnNsYXRpb25WaWV3Q29udHJvbGxlciByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9y KHNldFJlcGxhY2VtZW50SGFuZGxlcjopXSkgeworICAgIGlmIChpbmZvLm1vZGUgPT0gV2ViQ29y ZTo6VHJhbnNsYXRpb25Db250ZXh0TWVudU1vZGU6OkVkaXRhYmxlKSB7CiAgICAgICAgIFt0cmFu c2xhdGlvblZpZXdDb250cm9sbGVyIHNldElzU291cmNlRWRpdGFibGU6WUVTXTsKICAgICAgICAg W3RyYW5zbGF0aW9uVmlld0NvbnRyb2xsZXIgc2V0UmVwbGFjZW1lbnRIYW5kbGVyOlt0aGlzLCB3 ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKCp0aGlzKV0oTlNBdHRyaWJ1dGVkU3RyaW5nICpzdHJpbmcp IHsKICAgICAgICAgICAgIGlmICh3ZWFrVGhpcykKQEAgLTU4MDUsNiArNTgwNSw3IEBAIHZvaWQg V2ViVmlld0ltcGw6OmhhbmRsZUNvbnRleHRNZW51VHJhbnNsYXRpb24oY29uc3QgV2ViQ29yZTo6 VHJhbnNsYXRpb25Db250ZXh0CiAgICAgZWxzZQogICAgICAgICBwcmVmZXJyZWRFZGdlID0gYWlt ID4gaGlnaGxpZ2h0ID8gTlNSZWN0RWRnZU1heFggOiBOU1JlY3RFZGdlTWluWDsKIAorICAgIG1f bGFzdENvbnRleHRNZW51VHJhbnNsYXRpb25Qb3BvdmVyID0gcG9wb3Zlci5nZXQoKTsKICAgICBb cG9wb3ZlciBzaG93UmVsYXRpdmVUb1JlY3Q6aW5mby5zZWxlY3Rpb25Cb3VuZHNJblJvb3RWaWV3 IG9mVmlldzp2aWV3LmdldCgpIHByZWZlcnJlZEVkZ2U6cHJlZmVycmVkRWRnZV07CiB9CiAK