228774 2021-08-04 08:02:34 -0700 [iOS 15] "Look Up" action is sometimes missing after force pressing images 2021-08-04 11:44:28 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh hi megan_gardner thorton webkit-bug-importer oldest_to_newest 1781880 0 wenson_hsieh 2021-08-04 08:02:34 -0700 rdar://78040734 1781885 1 434905 wenson_hsieh 2021-08-04 08:29:52 -0700 Created attachment 434905 Patch 1781935 2 434905 hi 2021-08-04 10:54:21 -0700 Comment on attachment 434905 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434905&action=review r=me > Source/WebKit/UIProcess/ios/WKImageAnalysisGestureRecognizer.mm:68 > + if (touches.anyObject.force < forceThreshold) Is every `UITouch` guaranteed to have the same `force`? Or do we need to iterate this? 1781939 3 434905 wenson_hsieh 2021-08-04 10:58:01 -0700 Comment on attachment 434905 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434905&action=review Thanks for the review! >> Source/WebKit/UIProcess/ios/WKImageAnalysisGestureRecognizer.mm:68 >> + if (touches.anyObject.force < forceThreshold) > > Is every `UITouch` guaranteed to have the same `force`? Or do we need to iterate this? Each UITouch will have the force corresponding to that touch — I don't think it will be an issue here though, since the context menu is only triggered if there's one active touch. That said, I suppose I could add an early return if `touches.count > 1`. 1781943 4 434914 wenson_hsieh 2021-08-04 11:09:44 -0700 Created attachment 434914 Patch for landing 1781973 5 ews-feeder 2021-08-04 11:44:27 -0700 Committed r280647 (240258@main): <https://commits.webkit.org/240258@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434914. 434905 2021-08-04 08:29:52 -0700 2021-08-04 10:54:21 -0700 Patch bug-228774-20210804082951.patch text/plain 3129 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc3ZmRhZDFkNzZjMmM0ZGIz YTc0MDVlODBhYzQ0MGRmY2YxMDI4OWMuLmVmNmJlMTI1MTc1YzNmNzU2NzkzOWY1MjI0MzJmZTY5 MTQ3ZjA5NzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMjEtMDgtMDQgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPUyAxNV0gIkxvb2sg VXAiIGFjdGlvbiBpcyBzb21ldGltZXMgbWlzc2luZyBhZnRlciBmb3JjZSBwcmVzc2luZyBpbWFn ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyODc3 NAorICAgICAgICByZGFyOi8vNzgwNDA3MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBPbiBpT1MgZGV2aWNlcyB0aGF0IHN1cHBvcnQgYm90aCAzRCBU b3VjaCBhbmQgVmlzdWFsIExvb2sgVXAgKGkuZS4sIGlQaG9uZSBYUyBhbmQgaVBob25lIFhTIE1h eCksIGl0J3MgY3VycmVudGx5CisgICAgICAgIHBvc3NpYmxlIHRvIHNraXAgdGhlIGltYWdlIGFu YWx5c2lzIHByZWZsaWdodCBnZXN0dXJlIGVudGlyZWx5IHdoZW4gc2hvd2luZyB0aGUgY29udGV4 dCBtZW51IG92ZXIgaW1hZ2VzIGluIHRoZQorICAgICAgICBjYXNlIHdoZXJlIHRoZSB1c2VyIHRy aWdnZXJzIHRoZSBpbnRlcmFjdGlvbiBieSBleGNlZWRpbmcgdGhlIGZvcmNlIHByZXNzIHRocmVz aG9sZCBpbiB1bmRlciAxMDAgbXMgKHRoZSBjdXJyZW50CisgICAgICAgIGRlbGF5IG9mIHRoZSBp bWFnZSBhbmFseXNpcyBsb25nIHByZXNzIGdlc3R1cmUpLgorCisgICAgICAgIE1pdGlnYXRlIHRo aXMgYnkgdGVhY2hpbmcgV0tJbWFnZUFuYWx5c2lzR2VzdHVyZVJlY29nbml6ZXIgdG8gdHJpZ2dl ciBpbWFnZSBhbmFseXNpcyBwcmVmbGlnaHQgc2xpZ2h0bHkgYWhlYWQgb2YKKyAgICAgICAgdGhl IGNvbnRleHQgbWVudSBpbnRlcmFjdGlvbiB3aGVuIHBlcmZvcm1pbmcgYSBmb3JjZSBwcmVzcyBi eSB0cmFuc2l0aW9uaW5nIHRvIEJlZ2FuIHN0YXRlIGVhcmx5IHVuZGVyCisgICAgICAgIGAtdG91 Y2hlc0JlZ2FuOndpdGhFdmVudDpgIGFuZCBgLXRvdWNoZXNNb3ZlZDp3aXRoRXZlbnQ6YCwgaWYg dGhlIHRvdWNoJ3MgZm9yY2UgZXhjZWVkcyBhIGNlcnRhaW4gKHJlbGF0aXZlbHkKKyAgICAgICAg bG93KSB0aHJlc2hvbGQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLSW1hZ2VBbmFseXNp c0dlc3R1cmVSZWNvZ25pemVyLm1tOgorICAgICAgICAoLVtXS0ltYWdlQW5hbHlzaXNHZXN0dXJl UmVjb2duaXplciB0b3VjaGVzQmVnYW46d2l0aEV2ZW50Ol0pOgorICAgICAgICAoLVtXS0ltYWdl QW5hbHlzaXNHZXN0dXJlUmVjb2duaXplciB0b3VjaGVzTW92ZWQ6d2l0aEV2ZW50Ol0pOgorICAg ICAgICAoLVtXS0ltYWdlQW5hbHlzaXNHZXN0dXJlUmVjb2duaXplciBiZWdpbkFmdGVyRXhjZWVk aW5nRm9yY2VUaHJlc2hvbGRJZk5lZWRlZDpdKToKKwogMjAyMS0wOC0wMiAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvd2VibWVzc2FnaW5nL2Jyb2FkY2FzdGNoYW5uZWwvYmxvYnMuaHRtbCBpcyBhIGZsYWt5 IGZhaWx1cmUgc2luY2UgaW1wbGVtZW50aW5nIEJsb2JDaGFubmVsCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tJbWFnZUFuYWx5c2lzR2VzdHVyZVJlY29nbml6ZXIu bW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tJbWFnZUFuYWx5c2lzR2VzdHVyZVJl Y29nbml6ZXIubW0KaW5kZXggZDViNmY1OWUzMmFiODI0MTJlNjM3MjQ3MGY3NmQyZTRjNTJkODAy Ni4uMDdmNjVjOTUxNzVkOGUzMmE5NmFjYTA2OGY2MWZiYTAwOWFmOTU0ZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLSW1hZ2VBbmFseXNpc0dlc3R1cmVSZWNvZ25p emVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0ltYWdlQW5hbHlzaXNH ZXN0dXJlUmVjb2duaXplci5tbQpAQCAtNDUsNiArNDUsMzIgQEAgLSAoaW5zdGFuY2V0eXBlKWlu aXRXaXRoSW1hZ2VBbmFseXNpc0dlc3R1cmVEZWxlZ2F0ZTooVUlWaWV3IDxXS0ltYWdlQW5hbHlz aXNHZXMKICAgICByZXR1cm4gc2VsZjsKIH0KIAorLSAodm9pZCl0b3VjaGVzQmVnYW46KE5TU2V0 PFVJVG91Y2ggKj4gKil0b3VjaGVzIHdpdGhFdmVudDooVUlFdmVudCAqKWV2ZW50Cit7CisgICAg W3N1cGVyIHRvdWNoZXNCZWdhbjp0b3VjaGVzIHdpdGhFdmVudDpldmVudF07CisKKyAgICBbc2Vs ZiBiZWdpbkFmdGVyRXhjZWVkaW5nRm9yY2VUaHJlc2hvbGRJZk5lZWRlZDp0b3VjaGVzXTsKK30K KworLSAodm9pZCl0b3VjaGVzTW92ZWQ6KE5TU2V0PFVJVG91Y2ggKj4gKil0b3VjaGVzIHdpdGhF dmVudDooVUlFdmVudCAqKWV2ZW50Cit7CisgICAgW3N1cGVyIHRvdWNoZXNNb3ZlZDp0b3VjaGVz IHdpdGhFdmVudDpldmVudF07CisKKyAgICBbc2VsZiBiZWdpbkFmdGVyRXhjZWVkaW5nRm9yY2VU aHJlc2hvbGRJZk5lZWRlZDp0b3VjaGVzXTsKK30KKworLSAodm9pZCliZWdpbkFmdGVyRXhjZWVk aW5nRm9yY2VUaHJlc2hvbGRJZk5lZWRlZDooTlNTZXQ8VUlUb3VjaCAqPiAqKXRvdWNoZXMKK3sK KyAgICBpZiAoc2VsZi5zdGF0ZSAhPSBVSUdlc3R1cmVSZWNvZ25pemVyU3RhdGVQb3NzaWJsZSkK KyAgICAgICAgcmV0dXJuOworCisgICAgY29uc3RleHByIENHRmxvYXQgZm9yY2VUaHJlc2hvbGQg PSAxLjU7CisgICAgaWYgKHRvdWNoZXMuYW55T2JqZWN0LmZvcmNlIDwgZm9yY2VUaHJlc2hvbGQp CisgICAgICAgIHJldHVybjsKKworICAgIHNlbGYuc3RhdGUgPSBVSUdlc3R1cmVSZWNvZ25pemVy U3RhdGVCZWdhbjsKK30KKwogLSAodm9pZClzZXRTdGF0ZTooVUlHZXN0dXJlUmVjb2duaXplclN0 YXRlKXN0YXRlCiB7CiAgICAgYXV0byBwcmV2aW91c1N0YXRlID0gc2VsZi5zdGF0ZTsK 434914 2021-08-04 11:09:44 -0700 2021-08-04 11:44:28 -0700 Patch for landing bug-228774-20210804110944.patch text/plain 3174 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc3ZmRhZDFkNzZjMmM0ZGIz YTc0MDVlODBhYzQ0MGRmY2YxMDI4OWMuLmUyYTkyOTI5NjJiNGU0YjRlZGI2MTZmOTBkNDcwMzE4 ZTYyNzY5NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMjEtMDgtMDQgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPUyAxNV0gIkxvb2sg VXAiIGFjdGlvbiBpcyBzb21ldGltZXMgbWlzc2luZyBhZnRlciBmb3JjZSBwcmVzc2luZyBpbWFn ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyODc3 NAorICAgICAgICByZGFyOi8vNzgwNDA3MzQKKworICAgICAgICBSZXZpZXdlZCBieSBEZXZpbiBS b3Vzc28uCisKKyAgICAgICAgT24gaU9TIGRldmljZXMgdGhhdCBzdXBwb3J0IGJvdGggM0QgVG91 Y2ggYW5kIFZpc3VhbCBMb29rIFVwIChpLmUuLCBpUGhvbmUgWFMgYW5kIGlQaG9uZSBYUyBNYXgp LCBpdCdzIGN1cnJlbnRseQorICAgICAgICBwb3NzaWJsZSB0byBza2lwIHRoZSBpbWFnZSBhbmFs eXNpcyBwcmVmbGlnaHQgZ2VzdHVyZSBlbnRpcmVseSB3aGVuIHNob3dpbmcgdGhlIGNvbnRleHQg bWVudSBvdmVyIGltYWdlcyBpbiB0aGUKKyAgICAgICAgY2FzZSB3aGVyZSB0aGUgdXNlciB0cmln Z2VycyB0aGUgaW50ZXJhY3Rpb24gYnkgZXhjZWVkaW5nIHRoZSBmb3JjZSBwcmVzcyB0aHJlc2hv bGQgaW4gdW5kZXIgMTAwIG1zICh0aGUgY3VycmVudAorICAgICAgICBkZWxheSBvZiB0aGUgaW1h Z2UgYW5hbHlzaXMgbG9uZyBwcmVzcyBnZXN0dXJlKS4KKworICAgICAgICBNaXRpZ2F0ZSB0aGlz IGJ5IHRlYWNoaW5nIFdLSW1hZ2VBbmFseXNpc0dlc3R1cmVSZWNvZ25pemVyIHRvIHRyaWdnZXIg aW1hZ2UgYW5hbHlzaXMgcHJlZmxpZ2h0IHNsaWdodGx5IGFoZWFkIG9mCisgICAgICAgIHRoZSBj b250ZXh0IG1lbnUgaW50ZXJhY3Rpb24gd2hlbiBwZXJmb3JtaW5nIGEgZm9yY2UgcHJlc3MgYnkg dHJhbnNpdGlvbmluZyB0byBCZWdhbiBzdGF0ZSBlYXJseSB1bmRlcgorICAgICAgICBgLXRvdWNo ZXNCZWdhbjp3aXRoRXZlbnQ6YCBhbmQgYC10b3VjaGVzTW92ZWQ6d2l0aEV2ZW50OmAsIGlmIHRo ZSB0b3VjaCdzIGZvcmNlIGV4Y2VlZHMgYSBjZXJ0YWluIChyZWxhdGl2ZWx5CisgICAgICAgIGxv dykgdGhyZXNob2xkLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0ltYWdlQW5hbHlzaXNH ZXN0dXJlUmVjb2duaXplci5tbToKKyAgICAgICAgKC1bV0tJbWFnZUFuYWx5c2lzR2VzdHVyZVJl Y29nbml6ZXIgdG91Y2hlc0JlZ2FuOndpdGhFdmVudDpdKToKKyAgICAgICAgKC1bV0tJbWFnZUFu YWx5c2lzR2VzdHVyZVJlY29nbml6ZXIgdG91Y2hlc01vdmVkOndpdGhFdmVudDpdKToKKyAgICAg ICAgKC1bV0tJbWFnZUFuYWx5c2lzR2VzdHVyZVJlY29nbml6ZXIgYmVnaW5BZnRlckV4Y2VlZGlu Z0ZvcmNlVGhyZXNob2xkSWZOZWVkZWQ6XSk6CisKIDIwMjEtMDgtMDIgIENocmlzIER1bWV6ICA8 Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL3dlYm1lc3NhZ2luZy9icm9hZGNhc3RjaGFubmVsL2Jsb2JzLmh0bWwgaXMgYSBmbGFreSBm YWlsdXJlIHNpbmNlIGltcGxlbWVudGluZyBCbG9iQ2hhbm5lbApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLSW1hZ2VBbmFseXNpc0dlc3R1cmVSZWNvZ25pemVyLm1t IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLSW1hZ2VBbmFseXNpc0dlc3R1cmVSZWNv Z25pemVyLm1tCmluZGV4IGQ1YjZmNTllMzJhYjgyNDEyZTYzNzI0NzBmNzZkMmU0YzUyZDgwMjYu LjQxZDlkMmQwZjIyOTRhNTBjMzVlYjBjYjNiNDI5YTE4ZjNhNzM3YzEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0ltYWdlQW5hbHlzaXNHZXN0dXJlUmVjb2duaXpl ci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tJbWFnZUFuYWx5c2lzR2Vz dHVyZVJlY29nbml6ZXIubW0KQEAgLTQ1LDYgKzQ1LDM1IEBAIC0gKGluc3RhbmNldHlwZSlpbml0 V2l0aEltYWdlQW5hbHlzaXNHZXN0dXJlRGVsZWdhdGU6KFVJVmlldyA8V0tJbWFnZUFuYWx5c2lz R2VzCiAgICAgcmV0dXJuIHNlbGY7CiB9CiAKKy0gKHZvaWQpdG91Y2hlc0JlZ2FuOihOU1NldDxV SVRvdWNoICo+ICopdG91Y2hlcyB3aXRoRXZlbnQ6KFVJRXZlbnQgKilldmVudAoreworICAgIFtz dXBlciB0b3VjaGVzQmVnYW46dG91Y2hlcyB3aXRoRXZlbnQ6ZXZlbnRdOworCisgICAgW3NlbGYg YmVnaW5BZnRlckV4Y2VlZGluZ0ZvcmNlVGhyZXNob2xkSWZOZWVkZWQ6dG91Y2hlc107Cit9CisK Ky0gKHZvaWQpdG91Y2hlc01vdmVkOihOU1NldDxVSVRvdWNoICo+ICopdG91Y2hlcyB3aXRoRXZl bnQ6KFVJRXZlbnQgKilldmVudAoreworICAgIFtzdXBlciB0b3VjaGVzTW92ZWQ6dG91Y2hlcyB3 aXRoRXZlbnQ6ZXZlbnRdOworCisgICAgW3NlbGYgYmVnaW5BZnRlckV4Y2VlZGluZ0ZvcmNlVGhy ZXNob2xkSWZOZWVkZWQ6dG91Y2hlc107Cit9CisKKy0gKHZvaWQpYmVnaW5BZnRlckV4Y2VlZGlu Z0ZvcmNlVGhyZXNob2xkSWZOZWVkZWQ6KE5TU2V0PFVJVG91Y2ggKj4gKil0b3VjaGVzCit7Cisg ICAgaWYgKHNlbGYuc3RhdGUgIT0gVUlHZXN0dXJlUmVjb2duaXplclN0YXRlUG9zc2libGUpCisg ICAgICAgIHJldHVybjsKKworICAgIGlmICh0b3VjaGVzLmNvdW50ID4gMSkKKyAgICAgICAgcmV0 dXJuOworCisgICAgY29uc3RleHByIENHRmxvYXQgZm9yY2VUaHJlc2hvbGQgPSAxLjU7CisgICAg aWYgKHRvdWNoZXMuYW55T2JqZWN0LmZvcmNlIDwgZm9yY2VUaHJlc2hvbGQpCisgICAgICAgIHJl dHVybjsKKworICAgIHNlbGYuc3RhdGUgPSBVSUdlc3R1cmVSZWNvZ25pemVyU3RhdGVCZWdhbjsK K30KKwogLSAodm9pZClzZXRTdGF0ZTooVUlHZXN0dXJlUmVjb2duaXplclN0YXRlKXN0YXRlCiB7 CiAgICAgYXV0byBwcmV2aW91c1N0YXRlID0gc2VsZi5zdGF0ZTsK