228773 2021-08-04 07:45:43 -0700 [macOS] Update message filters 2021-08-04 11:28:57 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham webkit-bug-importer oldest_to_newest 1781877 0 pvollan 2021-08-04 07:45:43 -0700 Update message filters with enforcement on macOS based on telemetry. 1781878 1 webkit-bug-importer 2021-08-04 07:46:11 -0700 <rdar://problem/81514311> 1781879 2 434903 pvollan 2021-08-04 07:48:55 -0700 Created attachment 434903 Patch 1781912 3 434903 bfulgham 2021-08-04 09:51:35 -0700 Comment on attachment 434903 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434903&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:273 > + (allow (with telemetry-backtrace) iokit-external-method Do we really want telemetry-backtrace on these two methods? 1781931 4 pvollan 2021-08-04 10:41:46 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 434903 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434903&action=review > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:273 > > + (allow (with telemetry-backtrace) iokit-external-method > > Do we really want telemetry-backtrace on these two methods? Yes, I believe so. They are not expected to be frequently used. Thanks for reviewing! 1781936 5 434903 bfulgham 2021-08-04 10:55:03 -0700 Comment on attachment 434903 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434903&action=review r=me > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:269 > + (deny (with telemetry) (with message "IOMobileFramebufferUserClient") So we deny (with telemetry) pretty much all uses of iokit-async-external-method, and iokit-external-trap ... >>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:273 >>> + (allow (with telemetry-backtrace) iokit-external-method >> >> Do we really want telemetry-backtrace on these two methods? > > Yes, I believe so. They are not expected to be frequently used. > > Thanks for reviewing! ... and allow with backtrace iokit-external-method for these two methods. That means everything else is denied without telemetry, right? If so, I think this seems right. 1781948 6 pvollan 2021-08-04 11:19:39 -0700 (In reply to Brent Fulgham from comment #5) > Comment on attachment 434903 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434903&action=review > > r=me > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:269 > > + (deny (with telemetry) (with message "IOMobileFramebufferUserClient") > > So we deny (with telemetry) pretty much all uses of > iokit-async-external-method, and iokit-external-trap ... > > >>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:273 > >>> + (allow (with telemetry-backtrace) iokit-external-method > >> > >> Do we really want telemetry-backtrace on these two methods? > > > > Yes, I believe so. They are not expected to be frequently used. > > > > Thanks for reviewing! > > ... and allow with backtrace iokit-external-method for these two methods. > > That means everything else is denied without telemetry, right? > > If so, I think this seems right. Actually, I think we are keeping telemetry without backtraces for the denied items, in order to be able to see if they are being used. Thanks for reviewing! 1781959 7 ews-feeder 2021-08-04 11:28:56 -0700 Committed r280644 (240255@main): <https://commits.webkit.org/240255@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434903. 434903 2021-08-04 07:48:55 -0700 2021-08-04 11:28:57 -0700 Patch bug-228773-20210804074854.patch text/plain 2495 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyODA2MzMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIxLTA4LTA0ICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gVXBkYXRlIG1lc3NhZ2UgZmls dGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4 NzczCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84MTUxNDMxMT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgbWVzc2FnZSBmaWx0ZXJzIHdp dGggZW5mb3JjZW1lbnQgb24gbWFjT1MgYmFzZWQgb24gdGVsZW1ldHJ5LgorCisgICAgICAgICog V2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbjoKKwogMjAyMS0wOC0wMyAgSmVh bi1ZdmVzIEF2ZW5hcmQgIDxqeWFAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIy ODA1NjgpOiBBU1NFUlRJT04gRkFJTEVEOiB2aWRlb0Z1bGxzY3JlZW5NYW5hZ2VyLT5jbGllbnQo KSA9PSAmX3ZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94eUNsaWVudApJbmRleDogU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkocmV2 aXNpb24gMjgwNTQwKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQ cm9jZXNzLnNiLmluCSh3b3JraW5nIGNvcHkpCkBAIC0yNDAsNyArMjQwLDcgQEAKIAogKGRlZmlu ZSAoQXBwbGVBVkRVc2VyQ2xpZW50TWVzc2FnZUZpbHRlcikKICAgICAoYXBwbHktbWVzc2FnZS1m aWx0ZXIKLSAgICAgICAgKGFsbG93ICh3aXRoIHRlbGVtZXRyeSkgKHdpdGggbWVzc2FnZSAiQXBw bGVBVkRVc2VyQ2xpZW50IikKKyAgICAgICAgKGRlbnkgKHdpdGggdGVsZW1ldHJ5KSAod2l0aCBt ZXNzYWdlICJBcHBsZUFWRFVzZXJDbGllbnQiKQogICAgICAgICAgICAgaW9raXQtYXN5bmMtZXh0 ZXJuYWwtbWV0aG9kCiAgICAgICAgICAgICBpb2tpdC1leHRlcm5hbC1tZXRob2QKICAgICAgICAg ICAgIGlva2l0LWV4dGVybmFsLXRyYXAKQEAgLTI1MCwyMSArMjUwLDM0IEBACiAKIChkZWZpbmUg KElPU3VyZmFjZUFjY2VsZXJhdG9yQ2xpZW50TWVzc2FnZUZpbHRlcikKICAgICAoYXBwbHktbWVz c2FnZS1maWx0ZXIKLSAgICAgICAgKGFsbG93ICh3aXRoIHRlbGVtZXRyeSkgKHdpdGggbWVzc2Fn ZSAiSU9TdXJmYWNlQWNjZWxlcmF0b3JDbGllbnQiKQorICAgICAgICAoZGVueSAod2l0aCB0ZWxl bWV0cnkpICh3aXRoIG1lc3NhZ2UgIklPU3VyZmFjZUFjY2VsZXJhdG9yQ2xpZW50IikKICAgICAg ICAgICAgIGlva2l0LWFzeW5jLWV4dGVybmFsLW1ldGhvZAotICAgICAgICAgICAgaW9raXQtZXh0 ZXJuYWwtbWV0aG9kCiAgICAgICAgICAgICBpb2tpdC1leHRlcm5hbC10cmFwCiAgICAgICAgICkK KyAgICAgICAgKGFsbG93IGlva2l0LWV4dGVybmFsLW1ldGhvZAorI2lmIF9fTUFDX09TX1hfVkVS U0lPTl9NSU5fUkVRVUlSRUQgPj0gMTIwMDAwCisgICAgICAgICAgICAoaW9raXQtbWV0aG9kLW51 bWJlcgorICAgICAgICAgICAgICAgIDEKKyAgICAgICAgICAgICkKKyNlbmRpZgorICAgICAgICAp CiAgICAgKQogKQogCiAoZGVmaW5lIChJT01vYmlsZUZyYW1lYnVmZmVyVXNlckNsaWVudE1lc3Nh Z2VGaWx0ZXIpCiAgICAgKGFwcGx5LW1lc3NhZ2UtZmlsdGVyCi0gICAgICAgIChhbGxvdyAod2l0 aCB0ZWxlbWV0cnktYmFja3RyYWNlKSAod2l0aCBtZXNzYWdlICJJT01vYmlsZUZyYW1lYnVmZmVy VXNlckNsaWVudCIpCisgICAgICAgIChkZW55ICh3aXRoIHRlbGVtZXRyeSkgKHdpdGggbWVzc2Fn ZSAiSU9Nb2JpbGVGcmFtZWJ1ZmZlclVzZXJDbGllbnQiKQogICAgICAgICAgICAgaW9raXQtYXN5 bmMtZXh0ZXJuYWwtbWV0aG9kCi0gICAgICAgICAgICBpb2tpdC1leHRlcm5hbC1tZXRob2QKICAg ICAgICAgICAgIGlva2l0LWV4dGVybmFsLXRyYXAKICAgICAgICAgKQorICAgICAgICAoYWxsb3cg KHdpdGggdGVsZW1ldHJ5LWJhY2t0cmFjZSkgaW9raXQtZXh0ZXJuYWwtbWV0aG9kCisjaWYgX19N QUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMjAwMDAKKyAgICAgICAgICAgIChpb2tp dC1tZXRob2QtbnVtYmVyCisgICAgICAgICAgICAgICAgOAorICAgICAgICAgICAgICAgIDI4Cisg ICAgICAgICAgICApCisjZW5kaWYKKyAgICAgICAgKQogICAgICkKICkKIAo=