228771 2021-08-04 04:56:05 -0700 [cairo][GTK][WPE] Elliptic radial gradients are not working 2024-01-05 12:14:59 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 magomez magomez bugs-noreply crzwdjk fujii oohashi zdobersek oldest_to_newest 1781864 0 magomez 2021-08-04 04:56:05 -0700 There are some examples in this page that show the problem: https://people.igalia.com/magomez/gradient/index.html All of the rendered gradients are circular while some of them should be elliptic. The problem here is that we use cairo_pattern_create_radial() to create the gradients, and that doesn't support elliptic gradients. We need to do some transformation matrix magic in order to achieve the elliptic result. 1781865 1 434898 magomez 2021-08-04 05:00:08 -0700 Created attachment 434898 Patch 1781866 2 magomez 2021-08-04 05:02:15 -0700 (In reply to Miguel Gomez from comment #1) > Created attachment 434898 [details] > Patch This patch is going to break some layout tests that will need to be rebaselined. At this point I can't reproduce the results created by the bot, so in order to update the test results I'll wait for the bot to fail on them, get the result produced, and send later a gardening patch with the new expectations. 1782022 3 ews-feeder 2021-08-04 13:28:24 -0700 Committed r280654 (240265@main): <https://commits.webkit.org/240265@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434898. 1782528 4 crzwdjk 2021-08-06 11:02:06 -0700 As an added bonus this also fixed imported/w3c/web-platform-tests/css/css-images/multiple-position-color-stop-radial.html 2003228 5 dpino 2024-01-05 12:14:59 -0800 *** Bug 142516 has been marked as a duplicate of this bug. *** 434898 2021-08-04 05:00:08 -0700 2021-08-04 13:28:25 -0700 Patch bug-228771-20210804140006.patch text/plain 2818 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNjMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDAyNjlkZjUzNmM1NWVj Y2JiZmIzNjJkOTY3M2U0MmE2MzMzZGYyNy4uZTBmZWU1ZGEwNTdmOTAwYzNhZDljZmUwOGRkZWM4 MzMwYzRhMjc4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA4LTA0ICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBFbGxp cHRpYyByYWRpYWwgZ3JhZGllbnRzIGFyZSBub3Qgd29ya2luZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4NzcxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVHJhbnNmb3JtIHRoZSByYWRpYWwgY2lyY3Vs YXIgZ3JhZGllbnRzIHVzaW5nIHRoZSBhc3BlY3QgcmF0aW8gdG8gY29udmVydAorICAgICAgICB0 aGVtIGludG8gdGhlIGFwcHJvcHJpYXRlIGVsbGlwdGljIGdyYWRpZW50cy4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYWRpZW50Q2Fpcm8uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6R3JhZGllbnQ6OmNyZWF0ZVBhdHRlcm4pOgorCiAyMDIxLTA4LTA0ICBUaW0gSG9ydG9u ICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIGZhc3QvY2FudmFzL2NhbnZh cy1jcmFzaC5odG1sIGRvZXNuJ3QgdGVzdCB3aGF0IGl0IGludGVuZHMgdG8gb24gaU9TCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFkaWVudENh aXJvLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYWRpZW50 Q2Fpcm8uY3BwCmluZGV4IDcxNmY3NWYyMjNjZjNiNDU5NTQ5ZDY4YjNmODVkY2MyZGExMjVkNjYu LjE3NDIxMzRlNDgwODA1NWRkMjdmYmRlYjMyM2IwODg0OTZjNmZiZDEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYWRpZW50Q2Fpcm8uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYWRpZW50Q2Fpcm8u Y3BwCkBAIC0xOTUsNiArMTk1LDkgQEAgc3RhdGljIFJlZlB0cjxjYWlyb19wYXR0ZXJuX3Q+IGNy ZWF0ZUNvbmljKGZsb2F0IHhvLCBmbG9hdCB5bywgZmxvYXQgciwgZmxvYXQgYW4KIAogUmVmUHRy PGNhaXJvX3BhdHRlcm5fdD4gR3JhZGllbnQ6OmNyZWF0ZVBhdHRlcm4oZmxvYXQgZ2xvYmFsQWxw aGEsIGNvbnN0IEFmZmluZVRyYW5zZm9ybSYgZ3JhZGllbnRTcGFjZVRyYW5zZm9ybSkKIHsKKyAg ICBjYWlyb19tYXRyaXhfdCBtYXRyaXggPSB0b0NhaXJvTWF0cml4KGdyYWRpZW50U3BhY2VUcmFu c2Zvcm0pOworICAgIGNhaXJvX21hdHJpeF9pbnZlcnQoJm1hdHJpeCk7CisKICAgICBhdXRvIGdy YWRpZW50ID0gV1RGOjpzd2l0Y2hPbihtX2RhdGEsCiAgICAgICAgIFsmXSAoY29uc3QgTGluZWFy RGF0YSYgZGF0YSkgewogICAgICAgICAgICAgYXV0byBncmFkaWVudCA9IGFkb3B0UmVmKGNhaXJv X3BhdHRlcm5fY3JlYXRlX2xpbmVhcihkYXRhLnBvaW50MC54KCksIGRhdGEucG9pbnQwLnkoKSwg ZGF0YS5wb2ludDEueCgpLCBkYXRhLnBvaW50MS55KCkpKTsKQEAgLTIwNiw2ICsyMDksMTMgQEAg UmVmUHRyPGNhaXJvX3BhdHRlcm5fdD4gR3JhZGllbnQ6OmNyZWF0ZVBhdHRlcm4oZmxvYXQgZ2xv YmFsQWxwaGEsIGNvbnN0IEFmZmluZVQKICAgICAgICAgICAgIGF1dG8gZ3JhZGllbnQgPSBhZG9w dFJlZihjYWlyb19wYXR0ZXJuX2NyZWF0ZV9yYWRpYWwoZGF0YS5wb2ludDAueCgpLCBkYXRhLnBv aW50MC55KCksIGRhdGEuc3RhcnRSYWRpdXMsIGRhdGEucG9pbnQxLngoKSwgZGF0YS5wb2ludDEu eSgpLCBkYXRhLmVuZFJhZGl1cykpOwogICAgICAgICAgICAgZm9yIChhdXRvJiBzdG9wIDogc3Rv cHMoKSkKICAgICAgICAgICAgICAgICBhZGRDb2xvclN0b3BSR0JBKGdyYWRpZW50LmdldCgpLCBz dG9wLCBnbG9iYWxBbHBoYSk7CisKKyAgICAgICAgICAgIGlmIChkYXRhLmFzcGVjdFJhdGlvICE9 IDEpIHsKKyAgICAgICAgICAgICAgICBjYWlyb19tYXRyaXhfdHJhbnNsYXRlKCZtYXRyaXgsIGRh dGEucG9pbnQwLngoKSwgZGF0YS5wb2ludDAueSgpKTsKKyAgICAgICAgICAgICAgICBjYWlyb19t YXRyaXhfc2NhbGUoJm1hdHJpeCwgMS4wLCBkYXRhLmFzcGVjdFJhdGlvKTsKKyAgICAgICAgICAg ICAgICBjYWlyb19tYXRyaXhfdHJhbnNsYXRlKCZtYXRyaXgsIC1kYXRhLnBvaW50MC54KCksIC1k YXRhLnBvaW50MC55KCkpOworICAgICAgICAgICAgfQorCiAgICAgICAgICAgICByZXR1cm4gZ3Jh ZGllbnQ7CiAgICAgICAgIH0sCiAgICAgICAgIFsmXSAoY29uc3QgQ29uaWNEYXRhJiBkYXRhKSB7 CkBAIC0yMzAsOCArMjQwLDYgQEAgUmVmUHRyPGNhaXJvX3BhdHRlcm5fdD4gR3JhZGllbnQ6OmNy ZWF0ZVBhdHRlcm4oZmxvYXQgZ2xvYmFsQWxwaGEsIGNvbnN0IEFmZmluZVQKICAgICAgICAgYnJl YWs7CiAgICAgfQogCi0gICAgY2Fpcm9fbWF0cml4X3QgbWF0cml4ID0gdG9DYWlyb01hdHJpeChn cmFkaWVudFNwYWNlVHJhbnNmb3JtKTsKLSAgICBjYWlyb19tYXRyaXhfaW52ZXJ0KCZtYXRyaXgp OwogICAgIGNhaXJvX3BhdHRlcm5fc2V0X21hdHJpeChncmFkaWVudC5nZXQoKSwgJm1hdHJpeCk7 CiAKICAgICByZXR1cm4gZ3JhZGllbnQ7Cg==