228758 2021-08-03 15:34:45 -0700 [webkitpy] Handle case where no existing simulators are defined 2021-08-03 19:14:05 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap dewei_zhu ews-watchlist glenn ryanhaddad webkit-bug-importer oldest_to_newest 1781765 0 jbedard 2021-08-03 15:34:45 -0700 We need to handle the case where a machine has no existing simulated devices. 1781766 1 webkit-bug-importer 2021-08-03 15:35:41 -0700 <rdar://problem/81484040> 1781767 2 434866 jbedard 2021-08-03 15:38:51 -0700 Created attachment 434866 Patch 1781783 3 jbedard 2021-08-03 16:25:23 -0700 The important piece to understand with this change is that comparing device types is fuzzy. Ie, `iPhone running iOS` matches `iPhone 10 running iOS 14`, but not `iPad running iOS`. Many scripts, and run-api-tests, in particular, don't exactly define exact device types and instead rely on the devices available on a machine. This is where the current issue is. If no devices are available, we don't have anything to match against and end up with a device type too generic for actually running tests. The solution to this (as implemented in this patch) is to check all device types this machine declares, even if those types are not currently associated with a simulated device, from newest to oldest, picking the first one that matches the requested device type. 1781784 4 ews-feeder 2021-08-03 16:40:17 -0700 Committed r280622 (240235@main): <https://commits.webkit.org/240235@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434866. 434866 2021-08-03 15:38:51 -0700 2021-08-03 19:14:05 -0700 Patch bug-228758-20210803153850.patch text/plain 2324 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4MDYxOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTA4LTAzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIEhhbmRsZSBjYXNlIHdoZXJlIG5vIGV4aXN0aW5nIHNp bXVsYXRvcnMgYXJlIGRlZmluZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIyODc1OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODE0ODQwNDA+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHk6CisgICAgICAgIChTaW11bGF0ZWRE ZXZpY2VNYW5hZ2VyLl9kaXNhbWJpZ3VhdGVfZGV2aWNlX3R5cGUpOiBJZiB0aGVyZSBhcmUgbm8g YXZhaWxhYmxlIGRldmljZXMsCisgICAgICAgIGZpbmQgdGhlIG5ld2VzdCBkZXZpY2UgaWRlbnRp ZmllciB3aGljaCBtYXRjaGVzIHRoZSByZXF1ZXN0ZWQgdHlwZS4KKwogMjAyMS0wOC0wMyAgSmVy IE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJLaXRUZXN0UnVubmVy IHNob3VsZCBkdW1wIGN1cnJlbnQgcmVzdWx0cyBpbiB0aGUgY2FzZSBvZiBhIHRpbWVvdXQKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2Uu cHkJKHJldmlzaW9uIDI4MDYxMikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2lt dWxhdGVkX2RldmljZS5weQkod29ya2luZyBjb3B5KQpAQCAtMjQzLDEwICsyNDMsMTcgQEAgY2xh c3MgU2ltdWxhdGVkRGV2aWNlTWFuYWdlcihvYmplY3QpOgogCiAgICAgICAgIGlmIGZ1bGxfZGV2 aWNlX3R5cGUuaGFyZHdhcmVfdHlwZSBpcyBOb25lOgogICAgICAgICAgICAgIyBBZ2Fpbiwgd2Ug dXNlIHRoZSBleGlzdGluZyBkZXZpY2VzIHRvIGRldGVybWluZSBhIGxlZ2FsIGhhcmR3YXJlIHR5 cGUKLSAgICAgICAgICAgIGZvciBuYW1lIGluIFNpbXVsYXRlZERldmljZU1hbmFnZXIuX2Rldmlj ZV9pZGVudGlmaWVyX3RvX25hbWUudmFsdWVzKCk6Ci0gICAgICAgICAgICAgICAgdHlwZV9mcm9t X25hbWUgPSBEZXZpY2VUeXBlLmZyb21fc3RyaW5nKG5hbWUpCi0gICAgICAgICAgICAgICAgaWYg dHlwZV9mcm9tX25hbWUgPT0gZnVsbF9kZXZpY2VfdHlwZToKLSAgICAgICAgICAgICAgICAgICAg ZnVsbF9kZXZpY2VfdHlwZS5oYXJkd2FyZV90eXBlID0gdHlwZV9mcm9tX25hbWUuaGFyZHdhcmVf dHlwZQorICAgICAgICAgICAgZm9yIGRldmljZSBpbiBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLkFW QUlMQUJMRV9ERVZJQ0VTOgorICAgICAgICAgICAgICAgIGlmIGRldmljZS5kZXZpY2VfdHlwZSA9 PSBmdWxsX2RldmljZV90eXBlOgorICAgICAgICAgICAgICAgICAgICBmdWxsX2RldmljZV90eXBl LmhhcmR3YXJlX3R5cGUgPSBkZXZpY2UuZGV2aWNlX3R5cGUuaGFyZHdhcmVfdHlwZQorICAgICAg ICAgICAgICAgICAgICBicmVhaworCisgICAgICAgIGlmIG5vdCBmdWxsX2RldmljZV90eXBlLmhh cmR3YXJlX2ZhbWlseSBvciBub3QgZnVsbF9kZXZpY2VfdHlwZS5oYXJkd2FyZV90eXBlOgorICAg ICAgICAgICAgIyBJZiB3ZSBjb3VsZG4ndCBkZWZpbmUgYSBkZXZpY2Ugd2l0aCBleGlzdGluZyBk ZXZpY2VzLCBwaWNrIHRoZSBuZXdlc3QgbWF0Y2hpbmcgZGV2aWNlIHR5cGUKKyAgICAgICAgICAg IGZvciBfLCB0eXBlX25hbWUgaW4gcmV2ZXJzZWQoU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5fZGV2 aWNlX2lkZW50aWZpZXJfdG9fbmFtZS5pdGVtcygpKToKKyAgICAgICAgICAgICAgICBjYW5kaWRh dGUgPSBEZXZpY2VUeXBlLmZyb21fc3RyaW5nKHR5cGVfbmFtZSkKKyAgICAgICAgICAgICAgICBp ZiBjYW5kaWRhdGUgPT0gZnVsbF9kZXZpY2VfdHlwZToKKyAgICAgICAgICAgICAgICAgICAgZnVs bF9kZXZpY2VfdHlwZSA9IGNhbmRpZGF0ZQogICAgICAgICAgICAgICAgICAgICBicmVhawogCiAg ICAgICAgIGZ1bGxfZGV2aWNlX3R5cGUuY2hlY2tfY29uc2lzdGVuY3koKQo=