228752 2021-08-03 14:06:12 -0700 [webkitpy] Narrow set of terminated simulator processes 2021-08-03 17:56:31 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap dewei_zhu ews-watchlist glenn ryanhaddad webkit-bug-importer oldest_to_newest 1781735 0 jbedard 2021-08-03 14:06:12 -0700 We are terminating too many simulator processes in our simulator management code, and we're not recovering when failing to delete a simulated device. 1781736 1 webkit-bug-importer 2021-08-03 14:08:41 -0700 <rdar://problem/81479508> 1781737 2 434861 jbedard 2021-08-03 14:11:39 -0700 Created attachment 434861 Patch 1781740 3 434861 aakash_jain 2021-08-03 14:28:23 -0700 Comment on attachment 434861 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434861&action=review > Tools/Scripts/webkitpy/xcode/simulated_device.py:-508 > - if SimulatedDeviceManager._managing_simulator_app: why don't we need this anymore? 1781741 4 aakash_jain 2021-08-03 14:29:33 -0700 Overall, how do you come up with this? How do we know that we won't be killing too less (or different thing than needed) after this? 1781743 5 434861 jbedard 2021-08-03 14:40:15 -0700 Comment on attachment 434861 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434861&action=review >> Tools/Scripts/webkitpy/xcode/simulated_device.py:-508 >> - if SimulatedDeviceManager._managing_simulator_app: > > why don't we need this anymore? Because CoreSimulator is mature enough now that we don't need to do this any more, we end up killing processes before they finish tearing themselves down. 1781744 6 jbedard 2021-08-03 14:46:28 -0700 (In reply to Aakash Jain from comment #4) > Overall, how do you come up with this? How do we know that we won't be > killing too less (or different thing than needed) after this? We will be killing less, in every case. That's why I did Simulator.app instead of Simulator. I started to play around killing less processes and seeing what that did, it made interacting with simctl much more stable. Which isn't particularly surprising, we shouldn't really need to kill CoreSimulator processes. 1781749 7 434861 ap 2021-08-03 14:58:42 -0700 Comment on attachment 434861 Patch Seems worth trying! 1781756 8 ews-feeder 2021-08-03 15:17:20 -0700 Committed r280618 (240231@main): <https://commits.webkit.org/240231@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434861. 434861 2021-08-03 14:11:39 -0700 2021-08-03 17:56:31 -0700 Patch bug-228752-20210803141138.patch text/plain 3526 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4MDYxNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTA4LTAzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0cHldIE5hcnJvdyBzZXQgb2YgdGVybWluYXRlZCBzaW11bGF0 b3IgcHJvY2Vzc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjg3NTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgxNDc5NTA4PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS94Y29kZS9zaW11bGF0ZWRfZGV2aWNlLnB5OgorICAgICAgICAoU2ltdWxhdGVkRGV2aWNlTWFu YWdlci5pbml0aWFsaXplX2RldmljZXMpOiBPbmx5IGNoZWNrIFNpbXVsYXRvci5hcHAuCisgICAg ICAgIChTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLnRlYXJfZG93bik6IE9ubHkga2lsbCBTaW11bGF0 b3IuYXBwIHByb2Nlc3Nlcy4KKyAgICAgICAgKFNpbXVsYXRlZERldmljZS5fZGVsZXRlKTogUHJp bnQgZXJyb3IgaWYgYHNpbWN0bCBkZWxldGVgIGZhaWxzLCBidXQgY29udGludWUuCisKIDIwMjEt MDgtMDMgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFt3 ZWJraXRzY21weV0gQWRkIGFjY2VzcyB0byBgZ2l0IGNvbmZpZ2AKSW5kZXg6IFRvb2xzL1Njcmlw dHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3hjb2RlL3NpbXVsYXRlZF9kZXZpY2UucHkJKHJldmlzaW9uIDI4 MDYxMikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkveGNvZGUvc2ltdWxhdGVkX2RldmljZS5w eQkod29ya2luZyBjb3B5KQpAQCAtNDIyLDcgKzQyMiw3IEBAIGNsYXNzIFNpbXVsYXRlZERldmlj ZU1hbmFnZXIob2JqZWN0KToKIAogICAgICAgICAgICAgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5f Ym9vdF9kZXZpY2UoZGV2aWNlLCBob3N0KQogCi0gICAgICAgIGlmIHNpbXVsYXRvcl91aSBhbmQg aG9zdC5leGVjdXRpdmUucnVuX2NvbW1hbmQoWydraWxsYWxsJywgJy0wJywgJ1NpbXVsYXRvcidd LCByZXR1cm5fZXhpdF9jb2RlPVRydWUpICE9IDA6CisgICAgICAgIGlmIHNpbXVsYXRvcl91aSBh bmQgaG9zdC5leGVjdXRpdmUucnVuX2NvbW1hbmQoWydraWxsYWxsJywgJy0wJywgJ1NpbXVsYXRv ci5hcHAnXSwgcmV0dXJuX2V4aXRfY29kZT1UcnVlKSAhPSAwOgogICAgICAgICAgICAgU2ltdWxh dGVkRGV2aWNlTWFuYWdlci5fbWFuYWdpbmdfc2ltdWxhdG9yX2FwcCA9IG5vdCBob3N0LmV4ZWN1 dGl2ZS5ydW5fY29tbWFuZChbJ29wZW4nLCAnLWcnLCAnLWInLCBTaW11bGF0ZWREZXZpY2VNYW5h Z2VyLnNpbXVsYXRvcl9idW5kbGVfaWQsICctLWFyZ3MnLCAnLVBhc3RlYm9hcmRBdXRvbWF0aWNT eW5jJywgJzAnXSwgcmV0dXJuX2V4aXRfY29kZT1UcnVlKQogCiAgICAgICAgIGRlYWRsaW5lID0g dGltZS50aW1lKCkgKyB0aW1lb3V0CkBAIC00ODksNyArNDg5LDcgQEAgY2xhc3MgU2ltdWxhdGVk RGV2aWNlTWFuYWdlcihvYmplY3QpOgogICAgIGRlZiB0ZWFyX2Rvd24oaG9zdD1Ob25lLCB0aW1l b3V0PVNJTVVMQVRPUl9CT09UX1RJTUVPVVQpOgogICAgICAgICBob3N0ID0gaG9zdCBvciBTeXN0 ZW1Ib3N0KCkKICAgICAgICAgaWYgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5fbWFuYWdpbmdfc2lt dWxhdG9yX2FwcDoKLSAgICAgICAgICAgIGhvc3QuZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsna2ls bGFsbCcsICctOScsICdTaW11bGF0b3InXSwgcmV0dXJuX2V4aXRfY29kZT1UcnVlKQorICAgICAg ICAgICAgaG9zdC5leGVjdXRpdmUucnVuX2NvbW1hbmQoWydraWxsYWxsJywgJy05JywgJ1NpbXVs YXRvci5hcHAnXSwgcmV0dXJuX2V4aXRfY29kZT1UcnVlKQogICAgICAgICAgICAgU2ltdWxhdGVk RGV2aWNlTWFuYWdlci5fbWFuYWdpbmdfc2ltdWxhdG9yX2FwcCA9IEZhbHNlCiAKICAgICAgICAg aWYgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5JTklUSUFMSVpFRF9ERVZJQ0VTIGlzIE5vbmU6CkBA IC01MDUsMTAgKzUwNSw2IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZU1hbmFnZXIob2JqZWN0KToK IAogICAgICAgICBTaW11bGF0ZWREZXZpY2VNYW5hZ2VyLklOSVRJQUxJWkVEX0RFVklDRVMgPSBO b25lCiAKLSAgICAgICAgaWYgU2ltdWxhdGVkRGV2aWNlTWFuYWdlci5fbWFuYWdpbmdfc2ltdWxh dG9yX2FwcDoKLSAgICAgICAgICAgIGZvciBwaWQgaW4gaG9zdC5leGVjdXRpdmUucnVubmluZ19w aWRzKGxhbWJkYSBuYW1lOiAnQ29yZVNpbXVsYXRvci5mcmFtZXdvcmsnIGluIG5hbWUpOgotICAg ICAgICAgICAgICAgIGhvc3QuZXhlY3V0aXZlLmtpbGxfcHJvY2VzcyhwaWQpCi0KICAgICAgICAg IyBJZiB3ZSB3ZXJlIG1hbmFnaW5nIHRoZSBzaW11bGF0b3IsIHRoZXJlIGFyZSBzb21lIGNhY2hl IGZpbGVzIHdlIG5lZWQgdG8gcmVtb3ZlCiAgICAgICAgIGZvciBkaXJlY3RvcnkgaW4gaG9zdC5m aWxlc3lzdGVtLmdsb2IoJy90bXAvY29tLmFwcGxlLkNvcmVTaW11bGF0b3IuU2ltRGV2aWNlLion KToKICAgICAgICAgICAgIGhvc3QuZmlsZXN5c3RlbS5ybXRyZWUoZGlyZWN0b3J5KQpAQCAtNjA3 LDcgKzYwMyw4IEBAIGNsYXNzIFNpbXVsYXRlZERldmljZShvYmplY3QpOgogICAgICAgICBkZWFk bGluZSA9IHRpbWUudGltZSgpICsgdGltZW91dAogICAgICAgICBzZWxmLl9zaHV0X2Rvd24oZGVh ZGxpbmUgLSB0aW1lLnRpbWUoKSkKICAgICAgICAgX2xvZy5kZWJ1Zyh1IlJlbW92aW5nIGRldmlj ZSAne30nIi5mb3JtYXQoc2VsZi5uYW1lKSkKLSAgICAgICAgc2VsZi5leGVjdXRpdmUucnVuX2Nv bW1hbmQoW1NpbXVsYXRlZERldmljZU1hbmFnZXIueGNydW4sICdzaW1jdGwnLCAnZGVsZXRlJywg c2VsZi51ZGlkXSkKKyAgICAgICAgaWYgc2VsZi5leGVjdXRpdmUucnVuX2NvbW1hbmQoW1NpbXVs YXRlZERldmljZU1hbmFnZXIueGNydW4sICdzaW1jdGwnLCAnZGVsZXRlJywgc2VsZi51ZGlkXSwg cmV0dXJuX2V4aXRfY29kZT1UcnVlKToKKyAgICAgICAgICAgIF9sb2cuZXJyb3IodSJGYWlsZWQg dG8gcmVtb3ZlICd7fSwnIGVycm9yIGlzIG5vdCBmYXRhbCwgY29udGludWluZyIuZm9ybWF0KHNl bGYubmFtZSkpCiAKICAgICAgICAgIyBUaGlzIHdpbGwgKGJ5IGRlc2lnbikgZmFpbCBpZiBydW4g bW9yZSB0aGFuIG9uY2Ugb24gdGhlIHNhbWUgU2ltdWxhdGVkRGV2aWNlCiAgICAgICAgIFNpbXVs YXRlZERldmljZU1hbmFnZXIuQVZBSUxBQkxFX0RFVklDRVMucmVtb3ZlKHNlbGYpCg==