228740 2021-08-03 08:57:27 -0700 REGRESSION (r280568): ASSERTION FAILED: videoFullscreenManager->client() == &_videoFullscreenManagerProxyClient 2021-08-16 10:00:37 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Mac (Intel) Unspecified VERIFIED FIXED https://bugs.webkit.org/show_bug.cgi?id=228761 InRadar P2 Normal --- 1 ayumi_kojima jean-yves.avenard jean-yves.avenard jer.noble webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1781624 0 ayumi_kojima 2021-08-03 08:57:27 -0700 TestWebKitAPI.CloseWebViewAfterEnterFullscreen.ElementFullscreen TestWebKitAPI.CloseWebViewAfterEnterFullscreen.VideoFullscreen TestWebKitAPI.CloseWebViewDuringEnterFullscreen.ElementFullscreen TestWebKitAPI.CloseWebViewDuringEnterFullscreen.VideoFullscreen TestWebKitAPI.ExitFullscreenOnEnterPiP.ElementFullscreen TestWebKitAPI.ExitFullscreenOnEnterPiP.VideoFullscreen TestWebKitAPI.Fullscreen.Delegate TestWebKitAPI.Fullscreen.Focus TestWebKitAPI.Fullscreen.PointerLeave TestWebKitAPI.Fullscreen.RemoveNodeBeforeEnter TestWebKitAPI.TopContentInset.Fullscreen TestWebKitAPI.WKWebViewCloseAllMediaPresentations.VideoFullscreen Are crashing on MacOS Debug. ASSERTION FAILED: videoFullscreenManager->client() == &_videoFullscreenManagerProxyClient /Volumes/Data/worker/bigsur-debug/build/Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm(651) : -[WKFullScreenWindowController setVideoFullscreenManagerClient:] 1 0x111b924f9 WTFCrash 2 0x11a0b5b7b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x11b9ad212 -[WKFullScreenWindowController setVideoFullscreenManagerClient:] 4 0x11b9ad553 -[WKFullScreenWindowController windowDidEnterFullScreen:] 5 0x7fff2067210d __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ 6 0x7fff2070db6c ___CFXRegistrationPost_block_invoke 7 0x7fff2070daea _CFXRegistrationPost 8 0x7fff2064338e _CFXNotificationPost 9 0x7fff213b1dc8 -[NSNotificationCenter postNotificationName:object:userInfo:] 10 0x7fff239a5380 -[NSWindow(NSFullScreen) _didEnterFullScreen] 11 0x7fff233874eb -[_NSWindowEnterFullScreenTransitionController doAfterEnterFullScreen] 12 0x7fff237f572c -[_NSEnterFullScreenTransitionController _performFinalTransitionCleanup] 13 0x7fff237f7682 ___NSRunLoopTimerCreateWithHandler_block_invoke 14 0x7fff206952b9 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 15 0x7fff20694dad __CFRunLoopDoTimer 16 0x7fff2069490a __CFRunLoopDoTimers 17 0x7fff2067b4d3 __CFRunLoopRun 18 0x7fff2067a64c CFRunLoopRunSpecific 19 0x7fff21408647 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 20 0x1076b993e TestWebKitAPI::Util::run(bool*) 21 0x106c6ce84 TestWebKitAPI::CloseWebViewAfterEnterFullscreen_ElementFullscreen_Test::TestBody() 22 0x10794f224 void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 23 0x107911a1b void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) 24 0x107911953 testing::Test::Run() 25 0x107912b24 testing::TestInfo::Run() 26 0x107913c65 testing::TestSuite::Run() 27 0x107922d8d testing::internal::UnitTestImpl::RunAllTests() 28 0x107954864 bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 29 0x10792272b bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) 30 0x1079225fd testing::UnitTest::Run() 31 0x107631561 RUN_ALL_TESTS() LEAK: 1 WebPage TestWebKitAPI.WebKit.CreateNewPageDelegateFrameLoadState Also started timing out at the same timing, so might be related. History: https://results.webkit.org/?suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&suite=api-tests&test=TestWebKitAPI.CloseWebViewAfterEnterFullscreen.VideoFullscreen&test=TestWebKitAPI.CloseWebViewDuringEnterFullscreen.ElementFullscreen&test=TestWebKitAPI.CloseWebViewDuringEnterFullscreen.VideoFullscreen&test=TestWebKitAPI.ExitFullscreenOnEnterPiP.ElementFullscreen&test=TestWebKitAPI.ExitFullscreenOnEnterPiP.VideoFullscreen&test=TestWebKitAPI.Fullscreen.Delegate&test=TestWebKitAPI.Fullscreen.Focus&test=TestWebKitAPI.Fullscreen.PointerLeave&test=TestWebKitAPI.Fullscreen.RemoveNodeBeforeEnter&test=TestWebKitAPI.TopContentInset.Fullscreen&test=TestWebKitAPI.WKWebViewCloseAllMediaPresentations.VideoFullscreen&test=TestWebKitAPI.AppleLanguagesTest.UpdateAppleLanguages&test=TestWebKitAPI.WebKit.CreateNewPageDelegateFrameLoadState 1781625 1 webkit-bug-importer 2021-08-03 08:58:14 -0700 <rdar://problem/81464301> 1781626 2 ayumi_kojima 2021-08-03 08:58:39 -0700 History indicates that it started from this change: https://trac.webkit.org/changeset/280568/webkit 1781628 3 ayumi_kojima 2021-08-03 09:03:18 -0700 https://build.webkit.org/#/builders/23/builds/3080/steps/17/logs/stdio 1781807 4 434878 jean-yves.avenard 2021-08-03 19:52:11 -0700 Created attachment 434878 Patch 1781831 5 ews-feeder 2021-08-03 22:36:12 -0700 Committed r280628 (240241@main): <https://commits.webkit.org/240241@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434878. 434878 2021-08-03 19:52:11 -0700 2021-08-03 22:36:12 -0700 Patch bug-228740-20210804125210.patch text/plain 1840 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNjIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY0MWNlMDIwYTJhZGYzYmNh MDVmOWE5OWJjYjMwODllZGQ4YjViM2MuLjA1NTUwMjFlYmMwZWVkYjI3MGEzOTYxODE2NjU1YjI5 M2U1MzE3NGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjEtMDgtMDMgIEplYW4tWXZl cyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjgwNTY4 KTogQVNTRVJUSU9OIEZBSUxFRDogdmlkZW9GdWxsc2NyZWVuTWFuYWdlci0+Y2xpZW50KCkgPT0g Jl92aWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHlDbGllbnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyODc0MAorICAgICAgICByZGFyOi8vcHJvYmxl bS84MTQ2NDMwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeCBhc3NlcnRpb24gdG8gcmVmbGVjdCB0aGF0IHRoZSBjb2RlIGNhbiBiZSBjb2RlIGlu IHR3byB3YXlzLgorICAgICAgICBUaGlzIHdpbGwgYWxsIGdvIGF3YXkgZm9sbG93aW5nIGJ1ZyAy Mjg3NjEuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRy b2xsZXIubW06CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgc2V0Vmlk ZW9GdWxsc2NyZWVuTWFuYWdlckNsaWVudDpdKToKKwogMjAyMS0wOC0wMyAgQnJlbnQgRnVsZ2hh bSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBBbGxvdyBjaGVjayBmb3Ig bnZyYW0gImVtdSIgc3RhdGUgb24gaW50ZXJuYWwgT1MgYnVpbGRzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbSBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVy Lm1tCmluZGV4IGRiZGRjNDEyYWI4NDQ5ODZkMThhNTk3MzMxM2JiZWE4ODJlNTUwN2YuLmMzMWZi OTU2MGEwMmRlYzM3MzY1M2I5YWRiZTYwMmJiNDllM2ZkN2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVy Lm1tCkBAIC02NDgsNyArNjQ4LDcgQEAgLSAodm9pZClkaWRFbnRlclBpY3R1cmVJblBpY3R1cmUK IC0gKHZvaWQpc2V0VmlkZW9GdWxsc2NyZWVuTWFuYWdlckNsaWVudDooV2ViS2l0OjpWaWRlb0Z1 bGxzY3JlZW5NYW5hZ2VyUHJveHlDbGllbnQgKiljbGllbnQKIHsKICAgICBpZiAoYXV0byogdmlk ZW9GdWxsc2NyZWVuTWFuYWdlciA9IHNlbGYuX3ZpZGVvRnVsbHNjcmVlbk1hbmFnZXIpIHsKLSAg ICAgICAgQVNTRVJUKHZpZGVvRnVsbHNjcmVlbk1hbmFnZXItPmNsaWVudCgpID09ICZfdmlkZW9G dWxsc2NyZWVuTWFuYWdlclByb3h5Q2xpZW50KTsKKyAgICAgICAgQVNTRVJUKChjbGllbnQgJiYg IXZpZGVvRnVsbHNjcmVlbk1hbmFnZXItPmNsaWVudCgpKSB8fCAoIWNsaWVudCAmJiB2aWRlb0Z1 bGxzY3JlZW5NYW5hZ2VyLT5jbGllbnQoKSA9PSAmX3ZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94 eUNsaWVudCkpOwogICAgICAgICB2aWRlb0Z1bGxzY3JlZW5NYW5hZ2VyLT5zZXRDbGllbnQoY2xp ZW50KTsKICAgICB9CiB9Cg==