228737 2021-08-03 06:24:37 -0700 Crash while reading WebGL drawing buffer if canvas image buffer allocation fails 2021-08-03 10:34:58 -0700 1 1 1 Unclassified WebKit WebGL WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kkinnunen kkinnunen bfulgham cdumez changseok dino esprehn+autocc ews-watchlist gyuyoung.kim kbr kkinnunen kondapallykalyan sabouhallawa webkit-bug-importer oldest_to_newest 1781592 0 kkinnunen 2021-08-03 06:24:37 -0700 Crash while reading WebGL drawing buffer if canvas image buffer allocation fails 1781593 1 kkinnunen 2021-08-03 06:25:15 -0700 <rdar://81150042> 1781596 2 434827 kkinnunen 2021-08-03 06:32:31 -0700 Created attachment 434827 Patch 1781630 3 434827 bfulgham 2021-08-03 09:12:08 -0700 Comment on attachment 434827 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434827&action=review Looks good! r=me > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1221 > + if (auto buffer = base.buffer()) { Is a nullptr buffer something we should report in a log message or something? Or perhaps that allocation failure is logged elsewhere? 1781648 4 kkinnunen 2021-08-03 10:26:51 -0700 (In reply to Brent Fulgham from comment #3) > > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1221 > > + if (auto buffer = base.buffer()) { > > Is a nullptr buffer something we should report in a log message or > something? Or perhaps that allocation failure is logged elsewhere? Reported already in void HTMLCanvasElement::createImageBuffer() const 1781650 5 ews-feeder 2021-08-03 10:34:55 -0700 Committed r280601 (240219@main): <https://commits.webkit.org/240219@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434827. 434827 2021-08-03 06:32:31 -0700 2021-08-03 10:34:57 -0700 Patch bug-228737-20210803163229.patch text/plain 7220 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzI5ZTc2NzQ4NmVlMDM0 M2NkOWRiNjU2YmQ0YzBmNDFlZjgwMDhlYS4uYWRmM2U2MzU0ZTE0ZjVkYWVhNTVhNDFiZmE5ZGU4 NzFiMTI3NzZiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIxLTA4LTAzICBLaW1t byBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggd2hpbGUg cmVhZGluZyBXZWJHTCBkcmF3aW5nIGJ1ZmZlciBpZiBjYW52YXMgaW1hZ2UgYnVmZmVyIGFsbG9j YXRpb24gZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyODczNworICAgICAgICA8cmRhcjovLzgxMTUwMDQyPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjcmFzaCB3b3VsZCBoYXBwZW4gZm9y IGV4YW1wbGUgd2hlbiBydW5uaW5nIG91dCBvZiBtZW1vcnkgZHVyaW5nIHNuYXBzaG90CisgICAg ICAgIG9yIHByaW50aW5nLiBTbmFwc2hvdHMgYW5kIHByaW50aW5nIGZvcmNlcyB0aGUgV2ViR0wg Y2FudmFzIHRvIGJlICJwYWludGVkCisgICAgICAgIHRvIGRvY3VtZW50Iiwgd2hpY2ggd291bGQg dGhlbiB0cmlnZ2VyIHRoZSBjcmFzaC4KKworICAgICAgICBPdGhlciBjb2RlLXBhdGhzIHRoYXQg aW52b2tlIENhbnZhc0Jhc2U6Om1ha2VSZW5kZXJpbmdSZXN1bHRzQXZhaWxhYmxlLAorICAgICAg ICBlLmcuIHRvRGF0YVVSTCBhbmQgZHJhd0ltYWdlIHdpbGwgY2hlY2sgZm9yIHRoZSBidWZmZXIg YmVmb3JlLCBhbmQKKyAgICAgICAgYXMgc3VjaCBhcmUgbm90IHRlc3RhYmxlIGluIHRoZSBzZW5z ZSB0aGF0IGFkZGluZyB0aGUgdGVzdCB3b3VsZCB0cmlnZ2VyCisgICAgICAgIHRoZSBidWcuCisK KyAgICAgICAgVGVzdDogd2ViZ2wvd2ViZ2wtb29tLXBhaW50LWRvY3VtZW50LW5vLWNyYXNoLmh0 bWwKKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZTo6cGFpbnRSZW5k ZXJpbmdSZXN1bHRzVG9DYW52YXMpOgorICAgICAgICBDaGVjayBmb3IgdGhlIG51bGxwdHIgZnJv bSBDYW52YXNCYXNlOjpidWZmZXIoKS4gVGhpcyBtaWdodCBoYXBwZW4KKyAgICAgICAgd2hlbiB0 aGUgSW1hZ2VCdWZmZXIgd2FzIG5vdCBhbGxvY2F0ZWQgZHVlIHRvIG1lbW9yeSBjb25zdHJhaW50 cy4KKwogMjAyMS0wOC0wMiAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgW2Nzcy1zY3JvbGwtc25hcF0gQ29uc2lkZXIgYWxsIHNuYXAgYXJlYXMgYXQg YSBnaXZlbiBzbmFwIG9mZnNldCB3aGVuIHNuYXBwaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCmluZGV4IDA2 MTYwMzE3MzI3NTVhMGRkNzNmOGQ5NDE4YjBmNTg0NjdkMTE4M2EuLmE0NmI2NmQyNTQwZTYxYWU0 M2EzM2VhZTUyZTM4ZjA2ODhiOGE4ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv Y2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwCkBAIC0xMjE4LDExICsx MjE4LDEzIEBAIHZvaWQgV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZTo6cGFpbnRSZW5kZXJpbmdS ZXN1bHRzVG9DYW52YXMoKQogICAgICAgICAgICAgYXV0byYgYmFzZSA9IGNhbnZhc0Jhc2UoKTsK ICAgICAgICAgICAgIGJhc2UuY2xlYXJDb3BpZWRJbWFnZSgpOwogICAgICAgICAgICAgbV9tYXJr ZWRDYW52YXNEaXJ0eSA9IGZhbHNlOwotICAgICAgICAgICAgLy8gRklYTUU6IFJlbW90ZSBJbWFn ZUJ1ZmZlcnMgZG8gbm90IGZsdXNoIHRoZSBidWZmZXJzIHRoYXQgYXJlIGRyYXduIHRvIGEgYnVm ZmVyLgotICAgICAgICAgICAgLy8gQXZvaWQgbGVha2luZyB0aGUgV2ViR0wgY29udGVudCBpbiB0 aGUgY2FzZXMgd2hlcmUgYSBXZWJHTCBjYW52YXMgZWxlbWVudCBpcyBkcmF3biB0byBhIENvbnRl eHQyRAotICAgICAgICAgICAgLy8gY2FudmFzIGVsZW1lbnQgcmVwZWF0ZWRseS4KLSAgICAgICAg ICAgIGJhc2UuYnVmZmVyKCktPmZsdXNoRHJhd2luZ0NvbnRleHQoKTsKLSAgICAgICAgICAgIG1f Y29udGV4dC0+cGFpbnRDb21wb3NpdGVkUmVzdWx0c1RvQ2FudmFzKCpiYXNlLmJ1ZmZlcigpKTsK KyAgICAgICAgICAgIGlmIChhdXRvIGJ1ZmZlciA9IGJhc2UuYnVmZmVyKCkpIHsKKyAgICAgICAg ICAgICAgICAvLyBGSVhNRTogUmVtb3RlIEltYWdlQnVmZmVycyBkbyBub3QgZmx1c2ggdGhlIGJ1 ZmZlcnMgdGhhdCBhcmUgZHJhd24gdG8gYSBidWZmZXIuCisgICAgICAgICAgICAgICAgLy8gQXZv aWQgbGVha2luZyB0aGUgV2ViR0wgY29udGVudCBpbiB0aGUgY2FzZXMgd2hlcmUgYSBXZWJHTCBj YW52YXMgZWxlbWVudCBpcyBkcmF3biB0byBhIENvbnRleHQyRAorICAgICAgICAgICAgICAgIC8v IGNhbnZhcyBlbGVtZW50IHJlcGVhdGVkbHkuCisgICAgICAgICAgICAgICAgYnVmZmVyLT5mbHVz aERyYXdpbmdDb250ZXh0KCk7CisgICAgICAgICAgICAgICAgbV9jb250ZXh0LT5wYWludENvbXBv c2l0ZWRSZXN1bHRzVG9DYW52YXMoKmJ1ZmZlcik7CisgICAgICAgICAgICB9CiAgICAgICAgIH0K ICAgICAgICAgcmV0dXJuOwogICAgIH0KQEAgLTEyMzYsMTEgKzEyMzgsMTMgQEAgdm9pZCBXZWJH TFJlbmRlcmluZ0NvbnRleHRCYXNlOjpwYWludFJlbmRlcmluZ1Jlc3VsdHNUb0NhbnZhcygpCiAg ICAgYmFzZS5jbGVhckNvcGllZEltYWdlKCk7CiAKICAgICBtX21hcmtlZENhbnZhc0RpcnR5ID0g ZmFsc2U7Ci0gICAgLy8gRklYTUU6IFJlbW90ZSBJbWFnZUJ1ZmZlcnMgZG8gbm90IGZsdXNoIHRo ZSBidWZmZXJzIHRoYXQgYXJlIGRyYXduIHRvIGEgYnVmZmVyLgotICAgIC8vIEF2b2lkIGxlYWtp bmcgdGhlIFdlYkdMIGNvbnRlbnQgaW4gdGhlIGNhc2VzIHdoZXJlIGEgV2ViR0wgY2FudmFzIGVs ZW1lbnQgaXMgZHJhd24gdG8gYSBDb250ZXh0MkQKLSAgICAvLyBjYW52YXMgZWxlbWVudCByZXBl YXRlZGx5LgotICAgIGJhc2UuYnVmZmVyKCktPmZsdXNoRHJhd2luZ0NvbnRleHQoKTsKLSAgICBt X2NvbnRleHQtPnBhaW50UmVuZGVyaW5nUmVzdWx0c1RvQ2FudmFzKCpiYXNlLmJ1ZmZlcigpKTsK KyAgICBpZiAoYXV0byBidWZmZXIgPSBiYXNlLmJ1ZmZlcigpKSB7CisgICAgICAgIC8vIEZJWE1F OiBSZW1vdGUgSW1hZ2VCdWZmZXJzIGRvIG5vdCBmbHVzaCB0aGUgYnVmZmVycyB0aGF0IGFyZSBk cmF3biB0byBhIGJ1ZmZlci4KKyAgICAgICAgLy8gQXZvaWQgbGVha2luZyB0aGUgV2ViR0wgY29u dGVudCBpbiB0aGUgY2FzZXMgd2hlcmUgYSBXZWJHTCBjYW52YXMgZWxlbWVudCBpcyBkcmF3biB0 byBhIENvbnRleHQyRAorICAgICAgICAvLyBjYW52YXMgZWxlbWVudCByZXBlYXRlZGx5LgorICAg ICAgICBidWZmZXItPmZsdXNoRHJhd2luZ0NvbnRleHQoKTsKKyAgICAgICAgbV9jb250ZXh0LT5w YWludFJlbmRlcmluZ1Jlc3VsdHNUb0NhbnZhcygqYnVmZmVyKTsKKyAgICB9CiB9CiAKIHN0ZDo6 b3B0aW9uYWw8UGl4ZWxCdWZmZXI+IFdlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2U6OnBhaW50UmVu ZGVyaW5nUmVzdWx0c1RvUGl4ZWxCdWZmZXIoKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGQzYzY1OTkzNTI4ZGJlOTMxYmY5 NmU0NmQ2ZTJkNmUwYTYyMTkzNTguLjFhNmI2NzBjN2ZjYTE4YTZmMzZmOTUzZDUxODIzYjI2NDQ5 NDczZjggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAyMS0wOC0wMyAgS2ltbW8gS2lubnVuZW4g IDxra2lubnVuZW5AYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIHdoaWxlIHJlYWRpbmcgV2Vi R0wgZHJhd2luZyBidWZmZXIgaWYgY2FudmFzIGltYWdlIGJ1ZmZlciBhbGxvY2F0aW9uIGZhaWxz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg3MzcK KyAgICAgICAgPHJkYXI6Ly84MTE1MDA0Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IGZvciBmYWlsdXJlIHRvIHBhaW50IHRoZSBX ZWJHTCBjYW52YXMgdG8gZG9jdW1lbnQuCisgICAgICAgIFRyaWdnZXIgdGhlIG1vZGUgYnkgdXNp bmcgcHJpbnRpbmcuCisKKyAgICAgICAgT3RoZXIgY29kZS1wYXRocyB0aGF0IGludm9rZSBDYW52 YXNCYXNlOjptYWtlUmVuZGVyaW5nUmVzdWx0c0F2YWlsYWJsZSwKKyAgICAgICAgZS5nLiB0b0Rh dGFVUkwgYW5kIGRyYXdJbWFnZSB3aWxsIGNoZWNrIGZvciB0aGUgYnVmZmVyIGJlZm9yZSwgYW5k CisgICAgICAgIGFzIHN1Y2ggYXJlIG5vdCB0ZXN0YWJsZSBpbiB0aGUgc2Vuc2UgdGhhdCBhZGRp bmcgdGhlIHRlc3Qgd291bGQgdHJpZ2dlcgorICAgICAgICB0aGUgYnVnLgorCisgICAgICAgICog d2ViZ2wvd2ViZ2wtb29tLXBhaW50LWRvY3VtZW50LW5vLWNyYXNoLWV4cGVjdGVkLmh0bWw6IEFk ZGVkLgorICAgICAgICAqIHdlYmdsL3dlYmdsLW9vbS1wYWludC1kb2N1bWVudC1uby1jcmFzaC5o dG1sOiBBZGRlZC4KKwogMjAyMS0wOC0wMSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWpp aUBzb255LmNvbT4KIAogICAgICAgICBbV2luQ2Fpcm9dIFVucmV2aWV3ZWQgdGVzdCBnYXJkZW5p bmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYmdsL3dlYmdsLW9vbS1wYWludC1kb2N1bWVu dC1uby1jcmFzaC1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvd2ViZ2wvd2ViZ2wtb29tLXBh aW50LWRvY3VtZW50LW5vLWNyYXNoLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQK aW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2E0ODI2MGYw YTgwNTNmMzc1MGUzYTRjYzBlZGZkNjFkNjMyOTIxOAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL3dlYmdsL3dlYmdsLW9vbS1wYWludC1kb2N1bWVudC1uby1jcmFzaC1leHBlY3RlZC5o dG1sCkBAIC0wLDAgKzEsMTYgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxt ZXRhIGNoYXJzZXQ9InV0Zi04Ij4KKzx0aXRsZT5XZWJHTCBjYW52YXMgImltYWdlIGJ1ZmZlciIg T09NIGR1cmluZyBkb2N1bWVudCBwYWludCB0ZXN0IHJlZmVyZW5jZSBpbWFnZTwvdGl0bGU+Cis8 L2hlYWQ+Cis8Ym9keT4KKzxkaXYgc3R5bGU9InBvc2l0aW9uOiBhYnNvbHV0ZTsgd2lkdGg6IDMw MHB4OyBoZWlnaHQ6IDE1MHB4OyBib3JkZXI6NTVweCBzb2xpZCBncmVlbjsiPjwvZGl2PgorPHNj cmlwdD4KKyJ1c2Ugc3RyaWN0IjsKKy8vIFByaW50aW5nIGFkanVzdHMgdGhlIHNpemUgb2YgdGhl IHJlc3VsdC4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLnNldFByaW50 aW5nKCk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3dlYmdsL3dlYmdsLW9vbS1wYWludC1kb2N1bWVudC1uby1jcmFzaC5odG1sIGIvTGF5b3V0 VGVzdHMvd2ViZ2wvd2ViZ2wtb29tLXBhaW50LWRvY3VtZW50LW5vLWNyYXNoLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uMGQ1MWVlYzVlNGFkMzJiZWQ0MTgzNWI2Y2NjMjBjOWRhYzhmOTlhNAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL3dlYmdsL3dlYmdsLW9vbS1wYWludC1kb2N1bWVudC1uby1j cmFzaC5odG1sCkBAIC0wLDAgKzEsMzEgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVh ZD4KKzxtZXRhIGNoYXJzZXQ9InV0Zi04Ij4KKzx0aXRsZT5XZWJHTCBjYW52YXMgImltYWdlIGJ1 ZmZlciIgT09NIGR1cmluZyBkb2N1bWVudCBwYWludCB0ZXN0PC90aXRsZT4KKzwvaGVhZD4KKzxi b2R5PgorPCEtLQorQXQgdGhlIHRpbWUgb2Ygd3JpdGluZyBwcmludGluZyBvciBzbmFwc2hvdHRp bmcgd291bGQgYWNjZXNzIHRoZSAiaW1hZ2UgYnVmZmVyIiBvZiB0aGUgV2ViR0wgY2FudmFzLgor VGhpcyB3b3VsZCBsZWFkaW5nIHRvIGNyYXNoIGlmIHRoZSBhbGxvY2F0aW9uIHdhcyBkZW5pZWQu CitUbyBlbnN1cmUgZXhwZWN0ZWQgYmVoYXZpb3IsIGUuZy4gdG8gb2JzZXJ2ZSB0aGUgZmFpbHVy ZSwgdGhlIGNhbnZhcyBzaG91bGQgbm90IGJlIHZpc2libGUuCitUbyBhc3NlcnQgdGhpcywgdXNl IGRpdiB3aXRoIGJvcmRlciBhcyBpbmRpY2F0b3IuIEJhY2tncm91bmQgY2Fubm90IGJlIHVzZWQg YXMgcHJpbnRpbmcKK2Rpc2FibGVzIHRoZSBiYWNrZ3JvdW5kcyBhbmQgLXdlYmtpdC1wcmludC1j b2xvci1hZGp1c3Q6IGV4YWN0IGlzIG5vdCByZXNwZWN0ZWQgaW4KK1dUUiBwcmludGluZyBtb2Rl LgorLS0+Cis8ZGl2IHN0eWxlPSJwb3NpdGlvbjogYWJzb2x1dGU7IHdpZHRoOiAzMDBweDsgaGVp Z2h0OiAxNTBweDsgYm9yZGVyOjU1cHggc29saWQgZ3JlZW47Ij48L2Rpdj4KKzxjYW52YXMgc3R5 bGU9InBvc2l0aW9uOiBhYnNvbHV0ZTsiIGlkPSJnbCI+PC9jYW52YXM+Cis8L2Rpdj4KKzxzY3Jp cHQ+CisidXNlIHN0cmljdCI7Cit2YXIgY2FudmFzR0wgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgnZ2wnKTsKK2xldCBnbCA9IGNhbnZhc0dMLmdldENvbnRleHQoJ3dlYmdsJyk7CitnbC5jbGVh ckNvbG9yKDAsIDEsIDAsIDEpOworZ2wuY2xlYXIoZ2wuQ09MT1JfQlVGRkVSX0JJVCk7CitpZiAo d2luZG93LmludGVybmFscykKKyAgICB3aW5kb3cuaW50ZXJuYWxzLnNldE1heENhbnZhc1BpeGVs TWVtb3J5KDcpOworaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHRlc3RSdW5uZXIuc2V0UHJp bnRpbmcoKTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=