228735 2021-08-03 03:02:46 -0700 REGRESSION(r279050): Crash under CSSImageValue::createDeprecatedCSSOMWrapper with cursor images 2021-08-03 18:48:55 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned achristensen darin esprehn+autocc ews-watchlist glenn gyuyoung.kim macpherson menard mjs webkit-bug-importer oldest_to_newest 1781578 0 koivisto 2021-08-03 03:02:46 -0700 CSSCursorImageValue is not a CSSImageValue. 1781579 1 434824 koivisto 2021-08-03 03:46:34 -0700 Created attachment 434824 patch 1781635 2 mjs 2021-08-03 09:45:01 -0700 <rdar://81119647> 1781636 3 webkit-bug-importer 2021-08-03 09:45:15 -0700 <rdar://problem/81466490> 1781639 4 ews-feeder 2021-08-03 09:55:04 -0700 Committed r280599 (240217@main): <https://commits.webkit.org/240217@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434824. 1781804 5 434824 darin 2021-08-03 18:48:55 -0700 Comment on attachment 434824 patch View in context: https://bugs.webkit.org/attachment.cgi?id=434824&action=review > Source/WebCore/css/CSSValue.cpp:498 > + if (isImageValue()) > return downcast<CSSImageValue>(this)->createDeprecatedCSSOMWrapper(styleDeclaration); > if (isPrimitiveValue()) Occurs to me that we could come back here and make this more obviously correct by using is<CSSImageValue>, is<CSSPrimitiveValue>, and is<CSSValueList>. 434824 2021-08-03 03:46:34 -0700 2021-08-03 09:55:05 -0700 patch cursor-image-cssvalue.patch text/plain 3206 koivisto ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkM2M2NTk5MzUyOGQuLjM1ZmM3N2JjN2Q3MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA CisyMDIxLTA4LTAzICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAg ICBSRUdSRVNTSU9OKHIyNzkwNTApOiBDcmFzaCB1bmRlciBDU1NJbWFnZVZhbHVlOjpjcmVhdGVE ZXByZWNhdGVkQ1NTT01XcmFwcGVyIHdpdGggY3Vyc29yIGltYWdlcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4NzM1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2Nzcy9jdXJzb3ItaW1hZ2Ut Y3NzdmFsdWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9jdXJzb3It aW1hZ2UtY3NzdmFsdWUuaHRtbDogQWRkZWQuCisKIDIwMjEtMDgtMDEgIEZ1amlpIEhpcm9ub3Jp ICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CiAKICAgICAgICAgW1dpbkNhaXJvXSBVbnJldmll d2VkIHRlc3QgZ2FyZGVuaW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9jdXJz b3ItaW1hZ2UtY3NzdmFsdWUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvY3Vy c29yLWltYWdlLWNzc3ZhbHVlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAuLmQ5Mjc2NmRiNjRhOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvY3NzL2N1cnNvci1pbWFnZS1jc3N2YWx1ZS1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSBAQAordXJsKCJmaWxlOi8vL25vbi1leGlzdGVudC5wbmciKQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9jc3MvY3Vyc29yLWltYWdlLWNzc3ZhbHVlLmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L2Nzcy9jdXJzb3ItaW1hZ2UtY3NzdmFsdWUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAuLjMxZGExNDlmYzI4OAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91 dFRlc3RzL2Zhc3QvY3NzL2N1cnNvci1pbWFnZS1jc3N2YWx1ZS5odG1sCkBAIC0wLDAgKzEsMTMg QEAKKzxzdHlsZT4KKyN0YXJnZXQgeyBjdXJzb3I6dXJsKGZpbGU6Ly8vbm9uLWV4aXN0ZW50LnBu ZyksIGF1dG87IH0KKzwvc3R5bGU+Cis8ZGl2IGlkPXRhcmdldD48L2Rpdj4KKzxwcmUgaWQ9bG9n PjwvcHJlPgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVy LmR1bXBBc1RleHQoKTsKKworY29uc3QgY3Vyc29yVmFsdWUgPSBnZXRDb21wdXRlZFN0eWxlKHRh cmdldCkuZ2V0UHJvcGVydHlDU1NWYWx1ZSgiY3Vyc29yIik7CisKK2xvZy5pbm5lclRleHQgPSBj dXJzb3JWYWx1ZS5pdGVtKDApLmNzc1RleHQ7Cis8L3NjcmlwdD4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzMjll NzY3NDg2ZWUuLjZjMjA1YWU1ODFmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIx LTA4LTAzICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdS RVNTSU9OKHIyNzkwNTApOiBDcmFzaCB1bmRlciBDU1NJbWFnZVZhbHVlOjpjcmVhdGVEZXByZWNh dGVkQ1NTT01XcmFwcGVyIHdpdGggY3Vyc29yIGltYWdlcworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4NzM1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ1NTQ3Vyc29ySW1hZ2VWYWx1ZSBpcyBub3QgYSBD U1NJbWFnZVZhbHVlLiBUaGlzIHVzZWQgdG8gd29yayBiZWZvcmUgcjI3OTA1MCBiZWNhdXNlIHRo ZXkgaGFkCisgICAgICAgIHRoZSBVUkwgZmllbGQgaW4gdGhlIHNhbWUgb2Zmc2V0LgorCisgICAg ICAgIFRlc3Q6IGZhc3QvY3NzL2N1cnNvci1pbWFnZS1jc3N2YWx1ZS5odG1sCisKKyAgICAgICAg KiBjc3MvQ1NTVmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTVmFsdWU6OmNyZWF0ZURl cHJlY2F0ZWRDU1NPTVdyYXBwZXIgY29uc3QpOgorCisgICAgICAgIERvbid0IGRvIGFueSBzcGVj aWFsIGhhbmRsaW5nIGZvciBDU1NDdXJzb3JJbWFnZVZhbHVlLiBUaGV5IGFyZSBleHBvc2VkIGFz IGdlbmVyaWMgKGRlcHJlY2F0ZWQpCisgICAgICAgIENTUyB2YWx1ZXMgd2l0aCBjc3NUZXh0IG9u bHkuCisKIDIwMjEtMDgtMDIgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkB3ZWJraXQub3Jn PgogCiAgICAgICAgIFtjc3Mtc2Nyb2xsLXNuYXBdIENvbnNpZGVyIGFsbCBzbmFwIGFyZWFzIGF0 IGEgZ2l2ZW4gc25hcCBvZmZzZXQgd2hlbiBzbmFwcGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL0NTU1ZhbHVlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZS5jcHAK aW5kZXggMzUwMThiNTczYmM4Li44NzM2OWFiMGRiNTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NWYWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ZhbHVlLmNw cApAQCAtNDkzLDcgKzQ5Myw3IEBAIHZvaWQgQ1NTVmFsdWU6OmRlc3Ryb3koKQogCiBSZWY8RGVw cmVjYXRlZENTU09NVmFsdWU+IENTU1ZhbHVlOjpjcmVhdGVEZXByZWNhdGVkQ1NTT01XcmFwcGVy KENTU1N0eWxlRGVjbGFyYXRpb24mIHN0eWxlRGVjbGFyYXRpb24pIGNvbnN0CiB7Ci0gICAgaWYg KGlzSW1hZ2VWYWx1ZSgpIHx8IGlzQ3Vyc29ySW1hZ2VWYWx1ZSgpKQorICAgIGlmIChpc0ltYWdl VmFsdWUoKSkKICAgICAgICAgcmV0dXJuIGRvd25jYXN0PENTU0ltYWdlVmFsdWU+KHRoaXMpLT5j cmVhdGVEZXByZWNhdGVkQ1NTT01XcmFwcGVyKHN0eWxlRGVjbGFyYXRpb24pOwogICAgIGlmIChp c1ByaW1pdGl2ZVZhbHVlKCkpCiAgICAgICAgIHJldHVybiBEZXByZWNhdGVkQ1NTT01QcmltaXRp dmVWYWx1ZTo6Y3JlYXRlKGRvd25jYXN0PENTU1ByaW1pdGl2ZVZhbHVlPigqdGhpcyksIHN0eWxl RGVjbGFyYXRpb24pOwo=