228701 2021-08-02 09:05:43 -0700 [PlayStation] Make C files in testapi compile with a C standard rather than C++ one 2021-08-02 16:40:17 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned annulen ews-watchlist gyuyoung.kim keith_miller mark.lam msaboff ross.kirsling ryuan.choi saam sergio tzagallo webkit-bug-importer oldest_to_newest 1781257 0 stephan.szabo 2021-08-02 09:05:43 -0700 Building of testapi for playstation using Visual Studio started to fail for me complaining about having the argument to use c++17 as the standard for the .C files. We've seen this before and generally add either a compile as C++ or use an appropriate standard in our PlatformPlayStation.cmake. 1781264 1 434759 stephan.szabo 2021-08-02 09:28:06 -0700 Created attachment 434759 Patch 1781346 2 434759 ross.kirsling 2021-08-02 12:04:28 -0700 Comment on attachment 434759 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434759&action=review r=me > Source/JavaScriptCore/shell/PlatformPlayStation.cmake:34 > + PROPERTIES COMPILE_FLAGS --std=gnu17 I take it the GNU extensions are needed? 1781353 3 stephan.szabo 2021-08-02 12:20:03 -0700 Yes - something included tries to do some inline assembly which is unhappy in plain C mode. 1781456 4 ews-feeder 2021-08-02 16:39:17 -0700 Committed r280569 (240193@main): <https://commits.webkit.org/240193@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434759. 1781457 5 webkit-bug-importer 2021-08-02 16:40:17 -0700 <rdar://problem/81435038> 434759 2021-08-02 09:28:06 -0700 2021-08-02 16:39:19 -0700 Patch 228701.1.diff text/plain 1536 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDdkMDUxMzAzODgwMi4uNDRiNjJmMzhjM2EzIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMS0wOC0wMiAgU3Rl cGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CisKKyAgICAgICAgW1BsYXlTdGF0 aW9uXSBNYWtlIEMgZmlsZXMgaW4gdGVzdGFwaSBjb21waWxlIHdpdGggYSBDIHN0YW5kYXJkIHJh dGhlciB0aGFuIEMrKyBvbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyODcwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogc2hlbGwvUGxhdGZvcm1QbGF5U3RhdGlvbi5jbWFrZTogU2V0IHN0YW5kYXJk IGZvciBDIGZpbGVzIGluIHRlc3RhcGkKKwogMjAyMS0wNy0yOSAgWXVzdWtlIFN1enVraSAgPHlz dXp1a2lAYXBwbGUuY29tPiBhbmQgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBnbWFpbC5j b20+CiAKICAgICAgICAgW0pTQ10gTGVnYWN5IFJlZ0V4cCBmaWVsZHMgc2hvdWxkIGJlIGFjY2Vz c29ycwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3NoZWxsL1BsYXRmb3JtUGxh eVN0YXRpb24uY21ha2UgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvc2hlbGwvUGxhdGZvcm1QbGF5 U3RhdGlvbi5jbWFrZQppbmRleCA2ZTE4ZWUzZDVhZjEuLjY1MTQ0ZGFiZmUxNCAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3NoZWxsL1BsYXRmb3JtUGxheVN0YXRpb24uY21ha2UK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3NoZWxsL1BsYXRmb3JtUGxheVN0YXRpb24uY21h a2UKQEAgLTI0LDMgKzI0LDEzIEBAIHNldChQTEFZU1RBVElPTl9qc2NfTUFJTl9USFJFQURfTkFN RSAiSlNDU2hlbGwiKQogaWYgKCR7Q01BS0VfR0VORVJBVE9SfSBNQVRDSEVTICJWaXN1YWwgU3R1 ZGlvIikKICAgICBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMoanNjIFBST1BFUlRJRVMgVlNfREVCVUdH RVJfV09SS0lOR19ESVJFQ1RPUlkgIiR7Q01BS0VfUlVOVElNRV9PVVRQVVRfRElSRUNUT1JZfSIp CiBlbmRpZiAoKQorCisKK2lmICgke0NNQUtFX0dFTkVSQVRPUn0gTUFUQ0hFUyAiVmlzdWFsIFN0 dWRpbyIpCisgICAgIyBXaXRoIHRoZSBWaXN1YWxTdHVkaW8gZ2VuZXJhdG9yLCB0aGUgY29tcGls ZXIgY29tcGxhaW5zIGFib3V0IC1zdGQ9YysrKiBmb3IgQyBzb3VyY2VzLgorICAgIHNldF9zb3Vy Y2VfZmlsZXNfcHJvcGVydGllcygKKyAgICAgICAgLi4vQVBJL3Rlc3RzL0N1c3RvbUdsb2JhbE9i amVjdENsYXNzVGVzdC5jCisgICAgICAgIC4uL0FQSS90ZXN0cy90ZXN0YXBpLmMKKyAgICAgICAg UFJPUEVSVElFUyBDT01QSUxFX0ZMQUdTIC0tc3RkPWdudTE3CisgICAgKQorZW5kaWYgKCkK