228694 2021-08-01 18:30:24 -0700 Crash in -[WKFullScreenWindowController windowDidExitFullScreen:] 2021-08-02 17:39:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 227243 1 jean-yves.avenard jean-yves.avenard darin jer.noble webkit-bug-importer oldest_to_newest 1781173 0 jean-yves.avenard 2021-08-01 18:30:24 -0700 Crash in -[WKFullScreenWindowController windowDidExitFullScreen:] 1781174 1 jean-yves.avenard 2021-08-01 18:31:52 -0700 rdar://80727568 1781175 2 jean-yves.avenard 2021-08-01 18:51:03 -0700 Regression appears to have been introduced by bug 227243. In the method -[WKFullScreenWindowController windowDidExitFullScreen:] it seems that the call to [self finishedExitFullScreenAnimation:YES]; delete self. 1781179 3 434730 jean-yves.avenard 2021-08-01 19:22:10 -0700 Created attachment 434730 Patch 1781447 4 ews-feeder 2021-08-02 16:19:25 -0700 Committed r280568 (240192@main): <https://commits.webkit.org/240192@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434730. 1781484 5 434730 darin 2021-08-02 17:39:14 -0700 Comment on attachment 434730 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434730&action=review > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:691 > + RetainPtr<WKFullScreenWindowController> retain = self; In future we should be able to omit the template arguments: RetainPtr retain = self; 434730 2021-08-01 19:22:10 -0700 2021-08-02 16:19:26 -0700 Patch bug-228694-20210802122209.patch text/plain 4048 jean-yves.avenard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRmNTU4ZGM4ZTZjNmQ1YzI5 ZTg1ZmI4NzU0ZWE0OTU4NTBkNzU3ZDIuLjBiZTZiYTVjM2Q4YmZkYzkxZTZjOGU0ODBiZmM2Y2Fk YzY0OTc3M2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMjEtMDgtMDEgIEplYW4tWXZl cyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiAtW1dLRnVsbFNj cmVlbldpbmRvd0NvbnRyb2xsZXIgd2luZG93RGlkRXhpdEZ1bGxTY3JlZW46XQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4Njk0CisgICAgICAgIHJk YXI6Ly83OTU2OTg4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEl0IGFwcGVhcnMgdGhhdCBbV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBmaW5p c2hlZEVudGVyRnVsbFNjcmVlbkFuaW1hdGlvbl0gY2FuCisgICAgICAgIGNhdXNlIHRoZSByZXRh aW4gY291bnQgdG8gYmUgZGVjcmVhc2VkICh0aGlzIGlzIHRoZSBvbmx5IGV4cGxhbmF0aW9uIHRo YXQgbWFrZXMgYW55CisgICAgICAgIHNlbnNlIGNvbnNpZGVyaW5nIHRoZSBjcmFzaCBhbmQgd2hl biB0aGUgcmVncmVzc2lvbiBzdGFydGVkIGZvbGxvd2luZyBidWcgMjI3MjQzKS4KKyAgICAgICAg Tm8gdGVzdCwgY2FuJ3QgcmVwcm9kdWNlLgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9XS0Z1 bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tOgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5k b3dDb250cm9sbGVyIHNldFZpZGVvRnVsbHNjcmVlbk1hbmFnZXJDbGllbnQ6XSk6IEFkZCB1dGls aXR5IG1ldGhvZAorICAgICAgICB0byByZW1vdmUgZHVwbGljYXRlZCBjb2RlLgorICAgICAgICAo LVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIGRpZEV4aXRQaWN0dXJlSW5QaWN0dXJlXSk6 CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgd2luZG93RGlkRW50ZXJG dWxsU2NyZWVuOl0pOgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIHdp bmRvd0RpZEZhaWxUb0V4aXRGdWxsU2NyZWVuOl0pOgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5X aW5kb3dDb250cm9sbGVyIHdpbmRvd0RpZEV4aXRGdWxsU2NyZWVuOl0pOgorICAgICAgICAoLVtX S0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyIF9tYW5hZ2VyXSk6IGZseS1ieSBtYWtlIHN0eWxl IGNvbnNpc3RlbnQgd2l0aCBvdGhlcgorICAgICAgICBzaW1pbGFyIG1ldGhvZHMuCisKIDIwMjEt MDctMjYgIEplYW4tWXZlcyBBdmVuYXJkICA8anlhQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2Vi QXVkaW9dIEFkZCB3ZWJtL3ZvcmJpcyBjb250YWluZXIgc3VwcG9ydApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0g Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxl ci5tbQppbmRleCAxZjcwZjU4MjYzMjMzNzkzMjNhYjEyM2I0NDk1MDY2YTA5NzUxMjA1Li5kYmRk YzQxMmFiODQ0OTg2ZDE4YTU5NzMzMTNiYmVhODgyZTU1MDdmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxl ci5tbQpAQCAtNjQ1LDE0ICs2NDUsMTkgQEAgLSAodm9pZClkaWRFbnRlclBpY3R1cmVJblBpY3R1 cmUKICAgICAgICAgW3NlbGYgcmVxdWVzdEV4aXRGdWxsU2NyZWVuXTsKIH0KIAotLSAodm9pZClk aWRFeGl0UGljdHVyZUluUGljdHVyZQorLSAodm9pZClzZXRWaWRlb0Z1bGxzY3JlZW5NYW5hZ2Vy Q2xpZW50OihXZWJLaXQ6OlZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94eUNsaWVudCAqKWNsaWVu dAogewogICAgIGlmIChhdXRvKiB2aWRlb0Z1bGxzY3JlZW5NYW5hZ2VyID0gc2VsZi5fdmlkZW9G dWxsc2NyZWVuTWFuYWdlcikgewogICAgICAgICBBU1NFUlQodmlkZW9GdWxsc2NyZWVuTWFuYWdl ci0+Y2xpZW50KCkgPT0gJl92aWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHlDbGllbnQpOwotICAg ICAgICB2aWRlb0Z1bGxzY3JlZW5NYW5hZ2VyLT5zZXRDbGllbnQobnVsbHB0cik7CisgICAgICAg IHZpZGVvRnVsbHNjcmVlbk1hbmFnZXItPnNldENsaWVudChjbGllbnQpOwogICAgIH0KIH0KIAor LSAodm9pZClkaWRFeGl0UGljdHVyZUluUGljdHVyZQoreworICAgIFtzZWxmIHNldFZpZGVvRnVs bHNjcmVlbk1hbmFnZXJDbGllbnQ6bnVsbHB0cl07Cit9CisKICNwcmFnbWEgbWFyayAtCiAjcHJh Z21hIG1hcmsgQ3VzdG9tIE5TV2luZG93IEZ1bGwgU2NyZWVuIEFuaW1hdGlvbgogCkBAIC02ODMs MjcgKzY4OCwyMyBAQCAtICh2b2lkKXdpbmRvd0RpZEZhaWxUb0VudGVyRnVsbFNjcmVlbjooTlNX aW5kb3cgKil3aW5kb3cKIAogLSAodm9pZCl3aW5kb3dEaWRFbnRlckZ1bGxTY3JlZW46KE5TTm90 aWZpY2F0aW9uICopbm90aWZpY2F0aW9uCiB7CisgICAgUmV0YWluUHRyPFdLRnVsbFNjcmVlbldp bmRvd0NvbnRyb2xsZXI+IHJldGFpbiA9IHNlbGY7CiAgICAgW3NlbGYgZmluaXNoZWRFbnRlckZ1 bGxTY3JlZW5BbmltYXRpb246WUVTXTsKLQotICAgIGlmIChhdXRvKiB2aWRlb0Z1bGxzY3JlZW5N YW5hZ2VyID0gc2VsZi5fdmlkZW9GdWxsc2NyZWVuTWFuYWdlcikgewotICAgICAgICBBU1NFUlQo dmlkZW9GdWxsc2NyZWVuTWFuYWdlci0+Y2xpZW50KCkgPT0gbnVsbHB0cik7Ci0gICAgICAgIHZp ZGVvRnVsbHNjcmVlbk1hbmFnZXItPnNldENsaWVudCgmX3ZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQ cm94eUNsaWVudCk7Ci0gICAgfQorICAgIFtzZWxmIHNldFZpZGVvRnVsbHNjcmVlbk1hbmFnZXJD bGllbnQ6Jl92aWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHlDbGllbnRdOwogfQogCiAtICh2b2lk KXdpbmRvd0RpZEZhaWxUb0V4aXRGdWxsU2NyZWVuOihOU1dpbmRvdyAqKXdpbmRvdwogeworICAg IFJldGFpblB0cjxXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyPiByZXRhaW4gPSBzZWxmOwog ICAgIFtzZWxmIGZpbmlzaGVkRXhpdEZ1bGxTY3JlZW5BbmltYXRpb246Tk9dOworICAgIFtzZWxm IHNldFZpZGVvRnVsbHNjcmVlbk1hbmFnZXJDbGllbnQ6bnVsbHB0cl07CiB9CiAKIC0gKHZvaWQp d2luZG93RGlkRXhpdEZ1bGxTY3JlZW46KE5TTm90aWZpY2F0aW9uICopbm90aWZpY2F0aW9uCiB7 CisgICAgUmV0YWluUHRyPFdLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXI+IHJldGFpbiA9IHNl bGY7CiAgICAgW3NlbGYgZmluaXNoZWRFeGl0RnVsbFNjcmVlbkFuaW1hdGlvbjpZRVNdOwotCi0g ICAgaWYgKGF1dG8qIHZpZGVvRnVsbHNjcmVlbk1hbmFnZXIgPSBzZWxmLl92aWRlb0Z1bGxzY3Jl ZW5NYW5hZ2VyKSB7Ci0gICAgICAgIEFTU0VSVCh2aWRlb0Z1bGxzY3JlZW5NYW5hZ2VyLT5jbGll bnQoKSA9PSAmX3ZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94eUNsaWVudCk7Ci0gICAgICAgIHZp ZGVvRnVsbHNjcmVlbk1hbmFnZXItPnNldENsaWVudChudWxscHRyKTsKLSAgICB9CisgICAgW3Nl bGYgc2V0VmlkZW9GdWxsc2NyZWVuTWFuYWdlckNsaWVudDpudWxscHRyXTsKIH0KIAogLSAoTlNX aW5kb3cgKilkZXN0aW5hdGlvbldpbmRvd1RvRXhpdEZ1bGxTY3JlZW5Gb3JXaW5kb3c6KE5TV2lu ZG93ICopd2luZG93CkBAIC03MTgsNiArNzE5LDcgQEAgLSAoV2ViS2l0OjpXZWJGdWxsU2NyZWVu TWFuYWdlclByb3h5KilfbWFuYWdlcgogewogICAgIGlmICghX3BhZ2UpCiAgICAgICAgIHJldHVy biBudWxscHRyOworCiAgICAgcmV0dXJuIF9wYWdlLT5mdWxsU2NyZWVuTWFuYWdlcigpOwogfQog Cg==