228691 2021-08-01 14:55:19 -0700 Skip unnecessary invalidation of document level NodeList caches 2021-08-22 21:20:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 mjs mjs cdumez darin esprehn+autocc ews-watchlist kangil.han webkit-bug-importer oldest_to_newest 1781163 0 mjs 2021-08-01 14:55:19 -0700 Skip unnecessary invalidation of document level NodeList caches 1781164 1 434727 mjs 2021-08-01 14:56:46 -0700 Created attachment 434727 For EWS testing only 1781165 2 434727 mjs 2021-08-01 14:58:53 -0700 Comment on attachment 434727 For EWS testing only Not for landing. This version of the patch is like incorrect, as some NodeLists or Collections may need document-level invalidation even when the node isn't in the document. This is probably true for HTMLFormControlCollection, not clear what else may be affected. Testing if this builds and passes tests for now. 1782789 3 webkit-bug-importer 2021-08-08 14:56:17 -0700 <rdar://problem/81675082> 1786311 4 434727 darin 2021-08-22 21:20:51 -0700 Comment on attachment 434727 For EWS testing only View in context: https://bugs.webkit.org/attachment.cgi?id=434727&action=review > Source/WebCore/ChangeLog:10 > + Ported from an abansoned Chromium change by Adithya Srinivasan. Typo: abansoned 434727 2021-08-01 14:56:46 -0700 2021-08-01 14:58:53 -0700 For EWS testing only bug-228691-20210801145645.patch text/plain 2496 mjs U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY1ZGFhNzRiMzQ3OWEx NGJmODEzZDdkN2I5ODg5Y2Y5YTk4MDZhYi4uMDIzN2Y0MjcxMDMzYmY0MjgzNWJlNDE0OTI4OTUy OGYzNWVmMjI0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTA4LTAxICBNYWNp ZWogU3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CisKKyAgICAgICAgU2tpcCB1bm5lY2Vzc2Fy eSBpbnZhbGlkYXRpb24gb2YgZG9jdW1lbnQgbGV2ZWwgTm9kZUxpc3QgY2FjaGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg2OTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5v IGludGVuZGVkIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICBQb3J0ZWQgZnJvbSBhbiBhYmFu c29uZWQgQ2hyb21pdW0gY2hhbmdlIGJ5IEFkaXRoeWEgU3Jpbml2YXNhbi4KKworICAgICAgICAq IGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmludmFsaWRhdGVOb2RlTGlz dEFuZENvbGxlY3Rpb25DYWNoZXNJbkFuY2VzdG9ycyk6IERvbid0IGludmFsaWRhdGUgZG9jdW1l bnQgY2FjaGVzIGlmIHRoZSBub2RlIGlzIG5vdCBjb25uZWN0ZWQuCisgICAgICAgIChXZWJDb3Jl OjpOb2RlOjppbnZhbGlkYXRlTm9kZUxpc3RBbmRDb2xsZWN0aW9uQ2FjaGVzSW5BbmNlc3RvcnNG b3JBdHRyaWJ1dGUpOiBEb24ndCBpbnZhbGlkYXRlIGRvY3VtZW50IGNhY2hlcyBpZiB0aGUgbm9k ZSBpcyBub3QgY29ubmVjdGVkLgorCiAyMDIxLTA3LTMxICBNYWNpZWogU3RhY2hvd2lhayAgPG1q c0BhcHBsZS5jb20+CiAKICAgICAgICAgTGlzdEF0dHJpYnV0ZVRhcmdldE9ic2VydmVyIGlzIG5l ZWRsZXNzbHkgY3JlYXRlZCBldmVuIHdoZW4gdGhlcmUgaXMgbm8gbGlzdCBhdHRyaWJ1dGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9Ob2RlLmNwcAppbmRleCA2OTI0Y2YzNmExMjI5YTM0MzVkNzhlMGI3ZDRjNWQzZjYzYTZmZTE0 Li5iYjY4Zjk1YjAzMmEzOTk5ZmVlM2YzNTY3ZmUzNjE2ZjczY2I1MDU2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUu Y3BwCkBAIC05NTIsOSArOTUyLDExIEBAIHZvaWQgTm9kZTo6aW52YWxpZGF0ZU5vZGVMaXN0QW5k Q29sbGVjdGlvbkNhY2hlc0luQW5jZXN0b3JzKCkKICAgICBpZiAoIWRvY3VtZW50KCkuc2hvdWxk SW52YWxpZGF0ZU5vZGVMaXN0QW5kQ29sbGVjdGlvbkNhY2hlcygpKQogICAgICAgICByZXR1cm47 CiAKLSAgICBkb2N1bWVudCgpLmludmFsaWRhdGVOb2RlTGlzdEFuZENvbGxlY3Rpb25DYWNoZXMo W10oYXV0byYgbGlzdCkgewotICAgICAgICBsaXN0LmludmFsaWRhdGVDYWNoZSgpOwotICAgIH0p OworICAgIGlmIChpc0Nvbm5lY3RlZCgpKSB7CisgICAgICAgIGRvY3VtZW50KCkuaW52YWxpZGF0 ZU5vZGVMaXN0QW5kQ29sbGVjdGlvbkNhY2hlcyhbXShhdXRvJiBsaXN0KSB7CisgICAgICAgICAg ICBsaXN0LmludmFsaWRhdGVDYWNoZSgpOworICAgICAgICB9KTsKKyAgICB9CiAKICAgICBmb3Ig KGF1dG8qIG5vZGUgPSB0aGlzOyBub2RlOyBub2RlID0gbm9kZS0+cGFyZW50Tm9kZSgpKSB7CiAg ICAgICAgIGlmICghbm9kZS0+aGFzUmFyZURhdGEoKSkKQEAgLTk3Miw5ICs5NzQsMTEgQEAgdm9p ZCBOb2RlOjppbnZhbGlkYXRlTm9kZUxpc3RBbmRDb2xsZWN0aW9uQ2FjaGVzSW5BbmNlc3RvcnNG b3JBdHRyaWJ1dGUoY29uc3QgUXUKICAgICBpZiAoIWRvY3VtZW50KCkuc2hvdWxkSW52YWxpZGF0 ZU5vZGVMaXN0QW5kQ29sbGVjdGlvbkNhY2hlc0ZvckF0dHJpYnV0ZShhdHRyTmFtZSkpCiAgICAg ICAgIHJldHVybjsKIAotICAgIGRvY3VtZW50KCkuaW52YWxpZGF0ZU5vZGVMaXN0QW5kQ29sbGVj dGlvbkNhY2hlcyhbJmF0dHJOYW1lXShhdXRvJiBsaXN0KSB7Ci0gICAgICAgIGxpc3QuaW52YWxp ZGF0ZUNhY2hlRm9yQXR0cmlidXRlKGF0dHJOYW1lKTsKLSAgICB9KTsKKyAgICBpZiAoaXNDb25u ZWN0ZWQoKSkgeworICAgICAgICBkb2N1bWVudCgpLmludmFsaWRhdGVOb2RlTGlzdEFuZENvbGxl Y3Rpb25DYWNoZXMoWyZhdHRyTmFtZV0oYXV0byYgbGlzdCkgeworICAgICAgICAgICAgbGlzdC5p bnZhbGlkYXRlQ2FjaGVGb3JBdHRyaWJ1dGUoYXR0ck5hbWUpOworICAgICAgICB9KTsKKyAgICB9 CiAKICAgICBmb3IgKGF1dG8qIG5vZGUgPSB0aGlzOyBub2RlOyBub2RlID0gbm9kZS0+cGFyZW50 Tm9kZSgpKSB7CiAgICAgICAgIGlmICghbm9kZS0+aGFzUmFyZURhdGEoKSkK