228690 2021-08-01 13:43:08 -0700 REGRESSION (r280492): [Win] ASSERTION FAILED: evt->type() == eventNames().keydownEvent || evt->type() == eventNames().keypressEvent in WebView::interpretKeyEvent since r280492 2021-08-02 15:38:18 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=228009 InRadar P2 Normal --- 1 fujii fujii achristensen bfulgham dana.estra don.olmstead pvollan ross.kirsling webkit-bug-importer oldest_to_newest 1781157 0 fujii 2021-08-01 13:43:08 -0700 [Win] ASSERTION FAILED: evt->type() == eventNames().keydownEvent || evt->type() == eventNames().keypressEvent in WebView::interpretKeyEvent since r280492 Since r280492 (240124@main, Bug 228009) WinCairo-64-bit-WKL-Debug-Tests https://build.webkit.org/#/builders/32/builds/769 ASSERTION FAILED: evt->type() == eventNames().keydownEvent || evt->type() == eventNames().keypressEvent ..\..\Source\WebKitLegacy\win\WebView.cpp(2320) : WebView::interpretKeyEvent 1 00007FF8FE421E8A WTFCrash 2 00007FF8DD011D01 WTFCrashWithInfo 3 00007FF8DD1A536F WebView::interpretKeyEvent 4 00007FF8DD1A5800 WebView::handleEditingKeyboardEvent 5 00007FF8DD1FBC80 WebEditorClient::handleKeyboardEvent 6 00007FF8DFD1EC1C WebCore::Editor::handleKeyboardEvent 7 00007FF8E07C6EB9 WebCore::EventHandler::defaultKeyboardEventHandler 8 00007FF8DFB7A9D0 WebCore::Node::defaultEventHandler 9 00007FF8DFF21C3B WebCore::HTMLInputElement::defaultEventHandler 10 00007FF8DFAFD5B4 WebCore::callDefaultEventHandlersInBubblingOrder 11 00007FF8DFAF640C WebCore::EventDispatcher::dispatchEvent 12 00007FF8DFB7A332 WebCore::Node::dispatchEvent 13 00007FF8DFAC57E0 WebCore::Element::dispatchKeyEvent 14 00007FF8E07CC767 WebCore::EventHandler::internalKeyEvent 15 00007FF8E07C6A9E WebCore::EventHandler::keyEvent 16 00007FF8DD1A28F8 WebView::keyUp 17 00007FF8DD1AE7A7 WebView::WebViewWndProc 18 00007FF911EF74D6 DispatchMessageW 19 00007FF911EF6DBB CallWindowProcW 20 00007FF904F1B8CA DefSubclassProc 21 00007FF904F1B5D8 CCSetScrollInfo 22 00007FF904F1B8CA DefSubclassProc 23 00007FF904F1B6E2 CCSetScrollInfo 24 00007FF911EF74D6 DispatchMessageW 25 00007FF911EF6FF2 DispatchMessageW 26 00007FF8F959C348 keyDownCallback 27 00007FF8F3F4E077 JSC::APICallbackFunction::callImpl<JSC::JSCallbackFunction> 28 00007FF8F3F41EA2 JSC::callJSCallbackFunction 29 000001DE2B0D102C 1781160 1 fujii 2021-08-01 13:46:57 -0700 Apple-Win-10-Debug-Tests has been broken these days. And I didn't test with AppleWin, but I believe this is not a WinCairo port specific failure. https://build.webkit.org/#/builders/16 1781161 2 fujii 2021-08-01 14:11:16 -0700 WinCairo WK2 also have a similar code and is failing a similar assertion. > WTF.dll!WTFCrash() Line 321 C++ > WebKit2.dll!WTFCrashWithInfo(int __formal, const char * __formal, const char * __formal, int __formal) Line 698 C++ > WebKit2.dll!WebKit::WebPage::interpretKeyEvent(const WebCore::KeyboardEvent * evt) Line 226 C++ > WebKit2.dll!WebKit::WebPage::handleEditingKeyboardEvent(WebCore::KeyboardEvent & event) Line 268 C++ > WebKit2.dll!WebKit::WebEditorClient::handleKeyboardEvent(WebCore::KeyboardEvent & event) Line 350 C++ > WebKit2.dll!WebCore::Editor::handleKeyboardEvent(WebCore::KeyboardEvent & event) Line 320 C++ > WebKit2.dll!WebCore::EventHandler::defaultKeyboardEventHandler(WebCore::KeyboardEvent & event) Line 3808 C++ > WebKit2.dll!WebCore::Node::defaultEventHandler(WebCore::Event & event) Line 2439 C++ > WebKit2.dll!WebCore::callDefaultEventHandlersInBubblingOrder(WebCore::Event & event, const WebCore::EventPath & path) Line 64 C++ > WebKit2.dll!WebCore::EventDispatcher::dispatchEvent(WebCore::Node & node, WebCore::Event & event) Line 205 C++ > WebKit2.dll!WebCore::Node::dispatchEvent(WebCore::Event & event) Line 2382 C++ > WebKit2.dll!WebCore::Element::dispatchKeyEvent(const WebCore::PlatformKeyboardEvent & platformEvent) Line 471 C++ > WebKit2.dll!WebCore::EventHandler::internalKeyEvent(const WebCore::PlatformKeyboardEvent & initialKeyEvent) Line 3560 C++ > WebKit2.dll!WebCore::EventHandler::keyEvent(const WebCore::PlatformKeyboardEvent & keyEvent) Line 3463 C++ > WebKit2.dll!WebCore::UserInputBridge::handleKeyEvent(const WebCore::PlatformKeyboardEvent & keyEvent, WebCore::InputSource __formal) Line 83 C++ > WebKit2.dll!WebKit::handleKeyEvent(const WebKit::WebKeyboardEvent & keyboardEvent, WebCore::Page * page) Line 3058 C++ > WebKit2.dll!WebKit::WebPage::keyEvent(const WebKit::WebKeyboardEvent & keyboardEvent) Line 3071 C++ > WebKit2.dll!IPC::callMemberFunctionImpl<WebKit::WebPage,void (__cdecl WebKit::WebPage::*)(WebKit::WebKeyboardEvent const &),std::tuple<WebKit::WebKeyboardEvent>,0>(WebKit::WebPage * object, void(WebKit::WebPage::*)(const WebKit::WebKeyboardEvent &) function, std::tuple<WebKit::WebKeyboardEvent> && args, std::integer_sequence<unsigned __int64,0> __formal) Line 44 C++ > WebKit2.dll!IPC::callMemberFunction<WebKit::WebPage,void (__cdecl WebKit::WebPage::*)(WebKit::WebKeyboardEvent const &),std::tuple<WebKit::WebKeyboardEvent>,std::integer_sequence<unsigned __int64,0>>(std::tuple<WebKit::WebKeyboardEvent> && args, WebKit::WebPage * object, void(WebKit::WebPage::*)(const WebKit::WebKeyboardEvent &) function) Line 50 C++ > WebKit2.dll!IPC::handleMessage<Messages::WebPage::KeyEvent,WebKit::WebPage,void (__cdecl WebKit::WebPage::*)(WebKit::WebKeyboardEvent const &)>(IPC::Decoder & decoder, WebKit::WebPage * object, void(WebKit::WebPage::*)(const WebKit::WebKeyboardEvent &) function) Line 120 C++ > WebKit2.dll!WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection & connection, IPC::Decoder & decoder) Line 2875 C++ > WebKit2.dll!WebKit::WebPage::didReceiveMessage(IPC::Connection & connection, IPC::Decoder & decoder) Line 5009 C++ > WebKit2.dll!IPC::MessageReceiverMap::dispatchMessage(IPC::Connection & connection, IPC::Decoder & decoder) Line 130 C++ > WebKit2.dll!WebKit::WebProcess::didReceiveMessage(IPC::Connection & connection, IPC::Decoder & decoder) Line 857 C++ > WebKit2.dll!IPC::Connection::dispatchMessage(IPC::Decoder & decoder) Line 1059 C++ > WebKit2.dll!IPC::Connection::dispatchMessage(std::unique_ptr<IPC::Decoder,std::default_delete<IPC::Decoder>> message) Line 1105 C++ > WebKit2.dll!IPC::Connection::dispatchOneIncomingMessage() Line 1173 C++ > WebKit2.dll!IPC::Connection::enqueueIncomingMessage::__l2::<lambda>() Line 1028 C++ > WebKit2.dll!WTF::Detail::CallableWrapper<void <lambda>(void),void>::call() Line 53 C++ > WTF.dll!WTF::Function<void __cdecl(void)>::operator()() Line 83 C++ > WTF.dll!WTF::RunLoop::performWork() Line 134 C++ > WTF.dll!WTF::RunLoop::wndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 57 C++ > WTF.dll!WTF::RunLoop::RunLoopWndProc(HWND__ * hWnd, unsigned int message, unsigned __int64 wParam, __int64 lParam) Line 39 C++ > user32.dll!00007ffd46a7e858() Unknown > user32.dll!00007ffd46a7e299() Unknown > WTF.dll!WTF::RunLoop::run() Line 74 C++ > WebKit2.dll!WebKit::AuxiliaryProcessMainBase<WebKit::WebProcess,1>::run(int argc, char * * argv) Line 71 C++ > WebKit2.dll!WebKit::AuxiliaryProcessMain<WebKit::WebProcessMainWin>(int argc, char * * argv) Line 97 C++ > WebKit2.dll!WebKit::WebProcessMain(int argc, char * * argv) Line 58 C++ > WebKitWebProcess.exe!main(int argc, char * * argv) Line 35 C++ > [Inline Frame] WebKitWebProcess.exe!invoke_main() Line 78 C++ > WebKitWebProcess.exe!__scrt_common_main_seh() Line 288 C++ > kernel32.dll!00007ffd45127034() Unknown > ntdll.dll!00007ffd46f42651() Unknown 1781162 3 434726 fujii 2021-08-01 14:21:02 -0700 Created attachment 434726 Patch 1781389 4 434726 bfulgham 2021-08-02 14:13:28 -0700 Comment on attachment 434726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434726&action=review > Source/WebKit/ChangeLog:3 > + [Win] ASSERTION FAILED: evt->type() == eventNames().keydownEvent || evt->type() == eventNames().keypressEvent in WebView::interpretKeyEvent since r280492 Why doesn't Windows want the ability to handle KeyUp events? 1781392 5 434726 fujii 2021-08-02 14:33:02 -0700 Comment on attachment 434726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434726&action=review >> Source/WebKit/ChangeLog:3 >> + [Win] ASSERTION FAILED: evt->type() == eventNames().keydownEvent || evt->type() == eventNames().keypressEvent in WebView::interpretKeyEvent since r280492 > > Why doesn't Windows want the ability to handle KeyUp events? r280492 changed to pass keyup event to EditorClient::handleKeyboardEvent for smooth scrolling. But, WebView::handleEditingKeyboardEvent of Windows port doesn't need it. 1781405 6 434726 bfulgham 2021-08-02 14:55:38 -0700 Comment on attachment 434726 Patch r=me 1781406 7 434726 fujii 2021-08-02 15:02:17 -0700 Comment on attachment 434726 Patch Thank you for the review. 1781426 8 ews-feeder 2021-08-02 15:37:11 -0700 Committed r280565 (240189@main): <https://commits.webkit.org/240189@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434726. 1781427 9 webkit-bug-importer 2021-08-02 15:38:18 -0700 <rdar://problem/81432660> 434726 2021-08-01 14:21:02 -0700 2021-08-02 15:37:12 -0700 Patch bug-228690-20210802062101.patch text/plain 3300 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNTIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk1NmUyODZmNWQ4MmIwNGVm YmQxZDQwNmYzMjUzZjY3YjM0OTc3MWYuLjY2YjkwNDk0N2Y2NzA1Zjc0M2MzNmVjY2E1YTQ4OTE0 MmIxODAwOTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDgtMDEgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbl0gQVNTRVJU SU9OIEZBSUxFRDogZXZ0LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLmtleWRvd25FdmVudCB8fCBl dnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkua2V5cHJlc3NFdmVudCBpbiBXZWJWaWV3OjppbnRl cnByZXRLZXlFdmVudCBzaW5jZSByMjgwNDkyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg2OTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS93aW4vV2ViUGFnZVdpbi5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2U6OmhhbmRsZUVkaXRpbmdLZXlib2FyZEV2ZW50 KTogUmV0dXJuIGVhcmx5IHVubGVzcyB0aGUgZXZlbnQgaXMga2V5ZG93biBvciBrZXlwcmVzcy4K KwogMjAyMS0wOC0wMSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAg ICAgSW50cm9kdWNlIGFuIGV4cGVyaW1lbnRhbCBmZWF0dXJlIHRvIHRvZ2dsZSBXZWJSVEMgc29j a2V0IHByb3h5aW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VMb2cKaW5kZXggZDgzMWE2Mzc4NTEw MTYxMGI0MTRlZTQzNjBkYmFkODc3ZTgxMzE0ZC4uNTlhMjQwM2Y5ODQyNTJkZmU1NDQ1ZDE0OTU5 YzI4YTg5NDMwN2NlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExlZ2FjeS93aW4vQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTA4LTAxICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFtXaW5dIEFTU0VSVElPTiBGQUlMRUQ6IGV2dC0+dHlwZSgpID09IGV2ZW50 TmFtZXMoKS5rZXlkb3duRXZlbnQgfHwgZXZ0LT50eXBlKCkgPT0gZXZlbnROYW1lcygpLmtleXBy ZXNzRXZlbnQgaW4gV2ViVmlldzo6aW50ZXJwcmV0S2V5RXZlbnQgc2luY2UgcjI4MDQ5MgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4NjkwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJWaWV3LmNw cDoKKyAgICAgICAgKFdlYlZpZXc6OmhhbmRsZUVkaXRpbmdLZXlib2FyZEV2ZW50KTogUmV0dXJu IGVhcmx5IHVubGVzcyB0aGUgZXZlbnQgaXMga2V5ZG93biBvciBrZXlwcmVzcy4KKwogMjAyMS0w Ny0xNiAgTWVnYW4gR2FyZG5lciAgPG1lZ2FuX2dhcmRuZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFBpcGUgQXBwIEhpZ2hsaWdodCBzY3JvbGxpbmcgdGhyb3VnaCBVSSBQcm9jZXNzIGluIHByZXBh cmF0aW9uIGZvciBOb3RlIE92ZXJsYXkgYXZvaWRhbmNlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4uY3BwIGIvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1dlYlBhZ2Uvd2luL1dlYlBhZ2VXaW4uY3BwCmluZGV4IDhlOTQ1NDU5N2Ji MjNiMjJjNTA2ZjkyOTAyMGZjM2MzN2ZmYWE3MWEuLjBjZjQ3MDdkNDRmYjIwYTJjYjEyNWFhZjk0 NjVkMTI4MmJmODQ2NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ YWdlL3dpbi9XZWJQYWdlV2luLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS93aW4vV2ViUGFnZVdpbi5jcHAKQEAgLTI2NSw2ICsyNjUsOSBAQCBib29sIFdlYlBhZ2U6 OmhhbmRsZUVkaXRpbmdLZXlib2FyZEV2ZW50KFdlYkNvcmU6OktleWJvYXJkRXZlbnQmIGV2ZW50 KQogICAgIGlmICgha2V5RXZlbnQgfHwga2V5RXZlbnQtPmlzU3lzdGVtS2V5KCkpIC8vIERvIG5v dCB0cmVhdCB0aGlzIGFzIHRleHQgaW5wdXQgaWYgaXQncyBhIHN5c3RlbSBrZXkgZXZlbnQuCiAg ICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIGlmIChldmVudC50eXBlKCkgIT0gZXZlbnROYW1l cygpLmtleWRvd25FdmVudCAmJiBldmVudC50eXBlKCkgIT0gZXZlbnROYW1lcygpLmtleXByZXNz RXZlbnQpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIGF1dG8gY29tbWFuZCA9IGZyYW1l LT5lZGl0b3IoKS5jb21tYW5kKGludGVycHJldEtleUV2ZW50KCZldmVudCkpOwogCiAgICAgaWYg KGtleUV2ZW50LT50eXBlKCkgPT0gUGxhdGZvcm1FdmVudDo6UmF3S2V5RG93bikgewpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdExlZ2FjeS93aW4vV2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0 TGVnYWN5L3dpbi9XZWJWaWV3LmNwcAppbmRleCBhMDZjZjg1Y2E0ODVmZDU1MzU4MWFlZTVhMDkz NzlkMzZlMDA4MWVjLi5jZGU3YmNiZmNhNWI2ZGNiM2VmNWM3NjVhNDk5ZTZiNmNkYjNkNzg0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJWaWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJWaWV3LmNwcApAQCAtMjM1OSw2ICsyMzU5LDkgQEAgYm9v bCBXZWJWaWV3OjpoYW5kbGVFZGl0aW5nS2V5Ym9hcmRFdmVudChLZXlib2FyZEV2ZW50JiBldmVu dCkKICAgICBpZiAoIWtleUV2ZW50IHx8IGtleUV2ZW50LT5pc1N5c3RlbUtleSgpKSAgLy8gZG8g bm90IHRyZWF0IHRoaXMgYXMgdGV4dCBpbnB1dCBpZiBpdCdzIGEgc3lzdGVtIGtleSBldmVudAog ICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyAgICBpZiAoZXZlbnQudHlwZSgpICE9IGV2ZW50TmFt ZXMoKS5rZXlkb3duRXZlbnQgJiYgZXZlbnQudHlwZSgpICE9IGV2ZW50TmFtZXMoKS5rZXlwcmVz c0V2ZW50KQorICAgICAgICByZXR1cm4gZmFsc2U7CisKICAgICBhdXRvIGNvbW1hbmQgPSBmcmFt ZS0+ZWRpdG9yKCkuY29tbWFuZChpbnRlcnByZXRLZXlFdmVudCgmZXZlbnQpKTsKIAogICAgIGlm IChrZXlFdmVudC0+dHlwZSgpID09IFBsYXRmb3JtRXZlbnQ6OlJhd0tleURvd24pIHsK