228673 2021-07-30 17:27:15 -0700 [GPUProcess] REGRESSION: A noticeable slow down when browsing Live Photos album on iCloud.com 2022-04-26 20:36:29 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=239799 InRadar P2 Normal --- 1 sabouhallawa sabouhallawa dino simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1781018 0 sabouhallawa 2021-07-30 17:27:15 -0700 Appending FlushContext to the DL makes GPUProcess do two things: 1. Flushes the backend context. 2. Sends a DidFlush message back to the WebProcess. One of the callers of RemoteImageBufferProxy::flushDrawingContextAsync() is RemoteImageBufferProxy::flushDrawingContext() which assumes FlushContext is added all the times and this is why it waits for 3 seconds and then gives up. But flushDrawingContextAsync() adds FlushContext only 'if (!m_drawingContext.displayList().isEmpty())'. The opposite can happen very often since clearDisplayList() is called from flushDrawingContextAsync() itself. So we can waste three seconds waiting for a message that will never be received because the DisplayList is empty. If 'm_drawingContext.displayList().isEmpty()' is true, appending FlushContext may not be needed. But we do not know for sure if the GPUProcess is applying or will be applying items from the SharedBuffer for this ImageBuffer. We need to ensure all the items are processed and we may be waiting for a DidFlush message. So the solution is to make RemoteImageBufferProxy::flushDrawingContextAsync() append FlushContext to its DisplayList always. 1781038 1 434683 sabouhallawa 2021-07-30 19:45:39 -0700 Created attachment 434683 Patch 1781039 2 webkit-bug-importer 2021-07-30 19:46:53 -0700 <rdar://problem/81353138> 1781290 3 434683 wenson_hsieh 2021-08-02 10:09:50 -0700 Comment on attachment 434683 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434683&action=review Is there a reason why we don't just check `!m_drawingContext.displayList().isEmpty()` in `flushDrawingContext()`? > Source/WebKit/ChangeLog:15 > + the backend context is flushed. Also we need GPUProces to send the DidFush Nits - GPUProces => GPUProcess, DidFush => DidFlush 1781788 4 434872 sabouhallawa 2021-08-03 17:18:44 -0700 Created attachment 434872 Patch 1781794 5 434683 sabouhallawa 2021-08-03 17:30:07 -0700 Comment on attachment 434683 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434683&action=review I replaced 'if (!m_drawingContext.displayList().isEmpty())' by 'if (!hasPendingFlush())'. I think this makes more sense. Suppose CanvasRenderingContext2DBase::prepareForDisplay() calls RemoteImageBufferProxy::flushDrawingContextAsync() and this one adds the FlushContext item. Later and before we receive the DidFlush, ConcreteImageBuffer::copyNativeImage() calls flushDrawingContext(). In this case we will realize there is a pending FlushContext and we are not going to send a new one. We wait for DidFlush and it arrives as expected. Now suppose for example the destructor RemoteImageBufferProxy::~RemoteImageBufferProxy() calls flushDrawingContext(). It will add the FlushContext since it does not have a pending one. flushDrawingContext() waits for DidFlush and it arrives as expected. >> Source/WebKit/ChangeLog:15 >> + the backend context is flushed. Also we need GPUProces to send the DidFush > > Nits - GPUProces => GPUProcess, DidFush => DidFlush Fixed. 1781839 6 434890 sabouhallawa 2021-08-04 00:01:24 -0700 Created attachment 434890 Patch 1781995 7 sabouhallawa 2021-08-04 12:22:19 -0700 I changed the patch to add !hasPendingFlush() as a condition to add FlushContext item. Keeping the condition "!m_drawingContext.displayList().isEmpty()" will help with a sequence like the following: FillRect // Drawing to RemoteImageBufferProxy ... FlushContext // Added by flushDrawingContextAsync() because the DL is not empty (there is no pending FlushContext) ... StrokeRect // Continue drawing to RemoteImageBufferProxy ... FlushContext // Added by flushDrawingContextAsync() because the DL is not empty (there is a pending FlushContext) The condition "!hasPendingFlush()" will add the FlushContext even if the DL is empty which will force sending WakeUpAndApplyDisplayList to GPUP so we can guarantee the GPUP will send a DidFlush message. 1782005 8 ews-feeder 2021-08-04 12:43:07 -0700 Committed r280652 (240263@main): <https://commits.webkit.org/240263@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434890. 434683 2021-07-30 19:45:39 -0700 2021-08-04 00:01:19 -0700 Patch bug-228673-20210730194539.patch text/plain 2406 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk3YmE2ZDc5OWIxODI1NjZi ZThjMDBjNmZjOWYxNzk0ZGZiN2NhNTEuLjUxNWYzN2VmNjA2YTBlMzkxMDU5YThmYTg0NTRiZWZl ODUwZTFhN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDctMzAgIFNhaWQgQWJv dS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0dQVSBQcm9jZXNzXSBSZW1v dGVJbWFnZUJ1ZmZlclByb3h5OjpmbHVzaERyYXdpbmdDb250ZXh0QXN5bmMoKSBzaG91bGQgYWx3 YXlzIGFwcGVuZCBGbHVzaENvbnRleHQgdG8gaXRzIERpc3BsYXlMaXN0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg2NzMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdGVJbWFnZUJ1ZmZlclByb3h5 OjpmbHVzaERyYXdpbmdDb250ZXh0KCkgYXNzdW1lcyBhIEZsdXNoQ29udGV4dCBpdGVtCisgICAg ICAgIGlzIGFwcGVuZGVkIGFsd2F5cyB0byBpdHMgRGlzcGxheUxpc3Qgd2hlbiBpdCBjYWxscyBm bHVzaERyYXdpbmdDb250ZXh0QXN5bmMoKQorICAgICAgICBhbmQgdGhpcyBpcyB3aHkgaXQgd2Fp dHMgdXAgdG8gMyBzZWNvbmRzIGZvciB0aGUgRGlkRmx1c2ggbWVzc2FnZS4gQnV0IHRoaXMKKyAg ICAgICAgZG9lcyBub3QgaGFwcGVuIGlmIHRoZSBEaXNwbGF5TGlzdCBvZiBSZW1vdGVJbWFnZUJ1 ZmZlclByb3h5IGlzIGVtcHR5LgorCisgICAgICAgIFdlIG5lZWQgdG8gbWFrZSBmbHVzaERyYXdp bmdDb250ZXh0QXN5bmMoKSBhcHBlbmQgdGhlIEZsdXNoQ29udGV4dCBpdGVtIAorICAgICAgICBh bHdheXMgc28gd2UgY2FuIGVuc3VyZSB0aGUgcGVuZGluZyBpdGVtcyBhcmUgcHJvY2Vzc2VkIGJ5 IEdQVVByb2Nlc3MgYW5kCisgICAgICAgIHRoZSBiYWNrZW5kIGNvbnRleHQgaXMgZmx1c2hlZC4g QWxzbyB3ZSBuZWVkIEdQVVByb2NlcyB0byBzZW5kIHRoZSBEaWRGdXNoCisgICAgICAgIG1lc3Nh Z2Ugb25jZSBpdCBmaW5pc2hlcyBzbyBmbHVzaERyYXdpbmdDb250ZXh0KCkgY2FuIHJldHVybiBl YXJseS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdlQnVm ZmVyUHJveHkuaDoKKwogMjAyMS0wNy0yOSAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5 QGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjc4ODc3KSBbQ29jb2FdIFdlYkF1 dGhuIHN0b3BwZWQgd29ya2luZyBmb3Igbm9uLVNhZmFyaSBicm93c2VycyAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJQ cm94eS5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVJbWFn ZUJ1ZmZlclByb3h5LmgKaW5kZXggYzY0ODc5ZGUwNDYwMTg0MTJkMWU2ZTk1YmEwZGJlMGE1MWI1 ZGQ5MC4uYjRhZjFmYmRmYTY5NDdmNzUzMTQyYjE5NGQ0MzViYTM4ZjI5MzNlNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVJbWFnZUJ1ZmZl clByb3h5LmgKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1v dGVJbWFnZUJ1ZmZlclByb3h5LmgKQEAgLTI2MCwxMSArMjYwLDggQEAgcHJvdGVjdGVkOgogICAg ICAgICBpZiAoVU5MSUtFTFkoIW1fcmVtb3RlUmVuZGVyaW5nQmFja2VuZFByb3h5KSkKICAgICAg ICAgICAgIHJldHVybjsKIAotICAgICAgICBpZiAoIW1fZHJhd2luZ0NvbnRleHQuZGlzcGxheUxp c3QoKS5pc0VtcHR5KCkpIHsKLSAgICAgICAgICAgIG1fc2VudEZsdXNoSWRlbnRpZmllciA9IFdl YkNvcmU6OkRpc3BsYXlMaXN0OjpGbHVzaElkZW50aWZpZXI6OmdlbmVyYXRlKCk7Ci0gICAgICAg ICAgICBtX2RyYXdpbmdDb250ZXh0LnJlY29yZGVyKCkuZmx1c2hDb250ZXh0KG1fc2VudEZsdXNo SWRlbnRpZmllcik7Ci0gICAgICAgIH0KLQorICAgICAgICBtX3NlbnRGbHVzaElkZW50aWZpZXIg PSBXZWJDb3JlOjpEaXNwbGF5TGlzdDo6Rmx1c2hJZGVudGlmaWVyOjpnZW5lcmF0ZSgpOworICAg ICAgICBtX2RyYXdpbmdDb250ZXh0LnJlY29yZGVyKCkuZmx1c2hDb250ZXh0KG1fc2VudEZsdXNo SWRlbnRpZmllcik7CiAgICAgICAgIG1fcmVtb3RlUmVuZGVyaW5nQmFja2VuZFByb3h5LT5zZW5k RGVmZXJyZWRXYWtldXBNZXNzYWdlSWZOZWVkZWQoKTsKICAgICAgICAgY2xlYXJEaXNwbGF5TGlz dCgpOwogICAgIH0K 434872 2021-08-03 17:18:44 -0700 2021-08-04 00:01:22 -0700 Patch bug-228673-20210803171844.patch text/plain 2193 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc0MjI0ZGRjODViYzNlOGNk NDdkM2MyMTFjZDc0ZTRlMDliNjgxMWIuLjIwNzY4NDIzNmIzNWFmYTFhYzY5ODE1MDA3NjcwNDAy OGRhM2VjMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjEtMDgtMDIgIFNhaWQgQWJv dS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0dQVVByb2Nlc3NdIFJFR1JF U1NJT046IEEgbm90aWNlYWJsZSBzbG93IGRvd24gd2hlbiBicm93c2luZyBMaXZlIFBob3RvcyBh bGJ1bSBvbiBpQ2xvdWQuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjg2NzMKKworICAgICAgICBSZXZpZXdlZCBieSBXZW5zb24gSHNpZWguCisK KyAgICAgICAgUmVtb3RlSW1hZ2VCdWZmZXJQcm94eTo6Zmx1c2hEcmF3aW5nQ29udGV4dCgpIGFz c3VtZXMgYSBGbHVzaENvbnRleHQgaXRlbQorICAgICAgICBpcyBhbHdheXMgYXBwZW5kZWQgdG8g aXRzIERpc3BsYXlMaXN0IHdoZW4gaXQgY2FsbHMgZmx1c2hEcmF3aW5nQ29udGV4dEFzeW5jKCkK KyAgICAgICAgYW5kIHRoaXMgaXMgd2h5IGl0IHdhaXRzIHVwIHRvIDMgc2Vjb25kcyBmb3IgdGhl IERpZEZsdXNoIG1lc3NhZ2UuIEJ1dCB0aGlzCisgICAgICAgIGRvZXMgbm90IGhhcHBlbiBpZiB0 aGUgRGlzcGxheUxpc3Qgb2YgUmVtb3RlSW1hZ2VCdWZmZXJQcm94eSBpcyBlbXB0eS4KKworICAg ICAgICBJbnN0ZWFkIG9mIGNoZWNraW5nIHdoZXRoZXIgdGhlIERpc3BsYXlMaXN0IGlzIGVtcHR5 LCB3ZSBjYW4gY2hlY2sgd2hldGhlcgorICAgICAgICB3ZSBkbyBub3QgaGF2ZSBwZW5kaW5nIGEg Rmx1c2hDb250ZXh0IGl0ZW0gYmVmb3JlIGFwcGVuZGluZyBhIG5ldyBvbmUuIFRoaXMKKyAgICAg ICAgd2lsbCBlbnN1cmUgdGhlIHBlbmRpbmcgaXRlbXMgYXJlIHByb2Nlc3NlZCBieSBHUFVQcm9j ZXNzIGFuZCB0aGUgYmFja2VuZAorICAgICAgICBjb250ZXh0IGlzIGZsdXNoZWQuIEFsc28gdGhp cyB3aWxsIGVuc3VyZSBHUFVQcm9jZXNzIHdpbGwgc2VuZCBEaWRGbHVzaAorICAgICAgICBtZXNz YWdlIG9uY2UgaXQgZmluaXNoZXMgc28gZmx1c2hEcmF3aW5nQ29udGV4dCgpIGNhbiByZXR1cm4g ZWFybHkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVJbWFnZUJ1 ZmZlclByb3h5Lmg6CisKIDIwMjEtMDgtMDIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUu Y29tPgogCiAgICAgICAgIEF0dHJpYnV0ZSBudyBjb25uZWN0aW9ucyB0byB0aGUgcGFnZSBidW5k bGUgaWRlbnRpZmllcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9n cmFwaGljcy9SZW1vdGVJbWFnZUJ1ZmZlclByb3h5LmggYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdlQnVmZmVyUHJveHkuaAppbmRleCBjNjQ4NzlkZTA0 NjAxODQxMmQxZTZlOTViYTBkYmUwYTUxYjVkZDkwLi45YjI0MDhiMzVlYzU4NmVhYWEwZjEyNzQ2 Y2U2ZDQ2MzRkNGFiN2I5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BV L2dyYXBoaWNzL1JlbW90ZUltYWdlQnVmZmVyUHJveHkuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdlQnVmZmVyUHJveHkuaApAQCAtMjYwLDcg KzI2MCw3IEBAIHByb3RlY3RlZDoKICAgICAgICAgaWYgKFVOTElLRUxZKCFtX3JlbW90ZVJlbmRl cmluZ0JhY2tlbmRQcm94eSkpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgaWYgKCFt X2RyYXdpbmdDb250ZXh0LmRpc3BsYXlMaXN0KCkuaXNFbXB0eSgpKSB7CisgICAgICAgIGlmICgh aGFzUGVuZGluZ0ZsdXNoKCkpIHsKICAgICAgICAgICAgIG1fc2VudEZsdXNoSWRlbnRpZmllciA9 IFdlYkNvcmU6OkRpc3BsYXlMaXN0OjpGbHVzaElkZW50aWZpZXI6OmdlbmVyYXRlKCk7CiAgICAg ICAgICAgICBtX2RyYXdpbmdDb250ZXh0LnJlY29yZGVyKCkuZmx1c2hDb250ZXh0KG1fc2VudEZs dXNoSWRlbnRpZmllcik7CiAgICAgICAgIH0K 434890 2021-08-04 00:01:24 -0700 2021-08-04 12:43:08 -0700 Patch bug-228673-20210804000123.patch text/plain 2039 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNTU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc0MjI0ZGRjODViYzNlOGNk NDdkM2MyMTFjZDc0ZTRlMDliNjgxMWIuLjczNjRkMzY4ZGZhZGQwNTE3OGY4MDljMmI1YThlNDQ0 NDhmZTNjOWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDgtMDMgIFNhaWQgQWJv dS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0dQVVByb2Nlc3NdIFJFR1JF U1NJT046IEEgbm90aWNlYWJsZSBzbG93IGRvd24gd2hlbiBicm93c2luZyBMaXZlIFBob3RvcyBh bGJ1bSBvbiBpQ2xvdWQuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjg2NzMKKyAgICAgICAgPHJkYXI6Ly84MTM1MzEzOD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdGVJbWFnZUJ1ZmZlclBy b3h5OjpmbHVzaERyYXdpbmdDb250ZXh0KCkgYXNzdW1lcyBhIEZsdXNoQ29udGV4dCBpdGVtCisg ICAgICAgIGlzIGFsd2F5cyBhcHBlbmRlZCB0byBpdHMgRGlzcGxheUxpc3Qgd2hlbiBpdCBjYWxs cyBmbHVzaERyYXdpbmdDb250ZXh0QXN5bmMoKQorICAgICAgICBhbmQgdGhpcyBpcyB3aHkgaXQg d2FpdHMgdXAgdG8gMyBzZWNvbmRzIGZvciB0aGUgRGlkRmx1c2ggbWVzc2FnZS4gQnV0IHRoaXMK KyAgICAgICAgZG9lcyBub3QgaGFwcGVuIGlmIHRoZSBEaXNwbGF5TGlzdCBvZiBSZW1vdGVJbWFn ZUJ1ZmZlclByb3h5IGlzIGVtcHR5LgorCisgICAgICAgIEluIGFkZGl0aW9uIHRvIGNoZWNraW5n IHdoZXRoZXIgdGhlIERpc3BsYXlMaXN0IGlzIGVtcHR5LCB3ZSBjYW4gY2hlY2sgYWxzbworICAg ICAgICB3aGV0aGVyIHdlIGRvIG5vdCBoYXZlIHBlbmRpbmcgYSBGbHVzaENvbnRleHQgaXRlbSBi ZWZvcmUgYXBwZW5kaW5nIGEgbmV3CisgICAgICAgIG9uZS4KKworICAgICAgICAqIFdlYlByb2Nl c3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdlQnVmZmVyUHJveHkuaDoKKwogMjAyMS0wOC0wMiAg WW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQXR0cmlidXRlIG53 IGNvbm5lY3Rpb25zIHRvIHRoZSBwYWdlIGJ1bmRsZSBpZGVudGlmaWVyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdlQnVmZmVyUHJv eHkuaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvUmVtb3RlSW1hZ2VC dWZmZXJQcm94eS5oCmluZGV4IGM2NDg3OWRlMDQ2MDE4NDEyZDFlNmU5NWJhMGRiZTBhNTFiNWRk OTAuLjZkOWJmODU5NjJmMDU0NWUyNDNiYTdkMTgxYTY1NTk4ODliMTJjZTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJQ cm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvUmVtb3Rl SW1hZ2VCdWZmZXJQcm94eS5oCkBAIC0yNjAsNyArMjYwLDcgQEAgcHJvdGVjdGVkOgogICAgICAg ICBpZiAoVU5MSUtFTFkoIW1fcmVtb3RlUmVuZGVyaW5nQmFja2VuZFByb3h5KSkKICAgICAgICAg ICAgIHJldHVybjsKIAotICAgICAgICBpZiAoIW1fZHJhd2luZ0NvbnRleHQuZGlzcGxheUxpc3Qo KS5pc0VtcHR5KCkpIHsKKyAgICAgICAgaWYgKCFtX2RyYXdpbmdDb250ZXh0LmRpc3BsYXlMaXN0 KCkuaXNFbXB0eSgpIHx8ICFoYXNQZW5kaW5nRmx1c2goKSkgewogICAgICAgICAgICAgbV9zZW50 Rmx1c2hJZGVudGlmaWVyID0gV2ViQ29yZTo6RGlzcGxheUxpc3Q6OkZsdXNoSWRlbnRpZmllcjo6 Z2VuZXJhdGUoKTsKICAgICAgICAgICAgIG1fZHJhd2luZ0NvbnRleHQucmVjb3JkZXIoKS5mbHVz aENvbnRleHQobV9zZW50Rmx1c2hJZGVudGlmaWVyKTsKICAgICAgICAgfQo=