228631 2021-07-30 00:14:07 -0700 RemoteAudioMediaStreamTrackRendererInternalUnit should handle changes of requested sampleCount 2021-07-31 09:52:55 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist glenn jer.noble philipj sergio simon.fraser webkit-bug-importer youennf oldest_to_newest 1780709 0 youennf 2021-07-30 00:14:07 -0700 RemoteAudioMediaStreamTrackRendererInternalUnit should handle changes of requested sampleCount 1780710 1 youennf 2021-07-30 00:18:07 -0700 <rdar://80690191> 1780711 2 434609 youennf 2021-07-30 00:25:48 -0700 Created attachment 434609 Patch 1780801 3 434609 eric.carlson 2021-07-30 08:32:15 -0700 Comment on attachment 434609 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434609&action=review > Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:182 > + uint64_t requestedSamplesCount = m_generateOffset; Nit: could be `auto` 1780815 4 434609 simon.fraser 2021-07-30 09:11:07 -0700 Comment on attachment 434609 Patch Can this be tested? 1780825 5 youennf 2021-07-30 09:43:55 -0700 (In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 434609 [details] > Patch > > Can this be tested? I tested it manually but there is no easy way to test it automatically. 1780827 6 434640 youennf 2021-07-30 09:48:26 -0700 Created attachment 434640 Patch for landing 1780886 7 simon.fraser 2021-07-30 10:56:38 -0700 (In reply to youenn fablet from comment #5) > (In reply to Simon Fraser (smfr) from comment #4) > > Comment on attachment 434609 [details] > > Patch > > > > Can this be tested? > > I tested it manually but there is no easy way to test it automatically. Can we file a bug to create a mechanism for testing this kind of audio stuff? 1781078 8 youennf 2021-07-31 09:49:32 -0700 (In reply to Simon Fraser (smfr) from comment #7) > (In reply to youenn fablet from comment #5) > > (In reply to Simon Fraser (smfr) from comment #4) > > > Comment on attachment 434609 [details] > > > Patch > > > > > > Can this be tested? > > > > I tested it manually but there is no easy way to test it automatically. > > Can we file a bug to create a mechanism for testing this kind of audio stuff? I filed https://bugs.webkit.org/show_bug.cgi?id=228680 1781080 9 ews-feeder 2021-07-31 09:52:52 -0700 Committed r280516 (240148@main): <https://commits.webkit.org/240148@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434640. 434609 2021-07-30 00:25:48 -0700 2021-07-30 09:48:22 -0700 Patch bug-228631-20210730092546.patch text/plain 3085 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM2ZTUwODVkMjRkOTI1ZDk0 NTk0ZTljM2I3MGZiOWQxODkxYTA4NWUuLmM3YmNkNGI2MzlhNWVjYzM2NmVhZmE2YTE4ZGU4ODA2 ODI4Mjc3ZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDctMzAgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW90ZUF1ZGlvTWVkaWFTdHJl YW1UcmFja1JlbmRlcmVySW50ZXJuYWxVbml0IHNob3VsZCBoYW5kbGUgY2hhbmdlcyBvZiByZXF1 ZXN0ZWQgc2FtcGxlQ291bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyODYzMQorICAgICAgICA8cmRhcjovLzgwNjkwMTkxPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSByZXF1ZXN0ZWQgbnVtYmVy IG9mIHNhbXBsZXMgbWlnaHQgY2hhbmdlIGluIGNhc2UgdGhlIG91dHB1dCBkZXZpY2UgY2hhbmdl cy4KKyAgICAgICAgV2hlbiBjaGFuZ2luZyBkZXZpY2UsIHdlIG1pZ2h0IGhhdmUgYSBnZW5lcmF0 ZWQgYnVmZmVyIG9mIDQwOTYgd2hpbGUgMTAyNCBzYW1wbGVzIGFyZSByZXF1ZXN0ZWQuCisgICAg ICAgIEZvciBlYWNoIDEwMjQgc2FtcGxlIGNodW5rLCB3ZSB3aWxsIHJlcXVlc3QgYSBidWZmZXIg b2YgNDA5Niwgd2hpY2ggY2Fubm90IGJlIHByb3ZpZGVkIGJ5IFdlYlByb2Nlc3MuCisgICAgICAg IFRvIHByZXZlbnQgdGhpcyBjYXNlLCB3ZSBrZWVwIHRyYWNrIG9mIGEgcmVxdWVzdGVkIHNhbXBs ZSBjb3VudCBvdmVyc2hvb3Qgc28gdGhhdCBuZXh0IHRpbWUgdGhlIHJlbmRlciBjYWxsYmFjayBp cyBjYWxsZWQsCisgICAgICAgIHdlIG1pZ2h0IG5vdCByZXF1ZXN0IHRvIGdlbmVyYXRlIGFub3Ro ZXIgY2h1bmsuCisKKyAgICAgICAgKiBHUFVQcm9jZXNzL3dlYnJ0Yy9SZW1vdGVBdWRpb01lZGlh U3RyZWFtVHJhY2tSZW5kZXJlckludGVybmFsVW5pdE1hbmFnZXIuY3BwOgorICAgICAgICAoV2Vi S2l0OjpSZW1vdGVBdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlckludGVybmFsVW5pdE1hbmFn ZXI6OlVuaXQ6OnN0YXJ0KToKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlQXVkaW9NZWRpYVN0cmVh bVRyYWNrUmVuZGVyZXJJbnRlcm5hbFVuaXRNYW5hZ2VyOjpVbml0OjpyZW5kZXIpOgorCiAyMDIx LTA3LTI4ICBKZWFuLVl2ZXMgQXZlbmFyZCAgPGp5YUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dl YkF1ZGlvXSBBZGQgd2VibS9vcHVzIGNvbnRhaW5lciBzdXBwb3J0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L0dQVVByb2Nlc3Mvd2VicnRjL1JlbW90ZUF1ZGlvTWVkaWFTdHJlYW1UcmFja1Jl bmRlcmVySW50ZXJuYWxVbml0TWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3Mv d2VicnRjL1JlbW90ZUF1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRlcmVySW50ZXJuYWxVbml0TWFu YWdlci5jcHAKaW5kZXggYjNjNTY3ODBkZmE1YmQ0YmUxNTY5M2M2Y2RjMTNlYjVlMmVkNDNmMS4u OGM1NzI5MzExOTgyM2I1MzlkZDk2NWU4OGRhMmU3NDgxNDVkODM1MiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9HUFVQcm9jZXNzL3dlYnJ0Yy9SZW1vdGVBdWRpb01lZGlhU3RyZWFtVHJhY2tS ZW5kZXJlckludGVybmFsVW5pdE1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvR1BVUHJv Y2Vzcy93ZWJydGMvUmVtb3RlQXVkaW9NZWRpYVN0cmVhbVRyYWNrUmVuZGVyZXJJbnRlcm5hbFVu aXRNYW5hZ2VyLmNwcApAQCAtNjUsNiArNjUsNyBAQCBwcml2YXRlOgogICAgIFJlZjxJUEM6OkNv bm5lY3Rpb24+IG1fY29ubmVjdGlvbjsKICAgICBVbmlxdWVSZWY8V2ViQ29yZTo6QXVkaW9NZWRp YVN0cmVhbVRyYWNrUmVuZGVyZXJJbnRlcm5hbFVuaXQ+IG1fbG9jYWxVbml0OwogICAgIHVpbnQ2 NF90IG1fcmVhZE9mZnNldCB7IDAgfTsKKyAgICB1aW50NjRfdCBtX2dlbmVyYXRlT2Zmc2V0IHsg MCB9OwogICAgIHVpbnQ2NF90IG1fZnJhbWVDaHVua1NpemUgeyAwIH07CiAgICAgSVBDOjpTZW1h cGhvcmUgbV9yZW5kZXJTZW1hcGhvcmU7CiAjaWYgUExBVEZPUk0oQ09DT0EpCkBAIC0xNDksNiAr MTUwLDcgQEAgdm9pZCBSZW1vdGVBdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlckludGVybmFs VW5pdE1hbmFnZXI6OlVuaXQ6OnN0YXJ0KGNvbnN0IFMKICAgICAgICAgc3RvcCgpOwogCiAgICAg bV9yZWFkT2Zmc2V0ID0gMDsKKyAgICBtX2dlbmVyYXRlT2Zmc2V0ID0gMDsKICAgICBtX2lzUGxh eWluZyA9IHRydWU7CiAgICAgbV9yaW5nQnVmZmVyID0gV2ViQ29yZTo6Q0FSaW5nQnVmZmVyOjph ZG9wdFN0b3JhZ2UobWFrZVVuaXF1ZVJlZjxSZWFkT25seVNoYXJlZFJpbmdCdWZmZXJTdG9yYWdl PihoYW5kbGUpLCBkZXNjcmlwdGlvbiwgbnVtYmVyT2ZGcmFtZXMpLm1vdmVUb1VuaXF1ZVB0cigp OwogICAgIG1fcmVuZGVyU2VtYXBob3JlID0gV1RGTW92ZShzZW1hcGhvcmUpOwpAQCAtMTc3LDgg KzE3OSwxMCBAQCBPU1N0YXR1cyBSZW1vdGVBdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlcklu dGVybmFsVW5pdE1hbmFnZXI6OlVuaXQ6OnJlbmRlcihzaQogICAgICAgICBzdGF0dXMgPSBub0Vy cjsKICAgICB9CiAKLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgc2FtcGxlQ291bnQ7IGkg Kz0gbV9mcmFtZUNodW5rU2l6ZSkKKyAgICB1aW50NjRfdCByZXF1ZXN0ZWRTYW1wbGVzQ291bnQg PSBtX2dlbmVyYXRlT2Zmc2V0OworICAgIGZvciAoOyByZXF1ZXN0ZWRTYW1wbGVzQ291bnQgPCBz YW1wbGVDb3VudDsgcmVxdWVzdGVkU2FtcGxlc0NvdW50ICs9IG1fZnJhbWVDaHVua1NpemUpCiAg ICAgICAgIG1fcmVuZGVyU2VtYXBob3JlLnNpZ25hbCgpOworICAgIG1fZ2VuZXJhdGVPZmZzZXQg PSByZXF1ZXN0ZWRTYW1wbGVzQ291bnQgLSBzYW1wbGVDb3VudDsKIAogICAgIHJldHVybiBzdGF0 dXM7CiB9Cg== 434640 2021-07-30 09:48:26 -0700 2021-07-31 09:52:53 -0700 Patch for landing bug-228631-20210730184824.patch text/plain 3086 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYxN2JmM2U0ZWIzZTYzZDdl MjdkNDAzY2E5YzMxYjM0YTg2MzZiYjEuLjhmZDI1N2Q4OWM0MTY4ODBkZDU5ZmJjNzljNDc2NTQz YWUyODY4OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDctMzAgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW90ZUF1ZGlvTWVkaWFTdHJl YW1UcmFja1JlbmRlcmVySW50ZXJuYWxVbml0IHNob3VsZCBoYW5kbGUgY2hhbmdlcyBvZiByZXF1 ZXN0ZWQgc2FtcGxlQ291bnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyODYzMQorICAgICAgICA8cmRhcjovLzgwNjkwMTkxPgorCisgICAgICAgIFJl dmlld2VkIGJ5IEVyaWMgQ2FybHNvbi4KKworICAgICAgICBUaGUgcmVxdWVzdGVkIG51bWJlciBv ZiBzYW1wbGVzIG1pZ2h0IGNoYW5nZSBpbiBjYXNlIHRoZSBvdXRwdXQgZGV2aWNlIGNoYW5nZXMu CisgICAgICAgIFdoZW4gY2hhbmdpbmcgZGV2aWNlLCB3ZSBtaWdodCBoYXZlIGEgZ2VuZXJhdGVk IGJ1ZmZlciBvZiA0MDk2IHdoaWxlIDEwMjQgc2FtcGxlcyBhcmUgcmVxdWVzdGVkLgorICAgICAg ICBGb3IgZWFjaCAxMDI0IHNhbXBsZSBjaHVuaywgd2Ugd2lsbCByZXF1ZXN0IGEgYnVmZmVyIG9m IDQwOTYsIHdoaWNoIGNhbm5vdCBiZSBwcm92aWRlZCBieSBXZWJQcm9jZXNzLgorICAgICAgICBU byBwcmV2ZW50IHRoaXMgY2FzZSwgd2Uga2VlcCB0cmFjayBvZiBhIHJlcXVlc3RlZCBzYW1wbGUg Y291bnQgb3ZlcnNob290IHNvIHRoYXQgbmV4dCB0aW1lIHRoZSByZW5kZXIgY2FsbGJhY2sgaXMg Y2FsbGVkLAorICAgICAgICB3ZSBtaWdodCBub3QgcmVxdWVzdCB0byBnZW5lcmF0ZSBhbm90aGVy IGNodW5rLgorCisgICAgICAgICogR1BVUHJvY2Vzcy93ZWJydGMvUmVtb3RlQXVkaW9NZWRpYVN0 cmVhbVRyYWNrUmVuZGVyZXJJbnRlcm5hbFVuaXRNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYktp dDo6UmVtb3RlQXVkaW9NZWRpYVN0cmVhbVRyYWNrUmVuZGVyZXJJbnRlcm5hbFVuaXRNYW5hZ2Vy OjpVbml0OjpzdGFydCk6CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZUF1ZGlvTWVkaWFTdHJlYW1U cmFja1JlbmRlcmVySW50ZXJuYWxVbml0TWFuYWdlcjo6VW5pdDo6cmVuZGVyKToKKwogMjAyMS0w Ny0zMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQXR0cmli dXRlIG53IGNvbm5lY3Rpb25zIHRvIHRoZSBzb3VyY2UgYXBwbGljYXRpb24KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy93ZWJydGMvUmVtb3RlQXVkaW9NZWRpYVN0cmVhbVRy YWNrUmVuZGVyZXJJbnRlcm5hbFVuaXRNYW5hZ2VyLmNwcCBiL1NvdXJjZS9XZWJLaXQvR1BVUHJv Y2Vzcy93ZWJydGMvUmVtb3RlQXVkaW9NZWRpYVN0cmVhbVRyYWNrUmVuZGVyZXJJbnRlcm5hbFVu aXRNYW5hZ2VyLmNwcAppbmRleCBiM2M1Njc4MGRmYTViZDRiZTE1NjkzYzZjZGMxM2ViNWUyZWQ0 M2YxLi4xNmI2MGE3YWExNDZmNjE5YmI1MTNiOTk4OTVmYzgwYjAwNzAwODJhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3Mvd2VicnRjL1JlbW90ZUF1ZGlvTWVkaWFTdHJlYW1U cmFja1JlbmRlcmVySW50ZXJuYWxVbml0TWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9H UFVQcm9jZXNzL3dlYnJ0Yy9SZW1vdGVBdWRpb01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlckludGVy bmFsVW5pdE1hbmFnZXIuY3BwCkBAIC02NSw2ICs2NSw3IEBAIHByaXZhdGU6CiAgICAgUmVmPElQ Qzo6Q29ubmVjdGlvbj4gbV9jb25uZWN0aW9uOwogICAgIFVuaXF1ZVJlZjxXZWJDb3JlOjpBdWRp b01lZGlhU3RyZWFtVHJhY2tSZW5kZXJlckludGVybmFsVW5pdD4gbV9sb2NhbFVuaXQ7CiAgICAg dWludDY0X3QgbV9yZWFkT2Zmc2V0IHsgMCB9OworICAgIHVpbnQ2NF90IG1fZ2VuZXJhdGVPZmZz ZXQgeyAwIH07CiAgICAgdWludDY0X3QgbV9mcmFtZUNodW5rU2l6ZSB7IDAgfTsKICAgICBJUEM6 OlNlbWFwaG9yZSBtX3JlbmRlclNlbWFwaG9yZTsKICNpZiBQTEFURk9STShDT0NPQSkKQEAgLTE0 OSw2ICsxNTAsNyBAQCB2b2lkIFJlbW90ZUF1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRlcmVySW50 ZXJuYWxVbml0TWFuYWdlcjo6VW5pdDo6c3RhcnQoY29uc3QgUwogICAgICAgICBzdG9wKCk7CiAK ICAgICBtX3JlYWRPZmZzZXQgPSAwOworICAgIG1fZ2VuZXJhdGVPZmZzZXQgPSAwOwogICAgIG1f aXNQbGF5aW5nID0gdHJ1ZTsKICAgICBtX3JpbmdCdWZmZXIgPSBXZWJDb3JlOjpDQVJpbmdCdWZm ZXI6OmFkb3B0U3RvcmFnZShtYWtlVW5pcXVlUmVmPFJlYWRPbmx5U2hhcmVkUmluZ0J1ZmZlclN0 b3JhZ2U+KGhhbmRsZSksIGRlc2NyaXB0aW9uLCBudW1iZXJPZkZyYW1lcykubW92ZVRvVW5pcXVl UHRyKCk7CiAgICAgbV9yZW5kZXJTZW1hcGhvcmUgPSBXVEZNb3ZlKHNlbWFwaG9yZSk7CkBAIC0x NzcsOCArMTc5LDEwIEBAIE9TU3RhdHVzIFJlbW90ZUF1ZGlvTWVkaWFTdHJlYW1UcmFja1JlbmRl cmVySW50ZXJuYWxVbml0TWFuYWdlcjo6VW5pdDo6cmVuZGVyKHNpCiAgICAgICAgIHN0YXR1cyA9 IG5vRXJyOwogICAgIH0KIAotICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBzYW1wbGVDb3Vu dDsgaSArPSBtX2ZyYW1lQ2h1bmtTaXplKQorICAgIGF1dG8gcmVxdWVzdGVkU2FtcGxlc0NvdW50 ID0gbV9nZW5lcmF0ZU9mZnNldDsKKyAgICBmb3IgKDsgcmVxdWVzdGVkU2FtcGxlc0NvdW50IDwg c2FtcGxlQ291bnQ7IHJlcXVlc3RlZFNhbXBsZXNDb3VudCArPSBtX2ZyYW1lQ2h1bmtTaXplKQog ICAgICAgICBtX3JlbmRlclNlbWFwaG9yZS5zaWduYWwoKTsKKyAgICBtX2dlbmVyYXRlT2Zmc2V0 ID0gcmVxdWVzdGVkU2FtcGxlc0NvdW50IC0gc2FtcGxlQ291bnQ7CiAKICAgICByZXR1cm4gc3Rh dHVzOwogfQo=