228629 2021-07-29 18:13:43 -0700 [WPE][GTK] build broken with python2 after r280382 2021-07-29 19:58:05 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=228290 https://bugs.webkit.org/show_bug.cgi?id=228628 P2 Normal --- 1 clopez clopez annulen aperez cgarcia don.olmstead ews-watchlist gyuyoung.kim keith_miller mark.lam mcatanzaro msaboff pnormand ryuan.choi saam sergio tzagallo oldest_to_newest 1780668 0 clopez 2021-07-29 18:13:43 -0700 Before r280382 it was possible to build webkit with python2 If we want to make python3 mandatory for building we should do that at the CMake level by raising the minimum version But we should not call python3 directly, but ${PYTHON_EXECUTABLE} instead 1780669 1 434597 clopez 2021-07-29 18:19:47 -0700 Created attachment 434597 Patch 1780683 2 434597 pnormand 2021-07-29 19:39:58 -0700 Comment on attachment 434597 Patch Sorry about this, somehow I thought we were defaulting to Python3. Python2 has been EOL for a while now :) 1780684 3 ews-feeder 2021-07-29 19:58:01 -0700 Committed r280466 (240101@main): <https://commits.webkit.org/240101@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434597. 434597 2021-07-29 18:19:47 -0700 2021-07-29 19:58:03 -0700 Patch bug-228629-20210730021931.patch text/plain 6124 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 NThiYWZjMTEzNjViODYzOGIwMzkwNzllMWE2Zjg3MzI3NmY5NThmLi5lNjM0YTY1YjUzNzllZmRm OWQ1MTEwYWNiYjkwNTJjNmJhNDcyOWYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAyMS0wNy0yOSAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9w ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtHVEtdIGJ1aWxkIGJyb2tlbiB3aXRoIHB5 dGhvbjIgYWZ0ZXIgcjI4MDM4MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjI4NjI5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2FsbCB7UFlUSE9OX0VYRUNVVEFCTEV9IGluc3RlYWQgb2YgcHl0aG9uMy4K KworICAgICAgICAqIFBsYXRmb3JtR1RLLmNtYWtlOgorCiAyMDIxLTA3LTI5ICBNeWxlcyBDLiBN YXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIFdlYkdQVSB0byB3 ZWJraXQub3JnL3N0YXR1cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCBlYTM3NzYzYjkyOTE0ZjliOWMzOTZjMzdiMjE2 ZjJlZTMzOWIyMjlhLi5jNmQ3M2Y5YjFiNzk2ODc4MzUwNjZhMmE5NzZlMzY2OGJmMGY1ZDY0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTA3LTI5ICBDYXJsb3MgQWxiZXJ0byBMb3Bl eiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10gYnVpbGQg YnJva2VuIHdpdGggcHl0aG9uMiBhZnRlciByMjgwMzgyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg2MjkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWxsIHtQWVRIT05fRVhFQ1VUQUJMRX0gaW5zdGVh ZCBvZiBweXRob24zLiBPdXIgYnVpbGQgY3VycmVudGx5CisgICAgICAgIHN1cHBvcnRzIGJvdGgg dmVyc2lvbnMgb2YgcHl0aG9uICgyIGFuZCAzKS4gSWYgdGhlIHVzZXIgd2FudHMKKyAgICAgICAg dG8gZm9yY2UgYSBzcGVjaWZpYyB2ZXJzaW9uIGl0IGNhbiBkbyB0aGF0IHZpYSB0aGUgQ01ha2Ug YXJndW1lbnQKKyAgICAgICAgLURQWVRIT05fRVhFQ1VUQUJMRT0vcGF0aC90by9weXRob24vaW50 ZXJwcmV0ZXIKKworICAgICAgICBObyBuZXcgdGVzdHMsIGlzIGEgYnVpbGQgZml4LgorCisgICAg ICAgICogUGxhdGZvcm1HVEsuY21ha2U6CisgICAgICAgICogUGxhdGZvcm1XUEUuY21ha2U6CisK IDIwMjEtMDctMjkgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAg IFtQYXltZW50IFJlcXVlc3RdIGBhZGRpdGlvbmFsU2hpcHBpbmdNZXRob2RzYCBhcmUgbm90IHVz ZWQgaWYgYSBgcGF5bWVudE1ldGhvZFR5cGVgIGlzIHByb3ZpZGVkCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1HVEsuY21ha2UgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvUGxhdGZvcm1HVEsuY21ha2UKaW5kZXggODFlN2Y5MzlhNWU0YTAxNGY3M2IwOGUwNGI0ZGE2 MzFiODJhMmY0Ni4uNjAzYTAyMGM4OGM1ZWRmN2UwNTQwOTBiZTRhOGY0NTU0ZjQ2NmZjZSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtNiw3ICs2LDcgQEAgc2V0 KEphdmFTY3JpcHRDb3JlX09VVFBVVF9OQU1FIGphdmFzY3JpcHRjb3JlZ3RrLSR7V0VCS0lUR1RL X0FQSV9WRVJTSU9OfSkKIGlmIChFWElTVFMgIiR7VE9PTFNfRElSfS9nbGliL2FwcGx5LWJ1aWxk LXJldmlzaW9uLXRvLWZpbGVzLnB5IikKICAgICBjb25maWd1cmVfZmlsZShqYXZhc2NyaXB0Y29y ZWd0ay5wYy5pbiAke0phdmFTY3JpcHRDb3JlX1BLR0NPTkZJR19GSUxFfSBAT05MWSkKICAgICBh ZGRfY3VzdG9tX3RhcmdldChKYXZhU2NyaXB0Q29yZS1idWlsZC1yZXZpc2lvbgotICAgICAgICBw eXRob24zICIke1RPT0xTX0RJUn0vZ2xpYi9hcHBseS1idWlsZC1yZXZpc2lvbi10by1maWxlcy5w eSIgJHtKYXZhU2NyaXB0Q29yZV9QS0dDT05GSUdfRklMRX0KKyAgICAgICAgJHtQWVRIT05fRVhF Q1VUQUJMRX0gIiR7VE9PTFNfRElSfS9nbGliL2FwcGx5LWJ1aWxkLXJldmlzaW9uLXRvLWZpbGVz LnB5IiAke0phdmFTY3JpcHRDb3JlX1BLR0NPTkZJR19GSUxFfQogICAgICAgICBERVBFTkRTICR7 SmF2YVNjcmlwdENvcmVfUEtHQ09ORklHX0ZJTEV9CiAgICAgICAgIFdPUktJTkdfRElSRUNUT1JZ ICR7Q01BS0VfU09VUkNFX0RJUn0gVkVSQkFUSU0pCiAgICAgbGlzdChBUFBFTkQgSmF2YVNjcmlw dENvcmVfREVQRU5ERU5DSUVTCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RL LmNtYWtlIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCAyZGM1MDk1ZmM0 YjJjNjNjYTIyMTEzNGFkYmJiM2EyYmZmYzAwYTZmLi40OGFiN2MzYTM1MjNhMmJlNjA3NzY2NGVm NjVlNmVjMzBmMTQ2OTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtR1RLLmNt YWtlCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1HVEsuY21ha2UKQEAgLTE3LDcgKzE3LDcg QEAgaWYgKEVYSVNUUyAiJHtUT09MU19ESVJ9L2dsaWIvYXBwbHktYnVpbGQtcmV2aXNpb24tdG8t ZmlsZXMucHkiKQogICAgIGNvbmZpZ3VyZV9maWxlKGd0ay93ZWJraXQyZ3RrLXdlYi1leHRlbnNp b24ucGMuaW4gJHtXZWJLaXQyV2ViRXh0ZW5zaW9uX1BLR0NPTkZJR19GSUxFfSBAT05MWSkKICAg ICBjb25maWd1cmVfZmlsZShTaGFyZWQvZ2xpYi9CdWlsZFJldmlzaW9uLmguaW4gJHtXZWJLaXQy R3RrX0ZSQU1FV09SS19IRUFERVJTX0RJUn0vQnVpbGRSZXZpc2lvbi5oIEBPTkxZKQogICAgIGFk ZF9jdXN0b21fdGFyZ2V0KFdlYktpdC1idWlsZC1yZXZpc2lvbgotICAgICAgICBweXRob24zICIk e1RPT0xTX0RJUn0vZ2xpYi9hcHBseS1idWlsZC1yZXZpc2lvbi10by1maWxlcy5weSIgJHtXZWJL aXQyR3RrX0ZSQU1FV09SS19IRUFERVJTX0RJUn0vQnVpbGRSZXZpc2lvbi5oICR7V2ViS2l0Ml9Q S0dDT05GSUdfRklMRX0gJHtXZWJLaXQyV2ViRXh0ZW5zaW9uX1BLR0NPTkZJR19GSUxFfQorICAg ICAgICAke1BZVEhPTl9FWEVDVVRBQkxFfSAiJHtUT09MU19ESVJ9L2dsaWIvYXBwbHktYnVpbGQt cmV2aXNpb24tdG8tZmlsZXMucHkiICR7V2ViS2l0Mkd0a19GUkFNRVdPUktfSEVBREVSU19ESVJ9 L0J1aWxkUmV2aXNpb24uaCAke1dlYktpdDJfUEtHQ09ORklHX0ZJTEV9ICR7V2ViS2l0MldlYkV4 dGVuc2lvbl9QS0dDT05GSUdfRklMRX0KICAgICAgICAgREVQRU5EUyAke1dlYktpdDJHdGtfRlJB TUVXT1JLX0hFQURFUlNfRElSfS9CdWlsZFJldmlzaW9uLmggJHtXZWJLaXQyX1BLR0NPTkZJR19G SUxFfSAke1dlYktpdDJXZWJFeHRlbnNpb25fUEtHQ09ORklHX0ZJTEV9CiAgICAgICAgIFdPUktJ TkdfRElSRUNUT1JZICR7Q01BS0VfU09VUkNFX0RJUn0gVkVSQkFUSU0pCiAgICAgbGlzdChBUFBF TkQgV2ViS2l0X0RFUEVOREVOQ0lFUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9QbGF0Zm9y bVdQRS5jbWFrZSBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XUEUuY21ha2UKaW5kZXggMTI5ZDdk NDhjMGE3N2I5MGFmMjgwNWM2YzkyZjA1Zjk3MTE3NzdmMS4uNWRmMmZlMWIxMTY4ODA2ZjgzYzVi NGNiNTY2YWY3OTQzZmIxNjg4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybVdQ RS5jbWFrZQorKysgYi9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtV1BFLmNtYWtlCkBAIC0yMSw3ICsy MSw3IEBAIGNvbmZpZ3VyZV9maWxlKHdwZS93cGUtd2ViLWV4dGVuc2lvbi11bmluc3RhbGxlZC5w Yy5pbiAke0NNQUtFX0JJTkFSWV9ESVJ9L3dwZS13CiBpZiAoRVhJU1RTICIke1RPT0xTX0RJUn0v Z2xpYi9hcHBseS1idWlsZC1yZXZpc2lvbi10by1maWxlcy5weSIpCiAgICAgY29uZmlndXJlX2Zp bGUoU2hhcmVkL2dsaWIvQnVpbGRSZXZpc2lvbi5oLmluICR7Rk9SV0FSRElOR19IRUFERVJTX1dQ RV9ESVJ9L0J1aWxkUmV2aXNpb24uaCBAT05MWSkKICAgICBhZGRfY3VzdG9tX3RhcmdldChXZWJL aXQtYnVpbGQtcmV2aXNpb24KLSAgICAgICAgcHl0aG9uMyAiJHtUT09MU19ESVJ9L2dsaWIvYXBw bHktYnVpbGQtcmV2aXNpb24tdG8tZmlsZXMucHkiICR7Rk9SV0FSRElOR19IRUFERVJTX1dQRV9E SVJ9L0J1aWxkUmV2aXNpb24uaAorICAgICAgICAke1BZVEhPTl9FWEVDVVRBQkxFfSAiJHtUT09M U19ESVJ9L2dsaWIvYXBwbHktYnVpbGQtcmV2aXNpb24tdG8tZmlsZXMucHkiICR7Rk9SV0FSRElO R19IRUFERVJTX1dQRV9ESVJ9L0J1aWxkUmV2aXNpb24uaAogICAgICAgICBERVBFTkRTICR7Rk9S V0FSRElOR19IRUFERVJTX1dQRV9ESVJ9L0J1aWxkUmV2aXNpb24uaAogICAgICAgICBXT1JLSU5H X0RJUkVDVE9SWSAke0NNQUtFX1NPVVJDRV9ESVJ9IFZFUkJBVElNKQogICAgIGxpc3QoQVBQRU5E IFdlYktpdF9ERVBFTkRFTkNJRVMKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xz L0NoYW5nZUxvZwppbmRleCA2M2IxNGM2YmNmMjA1ZmY0NDk5NGYwODJiOTk0M2E1NjY4M2JiNDc4 Li4xZGI5ZDZkOTcxY2IyM2E3OGM3NTAwOTRjYjdkNjY4MzJiOTJkODRmIDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MjEtMDctMjkgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+ CisKKyAgICAgICAgW1dQRV1bR1RLXSBidWlsZCBicm9rZW4gd2l0aCBweXRob24yIGFmdGVyIHIy ODAzODIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy ODYyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZp eCBjb21wYXRpYmlsaXR5IHdpdGggcHl0aG9uMi4KKworICAgICAgICAqIGdsaWIvYXBwbHktYnVp bGQtcmV2aXNpb24tdG8tZmlsZXMucHk6CisgICAgICAgIChtYWluKToKKwogMjAyMS0wNy0yOSAg Sm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgW2dpdC13ZWJr aXRdIEhhbmRsZSByZWxhdGl2ZSBwYXRocyBpbiBmaWx0ZXJlZCBjb21tYW5kcwpkaWZmIC0tZ2l0 IGEvVG9vbHMvZ2xpYi9hcHBseS1idWlsZC1yZXZpc2lvbi10by1maWxlcy5weSBiL1Rvb2xzL2ds aWIvYXBwbHktYnVpbGQtcmV2aXNpb24tdG8tZmlsZXMucHkKaW5kZXggMjYzMjk5ZWM2OWJjOTUy ZDhkODNhODA2MmNiMjVmNWNkMjc5YTQ1OC4uMjE5NTJlNTI5NmU2ODIyNDUwNDI2ZTdlNjJiZDM0 MjdmNjE5NmFiNSAxMDA2NDQKLS0tIGEvVG9vbHMvZ2xpYi9hcHBseS1idWlsZC1yZXZpc2lvbi10 by1maWxlcy5weQorKysgYi9Ub29scy9nbGliL2FwcGx5LWJ1aWxkLXJldmlzaW9uLXRvLWZpbGVz LnB5CkBAIC0zMCw3ICszMCw3IEBAIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5maWxlc3lz dGVtIGltcG9ydCBGaWxlU3lzdGVtICAjIG5vcGVwOAogZGVmIG1haW4oYXJncyk6CiAgICAgc2Nt ID0gU0NNRGV0ZWN0b3IoRmlsZVN5c3RlbSgpLCBFeGVjdXRpdmUoKSkuZGVmYXVsdF9zY20oKQog ICAgIHN2bl9yZXZpc2lvbiA9IHNjbS5oZWFkX3N2bl9yZXZpc2lvbigpCi0gICAgYnVpbGRfcmV2 aXNpb24gPSBmInJ7c3ZuX3JldmlzaW9ufSIKKyAgICBidWlsZF9yZXZpc2lvbiA9ICJye30iLmZv cm1hdChzdm5fcmV2aXNpb24pCiAKICAgICBmb3IgaW5fZmlsZSBpbiBhcmdzOgogICAgICAgICB3 aXRoIG9wZW4oaW5fZmlsZSkgYXMgZmQ6Cg==