228621 2021-07-29 16:40:03 -0700 [git-webkit] Forward errors from log and blame 2021-07-30 10:46:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=228619 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain webkit-bug-importer oldest_to_newest 1780633 0 jbedard 2021-07-29 16:40:03 -0700 We should forward errors from `git/svn log/blame` commands. 1780634 1 webkit-bug-importer 2021-07-29 16:40:17 -0700 <rdar://problem/81297642> 1780791 2 434628 jbedard 2021-07-30 08:23:25 -0700 Created attachment 434628 Patch 1780813 3 434628 aakash_jain 2021-07-30 08:58:21 -0700 Comment on attachment 434628 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434628&action=review rs=me > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:258 > + if not log_output.returncode: Might be more clear to explicitly compare with 0 > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:260 > + sys.stderr.write(line) why not print? Also, can you avoid this for loop and directly print whole thing in a single statement? 1780834 4 jbedard 2021-07-30 10:02:00 -0700 (In reply to Aakash Jain from comment #3) > Comment on attachment 434628 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434628&action=review > > rs=me > > > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:258 > > + if not log_output.returncode: > > Might be more clear to explicitly compare with 0 It might be 'None', particularly for `git log` or `svn log` > > > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:260 > > + sys.stderr.write(line) > > why not print? Also, can you avoid this for loop and directly print whole > thing in a single statement? 1780837 5 434643 jbedard 2021-07-30 10:15:06 -0700 Created attachment 434643 Patch for landing 1780881 6 ews-feeder 2021-07-30 10:46:45 -0700 Committed r280483 (240118@main): <https://commits.webkit.org/240118@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434643. 434628 2021-07-30 08:23:25 -0700 2021-07-30 10:15:04 -0700 Patch bug-228621-20210730082324.patch text/plain 2858 jbedard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNDU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjNiMTRjNmJjZjIwNWZmNDQ5OTRmMDgyYjk5NDNhNTY2 ODNiYjQ3OC4uZjQzMjc2OWM3Y2M0NDc1Yzk1ZjEyNjgzYzZjYWMzYjFjNzY4ZjRmNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTA3LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKwor ICAgICAgICBbZ2l0LXdlYmtpdF0gRm9yd2FyZCBlcnJvcnMgZnJvbSBsb2cgYW5kIGJsYW1lCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg2MjEKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgxMjk3NjQyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkv c2V0dXAucHk6IEJ1bXAgdmVyc2lvbi4KKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJr aXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weTogRGl0dG8uCisgICAgICAgICogU2NyaXB0 cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvcHJvZ3JhbS9jb21tYW5kLnB5Ogor ICAgICAgICAoRmlsdGVyZWRDb21tYW5kLm1haW4pOiBJZiB0aGUgZXhpdCBjb2RlIGlzIG5vbi16 ZXJvLCBwcmludCBhbGwgZXJyb3JzLgorCiAyMDIxLTA3LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBbZ2l0LXdlYmtpdF0gSGFuZGxlIHJlbGF0aXZl IHBhdGhzIGluIGZpbHRlcmVkIGNvbW1hbmRzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2xp YnJhcmllcy93ZWJraXRzY21weS9zZXR1cC5weSBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dl YmtpdHNjbXB5L3NldHVwLnB5CmluZGV4IDE1YTZiZmVkMDE0YWI5ODUzNWY0NDM1MDRiYWVjMzJi YjI5MzlhOTEuLjc4MTdlYTY0OTExZmE1ZDg1OWE5ZGVlMWI0YWM1NzU0ODkyZTQzOWUgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3NldHVwLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3NldHVwLnB5CkBAIC0yOSw3ICsy OSw3IEBAIGRlZiByZWFkbWUoKToKIAogc2V0dXAoCiAgICAgbmFtZT0nd2Via2l0c2NtcHknLAot ICAgIHZlcnNpb249JzEuMC4yJywKKyAgICB2ZXJzaW9uPScxLjAuMycsCiAgICAgZGVzY3JpcHRp b249J0xpYnJhcnkgZGVzaWduZWQgdG8gaW50ZXJhY3Qgd2l0aCBnaXQgYW5kIHN2biByZXBvc2l0 b3JpZXMuJywKICAgICBsb25nX2Rlc2NyaXB0aW9uPXJlYWRtZSgpLAogICAgIGNsYXNzaWZpZXJz PVsKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtp dHNjbXB5L19faW5pdF9fLnB5IGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkv d2Via2l0c2NtcHkvX19pbml0X18ucHkKaW5kZXggNTBjYjIxMzdkYzFiNzYxZTcwMWNjYjZhYTQz YzdlODUxZWMxZDQyMy4uZjE5M2ZlYzRjOTAxY2IzNDBkMmU5ODFlZjBjZTdlMWIxM2QxN2JiZSAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2Nt cHkvX19pbml0X18ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkv d2Via2l0c2NtcHkvX19pbml0X18ucHkKQEAgLTQ2LDcgKzQ2LDcgQEAgZXhjZXB0IEltcG9ydEVy cm9yOgogICAgICAgICAiUGxlYXNlIGluc3RhbGwgd2Via2l0Y29yZXB5IHdpdGggYHBpcCBpbnN0 YWxsIHdlYmtpdGNvcmVweSAtLWV4dHJhLWluZGV4LXVybCA8cGFja2FnZSBpbmRleCBVUkw+YCIK ICAgICApCiAKLXZlcnNpb24gPSBWZXJzaW9uKDEsIDAsIDIpCit2ZXJzaW9uID0gVmVyc2lvbigx LCAwLCAzKQogCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdmYXN0ZW5lcnMnLCBWZXJz aW9uKDAsIDE1LCAwKSkpCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdtb25vdG9uaWMn LCBWZXJzaW9uKDEsIDUpKSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dl YmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Byb2dyYW0vY29tbWFuZC5weSBiL1Rvb2xzL1NjcmlwdHMv bGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Byb2dyYW0vY29tbWFuZC5weQppbmRl eCA1MTU2OWEzYzVjZWNkNTNkYjUwYjdhNmFlOTY5NDQ2NGEzOTk0ZTY5Li5hMGNmMzMzM2ZkMGE0 ZDY2NDg5MDViMDFhNjgxZDc2N2RjM2ZkNGMzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL2xp YnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9wcm9ncmFtL2NvbW1hbmQucHkKKysrIGIv VG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvcHJvZ3JhbS9j b21tYW5kLnB5CkBAIC0yNTUsNSArMjU1LDggQEAgY2xhc3MgRmlsdGVyZWRDb21tYW5kKG9iamVj dCk6CiAgICAgICAgICAgICAgICAgbGluZSA9IGxvZ19vdXRwdXQuc3Rkb3V0LnJlYWRsaW5lKCkK IAogICAgICAgICBmaW5hbGx5OgorICAgICAgICAgICAgaWYgbm90IGxvZ19vdXRwdXQucmV0dXJu Y29kZToKKyAgICAgICAgICAgICAgICBmb3IgbGluZSBpbiBsb2dfb3V0cHV0LnN0ZGVyci5yZWFk bGluZXMoKToKKyAgICAgICAgICAgICAgICAgICAgc3lzLnN0ZGVyci53cml0ZShsaW5lKQogICAg ICAgICAgICAgbG9nX291dHB1dC5raWxsKCkKICAgICAgICAgcmV0dXJuIGxvZ19vdXRwdXQucmV0 dXJuY29kZQo= 434643 2021-07-30 10:15:06 -0700 2021-07-30 10:46:46 -0700 Patch for landing bug-228621-20210730101505.patch text/plain 2564 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4MDQ3OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTA3LTMwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbZ2l0LXdlYmtpdF0gRm9yd2FyZCBlcnJvcnMgZnJvbSBsb2cgYW5kIGJs YW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg2 MjEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgxMjk3NjQyPgorCisgICAgICAgIFJ1YmJlci1z dGFtcGVkIGJ5IEFha2FzaCBKYWluLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Vi a2l0c2NtcHkvc2V0dXAucHk6IEJ1bXAgdmVyc2lvbi4KKyAgICAgICAgKiBTY3JpcHRzL2xpYnJh cmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weTogRGl0dG8uCisgICAgICAg ICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvcHJvZ3JhbS9jb21t YW5kLnB5OgorICAgICAgICAoRmlsdGVyZWRDb21tYW5kLm1haW4pOiBJZiB0aGUgZXhpdCBjb2Rl IGlzIG5vbi16ZXJvLCBwcmludCBhbGwgZXJyb3JzLgorCiAyMDIxLTA3LTMwICBKb25hdGhhbiBC ZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBbZ2l0LXdlYmtpdF0gTm90IGFs bCBwbGF0Zm9ybXMgc3VwcG9ydCBtb3JlIC1GCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmll cy93ZWJraXRzY21weS9zZXR1cC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJh cmllcy93ZWJraXRzY21weS9zZXR1cC5weQkocmV2aXNpb24gMjgwNDc5KQorKysgVG9vbHMvU2Ny aXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvc2V0dXAucHkJKHdvcmtpbmcgY29weSkKQEAgLTI5 LDcgKzI5LDcgQEAgZGVmIHJlYWRtZSgpOgogCiBzZXR1cCgKICAgICBuYW1lPSd3ZWJraXRzY21w eScsCi0gICAgdmVyc2lvbj0nMS4wLjMnLAorICAgIHZlcnNpb249JzEuMC40JywKICAgICBkZXNj cmlwdGlvbj0nTGlicmFyeSBkZXNpZ25lZCB0byBpbnRlcmFjdCB3aXRoIGdpdCBhbmQgc3ZuIHJl cG9zaXRvcmllcy4nLAogICAgIGxvbmdfZGVzY3JpcHRpb249cmVhZG1lKCksCiAgICAgY2xhc3Np ZmllcnM9WwpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0 c2NtcHkvX19pbml0X18ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMv d2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkJKHJldmlzaW9uIDI4MDQ3OSkKKysr IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9f LnB5CSh3b3JraW5nIGNvcHkpCkBAIC00Niw3ICs0Niw3IEBAIGV4Y2VwdCBJbXBvcnRFcnJvcjoK ICAgICAgICAgIlBsZWFzZSBpbnN0YWxsIHdlYmtpdGNvcmVweSB3aXRoIGBwaXAgaW5zdGFsbCB3 ZWJraXRjb3JlcHkgLS1leHRyYS1pbmRleC11cmwgPHBhY2thZ2UgaW5kZXggVVJMPmAiCiAgICAg KQogCi12ZXJzaW9uID0gVmVyc2lvbigxLCAwLCAzKQordmVyc2lvbiA9IFZlcnNpb24oMSwgMCwg NCkKIAogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnZmFzdGVuZXJzJywgVmVyc2lvbigw LCAxNSwgMCkpKQogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnbW9ub3RvbmljJywgVmVy c2lvbigxLCA1KSkpCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93 ZWJraXRzY21weS9wcm9ncmFtL2NvbW1hbmQucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvcHJvZ3JhbS9jb21tYW5kLnB5CShy ZXZpc2lvbiAyODA0NzkpCisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93 ZWJraXRzY21weS9wcm9ncmFtL2NvbW1hbmQucHkJKHdvcmtpbmcgY29weSkKQEAgLTI1Niw1ICsy NTYsNyBAQCBjbGFzcyBGaWx0ZXJlZENvbW1hbmQob2JqZWN0KToKICAgICAgICAgICAgICAgICBs aW5lID0gbG9nX291dHB1dC5zdGRvdXQucmVhZGxpbmUoKQogCiAgICAgICAgIGZpbmFsbHk6Cisg ICAgICAgICAgICBpZiBub3QgbG9nX291dHB1dC5yZXR1cm5jb2RlOgorICAgICAgICAgICAgICAg IHN5cy5zdGRlcnIud3JpdGUobG9nX291dHB1dC5zdGRlcnIucmVhZCgpKQogICAgICAgICAgICAg bG9nX291dHB1dC5raWxsKCkKICAgICAgICAgcmV0dXJuIGxvZ19vdXRwdXQucmV0dXJuY29kZQo=