228619 2021-07-29 16:14:43 -0700 [git-webkit] Not all platforms support more -F 2021-08-02 10:26:34 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=228027 https://bugs.webkit.org/show_bug.cgi?id=228621 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap dewei_zhu don.olmstead slewis webkit-bug-importer oldest_to_newest 1780620 0 jbedard 2021-07-29 16:14:43 -0700 Seems like not all platforms support -F being passed to 'more' 1780621 1 webkit-bug-importer 2021-07-29 16:14:58 -0700 <rdar://problem/81296290> 1780623 2 434584 jbedard 2021-07-29 16:18:14 -0700 Created attachment 434584 Patch 1780785 3 aakash_jain 2021-07-30 08:17:58 -0700 rs=me 1780806 4 434633 jbedard 2021-07-30 08:40:42 -0700 Created attachment 434633 Patch for landing 1780819 5 ews-feeder 2021-07-30 09:35:18 -0700 Committed r280478 (240113@main): <https://commits.webkit.org/240113@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434633. 1781053 6 434633 ap 2021-07-30 22:26:59 -0700 Comment on attachment 434633 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=434633&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:124 > + more = subprocess.Popen([which('more')] + ['-F'] if platform.system() == 'Darwin' else [], stdin=child.stdout) Not new with this patch, but what is `which` doing here? 1781246 7 434633 jbedard 2021-08-02 08:25:18 -0700 Comment on attachment 434633 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=434633&action=review >> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:124 >> + more = subprocess.Popen([which('more')] + ['-F'] if platform.system() == 'Darwin' else [], stdin=child.stdout) > > Not new with this patch, but what is `which` doing here? It's coming a library, whichcraft (import on line 31), basically the cross-platform equivalent of running `/usr/bin/which more`. It's giving us the path to the `more` executable. I think it was Don Olmstead that recommended this approach for Windows when I was working on some of the git and svn stuff last year, and I've been doing it whenever we need to run shell commands on multiple platforms. 1781299 8 ap 2021-08-02 10:26:34 -0700 it's almost certainly useless on Unix, as "which" won't find anything that Popen can't find on its own. Not sure what good it could be doing on Windows, but maybe there is some... witchcraft there. 434584 2021-07-29 16:18:14 -0700 2021-07-30 08:40:39 -0700 Patch bug-228619-20210729161813.patch text/plain 3105 jbedard U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwNDUwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjI5YzU4MjBkNmU5ZTY4ZDg3MjMwZTNmNTIwMjhhZDY2 ZDRhYTFkMC4uZTA3Y2U2Yjc5OWEzMWIzMmQ4ZDg0NDg5OTZjMGNmZjkyNDE0MTc3MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTA3LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKwor ICAgICAgICBbZ2l0LXdlYmtpdF0gTm90IGFsbCBwbGF0Zm9ybXMgc3VwcG9ydCBtb3JlIC1GCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg2MTkKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgxMjk2MjkwPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkv c2V0dXAucHk6IEJ1bXAgdmVyc2lvbi4KKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJr aXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weTogRGl0dG8uCisgICAgICAgICogU2NyaXB0 cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvcHJvZ3JhbS9jb21tYW5kLnB5Ogor ICAgICAgICAoRmlsdGVyZWRDb21tYW5kLnBhZ2VyKTogT25seSBwYXNzIC1GIHRvIG1vcmUgb24g RGFyd2luLgorCiAyMDIxLTA3LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KIAogICAgICAgICBbd2Via2l0c2NtcHldIFJldHVybiByZW1vdGUgb2JqZWN0cyBmcm9tIHJl bW90ZSgpIGZ1bmN0aW9uCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJr aXRzY21weS9zZXR1cC5weSBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3Nl dHVwLnB5CmluZGV4IGRiMDdkMTNlYmIzYjUxYzRhMTM4Y2JiZDMxZTE4Y2RmMDNmZWU0MDEuLjE1 YTZiZmVkMDE0YWI5ODUzNWY0NDM1MDRiYWVjMzJiYjI5MzlhOTEgMTAwNjQ0Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3NldHVwLnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3NldHVwLnB5CkBAIC0yOSw3ICsyOSw3IEBAIGRlZiBy ZWFkbWUoKToKIAogc2V0dXAoCiAgICAgbmFtZT0nd2Via2l0c2NtcHknLAotICAgIHZlcnNpb249 JzEuMC4xJywKKyAgICB2ZXJzaW9uPScxLjAuMicsCiAgICAgZGVzY3JpcHRpb249J0xpYnJhcnkg ZGVzaWduZWQgdG8gaW50ZXJhY3Qgd2l0aCBnaXQgYW5kIHN2biByZXBvc2l0b3JpZXMuJywKICAg ICBsb25nX2Rlc2NyaXB0aW9uPXJlYWRtZSgpLAogICAgIGNsYXNzaWZpZXJzPVsKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5p dF9fLnB5IGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkv X19pbml0X18ucHkKaW5kZXggYjdlN2VmOGVmZWM2Y2EwMWMwNWE2Mzk1Njk4YzdlNmNkYjAxMjRm Ni4uNTBjYjIxMzdkYzFiNzYxZTcwMWNjYjZhYTQzYzdlODUxZWMxZDQyMyAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18u cHkKKysrIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkv X19pbml0X18ucHkKQEAgLTQ2LDcgKzQ2LDcgQEAgZXhjZXB0IEltcG9ydEVycm9yOgogICAgICAg ICAiUGxlYXNlIGluc3RhbGwgd2Via2l0Y29yZXB5IHdpdGggYHBpcCBpbnN0YWxsIHdlYmtpdGNv cmVweSAtLWV4dHJhLWluZGV4LXVybCA8cGFja2FnZSBpbmRleCBVUkw+YCIKICAgICApCiAKLXZl cnNpb24gPSBWZXJzaW9uKDEsIDAsIDEpCit2ZXJzaW9uID0gVmVyc2lvbigxLCAwLCAyKQogCiBB dXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdmYXN0ZW5lcnMnLCBWZXJzaW9uKDAsIDE1LCAw KSkpCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdtb25vdG9uaWMnLCBWZXJzaW9uKDEs IDUpKSkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dl YmtpdHNjbXB5L3Byb2dyYW0vY29tbWFuZC5weSBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dl YmtpdHNjbXB5L3dlYmtpdHNjbXB5L3Byb2dyYW0vY29tbWFuZC5weQppbmRleCA5ZmU0NTQzYjA0 YjNlNWYwZjI3OTFjMjkxNzlmMDBhYmE1YjY1YWQ5Li45MWQ0MzViOWRhMGJjNmE0ODg5MDM4ZmE2 MmNkM2Y5ZDY2NDhhMjg5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJr aXRzY21weS93ZWJraXRzY21weS9wcm9ncmFtL2NvbW1hbmQucHkKKysrIGIvVG9vbHMvU2NyaXB0 cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvcHJvZ3JhbS9jb21tYW5kLnB5CkBA IC0yMSw2ICsyMSw3IEBACiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBU SEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKIGltcG9ydCBvcworaW1wb3J0IHBsYXRm b3JtCiBpbXBvcnQgcmUKIGltcG9ydCBzdWJwcm9jZXNzCiBpbXBvcnQgc3lzCkBAIC0xMTksNyAr MTIwLDcgQEAgY2xhc3MgRmlsdGVyZWRDb21tYW5kKG9iamVjdCk6CiAgICAgICAgICAgICAgICAg c3Rkb3V0PXN1YnByb2Nlc3MuUElQRSwKICAgICAgICAgICAgICAgICBzdGRlcnI9c3VicHJvY2Vz cy5QSVBFLAogICAgICAgICAgICAgKQotICAgICAgICAgICAgbW9yZSA9IHN1YnByb2Nlc3MuUG9w ZW4oW3doaWNoKCdtb3JlJyksICctRiddLCBzdGRpbj1jaGlsZC5zdGRvdXQpCisgICAgICAgICAg ICBtb3JlID0gc3VicHJvY2Vzcy5Qb3Blbihbd2hpY2goJ21vcmUnKV0gKyBbJy1GJ10gaWYgcGxh dGZvcm0uc3lzdGVtKCkgPT0gJ0RhcndpbicgZWxzZSBbXSwgc3RkaW49Y2hpbGQuc3Rkb3V0KQog CiAgICAgICAgICAgICB0cnk6CiAgICAgICAgICAgICAgICAgd2hpbGUgbW9yZS5wb2xsKCkgaXMg Tm9uZSBhbmQgbm90IGNoaWxkLnBvbGwoKToK 434633 2021-07-30 08:40:42 -0700 2021-07-30 09:35:19 -0700 Patch for landing bug-228619-20210730084041.patch text/plain 2861 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4MDQ3NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTA3LTMwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbZ2l0LXdlYmtpdF0gTm90IGFsbCBwbGF0Zm9ybXMgc3VwcG9ydCBtb3Jl IC1GCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg2 MTkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgxMjk2MjkwPgorCisgICAgICAgIFJldmlld2Vk IGJ5IEFha2FzaCBKYWluLgorCisgICAgICAgICogU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2Nt cHkvc2V0dXAucHk6IEJ1bXAgdmVyc2lvbi4KKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93 ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weTogRGl0dG8uCisgICAgICAgICogU2Ny aXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvcHJvZ3JhbS9jb21tYW5kLnB5 OgorICAgICAgICAoRmlsdGVyZWRDb21tYW5kLnBhZ2VyKTogT25seSBwYXNzIC1GIHRvIG1vcmUg b24gRGFyd2luLgorCiAyMDIxLTA3LTI5ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNs b3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdW0dUS10gYnVpbGQgYnJva2VuIHdpdGgg cHl0aG9uMiBhZnRlciByMjgwMzgyCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJr aXRzY21weS9zZXR1cC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93 ZWJraXRzY21weS9zZXR1cC5weQkocmV2aXNpb24gMjgwNDc1KQorKysgVG9vbHMvU2NyaXB0cy9s aWJyYXJpZXMvd2Via2l0c2NtcHkvc2V0dXAucHkJKHdvcmtpbmcgY29weSkKQEAgLTI5LDcgKzI5 LDcgQEAgZGVmIHJlYWRtZSgpOgogCiBzZXR1cCgKICAgICBuYW1lPSd3ZWJraXRzY21weScsCi0g ICAgdmVyc2lvbj0nMS4wLjInLAorICAgIHZlcnNpb249JzEuMC4zJywKICAgICBkZXNjcmlwdGlv bj0nTGlicmFyeSBkZXNpZ25lZCB0byBpbnRlcmFjdCB3aXRoIGdpdCBhbmQgc3ZuIHJlcG9zaXRv cmllcy4nLAogICAgIGxvbmdfZGVzY3JpcHRpb249cmVhZG1lKCksCiAgICAgY2xhc3NpZmllcnM9 WwpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkv X19pbml0X18ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkJKHJldmlzaW9uIDI4MDQ3NSkKKysrIFRvb2xz L1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC00Niw3ICs0Niw3IEBAIGV4Y2VwdCBJbXBvcnRFcnJvcjoKICAgICAg ICAgIlBsZWFzZSBpbnN0YWxsIHdlYmtpdGNvcmVweSB3aXRoIGBwaXAgaW5zdGFsbCB3ZWJraXRj b3JlcHkgLS1leHRyYS1pbmRleC11cmwgPHBhY2thZ2UgaW5kZXggVVJMPmAiCiAgICAgKQogCi12 ZXJzaW9uID0gVmVyc2lvbigxLCAwLCAyKQordmVyc2lvbiA9IFZlcnNpb24oMSwgMCwgMykKIAog QXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnZmFzdGVuZXJzJywgVmVyc2lvbigwLCAxNSwg MCkpKQogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnbW9ub3RvbmljJywgVmVyc2lvbigx LCA1KSkpCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRz Y21weS9wcm9ncmFtL2NvbW1hbmQucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJy YXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvcHJvZ3JhbS9jb21tYW5kLnB5CShyZXZpc2lv biAyODA0NzUpCisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRz Y21weS9wcm9ncmFtL2NvbW1hbmQucHkJKHdvcmtpbmcgY29weSkKQEAgLTIxLDYgKzIxLDcgQEAK ICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBP RiBTVUNIIERBTUFHRS4KIAogaW1wb3J0IG9zCitpbXBvcnQgcGxhdGZvcm0KIGltcG9ydCByZQog aW1wb3J0IHN1YnByb2Nlc3MKIGltcG9ydCBzeXMKQEAgLTEyMCw3ICsxMjEsNyBAQCBjbGFzcyBG aWx0ZXJlZENvbW1hbmQob2JqZWN0KToKICAgICAgICAgICAgICAgICBzdGRvdXQ9c3VicHJvY2Vz cy5QSVBFLAogICAgICAgICAgICAgICAgIHN0ZGVycj1zdWJwcm9jZXNzLlBJUEUsCiAgICAgICAg ICAgICApCi0gICAgICAgICAgICBtb3JlID0gc3VicHJvY2Vzcy5Qb3Blbihbd2hpY2goJ21vcmUn KSwgJy1GJ10sIHN0ZGluPWNoaWxkLnN0ZG91dCkKKyAgICAgICAgICAgIG1vcmUgPSBzdWJwcm9j ZXNzLlBvcGVuKFt3aGljaCgnbW9yZScpXSArIFsnLUYnXSBpZiBwbGF0Zm9ybS5zeXN0ZW0oKSA9 PSAnRGFyd2luJyBlbHNlIFtdLCBzdGRpbj1jaGlsZC5zdGRvdXQpCiAKICAgICAgICAgICAgIHRy eToKICAgICAgICAgICAgICAgICB3aGlsZSBtb3JlLnBvbGwoKSBpcyBOb25lIGFuZCBub3QgY2hp bGQucG9sbCgpOgo=