228590 2021-07-29 10:31:53 -0700 [webkitcorepy] Catch AttributeError when getting password 2021-07-29 11:18:10 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain webkit-bug-importer oldest_to_newest 1780426 0 jbedard 2021-07-29 10:31:53 -0700 Some Linux distros will raise an AttributeError in keyring when retrieving a password. Given that our code handles cases where keyring fails, we should also catch AttributeErrors. 1780427 1 webkit-bug-importer 2021-07-29 10:32:09 -0700 <rdar://problem/81278799> 1780430 2 434533 jbedard 2021-07-29 10:35:06 -0700 Created attachment 434533 Patch 1780435 3 aakash_jain 2021-07-29 10:46:08 -0700 Example of failure: https://ews-build.webkit-uat.org/#/builders/35/builds/105023/steps/10/logs/stdio Traceback (most recent call last): File "Tools/Scripts/check-github-mirror-integrity", line 56, in <module> sys.exit(main()) File "Tools/Scripts/check-github-mirror-integrity", line 37, in main mirror_tip = mirror.commit(branch='main') File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py", line 244, in commit commit_data = self.request('commits/{}'.format(branch or tag)) File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py", line 82, in request username, access_token = self.credentials(required=bool(authenticated)) File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py", line 71, in credentials key_name='token', File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py", line 73, in credentials key = keyring.get_password(url, username) File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/autoinstalled/python-3/keyring/core.py", line 42, in get_password return _keyring_backend.get_password(service_name, username) File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/autoinstalled/python-3/keyring/backends/file.py", line 62, in get_password username = escape_for_ini(username) File "/home/ews/worker/GTK-Build-EWS/build/Tools/Scripts/libraries/autoinstalled/python-3/keyring/util/escape.py", line 44, in escape return "".join(_escape_char(c) for c in value.encode('utf-8')) AttributeError: 'NoneType' object has no attribute 'encode' 1780456 4 ews-feeder 2021-07-29 11:18:09 -0700 Committed r280435 (240073@main): <https://commits.webkit.org/240073@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434533. 434533 2021-07-29 10:35:06 -0700 2021-07-29 11:18:10 -0700 Patch bug-228590-20210729103505.patch text/plain 2835 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI4MDQzMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTA3LTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0Y29yZXB5XSBDYXRjaCBBdHRyaWJ1dGVFcnJvciB3aGVuIGdl dHRpbmcgcGFzc3dvcmQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyODU5MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vODEyNzg3OTk+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2xpYnJh cmllcy93ZWJraXRjb3JlcHkvc2V0dXAucHk6IEJ1bXAgdmVyc2lvbi4KKyAgICAgICAgKiBTY3Jp cHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L19faW5pdF9fLnB5OiBEaXR0 by4KKyAgICAgICAgKiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5 L2NyZWRlbnRpYWxzLnB5OgorICAgICAgICAoY3JlZGVudGlhbHMpOiBDYXRjaCBBdHRyaWJ1dGVF cnJvci4KKwogMjAyMS0wNy0yOSAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgW2V3c10gVmVyaWZ5R2l0SHViSW50ZWdyaXR5IHN0ZXAgZmFpbHMgd2l0aCBh biBleGNlcHRpb24KSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS9z ZXR1cC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3Jl cHkvc2V0dXAucHkJKHJldmlzaW9uIDI4MDQzMSkKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVz L3dlYmtpdGNvcmVweS9zZXR1cC5weQkod29ya2luZyBjb3B5KQpAQCAtMzAsNyArMzAsNyBAQCBk ZWYgcmVhZG1lKCk6CiAKIHNldHVwKAogICAgIG5hbWU9J3dlYmtpdGNvcmVweScsCi0gICAgdmVy c2lvbj0nMC43LjInLAorICAgIHZlcnNpb249JzAuNy4zJywKICAgICBkZXNjcmlwdGlvbj0nTGli cmFyeSBjb250YWluaW5nIHZhcmlvdXMgUHl0aG9uIHN1cHBvcnQgY2xhc3NlcyBhbmQgZnVuY3Rp b25zLicsCiAgICAgbG9uZ19kZXNjcmlwdGlvbj1yZWFkbWUoKSwKICAgICBjbGFzc2lmaWVycz1b CkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5 L19faW5pdF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtp dGNvcmVweS93ZWJraXRjb3JlcHkvX19pbml0X18ucHkJKHJldmlzaW9uIDI4MDQzMSkKKysrIFRv b2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvX19pbml0X18u cHkJKHdvcmtpbmcgY29weSkKQEAgLTM5LDcgKzM5LDcgQEAgZnJvbSB3ZWJraXRjb3JlcHkuY3Jl ZGVudGlhbHMgaW1wb3J0IGNyZQogZnJvbSB3ZWJraXRjb3JlcHkubWVhc3VyZV90aW1lIGltcG9y dCBNZWFzdXJlVGltZQogZnJvbSB3ZWJraXRjb3JlcHkubmVzdGVkX2Z1enp5X2RpY3QgaW1wb3J0 IE5lc3RlZEZ1enp5RGljdAogCi12ZXJzaW9uID0gVmVyc2lvbigwLCA3LCAyKQordmVyc2lvbiA9 IFZlcnNpb24oMCwgNywgMykKIAogZnJvbSB3ZWJraXRjb3JlcHkuYXV0b2luc3RhbGwgaW1wb3J0 IFBhY2thZ2UsIEF1dG9JbnN0YWxsCiBpZiBzeXMudmVyc2lvbl9pbmZvID4gKDMsIDApOgpJbmRl eDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS9jcmVk ZW50aWFscy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRj b3JlcHkvd2Via2l0Y29yZXB5L2NyZWRlbnRpYWxzLnB5CShyZXZpc2lvbiAyODA0MzEpCisrKyBU b29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L2NyZWRlbnRp YWxzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC01Niw3ICs1Niw3IEBAIGRlZiBjcmVkZW50aWFscyh1 cmwsIHJlcXVpcmVkPVRydWUsIG5hbWUKICAgICAgICAgdHJ5OgogICAgICAgICAgICAgaWYga2V5 cmluZzoKICAgICAgICAgICAgICAgICB1c2VybmFtZSA9IGtleXJpbmcuZ2V0X3Bhc3N3b3JkKHVy bCwgJ3VzZXJuYW1lJykKLSAgICAgICAgZXhjZXB0IFJ1bnRpbWVFcnJvcjoKKyAgICAgICAgZXhj ZXB0IChSdW50aW1lRXJyb3IsIEF0dHJpYnV0ZUVycm9yKToKICAgICAgICAgICAgIHBhc3MKIAog ICAgICAgICBpZiBub3QgdXNlcm5hbWUgYW5kIHJlcXVpcmVkOgpAQCAtNzEsNyArNzEsNyBAQCBk ZWYgY3JlZGVudGlhbHModXJsLCByZXF1aXJlZD1UcnVlLCBuYW1lCiAgICAgICAgIHRyeToKICAg ICAgICAgICAgIGlmIGtleXJpbmc6CiAgICAgICAgICAgICAgICAga2V5ID0ga2V5cmluZy5nZXRf cGFzc3dvcmQodXJsLCB1c2VybmFtZSkKLSAgICAgICAgZXhjZXB0IFJ1bnRpbWVFcnJvcjoKKyAg ICAgICAgZXhjZXB0IChSdW50aW1lRXJyb3IsIEF0dHJpYnV0ZUVycm9yKToKICAgICAgICAgICAg IHBhc3MKIAogICAgICAgICBpZiBub3Qga2V5IGFuZCByZXF1aXJlZDoK