228566 2021-07-28 13:53:32 -0700 [WPE][GTK] .asc file extension is appended to filename of text/plain downloads 2021-07-29 07:56:33 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro aperez bugs-noreply mcatanzaro oldest_to_newest 1780194 0 mcatanzaro 2021-07-28 13:53:32 -0700 Our MIMETypeRegistry::preferredExtensionForMIMEType returns "asc" for text/plain, possibly because "asc" sorts alphabetically ahead of all other possible file extensions for text/plain, and we just pick the first one. E.g. try downloading the backtrace from https://bugzilla.redhat.com/show_bug.cgi?id=1985053 with WebKit and note that it gets named "backtrace.asc" indicating that it is a GPG signature. But if downloaded with Firefox, it just gets named "backtrace" which is the intended result. I don't know how to fix it, but we don't need to, because we don't really want to append any file extension for text/plain anyway. That's just annoying. If I download a file named "backtrace" then I don't want it renamed to "backtrace.txt". That would be expected on Windows, but certainly not from WebKitGTK. So I think it's reasonable to have a special case for text/plain. 1780204 1 434466 mcatanzaro 2021-07-28 14:16:07 -0700 Created attachment 434466 Patch 1780362 2 434466 aperez 2021-07-29 05:56:54 -0700 Comment on attachment 434466 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434466&action=review > Source/WebCore/platform/xdg/MIMETypeRegistryXdg.cpp:60 > + return String(); This looks reasonable to me. 1780373 3 ews-feeder 2021-07-29 07:56:31 -0700 Committed r280422 (240062@main): <https://commits.webkit.org/240062@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434466. 434466 2021-07-28 14:16:07 -0700 2021-07-29 07:56:32 -0700 Patch bug-228566-20210728161606.patch text/plain 5953 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjJhYjQwZjE1OWQxMDdj OWEzMzZkNDM3ZmFjZTVjY2IzOWMwMDJjOC4uN2FlMDI5YmIyZGI3MzllOWY2NWRlM2NmZWQ2NGM4 YzMxMDg1YjYwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTA3LTI4ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtXUEVdW0dU S10gLmFzYyBmaWxlIGV4dGVuc2lvbiBpcyBhcHBlbmRlZCB0byBmaWxlbmFtZSBvZiB0ZXh0L3Bs YWluIGRvd25sb2FkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI4NTY2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgT3VyIE1JTUVUeXBlUmVnaXN0cnk6OnByZWZlcnJlZEV4dGVuc2lvbkZvck1JTUVUeXBl IHJldHVybnMgImFzYyIgZm9yIHRleHQvcGxhaW4sIHBvc3NpYmx5CisgICAgICAgIGJlY2F1c2Ug ImFzYyIgc29ydHMgYWxwaGFiZXRpY2FsbHkgYWhlYWQgb2YgYWxsIG90aGVyIHBvc3NpYmxlIGZp bGUgZXh0ZW5zaW9ucyBmb3IKKyAgICAgICAgdGV4dC9wbGFpbiwgYW5kIHdlIGp1c3QgcGljayB0 aGUgZmlyc3Qgb25lLiBTbyBpZiB0aGUgdGV4dCBmaWxlIGRvZXMgbm90IGNvbnRhaW4gYW55IGZp bGUKKyAgICAgICAgZXh0ZW5zaW9uLCB3ZSBnaXZlIGl0IGEgZmlsZSBleHRlbnNpb24gZm9yIGEg R1BHIHNpZ25hdHVyZS4gT3VjaC4KKworICAgICAgICBJIGRvbid0IGtub3cgaG93IHRvIGZpeCBp dCwgYnV0IHdlIGRvbid0IG5lZWQgdG8sIGJlY2F1c2Ugd2UgZG9uJ3QgcmVhbGx5IHdhbnQgdG8g YXBwZW5kIGFueQorICAgICAgICBmaWxlIGV4dGVuc2lvbiBmb3IgdGV4dC9wbGFpbiBhbnl3YXku IFRoYXQncyBqdXN0IGFubm95aW5nLiBJZiBJIGRvd25sb2FkIGEgZmlsZSBuYW1lZAorICAgICAg ICAiYmFja3RyYWNlIiB0aGVuIEkgZG9uJ3Qgd2FudCBpdCByZW5hbWVkIHRvICJiYWNrdHJhY2Uu dHh0Ii4gVGhhdCB3b3VsZCBiZSBleHBlY3RlZCBvbgorICAgICAgICBXaW5kb3dzLCBidXQgY2Vy dGFpbmx5IG5vdCBmcm9tIFdlYktpdEdUSy4gU28gSSB0aGluayBpdCdzIHJlYXNvbmFibGUgdG8g aGF2ZSBhIHNwZWNpYWwgY2FzZQorICAgICAgICBmb3IgdGV4dC9wbGFpbi4KKworICAgICAgICAq IHBsYXRmb3JtL3hkZy9NSU1FVHlwZVJlZ2lzdHJ5WGRnLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Ok1JTUVUeXBlUmVnaXN0cnk6OnByZWZlcnJlZEV4dGVuc2lvbkZvck1JTUVUeXBlKToKKwogMjAy MS0wNy0yOCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBEZXBs b3kgbW9yZSB1c2Ugb2Ygc21hcnQgcG9pbnRlcnMgaW4gRG9jdW1lbnQuY3BwCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS94ZGcvTUlNRVR5cGVSZWdpc3RyeVhkZy5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS94ZGcvTUlNRVR5cGVSZWdpc3RyeVhkZy5jcHAKaW5kZXgg MDJiYmE0Zjc1ZDYxOWUxZDNmNDRiNjYwYzYyMGVlM2UxMTFhYjZmOS4uMmI5YjE2ZTU0YWYxYWY4 ZjY3NzgwNDZhMDViOWUxNjFiM2RiNTY2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0veGRnL01JTUVUeXBlUmVnaXN0cnlYZGcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3hkZy9NSU1FVHlwZVJlZ2lzdHJ5WGRnLmNwcApAQCAtNTYsNiArNTYsOSBAQCBTdHJp bmcgTUlNRVR5cGVSZWdpc3RyeTo6cHJlZmVycmVkRXh0ZW5zaW9uRm9yTUlNRVR5cGUoY29uc3Qg U3RyaW5nJiBtaW1lVHlwZSkKICAgICBpZiAobWltZVR5cGUuaXNFbXB0eSgpKQogICAgICAgICBy ZXR1cm4gU3RyaW5nKCk7CiAKKyAgICBpZiAobWltZVR5cGUuc3RhcnRzV2l0aCgidGV4dC9wbGFp biIpKQorICAgICAgICByZXR1cm4gU3RyaW5nKCk7CisKICAgICBTdHJpbmcgcmV0dXJuVmFsdWU7 CiAgICAgY2hhciogZXh0ZW5zaW9uOwogICAgIGlmICh4ZGdfbWltZV9nZXRfc2ltcGxlX2dsb2Jz KG1pbWVUeXBlLnV0ZjgoKS5kYXRhKCksICZleHRlbnNpb24sIDEpKSB7CmRpZmYgLS1naXQgYS9U b29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWExOThjMWQ5MTY3YTYxNWNh Mjg1OTVhMThlMjdiZDcyNDc5YjU2ZC4uMTgyODhlOTkyNjFmNDAzMWU0ZjVkZWY2OTI0MThkMTky OTFjNmE5NSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTA3LTI4ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh bnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtXUEVdW0dUS10gLmFzYyBmaWxlIGV4dGVuc2lv biBpcyBhcHBlbmRlZCB0byBmaWxlbmFtZSBvZiB0ZXh0L3BsYWluIGRvd25sb2FkcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4NTY2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJ L1Rlc3RzL1dlYktpdEdMaWIvVGVzdERvd25sb2Fkcy5jcHA6CisgICAgICAgIChzZXJ2ZXJDYWxs YmFjayk6CisgICAgICAgICh0ZXN0RG93bmxvYWRUZXh0UGxhaW5NSU1FVHlwZSk6CisgICAgICAg IChiZWZvcmVBbGwpOgorICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9y ZXNvdXJjZXMvdGV4dDogQWRkZWQuCisKIDIwMjEtMDctMjggIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBXZWJTb2NrZXQ6IFNhZmFyaSBvbiBp T1MgMTUgYmV0YSAzIGlzIHNlbmRpbmcgaW52YWxpZCBjbG9zZSBmcmFtZQpkaWZmIC0tZ2l0IGEv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3REb3dubG9hZHMuY3BwIGIv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHTGliL1Rlc3REb3dubG9hZHMuY3BwCmlu ZGV4IGM3NDU2NzcyYjlmMzczOWE3MTU3NWE2ODRlZDk0MGQ2ZGMwN2JlMjcuLjI2NGFkNTZlZTBh MzhhNzI1NDg1OTQzZWQ1OTYzNjgyZjk5MzZhZDkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0R0xpYi9UZXN0RG93bmxvYWRzLmNwcAorKysgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEdMaWIvVGVzdERvd25sb2Fkcy5jcHAKQEAgLTQ0NCw2ICs0 NDQsOCBAQCBzdGF0aWMgdm9pZCBzZXJ2ZXJDYWxsYmFjayhTb3VwU2VydmVyKiBzZXJ2ZXIsIFNv dXBTZXJ2ZXJNZXNzYWdlKiBtZXNzYWdlLCBjb25zdAogCiAgICAgaWYgKGdfc3RyX2VxdWFsKHBh dGgsICIvdW5rbm93biIpIHx8IGdfc3RyX2VxdWFsKHBhdGgsICIvdWEtdGVzdCIpKQogICAgICAg ICBwYXRoID0gIi90ZXN0LnBkZiI7CisgICAgZWxzZSBpZiAoZ19zdHJfZXF1YWwocGF0aCwgIi90 ZXh0IikpCisgICAgICAgIHBhdGggPSAiL3RleHQiOwogCiAgICAgR1VuaXF1ZVB0cjxjaGFyPiBm aWxlUGF0aChnX2J1aWxkX2ZpbGVuYW1lKFRlc3Q6OmdldFJlc291cmNlc0RpcigpLmRhdGEoKSwg cGF0aCwgbnVsbHB0cikpOwogICAgIGNoYXIqIGNvbnRlbnRzOwpAQCAtNzQ1LDYgKzc0NywyMyBA QCBzdGF0aWMgdm9pZCB0ZXN0RG93bmxvYWRNSU1FVHlwZShEb3dubG9hZFRlc3QqIHRlc3QsIGdj b25zdHBvaW50ZXIpCiAgICAgdGVzdC0+Y2hlY2tEZXN0aW5hdGlvbkFuZERlbGV0ZUZpbGUoZG93 bmxvYWQuZ2V0KCksIGV4cGVjdGVkRmlsZW5hbWUuZ2V0KCkpOwogfQogCitzdGF0aWMgdm9pZCB0 ZXN0RG93bmxvYWRUZXh0UGxhaW5NSU1FVHlwZShEb3dubG9hZFRlc3QqIHRlc3QsIGdjb25zdHBv aW50ZXIpCit7CisgICAgR1JlZlB0cjxXZWJLaXREb3dubG9hZD4gZG93bmxvYWQgPSB0ZXN0LT5k b3dubG9hZFVSSUFuZFdhaXRVbnRpbEZpbmlzaGVzKGtTZXJ2ZXItPmdldFVSSUZvclBhdGgoIi90 ZXh0IikpOworICAgIGdfYXNzZXJ0X251bGwod2Via2l0X2Rvd25sb2FkX2dldF93ZWJfdmlldyhk b3dubG9hZC5nZXQoKSkpOworCisgICAgV2ViS2l0VVJJUmVxdWVzdCogcmVxdWVzdCA9IHdlYmtp dF9kb3dubG9hZF9nZXRfcmVxdWVzdChkb3dubG9hZC5nZXQoKSk7CisgICAgZ19hc3NlcnRfdHJ1 ZShXRUJLSVRfSVNfVVJJX1JFUVVFU1QocmVxdWVzdCkpOworICAgIEFTU0VSVF9DTVBfQ1NUUklO Ryh3ZWJraXRfdXJpX3JlcXVlc3RfZ2V0X3VyaShyZXF1ZXN0KSwgPT0sIGtTZXJ2ZXItPmdldFVS SUZvclBhdGgoIi90ZXh0IikpOworCisgICAgV2ViS2l0VVJJUmVzcG9uc2UqIHJlc3BvbnNlID0g d2Via2l0X2Rvd25sb2FkX2dldF9yZXNwb25zZShkb3dubG9hZC5nZXQoKSk7CisgICAgZ19hc3Nl cnRfdHJ1ZShXRUJLSVRfSVNfVVJJX1JFU1BPTlNFKHJlc3BvbnNlKSk7CisgICAgZ19hc3NlcnRf Y21wc3RyKHdlYmtpdF91cmlfcmVzcG9uc2VfZ2V0X21pbWVfdHlwZShyZXNwb25zZSksID09LCAi dGV4dC9wbGFpbiIpOworICAgIGdfYXNzZXJ0X25vbm51bGwod2Via2l0X2Rvd25sb2FkX2dldF9k ZXN0aW5hdGlvbihkb3dubG9hZC5nZXQoKSkpOworICAgIGdfYXNzZXJ0X2NtcGZsb2F0KHdlYmtp dF9kb3dubG9hZF9nZXRfZXN0aW1hdGVkX3Byb2dyZXNzKGRvd25sb2FkLmdldCgpKSwgPT0sIDEp OworICAgIHRlc3QtPmNoZWNrRGVzdGluYXRpb25BbmREZWxldGVGaWxlKGRvd25sb2FkLmdldCgp LCBrU2VydmVyU3VnZ2VzdGVkRmlsZW5hbWUpOworfQorCiBzdGF0aWMgdm9pZCB0ZXN0RG93bmxv YWRVc2VyQWdlbnQoRG93bmxvYWRUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogewogICAgIHNf dXNlckFnZW50TWFwLmNsZWFyKCk7CkBAIC04OTIsNiArOTExLDcgQEAgdm9pZCBiZWZvcmVBbGwo KQogICAgIFBvbGljeVJlc3BvbnNlRG93bmxvYWRUZXN0OjphZGQoIkRvd25sb2FkcyIsICJwb2xp Y3ktZGVjaXNpb24tZG93bmxvYWQiLCB0ZXN0UG9saWN5UmVzcG9uc2VEb3dubG9hZCk7CiAgICAg UG9saWN5UmVzcG9uc2VEb3dubG9hZFRlc3Q6OmFkZCgiRG93bmxvYWRzIiwgInBvbGljeS1kZWNp c2lvbi1kb3dubG9hZC1jYW5jZWwiLCB0ZXN0UG9saWN5UmVzcG9uc2VEb3dubG9hZENhbmNlbCk7 CiAgICAgRG93bmxvYWRUZXN0OjphZGQoIkRvd25sb2FkcyIsICJtaW1lLXR5cGUiLCB0ZXN0RG93 bmxvYWRNSU1FVHlwZSk7CisgICAgRG93bmxvYWRUZXN0OjphZGQoIkRvd25sb2FkcyIsICJ0ZXh0 LXBsYWluLW1pbWUtdHlwZSIsIHRlc3REb3dubG9hZFRleHRQbGFpbk1JTUVUeXBlKTsKICAgICBE b3dubG9hZFRlc3Q6OmFkZCgiRG93bmxvYWRzIiwgInVzZXItYWdlbnQiLCB0ZXN0RG93bmxvYWRV c2VyQWdlbnQpOwogICAgIFRlc3Q6OmFkZCgiRG93bmxvYWRzIiwgImVwaGVtZXJhbC1jb250ZXh0 IiwgdGVzdERvd25sb2FkRXBoZW1lcmFsQ29udGV4dCk7CiAgICAgLy8gRklYTUU6IEltcGxlbWVu dCBrZXlTdHJva2UgaW4gV1BFLgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRHTGliL3Jlc291cmNlcy90ZXh0IGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRHTGliL3Jlc291cmNlcy90ZXh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjU3MjE0ZjcwMDMxY2FlMjEzZDJl YTAzM2FkOTJlM2Q0ZWY4N2U3MzcKLS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdEdMaWIvcmVzb3VyY2VzL3RleHQKQEAgLTAsMCArMSBAQAorVGhpcyBp cyBhIHRleHQvcGxhaW4gZG9jdW1lbnQhCg==