228551 2021-07-28 06:13:09 -0700 NetworkRTCUDPSocketCocoaConnections nw_listener_set_state_changed_handler callback should hold a reference to its listener 2021-07-29 04:21:35 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen eric.carlson markericc02 webkit-bug-importer youennf oldest_to_newest 1780035 0 youennf 2021-07-28 06:13:09 -0700 <rdar://81137047> 1780036 1 webkit-bug-importer 2021-07-28 06:13:26 -0700 <rdar://problem/81213617> 1780037 2 webkit-bug-importer 2021-07-28 06:13:44 -0700 <rdar://problem/81213635> 1780038 3 youennf 2021-07-28 06:13:50 -0700 <rdar://81137047> 1780041 4 434426 youennf 2021-07-28 06:28:20 -0700 Created attachment 434426 Patch 1780076 5 434426 achristensen 2021-07-28 09:11:45 -0700 Comment on attachment 434426 Patch Does it enter the cancelled state if it is destroyed before it transitions to the ready state? I think you could also use a WeakObjCPtr. 1780078 6 youennf 2021-07-28 09:14:46 -0700 (In reply to Alex Christensen from comment #5) > Comment on attachment 434426 [details] > Patch > > Does it enter the cancelled state if it is destroyed before it transitions > to the ready state? I think you could also use a WeakObjCPtr. Cancelled state is guaranteed to happen whenever cancel is called, even if state is failed or not ready. 1780327 7 434502 youennf 2021-07-28 23:46:41 -0700 Created attachment 434502 Patch for landing 1780354 8 ews-feeder 2021-07-29 04:21:33 -0700 Committed r280420 (240060@main): <https://commits.webkit.org/240060@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434502. 434426 2021-07-28 06:28:20 -0700 2021-07-28 23:46:36 -0700 Patch bug-228551-20210728152819.patch text/plain 3603 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDczZTE5OWUxYjdlYjIzZDQ3 OWZlMzA1MmNiZmI5NTA5ZDFiYjUyY2MuLmMwODA0ZmMxNWFkYmVhNDMyODk2MDM5ZTAyYWVmMTk4 ZGM2M2NmOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDctMjggIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE5ldHdvcmtSVENVRFBTb2NrZXRD b2NvYUNvbm5lY3Rpb25zIG53X2xpc3RlbmVyX3NldF9zdGF0ZV9jaGFuZ2VkX2hhbmRsZXIgY2Fs bGJhY2sgc2hvdWxkIGhvbGQgYSByZWZlcmVuY2UgdG8gaXRzIGxpc3RlbmVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg1NTEKKyAgICAgICAgPHJk YXI6Ly84MTEzNzA0Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBud19saXN0ZW5lciBpcyBub3QgZ3VhcmFudGVlZCB0byBzdGF5IHZhbGlkIHdoZW4g Y2FsbGluZyB0aGUgc3RhdGUgY2hhbmdlIGNhbGxiYWNrLgorICAgICAgICBXZSBuZWVkIHRvIGhv bGQgYSByZWZlcmVuY2UgdG8gdGhlIGxpc3RlbmVyIGluIHRoZSBjYWxsYmFjay4KKyAgICAgICAg VG8gcHJldmVudCBtZW1vcnkgbGVha3MsIHRoZSBjYWxsYmFjayB3aWxsIGNsZWFyIGl0cyBsaXN0 ZW5lciByZWZlcmVuY2Ugd2hlbiBlbnRlcmluZyBjYW5jZWxsZWQgc3RhdGUuCisgICAgICAgIFRo ZSBjYW5jZWxsZWQgc3RhdGUgaXMgZ3VhcmFudGVlZCB0byBoYXBwZW4gd2hlbiBjYWxsaW5nIGNh bmNlbCBpbiB0aGUgbGlzdGVuZXIsIHdoaWNoIGhhcHBlbnMgd2hlbiBjbG9zaW5nIHRoZSBzb2Nr ZXQuCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBOZXR3 b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1VEUFNvY2tldENvY29hLm1tOgorICAgICAgICAo V2ViS2l0OjpOZXR3b3JrUlRDVURQU29ja2V0Q29jb2FDb25uZWN0aW9uczo6TmV0d29ya1JUQ1VE UFNvY2tldENvY29hQ29ubmVjdGlvbnMpOgorCiAyMDIxLTA3LTI3ICBEZXZpbiBSb3Vzc28gIDxk cm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBbTW9kZXJuIE1lZGlhIENvbnRyb2xzXSBbbWFj T1NdIE92ZXJmbG93IGJ1dHRvbiBzdGlsbCBzaG93cyBhcyBgb25gIGV2ZW4gYWZ0ZXIgY29udGV4 dG1lbnUgaXMgZGlzbWlzc2VkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDVURQU29ja2V0Q29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L05l dHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDVURQU29ja2V0Q29jb2EubW0KaW5kZXggN2Y3 ZGM5Yzc4ZjhmM2ZkNDViYmUwOTU4YjBhNmFkMmI0NjE5ZDY1OC4uYjM3ZGIwMGEyZDE3MDExOWI1 NzQ0NWRmNWU2MGY0OGJkOGVmZjkyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3Jr UHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1VEUFNvY2tldENvY29hLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENVRFBTb2NrZXRDb2NvYS5tbQpA QCAtMTc0LDEzICsxNzQsMTQgQEAgTmV0d29ya1JUQ1VEUFNvY2tldENvY29hQ29ubmVjdGlvbnM6 Ok5ldHdvcmtSVENVRFBTb2NrZXRDb2NvYUNvbm5lY3Rpb25zKFdlYkNvcmUKICAgICBtX253TGlz dGVuZXIgPSBhZG9wdE5TKG53X2xpc3RlbmVyX2NyZWF0ZShwYXJhbWV0ZXJzLmdldCgpKSk7CiAg ICAgbndfbGlzdGVuZXJfc2V0X3F1ZXVlKG1fbndMaXN0ZW5lci5nZXQoKSwgdWRwU29ja2V0UXVl dWUoKSk7CiAKLSAgICBud19saXN0ZW5lcl9zZXRfc3RhdGVfY2hhbmdlZF9oYW5kbGVyKG1fbndM aXN0ZW5lci5nZXQoKSwgbWFrZUJsb2NrUHRyKFtud0xpc3RlbmVyID0gbV9ud0xpc3RlbmVyLmdl dCgpLCBjb25uZWN0aW9uID0gbV9jb25uZWN0aW9uLmNvcHlSZWYoKSwgcHJvdGVjdGVkUlRDUHJv dmlkZXIgPSBtYWtlUmVmKHJ0Y1Byb3ZpZGVyKSwgaWRlbnRpZmllciA9IG1faWRlbnRpZmllcl0o bndfbGlzdGVuZXJfc3RhdGVfdCBzdGF0ZSwgbndfZXJyb3JfdCBlcnJvcikgbXV0YWJsZSB7Cisg ICAgLy8gVGhlIGNhbGxiYWNrIGhvbGRzIGEgcmVmZXJlbmNlIHRvIHRoZSBud19saXN0ZW5lciBh bmQgd2UgY2xlYXIgaXQgd2hlbiBnb2luZyBpbiBud19saXN0ZW5lcl9zdGF0ZV9jYW5jZWxsZWQg c3RhdGUsIHdoaWNoIGlzIHRyaWdnZXJlZCB3aGVuIGNsb3NpbmcgdGhlIHNvY2tldC4KKyAgICBu d19saXN0ZW5lcl9zZXRfc3RhdGVfY2hhbmdlZF9oYW5kbGVyKG1fbndMaXN0ZW5lci5nZXQoKSwg bWFrZUJsb2NrUHRyKFtud0xpc3RlbmVyID0gbV9ud0xpc3RlbmVyLCBjb25uZWN0aW9uID0gbV9j b25uZWN0aW9uLmNvcHlSZWYoKSwgcHJvdGVjdGVkUlRDUHJvdmlkZXIgPSBtYWtlUmVmKHJ0Y1By b3ZpZGVyKSwgaWRlbnRpZmllciA9IG1faWRlbnRpZmllcl0obndfbGlzdGVuZXJfc3RhdGVfdCBz dGF0ZSwgbndfZXJyb3JfdCBlcnJvcikgbXV0YWJsZSB7CiAgICAgICAgIHN3aXRjaCAoc3RhdGUp IHsKICAgICAgICAgY2FzZSBud19saXN0ZW5lcl9zdGF0ZV9pbnZhbGlkOgogICAgICAgICBjYXNl IG53X2xpc3RlbmVyX3N0YXRlX3dhaXRpbmc6CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg Y2FzZSBud19saXN0ZW5lcl9zdGF0ZV9yZWFkeToKLSAgICAgICAgICAgIHByb3RlY3RlZFJUQ1By b3ZpZGVyLT5kb1NvY2tldFRhc2tPblJUQ05ldHdvcmtUaHJlYWQoaWRlbnRpZmllciwgW3BvcnQg PSBud19saXN0ZW5lcl9nZXRfcG9ydChud0xpc3RlbmVyKV0oYXV0byYgc29ja2V0KSBtdXRhYmxl IHsKKyAgICAgICAgICAgIHByb3RlY3RlZFJUQ1Byb3ZpZGVyLT5kb1NvY2tldFRhc2tPblJUQ05l dHdvcmtUaHJlYWQoaWRlbnRpZmllciwgW3BvcnQgPSBud19saXN0ZW5lcl9nZXRfcG9ydChud0xp c3RlbmVyLmdldCgpKV0oYXV0byYgc29ja2V0KSBtdXRhYmxlIHsKICAgICAgICAgICAgICAgICBh dXRvJiB1ZHBTb2NrZXQgPSBzdGF0aWNfY2FzdDxOZXR3b3JrUlRDVURQU29ja2V0Q29jb2EmPihz b2NrZXQpOwogICAgICAgICAgICAgICAgIHVkcFNvY2tldC5zZXRMaXN0ZW5pbmdQb3J0KHBvcnQp OwogICAgICAgICAgICAgfSk7CkBAIC0xOTMsNiArMTk0LDcgQEAgTmV0d29ya1JUQ1VEUFNvY2tl dENvY29hQ29ubmVjdGlvbnM6Ok5ldHdvcmtSVENVRFBTb2NrZXRDb2NvYUNvbm5lY3Rpb25zKFdl YkNvcmUKICAgICAgICAgICAgIGNvbm5lY3Rpb24tPnNlbmQoTWVzc2FnZXM6OkxpYldlYlJUQ05l dHdvcms6OlNpZ25hbENsb3NlKGlkZW50aWZpZXIsIC0xKSwgMCk7CiAgICAgICAgICAgICBicmVh azsKICAgICAgICAgY2FzZSBud19saXN0ZW5lcl9zdGF0ZV9jYW5jZWxsZWQ6CisgICAgICAgICAg ICBud0xpc3RlbmVyLmNsZWFyKCk7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfQogICAg IH0pLmdldCgpKTsK 434502 2021-07-28 23:46:41 -0700 2021-07-29 04:21:34 -0700 Patch for landing bug-228551-20210729084639.patch text/plain 3605 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDczZTE5OWUxYjdlYjIzZDQ3 OWZlMzA1MmNiZmI5NTA5ZDFiYjUyY2MuLjM4Mzk1ZGI0ODM0YjQwOTdjMDBmNjUyZDQxNzFlNjA4 NzUzODdmYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDctMjggIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIE5ldHdvcmtSVENVRFBTb2NrZXRD b2NvYUNvbm5lY3Rpb25zIG53X2xpc3RlbmVyX3NldF9zdGF0ZV9jaGFuZ2VkX2hhbmRsZXIgY2Fs bGJhY2sgc2hvdWxkIGhvbGQgYSByZWZlcmVuY2UgdG8gaXRzIGxpc3RlbmVyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg1NTEKKyAgICAgICAgPHJk YXI6Ly84MTEzNzA0Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4IENocmlzdGVuc2VuLgor CisgICAgICAgIG53X2xpc3RlbmVyIGlzIG5vdCBndWFyYW50ZWVkIHRvIHN0YXkgdmFsaWQgd2hl biBjYWxsaW5nIHRoZSBzdGF0ZSBjaGFuZ2UgY2FsbGJhY2suCisgICAgICAgIFdlIG5lZWQgdG8g aG9sZCBhIHJlZmVyZW5jZSB0byB0aGUgbGlzdGVuZXIgaW4gdGhlIGNhbGxiYWNrLgorICAgICAg ICBUbyBwcmV2ZW50IG1lbW9yeSBsZWFrcywgdGhlIGNhbGxiYWNrIHdpbGwgY2xlYXIgaXRzIGxp c3RlbmVyIHJlZmVyZW5jZSB3aGVuIGVudGVyaW5nIGNhbmNlbGxlZCBzdGF0ZS4KKyAgICAgICAg VGhlIGNhbmNlbGxlZCBzdGF0ZSBpcyBndWFyYW50ZWVkIHRvIGhhcHBlbiB3aGVuIGNhbGxpbmcg Y2FuY2VsIGluIHRoZSBsaXN0ZW5lciwgd2hpY2ggaGFwcGVucyB3aGVuIGNsb3NpbmcgdGhlIHNv Y2tldC4KKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICAqIE5l dHdvcmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDVURQU29ja2V0Q29jb2EubW06CisgICAgICAg IChXZWJLaXQ6Ok5ldHdvcmtSVENVRFBTb2NrZXRDb2NvYUNvbm5lY3Rpb25zOjpOZXR3b3JrUlRD VURQU29ja2V0Q29jb2FDb25uZWN0aW9ucyk6CisKIDIwMjEtMDctMjcgIERldmluIFJvdXNzbyAg PGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFtNb2Rlcm4gTWVkaWEgQ29udHJvbHNdIFtt YWNPU10gT3ZlcmZsb3cgYnV0dG9uIHN0aWxsIHNob3dzIGFzIGBvbmAgZXZlbiBhZnRlciBjb250 ZXh0bWVudSBpcyBkaXNtaXNzZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1By b2Nlc3Mvd2VicnRjL05ldHdvcmtSVENVRFBTb2NrZXRDb2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3Mvd2VicnRjL05ldHdvcmtSVENVRFBTb2NrZXRDb2NvYS5tbQppbmRleCA3 ZjdkYzljNzhmOGYzZmQ0NWJiZTA5NThiMGE2YWQyYjQ2MTlkNjU4Li5iMzdkYjAwYTJkMTcwMTE5 YjU3NDQ1ZGY1ZTYwZjQ4YmQ4ZWZmOTJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdv cmtQcm9jZXNzL3dlYnJ0Yy9OZXR3b3JrUlRDVURQU29ja2V0Q29jb2EubW0KKysrIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy93ZWJydGMvTmV0d29ya1JUQ1VEUFNvY2tldENvY29hLm1t CkBAIC0xNzQsMTMgKzE3NCwxNCBAQCBOZXR3b3JrUlRDVURQU29ja2V0Q29jb2FDb25uZWN0aW9u czo6TmV0d29ya1JUQ1VEUFNvY2tldENvY29hQ29ubmVjdGlvbnMoV2ViQ29yZQogICAgIG1fbndM aXN0ZW5lciA9IGFkb3B0TlMobndfbGlzdGVuZXJfY3JlYXRlKHBhcmFtZXRlcnMuZ2V0KCkpKTsK ICAgICBud19saXN0ZW5lcl9zZXRfcXVldWUobV9ud0xpc3RlbmVyLmdldCgpLCB1ZHBTb2NrZXRR dWV1ZSgpKTsKIAotICAgIG53X2xpc3RlbmVyX3NldF9zdGF0ZV9jaGFuZ2VkX2hhbmRsZXIobV9u d0xpc3RlbmVyLmdldCgpLCBtYWtlQmxvY2tQdHIoW253TGlzdGVuZXIgPSBtX253TGlzdGVuZXIu Z2V0KCksIGNvbm5lY3Rpb24gPSBtX2Nvbm5lY3Rpb24uY29weVJlZigpLCBwcm90ZWN0ZWRSVENQ cm92aWRlciA9IG1ha2VSZWYocnRjUHJvdmlkZXIpLCBpZGVudGlmaWVyID0gbV9pZGVudGlmaWVy XShud19saXN0ZW5lcl9zdGF0ZV90IHN0YXRlLCBud19lcnJvcl90IGVycm9yKSBtdXRhYmxlIHsK KyAgICAvLyBUaGUgY2FsbGJhY2sgaG9sZHMgYSByZWZlcmVuY2UgdG8gdGhlIG53X2xpc3RlbmVy IGFuZCB3ZSBjbGVhciBpdCB3aGVuIGdvaW5nIGluIG53X2xpc3RlbmVyX3N0YXRlX2NhbmNlbGxl ZCBzdGF0ZSwgd2hpY2ggaXMgdHJpZ2dlcmVkIHdoZW4gY2xvc2luZyB0aGUgc29ja2V0LgorICAg IG53X2xpc3RlbmVyX3NldF9zdGF0ZV9jaGFuZ2VkX2hhbmRsZXIobV9ud0xpc3RlbmVyLmdldCgp LCBtYWtlQmxvY2tQdHIoW253TGlzdGVuZXIgPSBtX253TGlzdGVuZXIsIGNvbm5lY3Rpb24gPSBt X2Nvbm5lY3Rpb24uY29weVJlZigpLCBwcm90ZWN0ZWRSVENQcm92aWRlciA9IG1ha2VSZWYocnRj UHJvdmlkZXIpLCBpZGVudGlmaWVyID0gbV9pZGVudGlmaWVyXShud19saXN0ZW5lcl9zdGF0ZV90 IHN0YXRlLCBud19lcnJvcl90IGVycm9yKSBtdXRhYmxlIHsKICAgICAgICAgc3dpdGNoIChzdGF0 ZSkgewogICAgICAgICBjYXNlIG53X2xpc3RlbmVyX3N0YXRlX2ludmFsaWQ6CiAgICAgICAgIGNh c2UgbndfbGlzdGVuZXJfc3RhdGVfd2FpdGluZzoKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICBjYXNlIG53X2xpc3RlbmVyX3N0YXRlX3JlYWR5OgotICAgICAgICAgICAgcHJvdGVjdGVkUlRD UHJvdmlkZXItPmRvU29ja2V0VGFza09uUlRDTmV0d29ya1RocmVhZChpZGVudGlmaWVyLCBbcG9y dCA9IG53X2xpc3RlbmVyX2dldF9wb3J0KG53TGlzdGVuZXIpXShhdXRvJiBzb2NrZXQpIG11dGFi bGUgeworICAgICAgICAgICAgcHJvdGVjdGVkUlRDUHJvdmlkZXItPmRvU29ja2V0VGFza09uUlRD TmV0d29ya1RocmVhZChpZGVudGlmaWVyLCBbcG9ydCA9IG53X2xpc3RlbmVyX2dldF9wb3J0KG53 TGlzdGVuZXIuZ2V0KCkpXShhdXRvJiBzb2NrZXQpIG11dGFibGUgewogICAgICAgICAgICAgICAg IGF1dG8mIHVkcFNvY2tldCA9IHN0YXRpY19jYXN0PE5ldHdvcmtSVENVRFBTb2NrZXRDb2NvYSY+ KHNvY2tldCk7CiAgICAgICAgICAgICAgICAgdWRwU29ja2V0LnNldExpc3RlbmluZ1BvcnQocG9y dCk7CiAgICAgICAgICAgICB9KTsKQEAgLTE5Myw2ICsxOTQsNyBAQCBOZXR3b3JrUlRDVURQU29j a2V0Q29jb2FDb25uZWN0aW9uczo6TmV0d29ya1JUQ1VEUFNvY2tldENvY29hQ29ubmVjdGlvbnMo V2ViQ29yZQogICAgICAgICAgICAgY29ubmVjdGlvbi0+c2VuZChNZXNzYWdlczo6TGliV2ViUlRD TmV0d29yazo6U2lnbmFsQ2xvc2UoaWRlbnRpZmllciwgLTEpLCAwKTsKICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICBjYXNlIG53X2xpc3RlbmVyX3N0YXRlX2NhbmNlbGxlZDoKKyAgICAgICAg ICAgIG53TGlzdGVuZXIuY2xlYXIoKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAg ICAgfSkuZ2V0KCkpOwo=