228549 2021-07-28 05:31:33 -0700 RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer should update m_currentRotationSessionAngle 2021-07-29 04:22:08 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw webkit-bug-importer youennf oldest_to_newest 1780021 0 youennf 2021-07-28 05:31:33 -0700 RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer should update m_currentRotationSessionAngle 1780022 1 youennf 2021-07-28 05:31:42 -0700 <rdar://80608977> 1780023 2 webkit-bug-importer 2021-07-28 05:31:59 -0700 <rdar://problem/81212597> 1780025 3 434420 youennf 2021-07-28 05:42:47 -0700 Created attachment 434420 Patch 1780048 4 434420 eric.carlson 2021-07-28 07:01:39 -0700 Comment on attachment 434420 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434420&action=review > Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:78 > + IntSize size = { (int)pixelWidth , (int)pixelHeight }; Nit: the local isn't strictly necessary. 1780328 5 434503 youennf 2021-07-28 23:52:14 -0700 Created attachment 434503 Patch for landing 1780355 6 ews-feeder 2021-07-29 04:22:06 -0700 Committed r280421 (240061@main): <https://commits.webkit.org/240061@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434503. 434420 2021-07-28 05:42:47 -0700 2021-07-28 23:52:09 -0700 Patch bug-228549-20210728144246.patch text/plain 2846 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGIzYmM5ZTgwYWM1MzAw M2E1OTdkODIzZjdiNGVjYjFlMGFlYzY3OC4uMTkxY2ZjYjk0NGM2ZGRlZTgyMWQ3NDQzMjRlNDA0 ZWMzM2Q3OGQzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA3LTI4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWFsdGltZU91dGdvaW5n VmlkZW9Tb3VyY2VDb2NvYTo6cm90YXRlUGl4ZWxCdWZmZXIgc2hvdWxkIHVwZGF0ZSBtX2N1cnJl bnRSb3RhdGlvblNlc3Npb25BbmdsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjI4NTQ5CisgICAgICAgIDxyZGFyOi8vODA2MDg5Nzc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90IGZvcmdldCB0 byB1cGRhdGUgbV9jdXJyZW50Um90YXRpb25TZXNzaW9uQW5nbGUgd2hlbiBjcmVhdGluZyBhIG5l dyByb3RhdGlvbiBzZXNzaW9uLgorICAgICAgICBBbHNvLCBtYWtlIHN1cmUgdG8gcmVjcmVhdGUg cm90YXRpb24gc2Vzc2lvbiBpbiBjYXNlIHRoZSBwaXhlbCBidWZmZXIgc2l6ZSBjaGFuZ2VzLgor CisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lT3V0Z29pbmdWaWRl b1NvdXJjZUNvY29hLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVhbHRpbWVPdXRnb2luZ1ZpZGVv U291cmNlQ29jb2E6OnJvdGF0ZVBpeGVsQnVmZmVyKToKKwogMjAyMS0wNy0yNyAgSm9vbmdodW4g UGFyayAgPGpoNzE4LnBhcmtAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gUmVt b3ZlIHRoZSBidWlsZCB3YXJuaW5nIGJlbG93IHNpbmNlIHIyODAzMzIuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVPdXRnb2luZ1Zp ZGVvU291cmNlQ29jb2EubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9t YWMvUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlQ29jb2EubW0KaW5kZXggZGUzYjNjOWIxY2Jl MjNjZTYxODUxZDhjODNjYTFhOTYyN2Y2MDYxMC4uNzEzZmFhODY1NDM2NzA3Y2RmOThiNTE4MTBi Y2IwZmNlOWQzY2UwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFz dHJlYW0vbWFjL1JlYWx0aW1lT3V0Z29pbmdWaWRlb1NvdXJjZUNvY29hLm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9SZWFsdGltZU91dGdvaW5nVmlkZW9T b3VyY2VDb2NvYS5tbQpAQCAtNzEsMTIgKzcxLDE4IEBAIFJldGFpblB0cjxDVlBpeGVsQnVmZmVy UmVmPiBSZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2VDb2NvYTo6cm90YXRlUGl4ZWxCdWZmZXIo CiAgICAgaWYgKCFyb3RhdGlvbikKICAgICAgICAgcmV0dXJuIHBpeGVsQnVmZmVyOwogCi0gICAg aWYgKCFtX3JvdGF0aW9uU2Vzc2lvbiB8fCByb3RhdGlvbiAhPSBtX2N1cnJlbnRSb3RhdGlvblNl c3Npb25BbmdsZSkgewotICAgICAgICBSRUxFQVNFX0xPR19FUlJPUihXZWJSVEMsICJSZWFsdGlt ZU91dGdvaW5nVmlkZW9Tb3VyY2VDb2NvYTo6cm90YXRlUGl4ZWxCdWZmZXIgY3JlYXRpbmcgcm90 YXRpb24gc2Vzc2lvbiBmb3Igcm90YXRpb24gJXUiLCByb3RhdGlvblRvQW5nbGUocm90YXRpb24p KTsKLSAgICAgICAgSW50U2l6ZSBzaXplID0geyAoaW50KUNWUGl4ZWxCdWZmZXJHZXRXaWR0aChw aXhlbEJ1ZmZlcikgLCAoaW50KUNWUGl4ZWxCdWZmZXJHZXRIZWlnaHQocGl4ZWxCdWZmZXIpIH07 CisgICAgYXV0byBwaXhlbFdpZHRoID0gQ1ZQaXhlbEJ1ZmZlckdldFdpZHRoKHBpeGVsQnVmZmVy KTsKKyAgICBhdXRvIHBpeGVsSGVpZ2h0ID0gQ1ZQaXhlbEJ1ZmZlckdldEhlaWdodChwaXhlbEJ1 ZmZlcik7CisgICAgaWYgKCFtX3JvdGF0aW9uU2Vzc2lvbiB8fCByb3RhdGlvbiAhPSBtX2N1cnJl bnRSb3RhdGlvblNlc3Npb25BbmdsZSB8fCBwaXhlbFdpZHRoICE9IG1fcm90YXRlZFdpZHRoIHx8 IHBpeGVsSGVpZ2h0ICE9IG1fcm90YXRlZEhlaWdodCkgeworICAgICAgICBSRUxFQVNFX0xPR19J TkZPKFdlYlJUQywgIlJlYWx0aW1lT3V0Z29pbmdWaWRlb1NvdXJjZUNvY29hOjpyb3RhdGVQaXhl bEJ1ZmZlciBjcmVhdGluZyByb3RhdGlvbiBzZXNzaW9uIGZvciByb3RhdGlvbiAldSIsIHJvdGF0 aW9uVG9BbmdsZShyb3RhdGlvbikpOworICAgICAgICBJbnRTaXplIHNpemUgPSB7IChpbnQpcGl4 ZWxXaWR0aCAsIChpbnQpcGl4ZWxIZWlnaHQgfTsKICAgICAgICAgQWZmaW5lVHJhbnNmb3JtIHRy YW5zZm9ybTsKICAgICAgICAgdHJhbnNmb3JtLnJvdGF0ZShyb3RhdGlvblRvQW5nbGUocm90YXRp b24pKTsKICAgICAgICAgbV9yb3RhdGlvblNlc3Npb24gPSBtYWtlVW5pcXVlPEltYWdlUm90YXRp b25TZXNzaW9uVlQ+KFdURk1vdmUodHJhbnNmb3JtKSwgc2l6ZSwgSW1hZ2VSb3RhdGlvblNlc3Np b25WVDo6SXNDR0ltYWdlQ29tcGF0aWJsZTo6Tm8pOworCisgICAgICAgIG1fY3VycmVudFJvdGF0 aW9uU2Vzc2lvbkFuZ2xlID0gcm90YXRpb247CisgICAgICAgIG1fcm90YXRlZFdpZHRoID0gcGl4 ZWxXaWR0aDsKKyAgICAgICAgbV9yb3RhdGVkSGVpZ2h0ID0gcGl4ZWxIZWlnaHQ7CiAgICAgfQog CiAgICAgcmV0dXJuIG1fcm90YXRpb25TZXNzaW9uLT5yb3RhdGUocGl4ZWxCdWZmZXIpOwo= 434503 2021-07-28 23:52:14 -0700 2021-07-29 04:22:07 -0700 Patch for landing bug-228549-20210729085212.patch text/plain 2993 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGIzYmM5ZTgwYWM1MzAw M2E1OTdkODIzZjdiNGVjYjFlMGFlYzY3OC4uMjU0ZGZhNGExN2I5OTQzY2FmYTQ0ZjUwZjNhOWJh NTkyOGJiZjAwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTA3LTI4ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWFsdGltZU91dGdvaW5n VmlkZW9Tb3VyY2VDb2NvYTo6cm90YXRlUGl4ZWxCdWZmZXIgc2hvdWxkIHVwZGF0ZSBtX2N1cnJl bnRSb3RhdGlvblNlc3Npb25BbmdsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjI4NTQ5CisgICAgICAgIDxyZGFyOi8vODA2MDg5Nzc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgRXJpYyBDYXJsc29uLgorCisgICAgICAgIERvIG5vdCBmb3JnZXQgdG8g dXBkYXRlIG1fY3VycmVudFJvdGF0aW9uU2Vzc2lvbkFuZ2xlIHdoZW4gY3JlYXRpbmcgYSBuZXcg cm90YXRpb24gc2Vzc2lvbi4KKyAgICAgICAgQWxzbywgbWFrZSBzdXJlIHRvIHJlY3JlYXRlIHJv dGF0aW9uIHNlc3Npb24gaW4gY2FzZSB0aGUgcGl4ZWwgYnVmZmVyIHNpemUgY2hhbmdlcy4KKwor ICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9SZWFsdGltZU91dGdvaW5nVmlkZW9T b3VyY2VDb2NvYS5tbToKKyAgICAgICAgKFdlYkNvcmU6OlJlYWx0aW1lT3V0Z29pbmdWaWRlb1Nv dXJjZUNvY29hOjpyb3RhdGVQaXhlbEJ1ZmZlcik6CisKIDIwMjEtMDctMjcgIEpvb25naHVuIFBh cmsgIDxqaDcxOC5wYXJrQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJlbW92 ZSB0aGUgYnVpbGQgd2FybmluZyBiZWxvdyBzaW5jZSByMjgwMzMyLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL1JlYWx0aW1lT3V0Z29pbmdWaWRl b1NvdXJjZUNvY29hLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFj L1JlYWx0aW1lT3V0Z29pbmdWaWRlb1NvdXJjZUNvY29hLm1tCmluZGV4IGRlM2IzYzliMWNiZTIz Y2U2MTg1MWQ4YzgzY2ExYTk2MjdmNjA2MTAuLjM4NDg1ZmJjMTk1NjE0YmIxNjAxMmY0ZmNiYjM1 YjlkNmQ5ZTJiMDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL21hYy9SZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2VDb2NvYS5tbQorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291 cmNlQ29jb2EubW0KQEAgLTcxLDEyICs3MSwxNyBAQCBSZXRhaW5QdHI8Q1ZQaXhlbEJ1ZmZlclJl Zj4gUmVhbHRpbWVPdXRnb2luZ1ZpZGVvU291cmNlQ29jb2E6OnJvdGF0ZVBpeGVsQnVmZmVyKAog ICAgIGlmICghcm90YXRpb24pCiAgICAgICAgIHJldHVybiBwaXhlbEJ1ZmZlcjsKIAotICAgIGlm ICghbV9yb3RhdGlvblNlc3Npb24gfHwgcm90YXRpb24gIT0gbV9jdXJyZW50Um90YXRpb25TZXNz aW9uQW5nbGUpIHsKLSAgICAgICAgUkVMRUFTRV9MT0dfRVJST1IoV2ViUlRDLCAiUmVhbHRpbWVP dXRnb2luZ1ZpZGVvU291cmNlQ29jb2E6OnJvdGF0ZVBpeGVsQnVmZmVyIGNyZWF0aW5nIHJvdGF0 aW9uIHNlc3Npb24gZm9yIHJvdGF0aW9uICV1Iiwgcm90YXRpb25Ub0FuZ2xlKHJvdGF0aW9uKSk7 Ci0gICAgICAgIEludFNpemUgc2l6ZSA9IHsgKGludClDVlBpeGVsQnVmZmVyR2V0V2lkdGgocGl4 ZWxCdWZmZXIpICwgKGludClDVlBpeGVsQnVmZmVyR2V0SGVpZ2h0KHBpeGVsQnVmZmVyKSB9Owor ICAgIGF1dG8gcGl4ZWxXaWR0aCA9IENWUGl4ZWxCdWZmZXJHZXRXaWR0aChwaXhlbEJ1ZmZlcik7 CisgICAgYXV0byBwaXhlbEhlaWdodCA9IENWUGl4ZWxCdWZmZXJHZXRIZWlnaHQocGl4ZWxCdWZm ZXIpOworICAgIGlmICghbV9yb3RhdGlvblNlc3Npb24gfHwgcm90YXRpb24gIT0gbV9jdXJyZW50 Um90YXRpb25TZXNzaW9uQW5nbGUgfHwgcGl4ZWxXaWR0aCAhPSBtX3JvdGF0ZWRXaWR0aCB8fCBw aXhlbEhlaWdodCAhPSBtX3JvdGF0ZWRIZWlnaHQpIHsKKyAgICAgICAgUkVMRUFTRV9MT0dfSU5G TyhXZWJSVEMsICJSZWFsdGltZU91dGdvaW5nVmlkZW9Tb3VyY2VDb2NvYTo6cm90YXRlUGl4ZWxC dWZmZXIgY3JlYXRpbmcgcm90YXRpb24gc2Vzc2lvbiBmb3Igcm90YXRpb24gJXUiLCByb3RhdGlv blRvQW5nbGUocm90YXRpb24pKTsKICAgICAgICAgQWZmaW5lVHJhbnNmb3JtIHRyYW5zZm9ybTsK ICAgICAgICAgdHJhbnNmb3JtLnJvdGF0ZShyb3RhdGlvblRvQW5nbGUocm90YXRpb24pKTsKLSAg ICAgICAgbV9yb3RhdGlvblNlc3Npb24gPSBtYWtlVW5pcXVlPEltYWdlUm90YXRpb25TZXNzaW9u VlQ+KFdURk1vdmUodHJhbnNmb3JtKSwgc2l6ZSwgSW1hZ2VSb3RhdGlvblNlc3Npb25WVDo6SXND R0ltYWdlQ29tcGF0aWJsZTo6Tm8pOworICAgICAgICBtX3JvdGF0aW9uU2Vzc2lvbiA9IG1ha2VV bmlxdWU8SW1hZ2VSb3RhdGlvblNlc3Npb25WVD4oV1RGTW92ZSh0cmFuc2Zvcm0pLCBGbG9hdFNp emUgeyBzdGF0aWNfY2FzdDxmbG9hdD4ocGl4ZWxXaWR0aCksIHN0YXRpY19jYXN0PGZsb2F0Pihw aXhlbEhlaWdodCkgfSwgSW1hZ2VSb3RhdGlvblNlc3Npb25WVDo6SXNDR0ltYWdlQ29tcGF0aWJs ZTo6Tm8pOworCisgICAgICAgIG1fY3VycmVudFJvdGF0aW9uU2Vzc2lvbkFuZ2xlID0gcm90YXRp b247CisgICAgICAgIG1fcm90YXRlZFdpZHRoID0gcGl4ZWxXaWR0aDsKKyAgICAgICAgbV9yb3Rh dGVkSGVpZ2h0ID0gcGl4ZWxIZWlnaHQ7CiAgICAgfQogCiAgICAgcmV0dXJuIG1fcm90YXRpb25T ZXNzaW9uLT5yb3RhdGUocGl4ZWxCdWZmZXIpOwo=