22849 2008-12-13 22:49:28 -0800 Re-enable Wrec on 64-bit 2008-12-13 23:19:52 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 102474 0 barraclough 2008-12-13 22:49:28 -0800 (works non-debug since olliej's executable allocator). 102475 1 26008 barraclough 2008-12-13 22:50:13 -0800 Created attachment 26008 The patch 102476 2 26009 barraclough 2008-12-13 22:57:05 -0800 Created attachment 26009 Now with new improved changelogy goodness! 102477 3 26009 zwarich 2008-12-13 23:00:59 -0800 Comment on attachment 26009 Now with new improved changelogy goodness! r=me, although in your comment in this bug you made a typo -- Oliver's executable allocator makes it work in Debug. It always worked in Release because we could change the protection flags on TCMalloc's mmap calls. 102479 4 barraclough 2008-12-13 23:19:52 -0800 Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/MacroAssembler.h Sending JavaScriptCore/assembler/X86Assembler.h Sending JavaScriptCore/wtf/Platform.h Transmitting file data .... Committed revision 39287. 26008 2008-12-13 22:50:13 -0800 2008-12-13 22:57:05 -0800 The patch patch.wrec642.txt text/plain 2727 barraclough SW5kZXg6IGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGFzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlci5oCShyZXZpc2lvbiAzOTI4NSkKKysrIGFzc2VtYmxlci9NYWNyb0Fz c2VtYmxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC04NDcsNiArODQ3LDE3IEBAIHByaXZhdGU6CiAg ICAgICAgIH0KICAgICB9CiAKKyAgICB2b2lkIHRlc3RJbW02NChSZWdpc3RlcklEIHJlZywgSW1t MzIgbWFzaykKKyAgICB7CisgICAgICAgIC8vIGlmIHdlIGFyZSBvbmx5IGludGVyZXN0ZWQgaW4g dGhlIGxvdyBzZXZlbiBiaXRzLCB0aGlzIGNhbiBiZSB0ZXN0ZWQgd2l0aCBhIHRlc3RiCisgICAg ICAgIGlmIChtYXNrLm1fdmFsdWUgPT0gLTEpCisgICAgICAgICAgICBtX2Fzc2VtYmxlci50ZXN0 cV9ycihyZWcsIHJlZyk7CisgICAgICAgIGVsc2UgaWYgKChtYXNrLm1fdmFsdWUgJiB+MHg3Zikg PT0gMCkKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLnRlc3RiX2k4cihtYXNrLm1fdmFsdWUsIHJl Zyk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLnRlc3RxX2kzMnIobWFz ay5tX3ZhbHVlLCByZWcpOworICAgIH0KKwogcHVibGljOgogICAgIEp1bXAgamFlMzIoUmVnaXN0 ZXJJRCBsZWZ0LCBJbW0zMiByaWdodCkKICAgICB7CkBAIC0xMDE2LDEyICsxMDI3LDE3IEBAIHB1 YmxpYzoKICAgICAgICAgcmV0dXJuIEp1bXAobV9hc3NlbWJsZXIuam5lKCkpOwogICAgIH0KICAg ICAKLSNpZiAhUExBVEZPUk0oWDg2XzY0KQogICAgIEp1bXAgam56UHRyKFJlZ2lzdGVySUQgcmVn LCBJbW0zMiBtYXNrID0gSW1tMzIoLTEpKQogICAgIHsKKyNpZiBQTEFURk9STShYODZfNjQpCisg ICAgICAgIHRlc3RJbW02NChyZWcsIG1hc2spOworICAgICAgICByZXR1cm4gSnVtcChtX2Fzc2Vt Ymxlci5qbmUoKSk7CisjZWxzZQogICAgICAgICByZXR1cm4gam56MzIocmVnLCBtYXNrKTsKKyNl bmRpZgogICAgIH0KIAorI2lmICFQTEFURk9STShYODZfNjQpCiAgICAgSnVtcCBqbnpQdHIoQWRk cmVzcyBhZGRyZXNzLCBJbW0zMiBtYXNrID0gSW1tMzIoLTEpKQogICAgIHsKICAgICAgICAgcmV0 dXJuIGpuejMyKGFkZHJlc3MsIG1hc2spOwpJbmRleDogYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIGFzc2VtYmxlci9YODZBc3NlbWJsZXIuaAkocmV2aXNpb24gMzkyODUp CisrKyBhc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTYwMiw2ICs2 MDIsMjIgQEAgcHVibGljOgogICAgICAgICBtb2RSbV9ycihzcmMsIGRzdCk7CiAgICAgfQogICAg IAorICAgIHZvaWQgdGVzdHFfaTMycihpbnQgaW1tLCBSZWdpc3RlcklEIGRzdCkKKyAgICB7Cisg ICAgICAgIG1fYnVmZmVyLmVuc3VyZVNwYWNlKG1heEluc3RydWN0aW9uU2l6ZSk7CisgICAgICAg IG1fYnVmZmVyLnB1dEJ5dGVVbmNoZWNrZWQoUkVYX1cpOworICAgICAgICBtX2J1ZmZlci5wdXRC eXRlVW5jaGVja2VkKE9QX0dST1VQM19Fdkl6KTsKKyAgICAgICAgbW9kUm1fb3ByX1VuY2hlY2tl ZChHUk9VUDNfT1BfVEVTVCwgZHN0KTsKKyAgICAgICAgbV9idWZmZXIucHV0SW50VW5jaGVja2Vk KGltbSk7CisgICAgfQorCisgICAgdm9pZCB0ZXN0cV9ycihSZWdpc3RlcklEIHNyYywgUmVnaXN0 ZXJJRCBkc3QpCisgICAgeworICAgICAgICBtX2J1ZmZlci5wdXRCeXRlKFJFWF9XKTsKKyAgICAg ICAgbV9idWZmZXIucHV0Qnl0ZShPUF9URVNUX0V2R3YpOworICAgICAgICBtb2RSbV9ycihzcmMs IGRzdCk7CisgICAgfQorICAgIAogICAgIHZvaWQgeG9ybF9pOHIoaW50IGltbSwgUmVnaXN0ZXJJ RCBkc3QpCiAgICAgewogICAgICAgICBtX2J1ZmZlci5wdXRCeXRlKE9QX0dST1VQMV9FdkliKTsK SW5kZXg6IHd0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHd0Zi9QbGF0Zm9ybS5oCShyZXZp c2lvbiAzOTI4NSkKKysrIHd0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC00MzEsOCAr NDMxLDEwIEBACiAjZGVmaW5lIEVOQUJMRV9KSVRfT1BUSU1JWkVfQVJJVEhNRVRJQyAxCiAjZW5k aWYKIAotLyogV1JFQyBvbmx5IHN1cHBvcnRzIHg4NiBhdCB0aGUgbW9tZW50LCBhbmQgaGFzIG9u bHkgYmVlbiB0ZXN0ZWQgb24gTWFjIGFuZCBXaW5kb3dzLiAqLwotI2lmICFkZWZpbmVkKEVOQUJM RV9XUkVDKSAmJiBQTEFURk9STShYODYpICYmIChQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFdJ TikpCisvKiBXUkVDIHN1cHBvcnRzIHg4NiAmIHg4Ni02NCwgYW5kIGhhcyBiZWVuIHRlc3RlZCBv biBNYWMgYW5kIFdpbmRvd3MgKCdjZXB0IG9uIDY0LWJpdCBvbiBNYWMpLiAqLworI2lmICghZGVm aW5lZChFTkFCTEVfV1JFQykgJiYgUExBVEZPUk0oWDg2KSAmJiBQTEFURk9STShNQUMpKSBcCisg fHwgKCFkZWZpbmVkKEVOQUJMRV9XUkVDKSAmJiBQTEFURk9STShYODZfNjQpICYmIFBMQVRGT1JN KE1BQykpIFwKKyB8fCAoIWRlZmluZWQoRU5BQkxFX1dSRUMpICYmIFBMQVRGT1JNKFg4NikgJiYg UExBVEZPUk0oV0lOKSkKICNkZWZpbmUgRU5BQkxFX1dSRUMgMQogI2VuZGlmCiAK 26009 2008-12-13 22:57:05 -0800 2008-12-13 23:00:59 -0800 Now with new improved changelogy goodness! patch.wrec643.txt text/plain 3540 barraclough SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM5Mjg2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDgtMTIt MTMgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlLWVuYWJsZSBXUkVDIG9u IDY0LWJpdC4KKyAgICAgICAgSW1wbGVtZW50cyBvbmUgb2YgdGhlIE1hY3JvQXNzZW1ibGVyOjpq bnpQdHIgbWV0aG9kcywgcHJldmlvdXNseSBvbmx5IGltcGxlbWVudGVkIGZvciAzMi1iaXQgeDg2 LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjg0 OQorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6 Ok1hY3JvQXNzZW1ibGVyOjp0ZXN0SW1tNjQpOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxl cjo6am56UHRyKToKKyAgICAgICAgKiBhc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmg6CisgICAgICAg IChKU0M6Olg4NkFzc2VtYmxlcjo6dGVzdHFfaTMycik6CisgICAgICAgIChKU0M6Olg4NkFzc2Vt Ymxlcjo6dGVzdHFfcnIpOgorICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDA4LTEyLTEz ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBG aXggUFBDIGJ1aWxkcy4KSW5kZXg6IGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oCShyZXZpc2lvbiAzOTI4NCkKKysrIGFz c2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC04NDcsNiArODQ3LDE3 IEBAIHByaXZhdGU6CiAgICAgICAgIH0KICAgICB9CiAKKyAgICB2b2lkIHRlc3RJbW02NChSZWdp c3RlcklEIHJlZywgSW1tMzIgbWFzaykKKyAgICB7CisgICAgICAgIC8vIGlmIHdlIGFyZSBvbmx5 IGludGVyZXN0ZWQgaW4gdGhlIGxvdyBzZXZlbiBiaXRzLCB0aGlzIGNhbiBiZSB0ZXN0ZWQgd2l0 aCBhIHRlc3RiCisgICAgICAgIGlmIChtYXNrLm1fdmFsdWUgPT0gLTEpCisgICAgICAgICAgICBt X2Fzc2VtYmxlci50ZXN0cV9ycihyZWcsIHJlZyk7CisgICAgICAgIGVsc2UgaWYgKChtYXNrLm1f dmFsdWUgJiB+MHg3ZikgPT0gMCkKKyAgICAgICAgICAgIG1fYXNzZW1ibGVyLnRlc3RiX2k4ciht YXNrLm1fdmFsdWUsIHJlZyk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIG1fYXNzZW1ibGVy LnRlc3RxX2kzMnIobWFzay5tX3ZhbHVlLCByZWcpOworICAgIH0KKwogcHVibGljOgogICAgIEp1 bXAgamFlMzIoUmVnaXN0ZXJJRCBsZWZ0LCBJbW0zMiByaWdodCkKICAgICB7CkBAIC0xMDE2LDEy ICsxMDI3LDE3IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIEp1bXAobV9hc3NlbWJsZXIuam5l KCkpOwogICAgIH0KICAgICAKLSNpZiAhUExBVEZPUk0oWDg2XzY0KQogICAgIEp1bXAgam56UHRy KFJlZ2lzdGVySUQgcmVnLCBJbW0zMiBtYXNrID0gSW1tMzIoLTEpKQogICAgIHsKKyNpZiBQTEFU Rk9STShYODZfNjQpCisgICAgICAgIHRlc3RJbW02NChyZWcsIG1hc2spOworICAgICAgICByZXR1 cm4gSnVtcChtX2Fzc2VtYmxlci5qbmUoKSk7CisjZWxzZQogICAgICAgICByZXR1cm4gam56MzIo cmVnLCBtYXNrKTsKKyNlbmRpZgogICAgIH0KIAorI2lmICFQTEFURk9STShYODZfNjQpCiAgICAg SnVtcCBqbnpQdHIoQWRkcmVzcyBhZGRyZXNzLCBJbW0zMiBtYXNrID0gSW1tMzIoLTEpKQogICAg IHsKICAgICAgICAgcmV0dXJuIGpuejMyKGFkZHJlc3MsIG1hc2spOwpJbmRleDogYXNzZW1ibGVy L1g4NkFzc2VtYmxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGFzc2VtYmxlci9YODZBc3NlbWJsZXIuaAko cmV2aXNpb24gMzkyODQpCisrKyBhc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmgJKHdvcmtpbmcgY29w eSkKQEAgLTYwMiw2ICs2MDIsMjIgQEAgcHVibGljOgogICAgICAgICBtb2RSbV9ycihzcmMsIGRz dCk7CiAgICAgfQogICAgIAorICAgIHZvaWQgdGVzdHFfaTMycihpbnQgaW1tLCBSZWdpc3RlcklE IGRzdCkKKyAgICB7CisgICAgICAgIG1fYnVmZmVyLmVuc3VyZVNwYWNlKG1heEluc3RydWN0aW9u U2l6ZSk7CisgICAgICAgIG1fYnVmZmVyLnB1dEJ5dGVVbmNoZWNrZWQoUkVYX1cpOworICAgICAg ICBtX2J1ZmZlci5wdXRCeXRlVW5jaGVja2VkKE9QX0dST1VQM19Fdkl6KTsKKyAgICAgICAgbW9k Um1fb3ByX1VuY2hlY2tlZChHUk9VUDNfT1BfVEVTVCwgZHN0KTsKKyAgICAgICAgbV9idWZmZXIu cHV0SW50VW5jaGVja2VkKGltbSk7CisgICAgfQorCisgICAgdm9pZCB0ZXN0cV9ycihSZWdpc3Rl cklEIHNyYywgUmVnaXN0ZXJJRCBkc3QpCisgICAgeworICAgICAgICBtX2J1ZmZlci5wdXRCeXRl KFJFWF9XKTsKKyAgICAgICAgbV9idWZmZXIucHV0Qnl0ZShPUF9URVNUX0V2R3YpOworICAgICAg ICBtb2RSbV9ycihzcmMsIGRzdCk7CisgICAgfQorICAgIAogICAgIHZvaWQgeG9ybF9pOHIoaW50 IGltbSwgUmVnaXN0ZXJJRCBkc3QpCiAgICAgewogICAgICAgICBtX2J1ZmZlci5wdXRCeXRlKE9Q X0dST1VQMV9FdkliKTsKSW5kZXg6IHd0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHd0Zi9Q bGF0Zm9ybS5oCShyZXZpc2lvbiAzOTI4NCkKKysrIHd0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNv cHkpCkBAIC00MzEsOCArNDMxLDEwIEBACiAjZGVmaW5lIEVOQUJMRV9KSVRfT1BUSU1JWkVfQVJJ VEhNRVRJQyAxCiAjZW5kaWYKIAotLyogV1JFQyBvbmx5IHN1cHBvcnRzIHg4NiBhdCB0aGUgbW9t ZW50LCBhbmQgaGFzIG9ubHkgYmVlbiB0ZXN0ZWQgb24gTWFjIGFuZCBXaW5kb3dzLiAqLwotI2lm ICFkZWZpbmVkKEVOQUJMRV9XUkVDKSAmJiBQTEFURk9STShYODYpICYmIChQTEFURk9STShNQUMp IHx8IFBMQVRGT1JNKFdJTikpCisvKiBXUkVDIHN1cHBvcnRzIHg4NiAmIHg4Ni02NCwgYW5kIGhh cyBiZWVuIHRlc3RlZCBvbiBNYWMgYW5kIFdpbmRvd3MgKCdjZXB0IG9uIDY0LWJpdCBvbiBNYWMp LiAqLworI2lmICghZGVmaW5lZChFTkFCTEVfV1JFQykgJiYgUExBVEZPUk0oWDg2KSAmJiBQTEFU Rk9STShNQUMpKSBcCisgfHwgKCFkZWZpbmVkKEVOQUJMRV9XUkVDKSAmJiBQTEFURk9STShYODZf NjQpICYmIFBMQVRGT1JNKE1BQykpIFwKKyB8fCAoIWRlZmluZWQoRU5BQkxFX1dSRUMpICYmIFBM QVRGT1JNKFg4NikgJiYgUExBVEZPUk0oV0lOKSkKICNkZWZpbmUgRU5BQkxFX1dSRUMgMQogI2Vu ZGlmCiAK