22842 2008-12-13 03:44:18 -0800 [Gtk] Top offsets of elements in DumpRenderTree are incorrect 2008-12-31 09:01:41 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 zan webkit-unassigned oldest_to_newest 102427 0 zan 2008-12-13 03:44:18 -0800 Element's top offset values when running the tests through DumpRenderTree differ from those when viewing test in GtkLauncher. A proof-of-problem patch to come. 102428 1 25997 zan 2008-12-13 04:33:39 -0800 Created attachment 25997 Patch for reproducing the problem This patch works with tests for SVG dynamic updates. Through all these tests, the two outputs seem to be constant: - when viewing any test in GtkLauncher, top offset is 66, - when running any test in DRT, top offset is 311. Left offset is always 8. The difference occurs in RenderObject's offsetTop function, more precisely in this iteration[1] - it goes through one loop, in which curr is a RenderObject with #document node and is not a table row. His yPos() is then added to y. In GtkLauncher, 58 is added to y, while in DRT y is increased by 303. y then increases to the final value when offsetPar is recognized as a body and adds its yPos() (which equals to 8) to the y variable. [1] http://trac.webkit.org/browser/trunk/WebCore/rendering/RenderObject.cpp#L538 103588 2 26279 zan 2008-12-28 08:45:24 -0800 Created attachment 26279 Fix - move size allocation to a proper place As it turns out, the problem is solved with a proper placement of widget's size allocation. At the moment, size allocation is done at dumping, when testing is already done. However, it should be done before loading the test in the WebKitWebView. Patch changes this. 103917 3 zecke 2008-12-31 09:01:41 -0800 Landed in r39529. 25997 2008-12-13 04:33:39 -0800 2008-12-13 04:33:39 -0800 Patch for reproducing the problem pop.patch text/plain 1082 zan SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCShyZXZpc2lvbiAzOTI0OCkKKysrIExheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0yMTI0LDcgKzIx MjQsNiBAQCBwcmludGluZwogc2Nyb2xsYmFycwogc2VjdXJpdHkKIHN0b3JhZ2UKLXN2ZwogdGFi bGVzCiB0cmFuc2Zvcm1zCiB0cmFuc2l0aW9ucwpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL2R5bmFt aWMtdXBkYXRlcy9yZXNvdXJjZXMvU1ZHVGVzdENhc2UuanMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvc3ZnL2R5bmFtaWMtdXBkYXRlcy9yZXNvdXJjZXMvU1ZHVGVzdENhc2UuanMJKHJldmlz aW9uIDM5MjQ4KQorKysgTGF5b3V0VGVzdHMvc3ZnL2R5bmFtaWMtdXBkYXRlcy9yZXNvdXJjZXMv U1ZHVGVzdENhc2UuanMJKHdvcmtpbmcgY29weSkKQEAgLTI1LDYgKzI1LDExIEBAIGZ1bmN0aW9u IHRyaWdnZXJVcGRhdGUoeCwgeSkgewogICAgIHggPSB4ICsgcm9vdFNWR0VsZW1lbnQub2Zmc2V0 TGVmdDsKICAgICB5ID0geSArIHJvb3RTVkdFbGVtZW50Lm9mZnNldFRvcDsKIAorICAgIGRlYnVn bm9kZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNwYW4iKTsKKyAgICBkb2N1bWVudC5ib2R5 LmFwcGVuZENoaWxkKGRlYnVnbm9kZSk7CisgICAgZGVidWdub2RlLmlubmVyVGV4dCA9ICJPZmZz ZXRzOiBvZmZzZXRMZWZ0PSIgKyByb290U1ZHRWxlbWVudC5vZmZzZXRMZWZ0CisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKyAiLCBvZmZzZXRUb3A9IiArIHJvb3RTVkdFbGVtZW50Lm9mZnNl dFRvcDsKKwogICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsKICAgICAgICAgZXZlbnRTZW5k ZXIubW91c2VNb3ZlVG8oeCwgeSk7CiAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOwo= 26279 2008-12-28 08:45:24 -0800 2008-12-31 06:23:03 -0800 Fix - move size allocation to a proper place p.patch text/plain 2065 zan SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM5NDkwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMTItMjggIFphbiBEb2JlcnNlayAgPHph bmRvYmVyc2VrQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4 NDIKKworICAgICAgICBNb3ZlIFdlYktpdFdlYlZpZXcncyBzaXplIGFsbG9jYXRpb24gaW50byBh IHByb3BlciBwbGFjZS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVy VHJlZS5jcHA6CisgICAgICAgIChkdW1wKToKKyAgICAgICAgKHJ1blRlc3QpOgorCiAyMDA4LTEy LTI0ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg VGltb3RoeSBIYXRjaGVyLgpJbmRleDogV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1 bXBSZW5kZXJUcmVlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS9ndGsvRHVtcFJlbmRlclRyZWUuY3BwCShyZXZpc2lvbiAzOTQ5MCkKKysrIFdlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTE0NywxNSArMTQ3LDggQEAgdm9pZCBkdW1wKCkKICAgICAgICAgZ0xheW91dFRlc3RDb250cm9s bGVyLT5zZXREdW1wQXNUZXh0KGR1bXBBc1RleHQpOwogICAgICAgICBpZiAoZ0xheW91dFRlc3RD b250cm9sbGVyLT5kdW1wQXNUZXh0KCkpCiAgICAgICAgICAgICByZXN1bHQgPSBkdW1wRnJhbWVz QXNUZXh0KG1haW5GcmFtZSk7Ci0gICAgICAgIGVsc2UgewotICAgICAgICAgICAgYm9vbCBpc1NW R1czQ1Rlc3QgPSAoZ0xheW91dFRlc3RDb250cm9sbGVyLT50ZXN0UGF0aE9yVVJMKCkuZmluZCgi c3ZnL1czQy1TVkctMS4xIikgIT0gc3RyaW5nOjpucG9zKTsKLSAgICAgICAgICAgIEd0a0FsbG9j YXRpb24gc2l6ZTsKLSAgICAgICAgICAgIHNpemUud2lkdGggPSBpc1NWR1czQ1Rlc3QgPyA0ODAg OiBtYXhWaWV3V2lkdGg7Ci0gICAgICAgICAgICBzaXplLmhlaWdodCA9IGlzU1ZHVzNDVGVzdCA/ IDM2MCA6IG1heFZpZXdIZWlnaHQ7Ci0gICAgICAgICAgICBndGtfd2lkZ2V0X3NpemVfYWxsb2Nh dGUoR1RLX1dJREdFVCh3ZWJWaWV3KSwgJnNpemUpOwotCisgICAgICAgIGVsc2UKICAgICAgICAg ICAgIHJlc3VsdCA9IHdlYmtpdF93ZWJfZnJhbWVfZHVtcF9yZW5kZXJfdHJlZShtYWluRnJhbWUp OwotICAgICAgICB9CiAKICAgICAgICAgaWYgKCFyZXN1bHQpIHsKICAgICAgICAgICAgIGNvbnN0 IGNoYXIqIGVycm9yTWVzc2FnZTsKQEAgLTI0Nyw2ICsyNDAsMTIgQEAgc3RhdGljIHZvaWQgcnVu VGVzdChjb25zdCBzdHJpbmcmIHRlc3RQYQogICAgIFdvcmtRdWV1ZTo6c2hhcmVkKCktPmNsZWFy KCk7CiAgICAgV29ya1F1ZXVlOjpzaGFyZWQoKS0+c2V0RnJvemVuKGZhbHNlKTsKIAorICAgIGJv b2wgaXNTVkdXM0NUZXN0ID0gKGdMYXlvdXRUZXN0Q29udHJvbGxlci0+dGVzdFBhdGhPclVSTCgp LmZpbmQoInN2Zy9XM0MtU1ZHLTEuMSIpICE9IHN0cmluZzo6bnBvcyk7CisgICAgR3RrQWxsb2Nh dGlvbiBzaXplOworICAgIHNpemUud2lkdGggPSBpc1NWR1czQ1Rlc3QgPyA0ODAgOiBtYXhWaWV3 V2lkdGg7CisgICAgc2l6ZS5oZWlnaHQgPSBpc1NWR1czQ1Rlc3QgPyAzNjAgOiBtYXhWaWV3SGVp Z2h0OworICAgIGd0a193aWRnZXRfc2l6ZV9hbGxvY2F0ZShHVEtfV0lER0VUKHdlYlZpZXcpLCAm c2l6ZSk7CisKICAgICB3ZWJraXRfd2ViX3ZpZXdfb3Blbih3ZWJWaWV3LCB1cmwpOwogCiAgICAg Z19mcmVlKHVybCk7Cg==