22837 2008-12-12 19:09:39 -0800 Remove dependency on the bytecode Instruction buffer in Interpreter::cti_op_call_NotJSFunction 2008-12-16 18:35:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 sam webkit-unassigned zwarich oldest_to_newest 102414 0 sam 2008-12-12 19:09:39 -0800 Interpreter::cti_op_call_NotJSFunction is one of the few remaining places where we require access to the bytecode Instruction buffer from JIT code. In order to purge the buffer after native code generation, we need to fix this. 102417 1 sam 2008-12-12 19:13:39 -0800 Related to <rdar://problem/6428342> 102737 2 26080 sam 2008-12-16 18:06:27 -0800 Created attachment 26080 patch 102741 3 26080 barraclough 2008-12-16 18:27:26 -0800 Comment on attachment 26080 patch please comment that the Instruction* may not actually be an Instruction*, r+ 102742 4 sam 2008-12-16 18:35:19 -0800 Fixed in r39351. One to go. 26080 2008-12-16 18:06:27 -0800 2008-12-16 18:27:26 -0800 patch patch.diff text/plain 3373 sam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM5MzQ4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDgtMTIt MTYgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjgzNworICAgICAgICBSZW1vdmUgZGVwZW5kZW5jeSBvbiB0aGUg Ynl0ZWNvZGUgSW5zdHJ1Y3Rpb24gYnVmZmVyIGluIEludGVycHJldGVyOjpjdGlfb3BfY2FsbF9O b3RKU0Z1bmN0aW9uCisgICAgICAgIFBhcnQgb2YgPHJkYXI6Ly9wcm9ibGVtLzY0MjgzNDI+CisK KyAgICAgICAgKiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OmJ5 dGVjb2RlT2Zmc2V0Rm9yUEMpOiBXZSBubyBsb25nZXIgaGF2ZSBhbnkgY2FzZXMgb2YgdGhlIFBD CisgICAgICAgIGJlaW5nIGluIHRoZSBpbnN0cnVjdGlvbiBzdHJlYW0gZm9yIEpJVCwgc28gd2Ug Y2FuIHJlbW92ZSB0aGUgY2hlY2suCisgICAgICAgIChKU0M6OkludGVycHJldGVyOjpjdGlfb3Bf Y2FsbF9Ob3RKU0Z1bmN0aW9uKTogVXNlIHRoZSBDVElfUkVUVVJOX0FERFJFU1MKKyAgICAgICAg YXMgdGhlIGNhbGwgZnJhbWUgcmV0dXJuUEMgYXMgaXQgaXMgb25seSBuZWNlc3NhcnkgZm9yIGxv b2tpbmcgdXAgd2hlbgorICAgICAgICB0aHJvd2luZyBhbiBleGNlcHRpb24uCisgICAgICAgICog aml0L0pJVC5oOiBSZW1vdmUgQVJHX2luc3RyNC4KKyAgICAgICAgKiBqaXQvSklUQ2FsbC5jcHA6 CisgICAgICAgIChKU0M6OkpJVDo6Y29tcGlsZU9wQ2FsbFNldHVwQXJncyk6IERvbid0IHBhc3Mg dGhlIGluc3RydWN0aW9uIHBvaW50ZXIuCisKIDIwMDgtMTItMTYgIEdhdmluIEJhcnJhY2xvdWdo ICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCBmb3IgJ2RvemUu CkluZGV4OiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaW50ZXJw cmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCShyZXZpc2lvbiAzOTM0MSkKKysrIGludGVycHJldGVyL0lu dGVycHJldGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTEsOCArOTEsNiBAQCBzdGF0aWMgY29u c3QgaW50IHByZWZlcnJlZFNjcmlwdENoZWNrVGltCiBzdGF0aWMgQUxXQVlTX0lOTElORSB1bnNp Z25lZCBieXRlY29kZU9mZnNldEZvclBDKENvZGVCbG9jayogY29kZUJsb2NrLCB2b2lkKiBwYykK IHsKICNpZiBFTkFCTEUoSklUKQotICAgIGlmIChwYyA+PSBjb2RlQmxvY2stPmluc3RydWN0aW9u cygpLmJlZ2luKCkgJiYgcGMgPCBjb2RlQmxvY2stPmluc3RydWN0aW9ucygpLmVuZCgpKQotICAg ICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8SW5zdHJ1Y3Rpb24qPihwYykgLSBjb2RlQmxvY2stPmlu c3RydWN0aW9ucygpLmJlZ2luKCk7CiAgICAgcmV0dXJuIGNvZGVCbG9jay0+Z2V0Qnl0ZWNvZGVJ bmRleChwYyk7CiAjZWxzZQogICAgIHJldHVybiBzdGF0aWNfY2FzdDxJbnN0cnVjdGlvbio+KHBj KSAtIGNvZGVCbG9jay0+aW5zdHJ1Y3Rpb25zKCkuYmVnaW4oKTsKQEAgLTQ5MDcsNyArNDkwNSw3 IEBAIEpTVmFsdWUqIEludGVycHJldGVyOjpjdGlfb3BfY2FsbF9Ob3RKU0YKICAgICAgICAgQ2Fs bEZyYW1lKiBwcmV2aW91c0NhbGxGcmFtZSA9IEFSR19jYWxsRnJhbWU7CiAgICAgICAgIENhbGxG cmFtZSogY2FsbEZyYW1lID0gQ2FsbEZyYW1lOjpjcmVhdGUocHJldmlvdXNDYWxsRnJhbWUtPnJl Z2lzdGVycygpICsgcmVnaXN0ZXJPZmZzZXQpOwogCi0gICAgICAgIGNhbGxGcmFtZS0+aW5pdCgw LCBBUkdfaW5zdHI0ICsgMSwgcHJldmlvdXNDYWxsRnJhbWUtPnNjb3BlQ2hhaW4oKSwgcHJldmlv dXNDYWxsRnJhbWUsIDAsIGFyZ0NvdW50LCAwKTsKKyAgICAgICAgY2FsbEZyYW1lLT5pbml0KDAs IHN0YXRpY19jYXN0PEluc3RydWN0aW9uKj4oQ1RJX1JFVFVSTl9BRERSRVNTKSwgcHJldmlvdXND YWxsRnJhbWUtPnNjb3BlQ2hhaW4oKSwgcHJldmlvdXNDYWxsRnJhbWUsIDAsIGFyZ0NvdW50LCAw KTsKICAgICAgICAgQVJHX3NldENhbGxGcmFtZShjYWxsRnJhbWUpOwogCiAgICAgICAgIFJlZ2lz dGVyKiBhcmd2ID0gQVJHX2NhbGxGcmFtZS0+cmVnaXN0ZXJzKCkgLSBSZWdpc3RlckZpbGU6OkNh bGxGcmFtZUhlYWRlclNpemUgLSBhcmdDb3VudDsKSW5kZXg6IGppdC9KSVQuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBqaXQvSklULmgJKHJldmlzaW9uIDM5MzQxKQorKysgaml0L0pJVC5oCSh3b3JraW5nIGNv cHkpCkBAIC03NCw3ICs3NCw2IEBACiAjZGVmaW5lIEFSR19mdW5jZXhwMSBzdGF0aWNfY2FzdDxG dW5jRXhwck5vZGUqPihBUkdTWzFdKQogI2RlZmluZSBBUkdfcmVnZXhwMSBzdGF0aWNfY2FzdDxS ZWdFeHAqPihBUkdTWzFdKQogI2RlZmluZSBBUkdfcG5pMSBzdGF0aWNfY2FzdDxKU1Byb3BlcnR5 TmFtZUl0ZXJhdG9yKj4oQVJHU1sxXSkKLSNkZWZpbmUgQVJHX2luc3RyNCBzdGF0aWNfY2FzdDxJ bnN0cnVjdGlvbio+KEFSR1NbNF0pCiAjZGVmaW5lIEFSR19yZXR1cm5BZGRyZXNzMiBzdGF0aWNf Y2FzdDx2b2lkKj4oQVJHU1syXSkKICNkZWZpbmUgQVJHX2NvZGVCbG9jazQgc3RhdGljX2Nhc3Q8 Q29kZUJsb2NrKj4oQVJHU1s0XSkKIApJbmRleDogaml0L0pJVENhbGwuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIGppdC9KSVRDYWxsLmNwcAkocmV2aXNpb24gMzkzNDEpCisrKyBqaXQvSklUQ2FsbC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTkxLDcgKzkxLDYgQEAgdm9pZCBKSVQ6OmNvbXBpbGVPcENhbGxT ZXR1cEFyZ3MoSW5zdHJ1YwogICAgIGVtaXRQdXRKSVRTdHViQXJnKFg4Njo6ZWN4LCAxKTsKICAg ICBlbWl0UHV0SklUU3R1YkFyZ0NvbnN0YW50KHJlZ2lzdGVyT2Zmc2V0LCAyKTsKICAgICBlbWl0 UHV0SklUU3R1YkFyZ0NvbnN0YW50KGFyZ0NvdW50LCAzKTsKLSAgICBlbWl0UHV0SklUU3R1YkFy Z0NvbnN0YW50KHJlaW50ZXJwcmV0X2Nhc3Q8dW5zaWduZWQ+KGluc3RydWN0aW9uKSwgNCk7CiB9 CiAKIHZvaWQgSklUOjpjb21waWxlT3BDYWxsRXZhbFNldHVwQXJncyhJbnN0cnVjdGlvbiogaW5z dHJ1Y3Rpb24pCg==