22835 2008-12-12 17:20:28 -0800 Crash during bytecode generation when comparing to null 2008-12-12 17:47:58 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P1 Normal --- 1 zwarich zwarich oldest_to_newest 102403 0 zwarich 2008-12-12 17:20:28 -0800 The following crashes: function f(a) { a != null; } f(); I have the fix. 102406 1 zwarich 2008-12-12 17:37:13 -0800 <rdar://problem/6286749> 102408 2 25994 zwarich 2008-12-12 17:43:07 -0800 Created attachment 25994 Proposed patch 102409 3 zwarich 2008-12-12 17:47:58 -0800 Landed in r39263. 25994 2008-12-12 17:43:07 -0800 2008-12-12 17:45:53 -0800 Proposed patch null.diff text/plain 5070 zwarich SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM5MjYwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDgtMTItMTIgIENhbWVyb24g WndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMjgzNTogQ3Jhc2ggZHVyaW5nIGJ5dGVjb2RlIGdl bmVyYXRpb24gd2hlbiBjb21wYXJpbmcgdG8gbnVsbAorICAgICAgICA8aHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyODM1PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NjI4Njc0OT4KKworICAgICAgICBDaGFuZ2UgdGhlIHNwZWNpYWwgY2FzZXMgaW4gYnl0ZWNvZGUg Z2VuZXJhdGlvbiBmb3IgY29tcGFyaXNvbiB0byBudWxsCisgICAgICAgIHRvIHVzZSB0ZW1wRGVz dGluYXRpb24oKS4KKworICAgICAgICAqIHBhcnNlci9Ob2Rlcy5jcHA6CisgICAgICAgIChKU0M6 OkJpbmFyeU9wTm9kZTo6ZW1pdEJ5dGVjb2RlKToKKyAgICAgICAgKEpTQzo6RXF1YWxOb2RlOjpl bWl0Qnl0ZWNvZGUpOgorCiAyMDA4LTEyLTEyICBDYW1lcm9uIFp3YXJpY2ggIDx6d2FyaWNoQGFw cGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTYW0gV2VpbmlnLgpJbmRleDogSmF2YVNj cmlwdENvcmUvcGFyc2VyL05vZGVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9w YXJzZXIvTm9kZXMuY3BwCShyZXZpc2lvbiAzOTI1NSkKKysrIEphdmFTY3JpcHRDb3JlL3BhcnNl ci9Ob2Rlcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMTQsNyArMTExNCw4IEBAIFJlZ2lzdGVy SUQqIEJpbmFyeU9wTm9kZTo6ZW1pdEJ5dGVjb2RlKEIKICAgICBPcGNvZGVJRCBvcGNvZGVJRCA9 IHRoaXMtPm9wY29kZUlEKCk7CiAgICAgaWYgKG9wY29kZUlEID09IG9wX25lcSkgewogICAgICAg ICBpZiAobV9leHByMS0+aXNOdWxsKCkgfHwgbV9leHByMi0+aXNOdWxsKCkpIHsKLSAgICAgICAg ICAgIFJlZlB0cjxSZWdpc3RlcklEPiBzcmMgPSBnZW5lcmF0b3IuZW1pdE5vZGUoZHN0LCBtX2V4 cHIxLT5pc051bGwoKSA/IG1fZXhwcjIuZ2V0KCkgOiBtX2V4cHIxLmdldCgpKTsKKyAgICAgICAg ICAgIFJlZlB0cjxSZWdpc3RlcklEPiBzcmMgPSBnZW5lcmF0b3IudGVtcERlc3RpbmF0aW9uKGRz dCk7CisgICAgICAgICAgICBnZW5lcmF0b3IuZW1pdE5vZGUoc3JjLmdldCgpLCBtX2V4cHIxLT5p c051bGwoKSA/IG1fZXhwcjIuZ2V0KCkgOiBtX2V4cHIxLmdldCgpKTsKICAgICAgICAgICAgIHJl dHVybiBnZW5lcmF0b3IuZW1pdFVuYXJ5T3Aob3BfbmVxX251bGwsIGdlbmVyYXRvci5maW5hbERl c3RpbmF0aW9uKGRzdCwgc3JjLmdldCgpKSwgc3JjLmdldCgpKTsKICAgICAgICAgfQogICAgIH0K QEAgLTExMjcsNyArMTEyOCw4IEBAIFJlZ2lzdGVySUQqIEJpbmFyeU9wTm9kZTo6ZW1pdEJ5dGVj b2RlKEIKIFJlZ2lzdGVySUQqIEVxdWFsTm9kZTo6ZW1pdEJ5dGVjb2RlKEJ5dGVjb2RlR2VuZXJh dG9yJiBnZW5lcmF0b3IsIFJlZ2lzdGVySUQqIGRzdCkKIHsKICAgICBpZiAobV9leHByMS0+aXNO dWxsKCkgfHwgbV9leHByMi0+aXNOdWxsKCkpIHsKLSAgICAgICAgUmVmUHRyPFJlZ2lzdGVySUQ+ IHNyYyA9IGdlbmVyYXRvci5lbWl0Tm9kZShkc3QsIG1fZXhwcjEtPmlzTnVsbCgpID8gbV9leHBy Mi5nZXQoKSA6IG1fZXhwcjEuZ2V0KCkpOworICAgICAgICBSZWZQdHI8UmVnaXN0ZXJJRD4gc3Jj ID0gZ2VuZXJhdG9yLnRlbXBEZXN0aW5hdGlvbihkc3QpOworICAgICAgICBnZW5lcmF0b3IuZW1p dE5vZGUoc3JjLmdldCgpLCBtX2V4cHIxLT5pc051bGwoKSA/IG1fZXhwcjIuZ2V0KCkgOiBtX2V4 cHIxLmdldCgpKTsKICAgICAgICAgcmV0dXJuIGdlbmVyYXRvci5lbWl0VW5hcnlPcChvcF9lcV9u dWxsLCBnZW5lcmF0b3IuZmluYWxEZXN0aW5hdGlvbihkc3QsIHNyYy5nZXQoKSksIHNyYy5nZXQo KSk7CiAgICAgfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzOTI2MCkKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDA4LTEyLTEyICBDYW1l cm9uIFp3YXJpY2ggIDx6d2FyaWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0cyBmb3IgYnVnIDIyODM1OiBDcmFzaCBkdXJp bmcgYnl0ZWNvZGUgZ2VuZXJhdGlvbiB3aGVuIGNvbXBhcmluZyB0byBudWxsCisgICAgICAgIDxo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MzU+CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS82Mjg2NzQ5PgorCisgICAgICAgICogZmFzdC9qcy9pZ25vcmVkLXJlc3Vs dC1udWxsLWNvbXBhcmlzb24tY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBm YXN0L2pzL2lnbm9yZWQtcmVzdWx0LW51bGwtY29tcGFyaXNvbi1jcmFzaC5odG1sOiBBZGRlZC4K KyAgICAgICAgKiBmYXN0L2pzL3Jlc291cmNlcy9pZ25vcmVkLXJlc3VsdC1udWxsLWNvbXBhcmlz b24tY3Jhc2guanM6IEFkZGVkLgorCiAyMDA4LTEyLTEyICBQaWVycmUtT2xpdmllciBMYXRvdXIg IDxwb2xAYXBwbGUuY29tPgogCiAgICAgICAgIENoZWNrZWQtaW4gbmV3IHJlc3VsdHMgZm9yIGZh aWxpbmcgU1ZHIHRlc3RzIHNvIHRoYXQgdGhlIGJvdHMgYXJlIGdyZWVuIGFnYWluLgpJbmRleDog TGF5b3V0VGVzdHMvZmFzdC9qcy9pZ25vcmVkLXJlc3VsdC1udWxsLWNvbXBhcmlzb24tY3Jhc2gt ZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMvaWdub3JlZC1y ZXN1bHQtbnVsbC1jb21wYXJpc29uLWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2Zhc3QvanMvaWdub3JlZC1yZXN1bHQtbnVsbC1jb21wYXJpc29uLWNyYXNo LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMSBAQAorVGhpcyB0ZXN0cyB0 aGF0IGJ5dGVjb2RlIGdlbmVyYXRpb24gZG9lc24ndCBjcmFzaCBvbiBhIGNvbXBhcmlzb24gdG8g bnVsbCB3aXRoIGFuIGlnbm9yZWQgcmVzdWx0LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUg YSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIu CisKKworUEFTUyBlcXVhbFRvTnVsbFRlc3QoKSBpcyB0cnVlCitQQVNTIG5vdEVxdWFsVG9OdWxs VGVzdCgpIGlzIHRydWUKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBD T01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL2lnbm9yZWQtcmVzdWx0LW51bGwt Y29tcGFyaXNvbi1jcmFzaC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvanMv aWdub3JlZC1yZXN1bHQtbnVsbC1jb21wYXJpc29uLWNyYXNoLmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9mYXN0L2pzL2lnbm9yZWQtcmVzdWx0LW51bGwtY29tcGFyaXNvbi1jcmFz aC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDEzIEBACis8IURPQ1RZUEUgSFRNTCBQVUJM SUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJz dHlsZXNoZWV0IiBocmVmPSJyZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdCBz cmM9InJlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4K KzxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2Ny aXB0IHNyYz0icmVzb3VyY2VzL2lnbm9yZWQtcmVzdWx0LW51bGwtY29tcGFyaXNvbi1jcmFzaC5q cyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9z Y3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291 cmNlcy9pZ25vcmVkLXJlc3VsdC1udWxsLWNvbXBhcmlzb24tY3Jhc2guanMKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvaWdub3JlZC1yZXN1bHQtbnVsbC1jb21w YXJpc29uLWNyYXNoLmpzCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNv dXJjZXMvaWdub3JlZC1yZXN1bHQtbnVsbC1jb21wYXJpc29uLWNyYXNoLmpzCShyZXZpc2lvbiAw KQpAQCAtMCwwICsxLDIxIEBACitkZXNjcmlwdGlvbigKKyJUaGlzIHRlc3RzIHRoYXQgYnl0ZWNv ZGUgZ2VuZXJhdGlvbiBkb2Vzbid0IGNyYXNoIG9uIGEgY29tcGFyaXNvbiB0byBudWxsIHdpdGgg YW4gaWdub3JlZCByZXN1bHQuIgorKTsKKworZnVuY3Rpb24gZXF1YWxUb051bGxUZXN0KGEpCit7 CisgICAgYSA9PSBudWxsOworICAgIHJldHVybiB0cnVlOworfQorCitzaG91bGRCZVRydWUoImVx dWFsVG9OdWxsVGVzdCgpIik7CisKK2Z1bmN0aW9uIG5vdEVxdWFsVG9OdWxsVGVzdChhKQorewor ICAgIGEgIT0gbnVsbDsKKyAgICByZXR1cm4gdHJ1ZTsKK30KKworc2hvdWxkQmVUcnVlKCJub3RF cXVhbFRvTnVsbFRlc3QoKSIpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK