<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>228335</bug_id>
          
          <creation_ts>2021-07-27 11:07:17 -0700</creation_ts>
          <short_desc>[build.webkit.org] Simulator temp files filling up disk</short_desc>
          <delta_ts>2021-08-03 17:12:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jonathan Bedard">jbedard</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>jenner</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>tsavell</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1779789</commentid>
    <comment_count>0</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2021-07-27 11:07:17 -0700</bug_when>
    <thetext>We have a bunch of temp files for our simulators filling up disk space, we should delete them between runs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1779790</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-07-27 11:07:40 -0700</bug_when>
    <thetext>&lt;rdar://problem/81171840&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1779791</commentid>
    <comment_count>2</comment_count>
      <attachid>434298</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2021-07-27 11:09:45 -0700</bug_when>
    <thetext>Created attachment 434298
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1779889</commentid>
    <comment_count>3</comment_count>
      <attachid>434385</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2021-07-27 16:39:18 -0700</bug_when>
    <thetext>Created attachment 434385
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1779890</commentid>
    <comment_count>4</comment_count>
      <attachid>434385</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2021-07-27 16:42:49 -0700</bug_when>
    <thetext>Comment on attachment 434385
Patch

rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1779893</commentid>
    <comment_count>5</comment_count>
      <attachid>434385</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2021-07-27 16:46:17 -0700</bug_when>
    <thetext>Comment on attachment 434385
Patch

Letting EWS chew on it before landing, the last version unexpectedly gave EWS problems.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1779921</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-07-27 17:47:10 -0700</bug_when>
    <thetext>Committed r280365 (240012@main): &lt;https://commits.webkit.org/240012@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434385.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1779923</commentid>
    <comment_count>7</comment_count>
      <attachid>434385</attachid>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2021-07-27 18:07:48 -0700</bug_when>
    <thetext>Comment on attachment 434385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434385&amp;action=review

&gt; Tools/CISupport/kill-old-processes:176
&gt; +        os.system(&apos;find /private/var/folders -name &quot;Deleting-*&quot; -maxdepth 4 -exec sudo rm -rf {} +&apos;)

This should be using $TMPDIR.

As discussed elsewhere, we should investigate why these are not getting deleted. It&apos;s quite possibly our own fault.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1779937</commentid>
    <comment_count>8</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2021-07-27 19:45:15 -0700</bug_when>
    <thetext>(In reply to Alexey Proskuryakov from comment #7)
&gt; Comment on attachment 434385 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=434385&amp;action=review
&gt; 
&gt; &gt; Tools/CISupport/kill-old-processes:176
&gt; &gt; +        os.system(&apos;find /private/var/folders -name &quot;Deleting-*&quot; -maxdepth 4 -exec sudo rm -rf {} +&apos;)
&gt; 
&gt; This should be using $TMPDIR.
&gt; 
&gt; As discussed elsewhere, we should investigate why these are not getting
&gt; deleted. It&apos;s quite possibly our own fault.

My hope is that this is just temporary, if it&apos;s not, I&apos;ll go back to add TMPDIR.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1779938</commentid>
    <comment_count>9</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2021-07-27 19:46:21 -0700</bug_when>
    <thetext>(re-opening this bug because it wasn&apos;t a permanent fix)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1781731</commentid>
    <comment_count>10</comment_count>
      <attachid>434859</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2021-08-03 13:42:38 -0700</bug_when>
    <thetext>Created attachment 434859
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1781779</commentid>
    <comment_count>11</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-08-03 16:14:53 -0700</bug_when>
    <thetext>Committed r280621 (240234@main): &lt;https://commits.webkit.org/240234@main&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 434859.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>434298</attachid>
            <date>2021-07-27 11:09:45 -0700</date>
            <delta_ts>2021-07-27 16:39:15 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-228335-20210727110944.patch</filename>
            <type>text/plain</type>
            <size>1490</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI4MDM0NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE0IEBACisyMDIxLTA3LTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gU2ltdWxhdG9yIHRlbXAgZmlsZXMgZmls
bGluZyB1cCBkaXNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0yMjgzMzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgxMTcxODQwPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ0lTdXBwb3J0L2tpbGwt
b2xkLXByb2Nlc3NlczoKKyAgICAgICAgKG1haW4pOiBEZWxldGUgc3RhbGUgc2ltdWxhdG9yIGZp
bGVzLgorCiAyMDIxLTA3LTI3ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+
CiAKICAgICAgICAgW0dUS11bV1BFXSBPcmdhbml6ZSBsaXN0IG9mIHBhY2thZ2UgZGVwZW5kZW5j
aWVzIGludG8gc2VwYXJhdGVkIGZpbGVzCkluZGV4OiBUb29scy9DSVN1cHBvcnQva2lsbC1vbGQt
cHJvY2Vzc2VzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9raWxsLW9sZC1wcm9jZXNz
ZXMJKHJldmlzaW9uIDI4MDM0MykKKysrIFRvb2xzL0NJU3VwcG9ydC9raWxsLW9sZC1wcm9jZXNz
ZXMJKHdvcmtpbmcgY29weSkKQEAgLTE3Miw2ICsxNzIsOCBAQCBkZWYgbWFpbih1c2VyPU5vbmUp
OgogICAgICAgICAgICAgb3Muc3lzdGVtKCJ4Y3J1biBzaW1jdGwgc2h1dGRvd24gYm9vdGVkIikK
ICAgICAgICAgIyBLaWxsIGFsbCBpbnN0YW5jZXMgb2YgcHl0aG9uIGV4ZWN1dGluZyBydW4td2Vi
a2l0LXRlc3RzCiAgICAgICAgIG9zLnN5c3RlbSgicHMgYXV4IHwgZ3JlcCAtRSAnLisvUHl0aG9u
IC4rKHJ1bl93ZWJraXRfdGVzdHN8cnVuLXdlYmtpdC10ZXN0c3xtb2RfcHl3ZWJzb2NrZXQpJyB8
IGdyZXAgLXYgZ3JlcCB8IGF3ayAne3ByaW50ICQyfScgfCB4YXJncyBraWxsIikKKyAgICAgICAg
IyBSZW1vdmUgc3RhbGUgc2ltdWxhdG9yIHRlbXAgZmlsZXMKKyAgICAgICAgb3Muc3lzdGVtKCdm
aW5kIC9wcml2YXRlL3Zhci9mb2xkZXJzIC1uYW1lICJEZWxldGluZy0qIiAtZXhlYyBzdWRvIHJt
IC1yZiB7fSArJykKICAgICBlbGlmIHN5cy5wbGF0Zm9ybSA9PSAnY3lnd2luJyBvciBzeXMucGxh
dGZvcm0gPT0gJ3dpbjMyJzoKICAgICAgICAgZm9yIHRhc2sgaW4gdGFza3NUb0tpbGwgKyB0YXNr
c1RvS2lsbFdpbjoKICAgICAgICAgICAgIG9zLnN5c3RlbSgidGFza2tpbGwgL3QgL2YgL2ltICIg
KyB0YXNrKQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>434385</attachid>
            <date>2021-07-27 16:39:18 -0700</date>
            <delta_ts>2021-08-03 13:42:37 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-228335-20210727163918.patch</filename>
            <type>text/plain</type>
            <size>1508</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI4MDM1OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE0IEBACisyMDIxLTA3LTI3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gU2ltdWxhdG9yIHRlbXAgZmlsZXMgZmls
bGluZyB1cCBkaXNrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0yMjgzMzUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzgxMTcxODQwPgorCisgICAgICAg
IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ0lTdXBwb3J0L2tpbGwt
b2xkLXByb2Nlc3NlczoKKyAgICAgICAgKG1haW4pOiBEZWxldGUgc3RhbGUgc2ltdWxhdG9yIGZp
bGVzLgorCiAyMDIxLTA3LTI3ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+
CiAKICAgICAgICAgW0dUS11bV1BFXSBNb3ZlIFdlYktpdEdUSyBhbmQgV1BFIGRlcGVuZGVuY3kg
cGFja2FnZXMgdG8gYSBjb21tb24gR0xJQiBsaXN0CkluZGV4OiBUb29scy9DSVN1cHBvcnQva2ls
bC1vbGQtcHJvY2Vzc2VzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9raWxsLW9sZC1w
cm9jZXNzZXMJKHJldmlzaW9uIDI4MDM1OSkKKysrIFRvb2xzL0NJU3VwcG9ydC9raWxsLW9sZC1w
cm9jZXNzZXMJKHdvcmtpbmcgY29weSkKQEAgLTE3Miw2ICsxNzIsOCBAQCBkZWYgbWFpbih1c2Vy
PU5vbmUpOgogICAgICAgICAgICAgb3Muc3lzdGVtKCJ4Y3J1biBzaW1jdGwgc2h1dGRvd24gYm9v
dGVkIikKICAgICAgICAgIyBLaWxsIGFsbCBpbnN0YW5jZXMgb2YgcHl0aG9uIGV4ZWN1dGluZyBy
dW4td2Via2l0LXRlc3RzCiAgICAgICAgIG9zLnN5c3RlbSgicHMgYXV4IHwgZ3JlcCAtRSAnLisv
UHl0aG9uIC4rKHJ1bl93ZWJraXRfdGVzdHN8cnVuLXdlYmtpdC10ZXN0c3xtb2RfcHl3ZWJzb2Nr
ZXQpJyB8IGdyZXAgLXYgZ3JlcCB8IGF3ayAne3ByaW50ICQyfScgfCB4YXJncyBraWxsIikKKyAg
ICAgICAgIyBSZW1vdmUgc3RhbGUgc2ltdWxhdG9yIHRlbXAgZmlsZXMKKyAgICAgICAgb3Muc3lz
dGVtKCdmaW5kIC9wcml2YXRlL3Zhci9mb2xkZXJzIC1uYW1lICJEZWxldGluZy0qIiAtbWF4ZGVw
dGggNCAtZXhlYyBzdWRvIHJtIC1yZiB7fSArJykKICAgICBlbGlmIHN5cy5wbGF0Zm9ybSA9PSAn
Y3lnd2luJyBvciBzeXMucGxhdGZvcm0gPT0gJ3dpbjMyJzoKICAgICAgICAgZm9yIHRhc2sgaW4g
dGFza3NUb0tpbGwgKyB0YXNrc1RvS2lsbFdpbjoKICAgICAgICAgICAgIG9zLnN5c3RlbSgidGFz
a2tpbGwgL3QgL2YgL2ltICIgKyB0YXNrKQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>434859</attachid>
            <date>2021-08-03 13:42:38 -0700</date>
            <delta_ts>2021-08-03 17:12:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-228335-20210803134237.patch</filename>
            <type>text/plain</type>
            <size>1880</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI4MDYxMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE0IEBACisyMDIxLTA4LTAzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gU2ltdWxhdG9yIHRlbXAgZmlsZXMgZmls
bGluZyB1cCBkaXNrIChGb2xsb3ctdXAgZml4KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4MzM1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84MTE3
MTg0MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq
IENJU3VwcG9ydC9raWxsLW9sZC1wcm9jZXNzZXM6CisgICAgICAgIChtYWluKTogVXNlIHRlbXBk
aXIgZW52aXJvbm1lbnQgdmFyaWFibGUsIGxpbmsgdG8gdW5kZXJseWluZyBidWcuCisKIDIwMjEt
MDgtMDMgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFt3
ZWJraXRzY21weV0gQWRkIGFjY2VzcyB0byBgZ2l0IGNvbmZpZ2AKSW5kZXg6IFRvb2xzL0NJU3Vw
cG9ydC9raWxsLW9sZC1wcm9jZXNzZXMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lTdXBwb3J0L2tp
bGwtb2xkLXByb2Nlc3NlcwkocmV2aXNpb24gMjgwNjA4KQorKysgVG9vbHMvQ0lTdXBwb3J0L2tp
bGwtb2xkLXByb2Nlc3Nlcwkod29ya2luZyBjb3B5KQpAQCAtMjgsNiArMjgsNyBAQCBpbXBvcnQg
b3MsIHN5cwogaW1wb3J0IGdldHBhc3MKIGltcG9ydCByZQogaW1wb3J0IHN1YnByb2Nlc3MKK2lt
cG9ydCB0ZW1wZmlsZQogCiBkZWYgbGlzdEFsbFdlYktpdFByb2dyYW1zKGJ1aWxkZGlyX2Jpbik6
CiAgICAgZm91bmRXZWJLaXRQcm9ncmFtcyA9IFtdCkBAIC0xNzIsOCArMTczLDggQEAgZGVmIG1h
aW4odXNlcj1Ob25lKToKICAgICAgICAgICAgIG9zLnN5c3RlbSgieGNydW4gc2ltY3RsIHNodXRk
b3duIGJvb3RlZCIpCiAgICAgICAgICMgS2lsbCBhbGwgaW5zdGFuY2VzIG9mIHB5dGhvbiBleGVj
dXRpbmcgcnVuLXdlYmtpdC10ZXN0cwogICAgICAgICBvcy5zeXN0ZW0oInBzIGF1eCB8IGdyZXAg
LUUgJy4rL1B5dGhvbiAuKyhydW5fd2Via2l0X3Rlc3RzfHJ1bi13ZWJraXQtdGVzdHN8bW9kX3B5
d2Vic29ja2V0KScgfCBncmVwIC12IGdyZXAgfCBhd2sgJ3twcmludCAkMn0nIHwgeGFyZ3Mga2ls
bCIpCi0gICAgICAgICMgUmVtb3ZlIHN0YWxlIHNpbXVsYXRvciB0ZW1wIGZpbGVzCi0gICAgICAg
IG9zLnN5c3RlbSgnZmluZCAvcHJpdmF0ZS92YXIvZm9sZGVycyAtbmFtZSAiRGVsZXRpbmctKiIg
LW1heGRlcHRoIDQgLWV4ZWMgc3VkbyBybSAtcmYge30gKycpCisgICAgICAgICMgRklYTUU6IDxy
ZGFyOi8vcHJvYmxlbS84MTQ3NjU0Nj4gUmVtb3ZlIHN0YWxlIHNpbXVsYXRvciB0ZW1wIGZpbGVz
CisgICAgICAgIG9zLnN5c3RlbSgnZmluZCB7fSAtbmFtZSAiRGVsZXRpbmctKiIgLW1heGRlcHRo
IDEgLWV4ZWMgc3VkbyBybSAtcmYge3t9fSArJy5mb3JtYXQodGVtcGZpbGUuZ2V0dGVtcGRpcigp
KSkKICAgICBlbGlmIHN5cy5wbGF0Zm9ybSA9PSAnY3lnd2luJyBvciBzeXMucGxhdGZvcm0gPT0g
J3dpbjMyJzoKICAgICAgICAgZm9yIHRhc2sgaW4gdGFza3NUb0tpbGwgKyB0YXNrc1RvS2lsbFdp
bjoKICAgICAgICAgICAgIG9zLnN5c3RlbSgidGFza2tpbGwgL3QgL2YgL2ltICIgKyB0YXNrKQo=
</data>
<flag name="commit-queue"
          id="457509"
          type_id="3"
          status="+"
          setter="jbedard"
    />
          </attachment>
      

    </bug>

</bugzilla>