228294 2021-07-26 12:33:21 -0700 Attribution context causes some performance regressions 2021-07-26 15:00:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham darin pvollan webkit-bug-importer oldest_to_newest 1779516 0 katherine_cheney 2021-07-26 12:33:21 -0700 Attribution context causes some performance regressions 1779517 1 434225 katherine_cheney 2021-07-26 12:34:16 -0700 Created attachment 434225 Patch 1779523 2 434225 pvollan 2021-07-26 12:45:54 -0700 Comment on attachment 434225 Patch R=me. 1779544 3 ews-feeder 2021-07-26 13:40:16 -0700 Committed r280311 (239961@main): <https://commits.webkit.org/239961@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434225. 1779545 4 webkit-bug-importer 2021-07-26 13:41:16 -0700 <rdar://problem/81127864> 1779570 5 434225 darin 2021-07-26 14:21:22 -0700 Comment on attachment 434225 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=434225&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:61 > static void processPCMRequest(WebCore::PrivateClickMeasurement::PcmDataCarried, NSMutableURLRequest *) { }; > +static void overrideAttributionContext(NSMutableURLRequest *) { }; These semicolons should not be here. 1779575 6 katherine_cheney 2021-07-26 14:30:50 -0700 Reopening to attach new patch. 1779576 7 434241 katherine_cheney 2021-07-26 14:30:52 -0700 Created attachment 434241 Patch for landing 1779586 8 ews-feeder 2021-07-26 14:59:22 -0700 Committed r280317 (239965@main): <https://commits.webkit.org/239965@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434241. 1779588 9 katherine_cheney 2021-07-26 15:00:20 -0700 (In reply to Darin Adler from comment #5) > Comment on attachment 434225 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=434225&action=review > > > Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:61 > > static void processPCMRequest(WebCore::PrivateClickMeasurement::PcmDataCarried, NSMutableURLRequest *) { }; > > +static void overrideAttributionContext(NSMutableURLRequest *) { }; > > These semicolons should not be here. Thanks, fixed it in a followup. 434225 2021-07-26 12:34:16 -0700 2021-07-26 14:30:47 -0700 Patch bug-228294-20210726123415.patch text/plain 2127 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMjg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYxYTA1YmNiNjVhNzdmYTQw ZjMwODQxM2JiYzMxNmFjMzk4MTUyYWUuLjA2ODlmMGRhMDMzZDk2YTM0MzlkMjQ4MjRmODdjODVm MzE0Y2UxMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDctMjYgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgQXR0cmlidXRpb24g Y29udGV4dCBjYXVzZXMgc29tZSBwZXJmb3JtYW5jZSByZWdyZXNzaW9ucworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4Mjk0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS83NjY2MzUyOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBdHRyaWJ1dGlvbiBjb250ZXh0IGlzIHVzZWQgYnkgdGhlIG5ldHdvcmtp bmcgc3RhY2sgZm9yIGEgdmFyaWV0eSBvZgorICAgICAgICBwdXJwb3NlcywgYnV0IGlzIG5vdCBh bHdheXMgbmVlZGVkIGFuZCBjYW4gbmVnYXRpdmVseSBhZmZlY3QKKyAgICAgICAgcGVyZm9ybWFu Y2UuIEZvciB0aGVzZSByZWFzb25zLCB3ZSBzaG91bGQgb3ZlcnJpZGUgaXQgaW4gc29tZSBjYXNl cy4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29h Lm1tOgorICAgICAgICAob3ZlcnJpZGVBdHRyaWJ1dGlvbkNvbnRleHQpOgorICAgICAgICAoV2Vi S2l0OjpOZXR3b3JrRGF0YVRhc2tDb2NvYTo6TmV0d29ya0RhdGFUYXNrQ29jb2EpOgorCiAyMDIx LTA3LTI0ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBbQXBw bGUgUGF5XSBEbyBub3QgYWRkIGNvdXBvbiBjb2RlIGBBcHBsZVBheUVycm9yQ29kZWAgdmFsdWVz IGZvciBzeXN0ZW1zIHRoYXQgZG8gbm90IHN1cHBvcnQgaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0gYi9Tb3Vy Y2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0NvY29hLm1tCmlu ZGV4IGQzZmY4ZWJlYjY3ODU1MjQ3ZjRjMjU2M2M4MjA5YmVjYzU4ZDhiYjEuLmU5YmZhMmZkZGJh ZDUwMzA1YTlkODVkZjQ1NzRhNjQ4NDU2NWY2MGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv TmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0RhdGFUYXNrQ29jb2EubW0KKysrIGIvU291cmNl L1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbQpAQCAt NTgsNiArNTgsNyBAQAogI2ltcG9ydCA8V2ViS2l0QWRkaXRpb25zL05ldHdvcmtEYXRhVGFza0Nv Y29hQWRkaXRpb25zLmg+CiAjZWxzZQogc3RhdGljIHZvaWQgcHJvY2Vzc1BDTVJlcXVlc3QoV2Vi Q29yZTo6UHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnQ6OlBjbURhdGFDYXJyaWVkLCBOU011dGFibGVV UkxSZXF1ZXN0ICopIHsgfTsKK3N0YXRpYyB2b2lkIG92ZXJyaWRlQXR0cmlidXRpb25Db250ZXh0 KE5TTXV0YWJsZVVSTFJlcXVlc3QgKikgeyB9OwogI2VuZGlmCiAKIG5hbWVzcGFjZSBXZWJLaXQg ewpAQCAtMzQ0LDYgKzM0NSw4IEBAIE5ldHdvcmtEYXRhVGFza0NvY29hOjpOZXR3b3JrRGF0YVRh c2tDb2NvYShOZXR3b3JrU2Vzc2lvbiYgc2Vzc2lvbiwgTmV0d29ya0RhdGFUCiAgICAgbXV0YWJs ZVJlcXVlc3QuZ2V0KCkuYXR0cmlidXRpb24gPSByZXF1ZXN0LmlzQXBwSW5pdGlhdGVkKCkgPyBO U1VSTFJlcXVlc3RBdHRyaWJ1dGlvbkRldmVsb3BlciA6IE5TVVJMUmVxdWVzdEF0dHJpYnV0aW9u VXNlcjsKICNlbmRpZgogCisgICAgb3ZlcnJpZGVBdHRyaWJ1dGlvbkNvbnRleHQobXV0YWJsZVJl cXVlc3QuZ2V0KCkpOworCiAgICAgaWYgKHBhcmFtZXRlcnMucGNtRGF0YUNhcnJpZWQpCiAgICAg ICAgIHByb2Nlc3NQQ01SZXF1ZXN0KCpwYXJhbWV0ZXJzLnBjbURhdGFDYXJyaWVkLCBtdXRhYmxl UmVxdWVzdC5nZXQoKSk7CiAK 434241 2021-07-26 14:30:52 -0700 2021-07-26 14:59:23 -0700 Patch for landing bug-228294-20210726143051.patch text/plain 1650 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg2M2NhZWFlODQ4NjdhMWQz Njc3MDEwYjBhMzUzZjNmZWQ3YTAzODAuLjU3MDUyOWU0M2JjNzhmYmYxNzFlNjEzZTE2YzcwM2Ji MTdlYzczZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDctMjYgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgQXR0cmlidXRpb24g Y29udGV4dCBjYXVzZXMgc29tZSBwZXJmb3JtYW5jZSByZWdyZXNzaW9ucworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI4Mjk0CisKKyAgICAgICAgVW5y ZXZpZXdlZCBmb2xsb3d1cCB0byBhZGRyZXNzIERhcmluJ3MgY29tbWVudCByZWdhcmRpbmcgdW5u ZWNlc3NhcnkKKyAgICAgICAgc2VtaS1jb2xvbnMuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vz cy9jb2NvYS9OZXR3b3JrRGF0YVRhc2tDb2NvYS5tbToKKyAgICAgICAgKHByb2Nlc3NQQ01SZXF1 ZXN0KToKKyAgICAgICAgKG92ZXJyaWRlQXR0cmlidXRpb25Db250ZXh0KToKKwogMjAyMS0wNy0y NiAgS2F0ZSBDaGVuZXkgIDxrYXRoZXJpbmVfY2hlbmV5QGFwcGxlLmNvbT4KIAogICAgICAgICBB dHRyaWJ1dGlvbiBjb250ZXh0IGNhdXNlcyBzb21lIHBlcmZvcm1hbmNlIHJlZ3Jlc3Npb25zCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRh VGFza0NvY29hLm1tIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3Jr RGF0YVRhc2tDb2NvYS5tbQppbmRleCBlOWJmYTJmZGRiYWQ1MDMwNWE5ZDg1ZGY0NTc0YTY0ODQ1 NjVmNjBiLi42ODcwODUxOTI1Mjg4NTcxYmQ2Yzc2M2IzZTYwMzEzZDkyNjBlOThjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtEYXRhVGFza0Nv Y29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya0Rh dGFUYXNrQ29jb2EubW0KQEAgLTU3LDggKzU3LDggQEAKICNpZiBVU0UoQVBQTEVfSU5URVJOQUxf U0RLKQogI2ltcG9ydCA8V2ViS2l0QWRkaXRpb25zL05ldHdvcmtEYXRhVGFza0NvY29hQWRkaXRp b25zLmg+CiAjZWxzZQotc3RhdGljIHZvaWQgcHJvY2Vzc1BDTVJlcXVlc3QoV2ViQ29yZTo6UHJp dmF0ZUNsaWNrTWVhc3VyZW1lbnQ6OlBjbURhdGFDYXJyaWVkLCBOU011dGFibGVVUkxSZXF1ZXN0 ICopIHsgfTsKLXN0YXRpYyB2b2lkIG92ZXJyaWRlQXR0cmlidXRpb25Db250ZXh0KE5TTXV0YWJs ZVVSTFJlcXVlc3QgKikgeyB9Oworc3RhdGljIHZvaWQgcHJvY2Vzc1BDTVJlcXVlc3QoV2ViQ29y ZTo6UHJpdmF0ZUNsaWNrTWVhc3VyZW1lbnQ6OlBjbURhdGFDYXJyaWVkLCBOU011dGFibGVVUkxS ZXF1ZXN0ICopIHsgfQorc3RhdGljIHZvaWQgb3ZlcnJpZGVBdHRyaWJ1dGlvbkNvbnRleHQoTlNN dXRhYmxlVVJMUmVxdWVzdCAqKSB7IH0KICNlbmRpZgogCiBuYW1lc3BhY2UgV2ViS2l0IHsK