22828 2008-12-12 14:18:47 -0800 Do not inspect bytecode instruction stream for op_get_by_id exception information 2008-12-12 14:49:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich zwarich sam oldest_to_newest 102378 0 zwarich 2008-12-12 14:18:47 -0800 We need to do this in order to delete the bytecode instruction stream after generating native code. 102379 1 25987 zwarich 2008-12-12 14:23:23 -0800 Created attachment 25987 Proposed patch 102387 2 25987 sam 2008-12-12 14:43:54 -0800 Comment on attachment 25987 Proposed patch r=me with the comments I gave on irc. 102389 3 zwarich 2008-12-12 14:49:11 -0800 Landed in r39255. 25987 2008-12-12 14:23:23 -0800 2008-12-12 14:43:54 -0800 Proposed patch exceptions.diff text/plain 7822 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM5MjUy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzAgQEAKKzIwMDgtMTIt MTIgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMjgyODogRG8gbm90IGluc3Bl Y3QgYnl0ZWNvZGUgaW5zdHJ1Y3Rpb24gc3RyZWFtIGZvciBvcF9nZXRfYnlfaWQgZXhjZXB0aW9u IGluZm9ybWF0aW9uCisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjI4Mjg+CisKKyAgICAgICAgSW4gb3JkZXIgdG8gcmVtb3ZlIHRoZSBieXRlY29kZSBp bnN0cnVjdGlvbiBzdHJlYW0gYWZ0ZXIgZ2VuZXJhdGluZworICAgICAgICBuYXRpdmUgY29kZSwg YWxsIGluc3BlY3Rpb24gb2YgYnl0ZWNvZGUgaW5zdHJ1Y3Rpb25zIGF0IHJ1bnRpbWUgbXVzdAor ICAgICAgICBiZSByZW1vdmVkLiBPbmUgcGFydGljdWxhciBpbnN0YW5jZSBvZiB0aGlzIGlzIHRo ZSBzcGVjaWFsIGhhbmRsaW5nIG9mCisgICAgICAgIGV4Y2VwdGlvbnMgdGhyb3duIGJ5IHRoZSBv cF9nZXRfYnlfaWQgZW1pdHRlZCBkaXJlY3RseSBiZWZvcmUgYW4KKyAgICAgICAgb3BfY29uc3Ry dWN0IG9yIGFuIG9wX2luc3RhbmNlb2YuIFRoaXMgcGF0Y2ggbW92ZXMgdGhhdCBpbmZvcm1hdGlv biB0bworICAgICAgICBhbiBhdXhpbGlhcnkgZGF0YSBzdHJ1Y3R1cmUgaW4gQ29kZUJsb2NrLgor CisgICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcDoKKyAgICAgICAgKEpTQzo6Q29kZUJs b2NrOjpnZXRCeUlERXhjZXB0aW9uSW5mb0ZvckJ5dGVjb2RlT2Zmc2V0KToKKyAgICAgICAgKiBi eXRlY29kZS9Db2RlQmxvY2suaDoKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjphZGRHZXRCeUlE RXhjZXB0aW9uSW5mbyk6CisgICAgICAgICogYnl0ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9y LmNwcDoKKyAgICAgICAgKEpTQzo6Qnl0ZWNvZGVHZW5lcmF0b3I6OmVtaXRDb25zdHJ1Y3QpOgor ICAgICAgICAqIGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oOgorICAgICAgICAoSlND OjpCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdEdldEJ5SURFeGNlcHRpb25JbmZvKToKKyAgICAgICAg KiBwYXJzZXIvTm9kZXMuY3BwOgorICAgICAgICAoSlNDOjpJbnN0YW5jZU9mTm9kZTo6ZW1pdEJ5 dGVjb2RlKToKKyAgICAgICAgKiBydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwOgorICAgICAg ICAoSlNDOjpjcmVhdGVOb3RBbk9iamVjdEVycm9yKToKKwogMjAwOC0xMi0xMiAgU2FtIFdlaW5p ZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb2ZmcmV5IEdhcmVu LgpJbmRleDogYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBieXRlY29kZS9D b2RlQmxvY2suY3BwCShyZXZpc2lvbiAzOTI1MikKKysrIGJ5dGVjb2RlL0NvZGVCbG9jay5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE0MDYsNiArMTQwNiwzMCBAQCBpbnQgQ29kZUJsb2NrOjpleHBy ZXNzaW9uUmFuZ2VGb3JCeXRlY29kCiAgICAgcmV0dXJuIGxpbmVOdW1iZXJGb3JCeXRlY29kZU9m ZnNldChieXRlY29kZU9mZnNldCk7CiB9CiAKK2Jvb2wgQ29kZUJsb2NrOjpnZXRCeUlERXhjZXB0 aW9uSW5mb0ZvckJ5dGVjb2RlT2Zmc2V0KHVuc2lnbmVkIGJ5dGVjb2RlT2Zmc2V0LCBPcGNvZGVJ RCYgb3Bjb2RlSUQpCit7CisgICAgQVNTRVJUKGJ5dGVjb2RlT2Zmc2V0IDwgbV9pbnN0cnVjdGlv bnMuc2l6ZSgpKTsKKworICAgIGlmICghbV9nZXRCeUlERXhjZXB0aW9uSW5mby5zaXplKCkpCisg ICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGludCBsb3cgPSAwOworICAgIGludCBoaWdoID0g bV9nZXRCeUlERXhjZXB0aW9uSW5mby5zaXplKCk7CisgICAgd2hpbGUgKGxvdyA8IGhpZ2gpIHsK KyAgICAgICAgaW50IG1pZCA9IGxvdyArIChoaWdoIC0gbG93KSAvIDI7CisgICAgICAgIGlmICht X2dldEJ5SURFeGNlcHRpb25JbmZvW21pZF0uYnl0ZWNvZGVPZmZzZXQgPD0gYnl0ZWNvZGVPZmZz ZXQpCisgICAgICAgICAgICBsb3cgPSBtaWQgKyAxOworICAgICAgICBlbHNlCisgICAgICAgICAg ICBoaWdoID0gbWlkOworICAgIH0KKworICAgIGlmICghbG93KQorICAgICAgICByZXR1cm4gZmFs c2U7CisKKyAgICBvcGNvZGVJRCA9IG1fZ2V0QnlJREV4Y2VwdGlvbkluZm9bbG93IC0gMV0uaXNP cENvbnN0cnVjdCA/IG9wX2NvbnN0cnVjdCA6IG9wX2luc3RhbmNlb2Y7CisgICAgcmV0dXJuIHRy dWU7Cit9CisKIHZvaWQgQ29kZUJsb2NrOjpzaHJpbmtUb0ZpdCgpCiB7CiAgICAgbV9pbnN0cnVj dGlvbnMuc2hyaW5rVG9GaXQoKTsKSW5kZXg6IGJ5dGVjb2RlL0NvZGVCbG9jay5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIGJ5dGVjb2RlL0NvZGVCbG9jay5oCShyZXZpc2lvbiAzOTI1MikKKysrIGJ5dGVjb2Rl L0NvZGVCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC03OCw2ICs3OCwxNCBAQCBuYW1lc3BhY2Ug SlNDIHsKICAgICAgICAgaW50MzJfdCBsaW5lTnVtYmVyOwogICAgIH07CiAKKyAgICAvLyBCb3Ro IG9wX2NvbnN0cnVjdCBhbmQgb3BfaW5zdGFuY2VvZiByZXF1aXJlIGEgdXNlIG9mIG9wX2dldF9i eV9pZCB0byBnZXQKKyAgICAvLyB0aGUgcHJvdG90eXBlIHByb3BlcnR5IGZyb20gYW4gb2JqZWN0 LiBUaGUgZXhjZXB0aW9uIG1lc3NhZ2VzIGZvciBleGNlcHRpb25zCisgICAgLy8gdGhyb3duIGJ5 IG9wX2dldF9ieV9pZCBuZWVkIHRvIGJlIHRyYWNrZWQgdG8gCisgICAgc3RydWN0IEdldEJ5SURF eGNlcHRpb25JbmZvIHsKKyAgICAgICAgdW5zaWduZWQgYnl0ZWNvZGVPZmZzZXQgOiAzMTsKKyAg ICAgICAgYm9vbCBpc09wQ29uc3RydWN0IDogMTsKKyAgICB9OworCiAjaWYgRU5BQkxFKEpJVCkK ICAgICBzdHJ1Y3QgQ2FsbExpbmtJbmZvIHsKICAgICAgICAgQ2FsbExpbmtJbmZvKCkKQEAgLTIy Nyw2ICsyMzUsNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgSGFuZGxlckluZm8qIGhhbmRs ZXJGb3JCeXRlY29kZU9mZnNldCh1bnNpZ25lZCBieXRlY29kZU9mZnNldCk7CiAgICAgICAgIGlu dCBsaW5lTnVtYmVyRm9yQnl0ZWNvZGVPZmZzZXQodW5zaWduZWQgYnl0ZWNvZGVPZmZzZXQpOwog ICAgICAgICBpbnQgZXhwcmVzc2lvblJhbmdlRm9yQnl0ZWNvZGVPZmZzZXQodW5zaWduZWQgYnl0 ZWNvZGVPZmZzZXQsIGludCYgZGl2b3QsIGludCYgc3RhcnRPZmZzZXQsIGludCYgZW5kT2Zmc2V0 KTsKKyAgICAgICAgYm9vbCBnZXRCeUlERXhjZXB0aW9uSW5mb0ZvckJ5dGVjb2RlT2Zmc2V0KHVu c2lnbmVkIGJ5dGVjb2RlT2Zmc2V0LCBPcGNvZGVJRCYpOwogCiAjaWYgRU5BQkxFKEpJVCkKICAg ICAgICAgdm9pZCBhZGRDYWxsZXIoQ2FsbExpbmtJbmZvKiBjYWxsZXIpCkBAIC0zMDIsNiArMzEx LDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIEhhbmRsZXJJbmZvJiBleGNlcHRpb25IYW5k bGVyKGludCBpbmRleCkgeyBBU1NFUlQobV9yYXJlRGF0YSk7IHJldHVybiBtX3JhcmVEYXRhLT5t X2V4Y2VwdGlvbkhhbmRsZXJzW2luZGV4XTsgfQogCiAgICAgICAgIHZvaWQgYWRkRXhwcmVzc2lv bkluZm8oY29uc3QgRXhwcmVzc2lvblJhbmdlSW5mbyYgZXhwcmVzc2lvbkluZm8pIHsgcmV0dXJu IG1fZXhwcmVzc2lvbkluZm8uYXBwZW5kKGV4cHJlc3Npb25JbmZvKTsgfQorICAgICAgICB2b2lk IGFkZEdldEJ5SURFeGNlcHRpb25JbmZvKGNvbnN0IEdldEJ5SURFeGNlcHRpb25JbmZvJiBpbmZv KSB7IG1fZ2V0QnlJREV4Y2VwdGlvbkluZm8uYXBwZW5kKGluZm8pOyB9CiAKICAgICAgICAgc2l6 ZV90IG51bWJlck9mTGluZUluZm9zKCkgY29uc3QgeyByZXR1cm4gbV9saW5lSW5mby5zaXplKCk7 IH0KICAgICAgICAgdm9pZCBhZGRMaW5lSW5mbyhjb25zdCBMaW5lSW5mbyYgbGluZUluZm8pIHsg cmV0dXJuIG1fbGluZUluZm8uYXBwZW5kKGxpbmVJbmZvKTsgfQpAQCAtNDI2LDYgKzQzNiw3IEBA IG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIFZlY3RvcjxFeHByZXNzaW9uUmFuZ2VJbmZvPiBt X2V4cHJlc3Npb25JbmZvOwogICAgICAgICBWZWN0b3I8TGluZUluZm8+IG1fbGluZUluZm87Cisg ICAgICAgIFZlY3RvcjxHZXRCeUlERXhjZXB0aW9uSW5mbz4gbV9nZXRCeUlERXhjZXB0aW9uSW5m bzsKIAogI2lmIEVOQUJMRShKSVQpCiAgICAgICAgIFZlY3RvcjxQQz4gbV9wY1ZlY3RvcjsKSW5k ZXg6IGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gYnl0 ZWNvbXBpbGVyL0J5dGVjb2RlR2VuZXJhdG9yLmNwcAkocmV2aXNpb24gMzkyNTIpCisrKyBieXRl Y29tcGlsZXIvQnl0ZWNvZGVHZW5lcmF0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzMzLDYg KzEzMzMsNyBAQCBSZWdpc3RlcklEKiBCeXRlY29kZUdlbmVyYXRvcjo6ZW1pdENvbnN0CiAKICAg ICAvLyBMb2FkIHByb3RvdHlwZS4KICAgICBlbWl0RXhwcmVzc2lvbkluZm8oZGl2b3QsIHN0YXJ0 T2Zmc2V0LCBlbmRPZmZzZXQpOworICAgIGVtaXRHZXRCeUlERXhjZXB0aW9uSW5mbyhvcF9jb25z dHJ1Y3QpOwogICAgIGVtaXRHZXRCeUlkKGZ1bmNQcm90by5nZXQoKSwgZnVuYywgZ2xvYmFsRGF0 YSgpLT5wcm9wZXJ0eU5hbWVzLT5wcm90b3R5cGUpOwogCiAgICAgLy8gUmVzZXJ2ZSBzcGFjZSBm b3IgY2FsbCBmcmFtZS4KSW5kZXg6IGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oCShyZXZpc2lvbiAz OTI1MikKKysrIGJ5dGVjb21waWxlci9CeXRlY29kZUdlbmVyYXRvci5oCSh3b3JraW5nIGNvcHkp CkBAIC0yMDgsNiArMjA4LDE3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAgaW5mby5l bmRPZmZzZXQgPSBlbmRPZmZzZXQ7CiAgICAgICAgICAgICBtX2NvZGVCbG9jay0+YWRkRXhwcmVz c2lvbkluZm8oaW5mbyk7CiAgICAgICAgIH0KKworICAgICAgICB2b2lkIGVtaXRHZXRCeUlERXhj ZXB0aW9uSW5mbyhPcGNvZGVJRCBvcGNvZGVJRCkKKyAgICAgICAgeworICAgICAgICAgICAgLy8g T25seSBvcF9jb25zdHJ1Y3QgYW5kIG9wX2luc3RhbmNlb2YgbmVlZCBleGNlcHRpb24gaW5mbyBm b3IKKyAgICAgICAgICAgIC8vIGEgcHJlY2VkaW5nIG9wX2dldF9ieV9pZC4KKyAgICAgICAgICAg IEFTU0VSVChvcGNvZGVJRCA9PSBvcF9jb25zdHJ1Y3QgfHwgb3Bjb2RlSUQgPT0gb3BfaW5zdGFu Y2VvZik7CisgICAgICAgICAgICBHZXRCeUlERXhjZXB0aW9uSW5mbyBpbmZvOworICAgICAgICAg ICAgaW5mby5ieXRlY29kZU9mZnNldCA9IGluc3RydWN0aW9ucygpLnNpemUoKTsKKyAgICAgICAg ICAgIGluZm8uaXNPcENvbnN0cnVjdCA9IChvcGNvZGVJRCA9PSBvcF9jb25zdHJ1Y3QpOworICAg ICAgICAgICAgbV9jb2RlQmxvY2stPmFkZEdldEJ5SURFeGNlcHRpb25JbmZvKGluZm8pOworICAg ICAgICB9CiAgICAgICAgIAogICAgICAgICBBTFdBWVNfSU5MSU5FIGJvb2wgbGVmdEhhbmRTaWRl TmVlZHNDb3B5KGJvb2wgcmlnaHRIYXNBc3NpZ25tZW50cywgYm9vbCByaWdodElzUHVyZSkKICAg ICAgICAgewpJbmRleDogcGFyc2VyL05vZGVzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBwYXJzZXIvTm9k ZXMuY3BwCShyZXZpc2lvbiAzOTI1MikKKysrIHBhcnNlci9Ob2Rlcy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTExNjQsNiArMTE2NCw3IEBAIFJlZ2lzdGVySUQqIEluc3RhbmNlT2ZOb2RlOjplbWl0 Qnl0ZWNvZGUKICAgICBSZWZQdHI8UmVnaXN0ZXJJRD4gc3JjMiA9IGdlbmVyYXRvci5lbWl0Tm9k ZShtX2V4cHIyLmdldCgpKTsKIAogICAgIGdlbmVyYXRvci5lbWl0RXhwcmVzc2lvbkluZm8oZGl2 b3QoKSwgc3RhcnRPZmZzZXQoKSwgZW5kT2Zmc2V0KCkpOworICAgIGdlbmVyYXRvci5lbWl0R2V0 QnlJREV4Y2VwdGlvbkluZm8ob3BfaW5zdGFuY2VvZik7CiAgICAgUmVnaXN0ZXJJRCogc3JjMlBy b3RvdHlwZSA9IGdlbmVyYXRvci5lbWl0R2V0QnlJZChnZW5lcmF0b3IubmV3VGVtcG9yYXJ5KCks IHNyYzIuZ2V0KCksIGdlbmVyYXRvci5nbG9iYWxEYXRhKCktPnByb3BlcnR5TmFtZXMtPnByb3Rv dHlwZSk7CiAKICAgICBnZW5lcmF0b3IuZW1pdEV4cHJlc3Npb25JbmZvKGRpdm90KCksIHN0YXJ0 T2Zmc2V0KCksIGVuZE9mZnNldCgpKTsKSW5kZXg6IHJ1bnRpbWUvRXhjZXB0aW9uSGVscGVycy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gcnVudGltZS9FeGNlcHRpb25IZWxwZXJzLmNwcAkocmV2aXNpb24g MzkyNTIpCisrKyBydW50aW1lL0V4Y2VwdGlvbkhlbHBlcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yMDgsMTAgKzIwOCwxMyBAQCBKU05vdEFuT2JqZWN0RXJyb3JTdHViKiBjcmVhdGVOb3RBbk9i amVjCiAKIEpTT2JqZWN0KiBjcmVhdGVOb3RBbk9iamVjdEVycm9yKEV4ZWNTdGF0ZSogZXhlYywg SlNOb3RBbk9iamVjdEVycm9yU3R1YiogZXJyb3IsIGNvbnN0IEluc3RydWN0aW9uKiB2UEMsIENv ZGVCbG9jayogY29kZUJsb2NrKQogewotICAgIGlmICh2UENbOF0udS5vcGNvZGUgPT0gZXhlYy0+ aW50ZXJwcmV0ZXIoKS0+Z2V0T3Bjb2RlKG9wX2luc3RhbmNlb2YpKQorICAgIE9wY29kZUlEIGZv bGxvd2luZ09wY29kZUlEOworICAgIGlmIChjb2RlQmxvY2stPmdldEJ5SURFeGNlcHRpb25JbmZv Rm9yQnl0ZWNvZGVPZmZzZXQodlBDIC0gY29kZUJsb2NrLT5pbnN0cnVjdGlvbnMoKS5iZWdpbigp LCBmb2xsb3dpbmdPcGNvZGVJRCkpIHsKKyAgICAgICAgQVNTRVJUKGZvbGxvd2luZ09wY29kZUlE ID09IG9wX2NvbnN0cnVjdCB8fCBmb2xsb3dpbmdPcGNvZGVJRCA9PSBvcF9pbnN0YW5jZW9mKTsK KyAgICAgICAgaWYgKGZvbGxvd2luZ09wY29kZUlEID09IG9wX2NvbnN0cnVjdCkKKyAgICAgICAg ICAgIHJldHVybiBjcmVhdGVOb3RBQ29uc3RydWN0b3JFcnJvcihleGVjLCBlcnJvci0+aXNOdWxs KCkgPyBqc051bGwoKSA6IGpzVW5kZWZpbmVkKCksIHZQQywgY29kZUJsb2NrKTsKICAgICAgICAg cmV0dXJuIGNyZWF0ZUludmFsaWRQYXJhbUVycm9yKGV4ZWMsICJpbnN0YW5jZW9mIiwgZXJyb3It PmlzTnVsbCgpID8ganNOdWxsKCkgOiBqc1VuZGVmaW5lZCgpLCB2UEMsIGNvZGVCbG9jayk7Ci0g ICAgaWYgKHZQQ1s4XS51Lm9wY29kZSA9PSBleGVjLT5pbnRlcnByZXRlcigpLT5nZXRPcGNvZGUo b3BfY29uc3RydWN0KSkKLSAgICAgICAgcmV0dXJuIGNyZWF0ZU5vdEFDb25zdHJ1Y3RvckVycm9y KGV4ZWMsIGVycm9yLT5pc051bGwoKSA/IGpzTnVsbCgpIDoganNVbmRlZmluZWQoKSwgdlBDLCBj b2RlQmxvY2spOworICAgIH0KIAogICAgIGludCBzdGFydE9mZnNldCA9IDA7CiAgICAgaW50IGVu ZE9mZnNldCA9IDA7Cg==