22827 2008-12-12 13:56:30 -0800 RenderThemeWin buttons have weird heavy text 2008-12-16 17:55:43 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 adele webkit-unassigned hyatt ojan oldest_to_newest 102375 0 adele 2008-12-12 13:56:30 -0800 RenderThemeWin buttons have weird heavy text 102376 1 25986 adele 2008-12-12 13:59:29 -0800 Created attachment 25986 patch Potential fix. Not sure if the default GUI font is right here. But it matches Firefox. 102377 2 hyatt 2008-12-12 14:15:02 -0800 This is wrong IMO. - fontDescription.setSpecifiedSize(abs(logFont.lfHeight)); + fontDescription.setSpecifiedSize(fontSize); Just pass in the size you want instead. It's an argument to fillFontDescription, so i don't see why you'd ignore the argument. The rest of it looks good. Eyeballing Mozilla's code they do indeed use the stock DEFAULT_GUI_FONT for buttons. 102730 3 26079 adele 2008-12-16 17:05:20 -0800 Created attachment 26079 now with changelog The patch does explicitly set the font size for the controls, and after Hyatt and I talked more about the patch, I think this is right. Chromium has a slightly different strategy that we may want to merge with in the future. But for now, this will get us closer to a reasonable control look w/ RenderThemeWin. 102733 4 26079 darin 2008-12-16 17:41:14 -0800 Comment on attachment 26079 now with changelog r=me 102735 5 adele 2008-12-16 17:55:43 -0800 Committed r39349 25986 2008-12-12 13:59:29 -0800 2008-12-16 17:05:20 -0800 patch patch.txt text/plain 3207 adele SW5kZXg6IHJlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcmVuZGVy aW5nL1JlbmRlclRoZW1lV2luLmNwcAkocmV2aXNpb24gMzkyMTMpCisrKyByZW5kZXJpbmcvUmVu ZGVyVGhlbWVXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04OCw2ICs4OCw5IEBAIHN0YXRpYyBj b25zdCBpbnQgZHJvcERvd25CdXR0b25XaWR0aCA9IDEKIAogc3RhdGljIGNvbnN0IGludCBzaGVs bDMyTWFnbmlmaWVySWNvbkluZGV4ID0gMjI7CiAKKy8vIERlZmF1bHQgZm9udCBzaXplIHRvIG1h dGNoIEZpcmVmb3guCitzdGF0aWMgY29uc3QgZmxvYXQgZGVmYXVsdENvbnRyb2xGb250UGl4ZWxT aXplID0gMTM7CisKIFNPRlRfTElOS19MSUJSQVJZKHV4dGhlbWUpCiBTT0ZUX0xJTksodXh0aGVt ZSwgT3BlblRoZW1lRGF0YSwgSEFORExFLCBXSU5BUEksIChIV05EIGh3bmQsIExQQ1dTVFIgcHN6 Q2xhc3NMaXN0KSwgKGh3bmQsIHBzekNsYXNzTGlzdCkpCiBTT0ZUX0xJTksodXh0aGVtZSwgQ2xv c2VUaGVtZURhdGEsIEhSRVNVTFQsIFdJTkFQSSwgKEhBTkRMRSBoVGhlbWUpLCAoaFRoZW1lKSkK QEAgLTIxOSwxOSArMjIyLDI1IEBAIENvbG9yIFJlbmRlclRoZW1lV2luOjpwbGF0Zm9ybUluYWN0 aXZlU2UKICAgICByZXR1cm4gQ29sb3I6OndoaXRlOwogfQogCi1zdGF0aWMgdm9pZCBmaWxsRm9u dERlc2NyaXB0aW9uKEZvbnREZXNjcmlwdGlvbiYgZm9udERlc2NyaXB0aW9uLCBMT0dGT05UJiBs b2dGb250KQorc3RhdGljIHZvaWQgZmlsbEZvbnREZXNjcmlwdGlvbihGb250RGVzY3JpcHRpb24m IGZvbnREZXNjcmlwdGlvbiwgTE9HRk9OVCYgbG9nRm9udCwgZmxvYXQgZm9udFNpemUpCiB7ICAg IAogICAgIGZvbnREZXNjcmlwdGlvbi5zZXRJc0Fic29sdXRlU2l6ZSh0cnVlKTsKICAgICBmb250 RGVzY3JpcHRpb24uc2V0R2VuZXJpY0ZhbWlseShGb250RGVzY3JpcHRpb246Ok5vRmFtaWx5KTsK ICAgICBmb250RGVzY3JpcHRpb24uZmlyc3RGYW1pbHkoKS5zZXRGYW1pbHkoU3RyaW5nKGxvZ0Zv bnQubGZGYWNlTmFtZSkpOwotICAgIGZvbnREZXNjcmlwdGlvbi5zZXRTcGVjaWZpZWRTaXplKGFi cyhsb2dGb250LmxmSGVpZ2h0KSk7CisgICAgZm9udERlc2NyaXB0aW9uLnNldFNwZWNpZmllZFNp emUoZm9udFNpemUpOwogICAgIGZvbnREZXNjcmlwdGlvbi5zZXRXZWlnaHQobG9nRm9udC5sZldl aWdodCA+PSA3MDAgPyBGb250V2VpZ2h0Qm9sZCA6IEZvbnRXZWlnaHROb3JtYWwpOyAvLyBGSVhN RTogVXNlIHJlYWwgd2VpZ2h0LgogICAgIGZvbnREZXNjcmlwdGlvbi5zZXRJdGFsaWMobG9nRm9u dC5sZkl0YWxpYyk7CiB9CiAKK3N0YXRpYyB2b2lkIGZpbGxGb250RGVzY3JpcHRpb24oRm9udERl c2NyaXB0aW9uJiBmb250RGVzY3JpcHRpb24sIExPR0ZPTlQmIGxvZ0ZvbnQpCit7ICAgCisgICAg ZmlsbEZvbnREZXNjcmlwdGlvbihmb250RGVzY3JpcHRpb24sIGxvZ0ZvbnQsIGFicyhsb2dGb250 LmxmSGVpZ2h0KSk7Cit9CisKIHZvaWQgUmVuZGVyVGhlbWVXaW46OnN5c3RlbUZvbnQoaW50IHBy b3BJZCwgRm9udERlc2NyaXB0aW9uJiBmb250RGVzY3JpcHRpb24pIGNvbnN0CiB7CiAgICAgc3Rh dGljIEZvbnREZXNjcmlwdGlvbiBjYXB0aW9uRm9udDsKKyAgICBzdGF0aWMgRm9udERlc2NyaXB0 aW9uIGNvbnRyb2xGb250OwogICAgIHN0YXRpYyBGb250RGVzY3JpcHRpb24gc21hbGxDYXB0aW9u Rm9udDsKICAgICBzdGF0aWMgRm9udERlc2NyaXB0aW9uIG1lbnVGb250OwogICAgIHN0YXRpYyBG b250RGVzY3JpcHRpb24gaWNvbkZvbnQ7CkBAIC0yNzksMTMgKzI4OCwyMyBAQCB2b2lkIFJlbmRl clRoZW1lV2luOjpzeXN0ZW1Gb250KGludCBwcm9wCiAgICAgICAgICAgICBmb250RGVzY3JpcHRp b24gPSBjYXB0aW9uRm9udDsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIENTU1Zh bHVlU21hbGxDYXB0aW9uOgotICAgICAgICBjYXNlIENTU1ZhbHVlV2Via2l0U21hbGxDb250cm9s OiAvLyBFcXVpdmFsZW50IHRvIHNtYWxsLWNhcHRpb24uCi0gICAgICAgIGNhc2UgQ1NTVmFsdWVX ZWJraXRNaW5pQ29udHJvbDogLy8gSnVzdCBtYXAgdG8gc21hbGwuCi0gICAgICAgIGNhc2UgQ1NT VmFsdWVXZWJraXRDb250cm9sOiAvLyBKdXN0IG1hcCB0byBzbWFsbC4KICAgICAgICAgICAgIGlm ICghc21hbGxDYXB0aW9uRm9udC5pc0Fic29sdXRlU2l6ZSgpKQogICAgICAgICAgICAgICAgIGZp bGxGb250RGVzY3JpcHRpb24oc21hbGxDYXB0aW9uRm9udCwgbmNtLmxmU21DYXB0aW9uRm9udCk7 CiAgICAgICAgICAgICBmb250RGVzY3JpcHRpb24gPSBzbWFsbENhcHRpb25Gb250OwogICAgICAg ICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgQ1NTVmFsdWVXZWJraXRTbWFsbENvbnRyb2w6Cisg ICAgICAgIGNhc2UgQ1NTVmFsdWVXZWJraXRNaW5pQ29udHJvbDogLy8gSnVzdCBtYXAgdG8gc21h bGwuCisgICAgICAgIGNhc2UgQ1NTVmFsdWVXZWJraXRDb250cm9sOiAvLyBKdXN0IG1hcCB0byBz bWFsbC4KKyAgICAgICAgICAgIGlmICghY29udHJvbEZvbnQuaXNBYnNvbHV0ZVNpemUoKSkgewor ICAgICAgICAgICAgICAgIEhHRElPQkogaEdESSA9IDo6R2V0U3RvY2tPYmplY3QoREVGQVVMVF9H VUlfRk9OVCk7CisgICAgICAgICAgICAgICAgaWYgKGhHREkpIHsKKyAgICAgICAgICAgICAgICAg ICAgTE9HRk9OVCBsb2dGb250OworICAgICAgICAgICAgICAgICAgICBpZiAoOjpHZXRPYmplY3Qo aEdESSwgc2l6ZW9mKGxvZ0ZvbnQpLCAmbG9nRm9udCkgPiAwKQorICAgICAgICAgICAgICAgICAg ICAgICAgZmlsbEZvbnREZXNjcmlwdGlvbihjb250cm9sRm9udCwgbG9nRm9udCwgZGVmYXVsdENv bnRyb2xGb250UGl4ZWxTaXplKTsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9Cisg ICAgICAgICAgICBmb250RGVzY3JpcHRpb24gPSBjb250cm9sRm9udDsKKyAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICBkZWZhdWx0OiB7IC8vIEV2ZXJ5dGhpbmcgZWxzZSB1c2VzIHRoZSBzdG9j ayBHVUkgZm9udC4KICAgICAgICAgICAgIGlmICghc3lzdGVtRm9udC5pc0Fic29sdXRlU2l6ZSgp KSB7CiAgICAgICAgICAgICAgICAgSEdESU9CSiBoR0RJID0gOjpHZXRTdG9ja09iamVjdChERUZB VUxUX0dVSV9GT05UKTsK 26079 2008-12-16 17:05:20 -0800 2008-12-16 17:41:14 -0800 now with changelog patch_control-fonts.txt text/plain 3955 adele SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM5MzQ0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMTIt MTYgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyODI3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MjQ3 NzI0PiBSZW5kZXJUaGVtZVdpbiBidXR0b25zIGhhdmUgd2VpcmQgaGVhdnkgdGV4dAorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmZp bGxGb250RGVzY3JpcHRpb24pOiBBZGQgdmVyc2lvbiB0aGF0IHRha2VzIGEgZm9udCBzaXplLgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVXaW46OnN5c3RlbUZvbnQpOiBVc2UgdGhlIGRl ZmF1bHQgR1VJIGZvbnQgZm9yIGNvbnRyb2wgZm9udHMsIGJ1dCBzcGVjaWZ5IHRoZSBzaXplLgor ICAgICAgICBUaGlzIHdpbGwgbWF0Y2ggRmlyZWZveC4KKwogMjAwOC0xMi0xNiAgUGV0ZXIgS2Fz dGluZyAgPHBrYXN0aW5nQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQg SHlhdHQuCkluZGV4OiByZW5kZXJpbmcvUmVuZGVyVGhlbWVXaW4uY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IHJlbmRlcmluZy9SZW5kZXJUaGVtZVdpbi5jcHAJKHJldmlzaW9uIDM5MzM1KQorKysgcmVuZGVy aW5nL1JlbmRlclRoZW1lV2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODgsNiArODgsOSBAQCBz dGF0aWMgY29uc3QgaW50IGRyb3BEb3duQnV0dG9uV2lkdGggPSAxCiAKIHN0YXRpYyBjb25zdCBp bnQgc2hlbGwzMk1hZ25pZmllckljb25JbmRleCA9IDIyOwogCisvLyBEZWZhdWx0IGZvbnQgc2l6 ZSB0byBtYXRjaCBGaXJlZm94Lgorc3RhdGljIGNvbnN0IGZsb2F0IGRlZmF1bHRDb250cm9sRm9u dFBpeGVsU2l6ZSA9IDEzOworCiBTT0ZUX0xJTktfTElCUkFSWSh1eHRoZW1lKQogU09GVF9MSU5L KHV4dGhlbWUsIE9wZW5UaGVtZURhdGEsIEhBTkRMRSwgV0lOQVBJLCAoSFdORCBod25kLCBMUENX U1RSIHBzekNsYXNzTGlzdCksIChod25kLCBwc3pDbGFzc0xpc3QpKQogU09GVF9MSU5LKHV4dGhl bWUsIENsb3NlVGhlbWVEYXRhLCBIUkVTVUxULCBXSU5BUEksIChIQU5ETEUgaFRoZW1lKSwgKGhU aGVtZSkpCkBAIC0yMTksMTkgKzIyMiwyNSBAQCBDb2xvciBSZW5kZXJUaGVtZVdpbjo6cGxhdGZv cm1JbmFjdGl2ZVNlCiAgICAgcmV0dXJuIENvbG9yOjp3aGl0ZTsKIH0KIAotc3RhdGljIHZvaWQg ZmlsbEZvbnREZXNjcmlwdGlvbihGb250RGVzY3JpcHRpb24mIGZvbnREZXNjcmlwdGlvbiwgTE9H Rk9OVCYgbG9nRm9udCkKK3N0YXRpYyB2b2lkIGZpbGxGb250RGVzY3JpcHRpb24oRm9udERlc2Ny aXB0aW9uJiBmb250RGVzY3JpcHRpb24sIExPR0ZPTlQmIGxvZ0ZvbnQsIGZsb2F0IGZvbnRTaXpl KQogeyAgICAKICAgICBmb250RGVzY3JpcHRpb24uc2V0SXNBYnNvbHV0ZVNpemUodHJ1ZSk7CiAg ICAgZm9udERlc2NyaXB0aW9uLnNldEdlbmVyaWNGYW1pbHkoRm9udERlc2NyaXB0aW9uOjpOb0Zh bWlseSk7CiAgICAgZm9udERlc2NyaXB0aW9uLmZpcnN0RmFtaWx5KCkuc2V0RmFtaWx5KFN0cmlu Zyhsb2dGb250LmxmRmFjZU5hbWUpKTsKLSAgICBmb250RGVzY3JpcHRpb24uc2V0U3BlY2lmaWVk U2l6ZShhYnMobG9nRm9udC5sZkhlaWdodCkpOworICAgIGZvbnREZXNjcmlwdGlvbi5zZXRTcGVj aWZpZWRTaXplKGZvbnRTaXplKTsKICAgICBmb250RGVzY3JpcHRpb24uc2V0V2VpZ2h0KGxvZ0Zv bnQubGZXZWlnaHQgPj0gNzAwID8gRm9udFdlaWdodEJvbGQgOiBGb250V2VpZ2h0Tm9ybWFsKTsg Ly8gRklYTUU6IFVzZSByZWFsIHdlaWdodC4KICAgICBmb250RGVzY3JpcHRpb24uc2V0SXRhbGlj KGxvZ0ZvbnQubGZJdGFsaWMpOwogfQogCitzdGF0aWMgdm9pZCBmaWxsRm9udERlc2NyaXB0aW9u KEZvbnREZXNjcmlwdGlvbiYgZm9udERlc2NyaXB0aW9uLCBMT0dGT05UJiBsb2dGb250KQoreyAg IAorICAgIGZpbGxGb250RGVzY3JpcHRpb24oZm9udERlc2NyaXB0aW9uLCBsb2dGb250LCBhYnMo bG9nRm9udC5sZkhlaWdodCkpOworfQorCiB2b2lkIFJlbmRlclRoZW1lV2luOjpzeXN0ZW1Gb250 KGludCBwcm9wSWQsIEZvbnREZXNjcmlwdGlvbiYgZm9udERlc2NyaXB0aW9uKSBjb25zdAogewog ICAgIHN0YXRpYyBGb250RGVzY3JpcHRpb24gY2FwdGlvbkZvbnQ7CisgICAgc3RhdGljIEZvbnRE ZXNjcmlwdGlvbiBjb250cm9sRm9udDsKICAgICBzdGF0aWMgRm9udERlc2NyaXB0aW9uIHNtYWxs Q2FwdGlvbkZvbnQ7CiAgICAgc3RhdGljIEZvbnREZXNjcmlwdGlvbiBtZW51Rm9udDsKICAgICBz dGF0aWMgRm9udERlc2NyaXB0aW9uIGljb25Gb250OwpAQCAtMjc5LDEzICsyODgsMjMgQEAgdm9p ZCBSZW5kZXJUaGVtZVdpbjo6c3lzdGVtRm9udChpbnQgcHJvcAogICAgICAgICAgICAgZm9udERl c2NyaXB0aW9uID0gY2FwdGlvbkZvbnQ7CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2Fz ZSBDU1NWYWx1ZVNtYWxsQ2FwdGlvbjoKLSAgICAgICAgY2FzZSBDU1NWYWx1ZVdlYmtpdFNtYWxs Q29udHJvbDogLy8gRXF1aXZhbGVudCB0byBzbWFsbC1jYXB0aW9uLgotICAgICAgICBjYXNlIENT U1ZhbHVlV2Via2l0TWluaUNvbnRyb2w6IC8vIEp1c3QgbWFwIHRvIHNtYWxsLgotICAgICAgICBj YXNlIENTU1ZhbHVlV2Via2l0Q29udHJvbDogLy8gSnVzdCBtYXAgdG8gc21hbGwuCiAgICAgICAg ICAgICBpZiAoIXNtYWxsQ2FwdGlvbkZvbnQuaXNBYnNvbHV0ZVNpemUoKSkKICAgICAgICAgICAg ICAgICBmaWxsRm9udERlc2NyaXB0aW9uKHNtYWxsQ2FwdGlvbkZvbnQsIG5jbS5sZlNtQ2FwdGlv bkZvbnQpOwogICAgICAgICAgICAgZm9udERlc2NyaXB0aW9uID0gc21hbGxDYXB0aW9uRm9udDsK ICAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIENTU1ZhbHVlV2Via2l0U21hbGxDb250 cm9sOgorICAgICAgICBjYXNlIENTU1ZhbHVlV2Via2l0TWluaUNvbnRyb2w6IC8vIEp1c3QgbWFw IHRvIHNtYWxsLgorICAgICAgICBjYXNlIENTU1ZhbHVlV2Via2l0Q29udHJvbDogLy8gSnVzdCBt YXAgdG8gc21hbGwuCisgICAgICAgICAgICBpZiAoIWNvbnRyb2xGb250LmlzQWJzb2x1dGVTaXpl KCkpIHsKKyAgICAgICAgICAgICAgICBIR0RJT0JKIGhHREkgPSA6OkdldFN0b2NrT2JqZWN0KERF RkFVTFRfR1VJX0ZPTlQpOworICAgICAgICAgICAgICAgIGlmIChoR0RJKSB7CisgICAgICAgICAg ICAgICAgICAgIExPR0ZPTlQgbG9nRm9udDsKKyAgICAgICAgICAgICAgICAgICAgaWYgKDo6R2V0 T2JqZWN0KGhHREksIHNpemVvZihsb2dGb250KSwgJmxvZ0ZvbnQpID4gMCkKKyAgICAgICAgICAg ICAgICAgICAgICAgIGZpbGxGb250RGVzY3JpcHRpb24oY29udHJvbEZvbnQsIGxvZ0ZvbnQsIGRl ZmF1bHRDb250cm9sRm9udFBpeGVsU2l6ZSk7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAg ICAgfQorICAgICAgICAgICAgZm9udERlc2NyaXB0aW9uID0gY29udHJvbEZvbnQ7CisgICAgICAg ICAgICBicmVhazsKICAgICAgICAgZGVmYXVsdDogeyAvLyBFdmVyeXRoaW5nIGVsc2UgdXNlcyB0 aGUgc3RvY2sgR1VJIGZvbnQuCiAgICAgICAgICAgICBpZiAoIXN5c3RlbUZvbnQuaXNBYnNvbHV0 ZVNpemUoKSkgewogICAgICAgICAgICAgICAgIEhHRElPQkogaEdESSA9IDo6R2V0U3RvY2tPYmpl Y3QoREVGQVVMVF9HVUlfRk9OVCk7Cg==