228266 2021-07-24 08:24:25 -0700 [GTK] USE_OPENGL_OR_ES should not be an automagic feature 2021-07-25 11:29:37 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro annulen bugs-noreply ews-watchlist fujii gyuyoung.kim mcatanzaro ryuan.choi sergio oldest_to_newest 1779323 0 mcatanzaro 2021-07-24 08:24:25 -0700 The USE_OPENGL_OR_ES feature flag added in r271220 is currently automagic: that is, if neither OpenGL nor OpenGL ES is available at build time, it gets silently disabled. This is not OK because it makes it easy for distributors to accidentally fail to enable OpenGL support. We should require manually disabling the feature with -DUSE_OPENGL_OR_ES=OFF in order to build with OpenGL disabled. 1779324 1 mcatanzaro 2021-07-24 08:27:03 -0700 Note that automagic detection of OpenGL ES is OK because that is not a "feature." It doesn't matter to the user whether OpenGL or OpenGL ES gets used under the hood. But it matters very much if neither is used at all. 1779325 2 434169 mcatanzaro 2021-07-24 08:37:04 -0700 Created attachment 434169 Patch 1779341 3 434169 fujii 2021-07-24 15:06:34 -0700 Comment on attachment 434169 Patch It's my mistake. Thank you. 1779366 4 434169 mcatanzaro 2021-07-25 10:59:55 -0700 Comment on attachment 434169 Patch No problem. Build options are hard.... 1779368 5 ews-feeder 2021-07-25 11:29:34 -0700 Committed r280287 (239945@main): <https://commits.webkit.org/239945@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 434169. 434169 2021-07-24 08:37:04 -0700 2021-07-25 11:29:35 -0700 Patch bug-228266-20210724103704.patch text/plain 2759 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMjg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDNiMGFi NDBkYTUwMDJhMGE3NGVjNDMzMWFhNjVmYjNiNGEzNWY2NjMuLmI3MjkwZGE0NDdiODYzNThkMTY5 NzgwMDVhZjIyMjM1NGU3MTAxMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC00OSwxNiArNDks MTAgQEAgaWYgKCIke1BDX0hBUkZCVVpaX1ZFUlNJT059IiBWRVJTSU9OX0xFU1MgIjEuMy4zIikK ICAgICBhZGRfZGVmaW5pdGlvbnMoLURFTkFCTEVfT1BFTlRZUEVfTUFUSD0xKQogZW5kaWYgKCkK IAotIyBTZXQgdGhlIGRlZmF1bHQgdmFsdWUgZm9yIEVOQUJMRV9HTEVTMiBhbmQgVVNFX09QRU5H TF9PUl9FUy4KLXNldChFTkFCTEVfR0xFUzJfREVGQVVMVCBPRkYpCi1zZXQoVVNFX09QRU5HTF9P Ul9FU19ERUZBVUxUIE9GRikKLQogaWYgKE9QRU5HTEVTMl9GT1VORCBBTkQgKE5PVCBPUEVOR0xf Rk9VTkQgT1IgV1RGX0NQVV9BUk0gT1IgV1RGX0NQVV9BUk02NCkpCiAgICAgc2V0KEVOQUJMRV9H TEVTMl9ERUZBVUxUIE9OKQotZW5kaWYgKCkKLQotaWYgKE9QRU5HTF9GT1VORCBPUiBPUEVOR0xF UzJfRk9VTkQpCi0gICAgc2V0KFVTRV9PUEVOR0xfT1JfRVNfREVGQVVMVCBPTikKK2Vsc2UgKCkK KyAgICBzZXQoRU5BQkxFX0dMRVMyX0RFRkFVTFQgT0ZGKQogZW5kaWYgKCkKIAogIyBQdWJsaWMg b3B0aW9ucyBzcGVjaWZpYyB0byB0aGUgR1RLIHBvcnQuIERvIG5vdCBhZGQgYW55IG9wdGlvbnMg aGVyZSB1bmxlc3MKQEAgLTc2LDcgKzcwLDcgQEAgV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX0xD TVMgIldoZXRoZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIGltYWdlIGNvbG9yIG1hbmFnZW0KIFdF QktJVF9PUFRJT05fREVGSU5FKFVTRV9MSUJIWVBIRU4gIldoZXRoZXIgdG8gZW5hYmxlIHRoZSBk ZWZhdWx0IGF1dG9tYXRpYyBoeXBoZW5hdGlvbiBpbXBsZW1lbnRhdGlvbi4iIFBVQkxJQyBPTikK IFdFQktJVF9PUFRJT05fREVGSU5FKFVTRV9MSUJOT1RJRlkgIldoZXRoZXIgdG8gZW5hYmxlIHRo ZSBkZWZhdWx0IHdlYiBub3RpZmljYXRpb24gaW1wbGVtZW50YXRpb24uIiBQVUJMSUMgT04pCiBX RUJLSVRfT1BUSU9OX0RFRklORShVU0VfTElCU0VDUkVUICJXaGV0aGVyIHRvIGVuYWJsZSB0aGUg cGVyc2lzdGVudCBjcmVkZW50aWFsIHN0b3JhZ2UgdXNpbmcgbGlic2VjcmV0LiIgUFVCTElDIE9O KQotV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX09QRU5HTF9PUl9FUyAiV2hldGhlciB0byB1c2Ug T3BlbkdMIG9yIEVTLiIgUFVCTElDICR7VVNFX09QRU5HTF9PUl9FU19ERUZBVUxUfSkKK1dFQktJ VF9PUFRJT05fREVGSU5FKFVTRV9PUEVOR0xfT1JfRVMgIldoZXRoZXIgdG8gdXNlIE9wZW5HTCBv ciBFUy4iIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGSU5FKFVTRV9PUEVOSlBFRyAiV2hl dGhlciB0byBlbmFibGUgc3VwcG9ydCBmb3IgSlBFRzIwMDAgaW1hZ2VzLiIgUFVCTElDIE9OKQog V0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX1NPVVAyICJXaGV0aGVyIHRvIGVuYWJsZSB1c2FnZSBv ZiBTb3VwIDIgaW5zdGVhZCBvZiBTb3VwIDMuIiBQVUJMSUMgT0ZGKQogV0VCS0lUX09QVElPTl9E RUZJTkUoVVNFX1NZU1RFTUQgIldoZXRoZXIgdG8gZW5hYmxlIGpvdXJuYWxkIGxvZ2dpbmciIFBV QkxJQyBPTikKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBjNmQ5MGU5 ZDc2OGFiZjVhYzVmZDE4YjVjYmM0NmZlNzhhMGY1NDRjLi4zOWFlYjQ0NDY4M2E0Zjk4OWM0YTM1 MTA3NTBkNzg1MzQ5NWE5NzEzIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDctMjQgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFu emFyb0Bnbm9tZS5vcmc+CisKKyAgICAgICAgW0dUS10gVVNFX09QRU5HTF9PUl9FUyBzaG91bGQg bm90IGJlIGFuIGF1dG9tYWdpYyBmZWF0dXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjgyNjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGUgVVNFX09QRU5HTF9PUl9FUyBmZWF0dXJlIGZsYWcgYWRk ZWQgaW4gcjI3MTIyMCBpcyBjdXJyZW50bHkgYXV0b21hZ2ljOiB0aGF0IGlzLCBpZgorICAgICAg ICBuZWl0aGVyIE9wZW5HTCBub3IgT3BlbkdMIEVTIGlzIGF2YWlsYWJsZSBhdCBidWlsZCB0aW1l LCBpdCBnZXRzIHNpbGVudGx5IGRpc2FibGVkLiBUaGlzIGlzCisgICAgICAgIG5vdCBPSyBiZWNh dXNlIGl0IG1ha2VzIGl0IGVhc3kgZm9yIGRpc3RyaWJ1dG9ycyB0byBhY2NpZGVudGFsbHkgZmFp bCB0byBlbmFibGUgT3BlbkdMCisgICAgICAgIHN1cHBvcnQuIFdlIHNob3VsZCByZXF1aXJlIG1h bnVhbGx5IGRpc2FibGluZyB0aGUgZmVhdHVyZSB3aXRoIC1EVVNFX09QRU5HTF9PUl9FUz1PRkYg aW4KKyAgICAgICAgb3JkZXIgdG8gYnVpbGQgd2l0aCBPcGVuR0wgZGlzYWJsZWQuCisKKyAgICAg ICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZToKKwogMjAyMS0wNy0yMyAgUGhpbGlw cGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dMaWJdIFJlbW92 ZSBsaWJwb3J0YWwgZGVwZW5kZW5jeQo=